- 30 Aug, 2019 40 commits
-
-
John Delaney authored
This change adds a threshold for peak windowed cpu usage to the heavy ad thresholds. Relevant histograms are versioned. Bug: 989141 Change-Id: I71d1064cb809ca3adafb1dd576e7d2a6363036cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769514 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692226}
-
Lorne Mitchell authored
All settings specified via the module.json were not calling ls(). They were being picked up by our localization system and existed in GRDP files. This fix simply calls ls() on the setting's title descriptor. Screenshot of settings: https://imgur.com/YuJ647w Bug: 941561 Change-Id: I051fae1f7398cb5b2efc7d277abc391b41bfa603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775438 Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Jeff Fisher <jeffish@microsoft.com> Cr-Commit-Position: refs/heads/master@{#692225}
-
Jenny Zhang authored
Bug: 995962 Change-Id: I7944ae293fb146e3d9314a8b029fcab6ba2809de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778595Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jenny Zhang <jennyz@chromium.org> Cr-Commit-Position: refs/heads/master@{#692224}
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/952ccb9..53f6b23 53f6b23 Fix leakage in adoptCalendar Bug: chromium:997401 Change-Id: I3e152496ac9e4ee6bf2c95e90d23e489d672ff68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777048 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Jungshik Shin <jshin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692223}
-
Ryan Hamilton authored
Bug: 984738 Change-Id: I5432006796a0959a0d32bd062cf4c37180acc3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778593 Commit-Queue: Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Auto-Submit: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#692222}
-
Min Qin authored
Currently the text uses "incognito", it should be "guest". BUG=998139 Change-Id: I4b1f83394dfc1e4b4f72b9d6f274bdbe8f99f89e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772503Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#692221}
-
kylechar authored
By default LayerTreeSettings::enable_surface_synchronization was false. Most cc_unittests were running with the default. This CL switches the default to true and fixes most tests. The primary change for tests is with regards to LocalSurfaceId allocation. With surface sync off LocalSurfaceIds would be allocated automatically. With surface sync on the test has to ensure new LocalSurfaceIds are allocated at the correct time. Bug: 985009 Change-Id: I9bd62da2b96f9eddb4ea85656c61364c0ee5ada8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774309 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#692220}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d70702fad6d1..408dc11ec29e Created with: gclient setdep -r src-internal@408dc11ec29e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7fcbd88f680c5ca88c1cdac1b5150c843bb83263 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778632Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692219}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8a1c4425..fe2e9f99 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I22bc0c90524002cc05ddb4ce9ac3744496ba7fe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779262Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692218}
-
Etienne Pierre-doray authored
To avoid having 2 tasks with same queue_time, each PushTask is preceded by a FastForward(). Bug: 998477 Change-Id: Ibecca4edf6d4c53420c0584676356284681d4868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778925 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#692217}
-
Sebastien Marchand authored
Using an EmbeddedTestServer bound to a specific port is flaky because it's not guaranteed that this port will be available when running the test, switching to a URLLoaderInterceptor fix this. Bug: 998071 Change-Id: Ieae65bb2e9a12f5e5cf3aaaa772667a1d0e2aef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779201Reviewed-by:
-
Andrew Grieve authored
Change-Id: I4e275a5cc27460a2d6b66c10f486c8f5d0636626 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778589 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#692215}
-
Toni Barzic authored
Updates how apps grid horizontal margins are calculated with kScalableAppList feature enabled. Adds some tests that verify the apps grid layout in fullscreen state. Bug: 999273 Change-Id: I63f36f6b946afc7b55b66568a8113bf19ce381b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776715 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#692214}
-
Sigurdur Asgeirsson authored
As-is, a late UserMessageReadAckEvent will call Delegate::PortStatusChanged with an invalid PortRef. Change-Id: I9f089df40692fc2c39c2de035b6890a1d2995e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779183 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#692213}
-
Kyle Horimoto authored
Before this CL, clicking on a non-connectable Cellular network in the mobile subpage would result in no action except for some UI jank. This was due to the fact that the network cannot be configured and thus it is not possible to attempt a connection. This CL fixes this situation by navigating to the network's detail page in this situation. Bug: 947351 Change-Id: If390de1f8fd5476fbae193a9597f64dc31fa9143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777067 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692212}
-
Alex Chau authored
- Added transparent SharedClipboardShareActivity that mimic a BottomSheet to show device list. BottomSheet cannot be used if calling acitivty is not part of Chrome. - Re-used layout of self-share device picker for UI consistency - Implemented sending and error notification in Android Bug: 996318, 996322 Change-Id: I08708e17af3422ebdb19c71f7db387cff6c8ff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776053 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692211}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d7245686774..4ece96d76d9d git log 8d7245686774..4ece96d76d9d --date=short --no-merges --format='%ad %ae %s' 2019-08-30 csmartdalton@google.com Reland "Initiate MSAA resolves during DAG generation" 2019-08-30 ethannicholas@google.com .fp files now support user-defined functions 2019-08-30 ethannicholas@google.com removed dead code from SkSLPipelineStateCodeGenerator Created with: gclient setdep -r src/third_party/skia@4ece96d76d9d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@google.com Bug: None Change-Id: Ia3275e8722a7eb71b6e8dafd2630aafa2bae4f51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778631Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692210}
-
Maksim Ivanov authored
Display a big lock icon in the top-left corner of the security token PIN dialog, which is shown during the SAML user sign-in on Chrome OS when a security token (e.g., a smart card) is used. The icon corresponds to the UI mocks prepared for this dialog. Bug: 964069 Change-Id: I39afcb9d5e5776f7c1ec02ca2a0b56015f8aca05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751184 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#692209}
-
Mounir Lamouri authored
As part of the load algorithm, the video gets paused but the pause event is not fired (per spec). As a result, the video wake lock would stay around on the paused video. Emptied is fired in this case and can be used as a proxy. Bug: 980024 Change-Id: I0c6f2e14a8f3732250d339e01fe1e598bea614d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779186Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#692208}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f5980f492582..f06000e894cd git log f5980f492582..f06000e894cd --date=short --no-merges --format='%ad %ae %s' 2019-08-30 avi@chromium.org Support macOS 10.15 Catalina. 2019-08-30 bsheedy@chromium.org Revert "Reland "Reland "Support minidump symbolization on ChromeOS""" Created with: gclient setdep -r src/third_party/catapult@f06000e894cd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: chromium:998877,chromium:998871,chromium:978952 Change-Id: I1b81f463284b403155eb32d290ee7b9e98e6400c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778648Reviewed-by:
-
Stefan Zager authored
For an observer with multiple observations, this avoids doing redundant work to compute the local bounds of the root and its transform to absolute coordinates. BUG=956071 Change-Id: I587997da1f5f120a1fd276f703aa1e5a1131696b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774246 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692206}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f0033328dd22..6d684b4c7991 git log f0033328dd22..6d684b4c7991 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 swiftshader.regress@gmail.com Regres: Update test lists @ 680d3761 Created with: gclient setdep -r src/third_party/swiftshader@6d684b4c7991 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Ie198b23e1f2803e66f10cb1615c71e204b961517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778630Reviewed-by:
-
Tommy Nyquist authored
The feature_engagement component needs to be configured according to whatever experiment is being tested. The documentation for how to do this was written a while ago, and has since then become outdated. This CL updates the documentation to how things are supposed to be configured now, since there's been a couple of instances recently as to why the feature engagement does not work as expected. Bug: None Change-Id: Ibdfcb1d118dde660be8de7b59d944a641f1792f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749005 Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#692204}
-
Jeevan Shikaram authored
This CL adds an uninstall button that allows a user to uninstall apps from App Management. Bug: 999431, 979531 Change-Id: Ib2e88f5e7bb7f0fac09067a38bfd139a7adf168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777465Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#692203}
-
Stefan Zager authored
Most of the ideas for improving the performance of IntersectionObserver are contingent on processing the observations for a single observer at the same time. Prior to this patch, the processing model was: document -> element -> observation with element as target -> observation with element as target -> element -> observation with element as target -> observation with element as target With this patch, the model becomes: document -> element -> implicit-root observation with element as target -> implicit-root observation with element as target -> explicit-root observer with element as root -> observation -> observation -> explicit-root observer with element as root -> observation -> observation So, explicit-root observers will process all of their observations together. This isn't possible for implicit-root observers, because the targets of an implicit-root observer may be spread across multiple documents in multiple tabs or windows. BUG=956071 Change-Id: I72e9fe1c4a9d0e0cd37e401cbb3a40774d5589b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774244Reviewed-by: -
Fabrice de Gans-Riberi authored
* Simplify CastComponent constructor to take a single structure. * Spin-off from https://crrev.com/c/1770434 Bug: 976975 Change-Id: Icb42418bfa60e1b6f34bd3f29f1f1c29d754cf07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778915 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692201}
-
Alex Danilo authored
Bug: 999653 Change-Id: I3c2a65fc04817a1ced86ecbd5157877a6ac07244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778883 Commit-Queue: Alex Danilo <adanilo@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Auto-Submit: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#692200}
-
Eric Stevenson authored
--sdk-version isn't currently used, but it's a bit misleading that it implies --minimal. This CL changes app_bundle_utils.GenerateBundleApks to enforce minimal to be passed for --sdk-version to work. Bug: 996362 Change-Id: I808273d92f73cd50015101da551df04d53ad6d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779008Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/864bae4cc6a2..adbecedad5e0 git log 864bae4cc6a2..adbecedad5e0 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 natlee@microsoft.com D3D12: clear nonrenderable texture formats Created with: gclient setdep -r src/third_party/dawn@adbecedad5e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ic0bf082ad06e34d6adb19ea2787f071078cc8f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778646Reviewed-by:
-
Findit authored
This reverts commit 2f2b401b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 692146 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzJmMmI0MDFiZjQwMTdjNTA3ZDgyYTNlNjUyZmFjMTMzYWY3MTk2NGQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-archive-rel/4128 Sample Failed Step: compile Original change's description: > Android: Make Linker.java optimized out when use_chromium_linker=false > > Two fixes: > 1) Move static getters to a separate LibraryLoaderConfig.java > * Required because of the non-trivial class initializer in > LibraryLoader preventing inlining. > 2) Change JNI proguard rules to not -keep natives when the linker > is not used. > > TBR=agrieve # Renames > > Change-Id: I0f4a40af6168cbe7243f462c24d230d277e642ab > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703155 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692146} Change-Id: Icfe9c719c7f1fdfa7b95acc41c98319972d50abb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779168 Cr-Commit-Position: refs/heads/master@{#692197}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/56ba54cc03f3..2c5d48a6f0e4 git log 56ba54cc03f3..2c5d48a6f0e4 --date=short --no-merges --format='%ad %ae %s' 2019-08-30 lujc@google.com Use FramebufferID in place of GLuint handle 2019-08-30 syoussefi@chromium.org Move timer functionality from util/ to common/ 2019-08-30 syoussefi@chromium.org Vulkan: Split Vulkan docs from README.md into doc/ 2019-08-30 jmadill@chromium.org SystemInfo: Add Google VendorID. Created with: gclient setdep -r src/third_party/angle@2c5d48a6f0e4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Bug: None Change-Id: I1ba17f206dcdf3f1bbf4869c381382591bd69292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778649Reviewed-by:
-
Erik Chen authored
On macOS, ExternalPopupMenu queued a timer event to dispatch an event to the main frame widget. This is incorrect and assumes that child frame is an in-process iframe. Instead, the event should be dispatched to the local root widget. Change-Id: I9a89496a333c6788621cca305d618900e3c4be88 Bug: 995981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775600 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#692195}
-
Antonio Gomes authored
PostCrossThreadTask() (and FWIW PostDelayedCrossThreadTask too) are thin wrapper to //base's equivalent in //base/task_runner.h. The goal is to ensure CrossThreadXXX is used when binding the functors. However, the wrappers miss the boolean return type of their //base equivalent. The limination makes switching some code from using base::Bind to use WTF::Bind if not impossible, at least not straightforward. eg.: 484 bool RTCVideoDecoderAdapter::ReinitializeSync( 485 const media::VideoDecoderConfig& config) { 486 DCHECK_CALLED_ON_VALID_SEQUENCE(decoding_sequence_checker_); 487 (...) 499 if (media_task_runner_->PostTask( 500 FROM_HERE, base::BindOnce(&RTCVideoDecoderAdapter::FlushOnMediaThread, 501 weak_this_, std::move(flush_success_cb), 502 std::move(flush_fail_cb)))) { 503 waiter.Wait(); 504 } ... in //third_party/blink/renderer/platform/peerconnection/rtc_video_decoder_adapter.cc. This CL pairs up both wrapper and wrapped behavior, so it unblocks the migration. BUG=787254 R=haraken@chromium.org Change-Id: I518bdd03496f58ffcd36906e19dfc5c4112a493d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778663 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#692194}
-
Gavin Williams authored
-Set a specific dialog width because the default cr-dialog width is too large -Reduced padding to bring the elements closer together Bug: 985108 Change-Id: I0b4f9a958b88a43669dcabceefbc9e9eb3a632da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775219Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#692193}
-
Dominik Röttsches authored
The Windows 7 bot does currently not efficiently cache the font lookup table for layout tests because a cache directory is not configured. Also, Win7 layout tests failed with DCHECKs when a path was not configured. Disable FontSrcLocalMatching on Windows until this is properly addressed. Bug: 996027, 996167 Change-Id: Iaa21ab1a32cda73d8f7e3a2e6bd803c132105781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778491Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#692192}
-
Jamie Madill authored
No longer needed for any integration. Bug: angleproject:3320 Change-Id: Ie963ab28f9c9f05f57629fb78d5e1bdae6aa061b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779066 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#692191}
-
manuk authored
The triage readme includes a link to bugs.chromium.org filtered to omnibox related but -component:UI>Browser>Omnibox issues. It mentions the view can optionally be filtered to the last week. This CL adds a link filtered to the last 2 weeks. Bug: 871898 Change-Id: Ic7d0d5175fb40e5b7d384c36a4e60768ba815c81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779065Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#692190}
-
Tommy Li authored
Works great on my desktop. Needs further testing though. Making this flag available on Desktop. Bug: 925072 Change-Id: I77ced4f1b72694db389ba528b9f1d3cd648bd58d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775221Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#692189}
-
Ella Ge authored
This CL makes VariationsFieldTrialCreator::GetShortHardwareClass return base::SysInfo::HardwareModelName() so that we can use hardware class on Android in finch config. Bug: 999341 Change-Id: I4f33a07739005c7cd369a5eb5820725547b767a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776980 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#692188}
-
Xing Liu authored
DexLoaderTest#testLoadFromLocalDataDir is failing on Android O builder. TBR=hanxi@chromium.org Bug: 999363 Change-Id: Ied3e88b74580ab2395e31c651eba0643bb0290ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779063 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692187}
-
