Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 08 Feb, 2019 30 commits
  3. 07 Feb, 2019 10 commits
    • manuk's avatar
      [omnibox]: Show original text when reverting with a default keyword match. · 5beff680
      manuk authored 
      Previously, reverting the omnibox's selected match (e.g. by pressing escape)
when the default match is in keyword mode resulted in incorrect behavior
regarding the user text, autocomplete text, and text styling:

(1) The user text has its first word removed for each time keyword mode was
entered. If the results popup included a navigation result, pressing
up/down to select the navigation result leaves keyword mode. Pressing
up/down to select a search result or pressing escape to revert the omnibox text
reenters keyword mode. Each time keyword mode is entered, the user text drops
the first word. E.g. if the 2nd result is a navigation result, and the third
result is a search result, pressing <down><down><up><escape> would enter keyword
mode twice, and drop the first two words of the user text.

(2) The user text would be styled as a URL (grey font color) if the result
selected before reverting was a URL result.

(3) The autocomplete text is not restored.

This CL addresses (1) and (3). (2) is partially addressed as well;
for cases where the default match has autocomplete text, restoring it correctly
also restores the user text styling. The fix is 2 part:

(1) Before, the first word of the user text was stripped upon entering keyword
mode because we assumed the first word must be the keyword word. However, this
assumption is only true when accepting a keyword (e.g. pressing <space> or
<tab>), and not when entering keyword mode by reverting the omnibox's selected
match (e.g. pressing <escape>). This CL moves the stripping call from
OmniboxEditModel::OnPopupDataChanged, which is called in both cases, to
OmniboxEditModel::OnCurrentMatchChanged, which is only called in the first case.

(2) Before, the cursor was reset to the beginning of the user text when entering
keyword mode while the default match was either already selected or becoming
selected. The first occurs when (a) inserting a space between a keyword name and
a search string, while the latter occurs when (b) reverting the omnibox's
selected match. This was desired behavior in case (a), but undesired in case
(b). We incorrectly assumed it was ok to do this in case (b) because we would be
reverting the text anyways. However, the revert happens prior to this, resulting
in incorrect autocomplete selection. This CL conditions the cursor reset on not
having autocomplete text.

Bug: 702867
Change-Id: Iac0bdae7e17c86b3e0feb3075dd916d85e5d7e39
Reviewed-on: https://chromium-review.googlesource.com/c/1458697
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630105}
      5beff680
    • ssid's avatar
      Fix ProcessMemoryMetricsEmitterTest · 8b43cc42
      ssid authored 
      Do not check for uptime to be less than 10. Process could be running
longer in the test. This does not fix the failure due to missing uptime
value.

BUG=731466

Change-Id: I0b176da810dd8f3bc90ad4b94386bc46e68fa1e7
Reviewed-on: https://chromium-review.googlesource.com/c/1338954Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630104}
      8b43cc42
    • Yoshifumi Inoue's avatar
      Get rid of unused class SearchBuffer · 16f86086
      Yoshifumi Inoue authored 
      This patch gets rid of unused class |SearchBuffer| and related files for
improving code health.

Since the CL[1], nobody use this class.

[1] http://crrev.com/c/1451697: Make FindStringBetweenPositions use FindBuffer
and activate invisible matches

Change-Id: I36589acdc8e00d89f7fc2cc6d028a84e2389ea2f
Reviewed-on: https://chromium-review.googlesource.com/c/1457702
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: default avatarRakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630103}
      16f86086
    • David Bienvenu's avatar
      Add user visible flag for WebContentsOcclusion on Windows. · c713d509
      David Bienvenu authored 
      Bug: 813093
Change-Id: I8e4779551cb75d88f1f07c069cd7e5d7793da5b1
Reviewed-on: https://chromium-review.googlesource.com/c/1455094
Commit-Queue: David Bienvenu <davidbienvenu@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: default avatarFrançois Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630102}
      c713d509
    • Zhenyao Mo's avatar
      Add back direct composition InfoCollection test. · 169ec7e7
      Zhenyao Mo authored 
      This test was commented out due to flakiness, but we found out
the failures are limited to two bots only where overlay cap is
DIRECT instead of SCALING. So we removed these two bots from
swarming pool so we can add back this test.

However, this time we split it into its own test.

BUG=929469
TEST=Win/Intel GPU bots
R=kbr@chromium.org

Change-Id: Ibe0402996709fbdaceee6f9431b8b58d05f59d33
Reviewed-on: https://chromium-review.googlesource.com/c/1457664Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630101}
      169ec7e7
    • Raul Tambre's avatar
      //gpu: Convert base::(U)Int(64)ToString(16) to NumberToString(16) · 36584543
      Raul Tambre authored 
      The former non-overloaded variants are deprecated.

This is a mechanical change; there is no intended behavior change.

Bug: 929827
Change-Id: I345b5acb91681b795125dc7dcf627c9534d5cec7
Reviewed-on: https://chromium-review.googlesource.com/c/1459376Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#630100}
      36584543
    • Dominik Röttsches's avatar
      Move font unique name lookup table construction to own singleton class · 56c3f510
      Dominik Röttsches authored 
      Preparation for background scheduling of font unique name table
construction at browser startup. In a forthcoming CL, threading
primitives are added to support scheduling the font lookup table
construction at startup. For now, move the existing code to a separate
singleton class.

Bug: 889864
Change-Id: Idaa0bdf4cd7128e42cdc36d409eab37ae83c1d1a
Reviewed-on: https://chromium-review.googlesource.com/c/1458186
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Reviewed-by: default avatarEmil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630099}
      56c3f510
    • Boris Sazonov's avatar
      [Unity][Android] Implement bottom button bar in SyncAndServicesPreferences · ad1c576f
      Boris Sazonov authored 
      This CL implements bottom bar with "Cancel" and "Confirm" buttons in
SyncAndServicesPreferences. This bottom bar is only shown when the user
opens SyncAndServicesPreferences screen from the sign-in screen.

Bug: 914056
Change-Id: I3f5f2002ab7bcd566f3305fd2344a79069bb82fb
Reviewed-on: https://chromium-review.googlesource.com/c/1435276Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630098}
      ad1c576f
    • Avi Drissman's avatar
      Port flag doc to markdown. · 465e778e
      Avi Drissman authored 
      BUG=none

Change-Id: I04b897dca22734caa56abd08acda1d5182d2fcd3
Reviewed-on: https://chromium-review.googlesource.com/c/1456289
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630097}
      465e778e
    • Luciano Pacheco's avatar
      [Files app] Hide delete button for Downloads folder · ebea4420
      Luciano Pacheco authored 
      Change FileSelection to receive VolumeManager to be able to get
location info and determine if the selection contains any read-only
entry.

Change logic to hide delete button to check read-only from the file
selection and the special case for /Downloads folder inside MyFiles.

Remove test checkDownloadsContextMenu with MyFilesVolume flag disabled
because the delete button behaves differently and the flag is enabled
by default.

Bug: 921483
Change-Id: I731624948606f6b7ccb6617dd424617d97b0020e
Reviewed-on: https://chromium-review.googlesource.com/c/1457884
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630096}
      ebea4420