- 04 Jul, 2018 40 commits
-
-
Makoto Shimazu authored
TBR=reveman@chromium.org Bug: 856145 Change-Id: I8280cf4c382282237d24bd6c4f432104c5f023aa Reviewed-on: https://chromium-review.googlesource.com/1125645Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#572502}
-
Nicholas Verne authored
Crostini Terminal icon now has a Shut Down Linux item, which is enabled if and only if the default vm is running for this user. CrostiniManager now tracks |running_vms_| and updates this multimap when vms start and stop. Bug: 848116 Change-Id: I1130f0ff2e122828c81c286fa3a4362e3cb3138d Reviewed-on: https://chromium-review.googlesource.com/1124065Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#572501}
-
Trent Apted authored
Although it doesn't flake in Release, the presense of DCHECKs makes this test fail. Waiting just for the gallery element could read the button state in the static gallery.html DOM, so wait for the first image to be fully loaded. Bug: 857021 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I4e07384b105489410a73894b4a9e0a58bdae287d Reviewed-on: https://chromium-review.googlesource.com/1125589Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#572500}
-
Luciano Pacheco authored
This is a preparation for crrev.com/c/1113258 which uses this deps. Bug: 846587 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I9fc23fa6a137df4256420464384ac3366d260b3c Reviewed-on: https://chromium-review.googlesource.com/1116400 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#572499}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I147efd9556ff6dad0a5afb08f29f791dd6ef0547 Reviewed-on: https://chromium-review.googlesource.com/1125533Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572498}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 22bb66f2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/20740 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kozyatinskiy@chromium.org: external/wpt/console TBR=markdittmer No-Export: true Change-Id: Idc755344530ed753097aea477e632b001b51d615 Reviewed-on: https://chromium-review.googlesource.com/1125530 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#572497}
-
Luciano Pacheco authored
Add interface FilesAppEntry which is the base interface that moving forward the app UI will converge as base type that can be displayed on different UI components such as: navigation tree, file list and breadcrumbs, eventually superseding Entry type. Add VolumeEntry which implements interface FilesAppEntry to represent a Volume, this will allow to display Volumes on file list/Right Hand Side (RHS). Add EntryList which implements interface FilesAppEntry to represent a list of entries. This will be used to implement "My Files" which will contain a list of VolumeEntry for the volumes: Downloads, Linux Files (Crostini) and Play Files (ARC++). Design doc: https://docs.google.com/document/d/1X5XSLKJd0yerL-qFhpb2z9ibUVb_W3gG_tfIV7T_Qt0 Bug: 846587, 835203 Test: Unit-test for the new types. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia2fce233338f8b8e0969b77daf4c77139852c441 Reviewed-on: https://chromium-review.googlesource.com/1086680 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
Tarun Bansal authored
This separates out the code for parsing accept-ch and accept-cl-lifetime header. This makes it easier to parse http-equiv accept-cl-lifetime header which will be added in the next CL. Previously, when only accept-ch header was present, it was handled using a different code path then when both accept-ch and accept-cl-lifetime headers are present. This CL changes it to handle the two headers separately. That also makes it possible to unify the two code paths. Change-Id: I1013419a55360249718855677678356f8446ec11 Bug: 852484 Reviewed-on: https://chromium-review.googlesource.com/1125083 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#572495}
-
Kyle Milka authored
Bug: 859381 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ibd5a7f08e9aa20682ca2a43baf491bcfa43f2ca7 Reviewed-on: https://chromium-review.googlesource.com/1123034Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#572494}
-
Adam Rice authored
Once the context in which a fetch is executing has been destroyed the fetch cannot be aborted. blink::BodyStreamBuffer was attempting to abort the fetch anyway, leading to a crash. Check that the context hasn't been destroyed before attempting the abort. BUG=860063 Change-Id: I593dcbfe2f2dacd7be9df456399cd0328da7af39 Reviewed-on: https://chromium-review.googlesource.com/1125543Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#572493}
-
Zhuoyu Qian authored
As the comment in frame_selection.h by yoichio@, rename SelectLineBreak to SelectSoftLineBreak. Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iadba94c4212ff7384f8bd0e460a89bb25c6fbe77 Reviewed-on: https://chromium-review.googlesource.com/1124207Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#572492}
-
Ramin Halavati authored
When network traffic annotation tests are run on Windows without filtering for relevant files (to test heuristics), there might be compile errors that can be ignored. Bug: 844014 Change-Id: Ib1e843971ea8892430142ccb6a5f7ac71714e0ff TBR: georgesak@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1125069Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#572491}
-
Makoto Shimazu authored
This reverts commit 87135a31. Reason for revert: ChromeNetworkServiceBrowserTest.EncryptedCookies keeps failing on Mac10.11 bot. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/27835 Original change's description: > Network Service: Enable encrypted cookies > > Cookies will now be stored encrypted by default in the network service. > Tested that crbug.com/848361 is fixed with this change. > > Bug: 789632, 848361, 789644 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ic627501ddf1c5030bbf2a203f005f5ebca92dfd8 > Reviewed-on: https://chromium-review.googlesource.com/1104791 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Maks Orlovich <morlovich@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572444} TBR=dcheng@chromium.org,jam@chromium.org,mmenke@chromium.org,cfroussios@chromium.org,morlovich@chromium.org,cduvall@chromium.org Change-Id: I192a10c6d28a102dcf5ae247cdbda4c602872eb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789632, 848361, 789644 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1125460Reviewed-by:
-
rbpotter authored
Ensure user can tab to destination list items in the destinations dialog. Bug: 859846 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I137fc8cc73ee6bfef197607ed7a75d711002a6f8 Reviewed-on: https://chromium-review.googlesource.com/1125279 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#572489}
-
Julie Jeongeun Kim authored
Each Ozone platform creates its own NativeDisplayDelegate to get display information. Otherwise, 'display::FakeDisplayDelegate' is used for NativeDisplayDelegate. Per bug, ozone headless is crashing because it uses FakeDisplayDelegate and it doesn't invoke OnConfigurationChanged before initialization completes so ScreenBase can't add the display. Once NativeDisplayDelegate is initialized, DesktopScreenOzone requires DisplayMode from DisplaySnapshot but FakeDisplayDelegate has FakeDisplaySnapshot and it doesn't have DisplayMode. This CL creates HeadlessNativeDisplayDelegate which owns DisplaySnapshot and DisplayMode for ozone/headless. DesktopScreenOzone keeps it in delegate_ and communicates with it. To try this, compile with the following gn args use_ozone = true ozone_platform_headless = true TEST=./out/Debug/chrome --ozone-platform=headless Bug: 851375 Change-Id: I2c097bf54fafb2d9311919647801e401c59ba929 Reviewed-on: https://chromium-review.googlesource.com/1120447 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#572488}
-
Christopher Cameron authored
Add missing patchset from crrev.com/572420 Bug: 826265 Change-Id: I2506916da8a489c83f3c93ff3a143070505c3bba Reviewed-on: https://chromium-review.googlesource.com/1125528Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#572487}
-
Esmael El-Moslimany authored
Bug: 852056 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7c8bde3aa2b5fc77daf1b022f85cbecffa5915ce Reviewed-on: https://chromium-review.googlesource.com/1123403 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This reverts commit 9f1eb0ba. Reason for revert: speculative revert due to cc_unittests failures https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/51119 Original change's description: > Switching all ui/gl dependent tests to SwiftShader > > This cl's switches cc_unittests and viz_unittests from OSMesa > to SwiftShader and fixes other issues related to that change. > > Bug chromium:848035 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Ib1b58e02d4df4a687ef7be57284c06097bdeca94 > Reviewed-on: https://chromium-review.googlesource.com/1070490 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: danakj <danakj@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Eric Karl <ericrk@chromium.org> > Commit-Queue: Alexis Hétu <sugoi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572442} TBR=danakj@chromium.org,sugoi@chromium.org,dcastagna@chromium.org,piman@chromium.org,ericrk@chromium.org Change-Id: I5957fd458b172fd58d4d1fe866e4b07be600c6cb No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1125599Reviewed-by:
-
Junichi Uekawa authored
Also add some blurb about Chrome OS specific things. BUG=None. TEST=read it. Change-Id: Ia9755c354aee0872f7225695c17a5ebdf08cea54 Reviewed-on: https://chromium-review.googlesource.com/1111747 Commit-Queue: Junichi Uekawa <uekawa@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#572484}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/7c8e16a9e9d6..c79c3e591230 git log 7c8e16a9e9d6..c79c3e591230 --date=short --no-merges --format='%ad %ae %s' 2018-07-04 zhuohao@chromium.org kukui: add new paladin Created with: gclient setdep -r src/third_party/chromite@c79c3e591230 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I42499f2fd1d41a50de88dde0987fe5d1fceb56db Reviewed-on: https://chromium-review.googlesource.com/1125422Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572483}
-
Sam McNally authored
Returning transient errors when the refresh token isn't loaded yet was better than persistent errors, but it could result in quite a few errors being returned before a success, sometimes causing DriveFS to give up anyway. Avoid this by waiting for the account to be ready before servicing any access token requests. Bug: 855002 Change-Id: I1578f8f9116592e1ee2864a804269a4a49ba8c92 Reviewed-on: https://chromium-review.googlesource.com/1125551Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#572482}
-
Yutaka Hirano authored
This CL adds DocumentThreadableLoader::module_id_ to see which module is to blame for the CHECK failure. I'll revert this change once the cause is found. Bug: 837511 Change-Id: I76a724d1d8277d5e70afed85bb5576df99d997ca Reviewed-on: https://chromium-review.googlesource.com/1125546Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#572481}
-
Tetsui Ohkubo authored
This CL does two things: * It decreases height of feature pod hover when the pod doesn't have sub-label. (https://crbug.com/858942) * It increases width of the hover when it doesn't have enough space to show detailed view arrow. Previously, it hid the arrow in such case. In order to do that, it increased the width of feature pod button by 28px because we symmetrically increase the hover width. The arrow and the spacing takes 14px in total. Screenshot(before): http://screen/5bzdLf3rGQn Screenshot(after): http://screen/48Jr2f39Kp7 TEST=manual BUG=858942,858913 Change-Id: If1db17c0fa932188b36b02979374253f5cde084d Reviewed-on: https://chromium-review.googlesource.com/1124199 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#572480}
-
Darren Shen authored
It currently returns a mutable reference, which is discouraged by the style guide. TBR=blundell@chromium.org Change-Id: Ie7537feffeeeacf317deb02cc5fa9e90a186db70 Reviewed-on: https://chromium-review.googlesource.com/1123963 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#572479}
-
Yoshifumi Inoue authored
This patch introduces |NGPhysicalTextFragment::IsGeneratedText()| with |NGTextType::kGeneratedText| to distinguish between normal text and generated text, e.g. hyphen and ellipsis, for sorting fragments with |StartOffset()|. This patch is a preparation of the patch[1]. [1] http://crrev.com/c/1114673 Make Element#innerText specification compliant Bug: 859410 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic9879985d1b5dd4cab921ce042ebc393043e3166 Reviewed-on: https://chromium-review.googlesource.com/1122061 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 7403 7404 7406 7414 7419 7422 7433 7442 7450 7454 7467 7472 7480 7484 7490 7494 7499 7507 6 lines were removed and 4 lines were deflaked by consecutive results since 7433. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I65155db15aab968e51e16157ef04bb6a1aa2d5c7 Reviewed-on: https://chromium-review.googlesource.com/1121936 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This reverts commit ced45ea8. Reason for revert: Concurrently a suspicious CL has been reverted: https://chromium-review.googlesource.com/c/chromium/src/+/1125459 Original change's description: > Disable SessionRestoreTest.MemoryPressureLoadsNotAllTabs on CrOS > > TBR=sky@chromium.org > NOTRY=true > > Bug: 860111 > Change-Id: Ida98cb932b4caf9ffb60622a293dfd2da6b5c29d > Reviewed-on: https://chromium-review.googlesource.com/1125540 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572451} TBR=sky@chromium.org,shimazu@chromium.org Change-Id: I3b5b6a885e76e6090c87873880836b7bb3c344f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860111 Reviewed-on: https://chromium-review.googlesource.com/1125559Reviewed-by:
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/22b68f285d2c..5abd99f5f768 git log 22b68f285d2c..5abd99f5f768 --date=short --no-merges --format='%ad %ae %s' 2018-07-04 nednguyen@google.com Make sure that Telemetry only generate skipped entries for filtered stories when test is interrupted Created with: gclient setdep -r src/third_party/catapult@5abd99f5f768 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860091 TBR=sullivan@chromium.org Change-Id: Ic208e995fe193cd69d99a42f5f62db669770ddeb Reviewed-on: https://chromium-review.googlesource.com/1124704Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#572475}
-
Tetsui Ohkubo authored
Previously, brightness change by slider less than the threshold was not ignored in UnifiedSystemTray, which led to some artifacts (see the video in the bug.) TEST=manual BUG=858948 Change-Id: I14dcbe6f02e0b35cb88b468421ca8416b9285dbe Reviewed-on: https://chromium-review.googlesource.com/1124210Reviewed-by:
-
Esmael El-Moslimany authored
Bug: 849857 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I870f5fb93644ac7606d6ea2d810cee7ec9444ed7 Reviewed-on: https://chromium-review.googlesource.com/1120681Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
-
Darren Shen authored
Not used. Can use |GetKeyboardWindow| to do the same thing (check for null). TBR=yhanada@chromium.org Bug: 845780 Change-Id: I4f104099e92032e25c1aec15c3b67850253ad3e8 Reviewed-on: https://chromium-review.googlesource.com/1124737Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#572472}
-
Makoto Shimazu authored
WizardControllerDeviceStateWithInitialEnrollmentTest.ControlFlowWaitSystemClockSyncTimeout is now flaky. It seems affected by crrev.com/c/1118532, but that CL just added some CHECKs to check if it's not captured by ThreadTaskRunnerHandle. I think we need to keep the task runner properly. TBR=jdufault@chromium.org NOTRY=true Bug: 860092 Change-Id: Id7e566d4a48f59e2f2b7121c0875afcd9dc09b24 Reviewed-on: https://chromium-review.googlesource.com/1125554Reviewed-by:
-
Ramin Halavati authored
Flash content settings are planned to become ephemeral and this feature is behind 'EnableEphemeralFlashPermission' switch. To make the ephemeral case more apparent to the user, the 'Add' buttons for 'Allow' and 'Block' exceptions in Flash content settings are removed and this is done by making the list read only. Bug: 850062 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I0c216cc0f319a579bcab1639f0b7345070b474c8 Reviewed-on: https://chromium-review.googlesource.com/1124360Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#572470}
-
Han Leon authored
This CL changes type of blink::ServiceWorkerStatusCode from 'enum' to 'enum class', then updates everywhere it is accessed. BUG=789854 Change-Id: I837d8b0b06924f8f42fa7246231e654e364523f6 Reviewed-on: https://chromium-review.googlesource.com/1124102 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
-
Haruka Matsumura authored
This unit test is named SwapTest. But, in actual, Move() function is called. Change-Id: I929047b9a04dd407534c769c5b4edc97f466c0b4 Reviewed-on: https://chromium-review.googlesource.com/1124341 Commit-Queue: Haruka Matsumura <harukamt@google.com> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This reverts commit 9cd2322d. Reason for revert: This CL seems causing flaky timeouts of HeadlessProtocolBrowserTest.VirtualTimeErrorLoop. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=headless_browsertests&tests=HeadlessProtocolBrowserTest.VirtualTimeErrorLoop%0A Original change's description: > Implemented headless compositor protocol tests for basic rAF, GIF and CSS animations. > > Change-Id: I956ea3523eb42b6d7f0cf851a126c6a11578912e > Reviewed-on: https://chromium-review.googlesource.com/1121378 > Commit-Queue: Peter Kvitek <kvitekp@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572253} TBR=dgozman@chromium.org,pfeldman@chromium.org,kvitekp@chromium.org Change-Id: I777f261f3d4a69ca15cdc4cb717ea485bc5308c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1125480Reviewed-by:
-
Ian Kilpatrick authored
This is to allow easy user-testing. Bug: 591099 Change-Id: Ib08bbe1144b27c0fa37de9a12be9d4d21d00f52e Reviewed-on: https://chromium-review.googlesource.com/1124138Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#572466}
-
Darren Shen authored
In AppListFolderView, we currently use the virtual keyboard occluded bounds without checking if it's empty first. This means that when we use the floating keyboard, which has empty occluded bounds, AppListFolderView thinks that the occluded y position is 0, so it overscrolls the view off the screen. We change the code to only overscroll if the occluded bounds are not empty. Bug: 860087 Change-Id: Ibab4170a73932c587bb87ef368a1682885189429 Reviewed-on: https://chromium-review.googlesource.com/1124733Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#572465}
-
Makoto Shimazu authored
TBR=yosin@chromium.org NOTRY=true BUG: 860117 Change-Id: Ibcb6d72b0bdefa2f4538cb9b04ee753840c804b7 Reviewed-on: https://chromium-review.googlesource.com/1125545Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I6e2c6362dc91c20f182e74de665e488640571b32 Reviewed-on: https://chromium-review.googlesource.com/1125443Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#572463}
-
