GitLab

Bug: 867511
Change-Id: I893a4d7b56d0ba4a14f54bb2fa59c33b51283316
Reviewed-on: https://chromium-review.googlesource.com/1150097Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577963}

ThreatDetails is a ref counted object, and its first reference can be
made by base::BindRepeating through ThreadDetails::StartCollection.
The ref count is released when the callback instance is destroyed.

As the RepeatingCallback instance created in StartCollection is
destroyed after the scope out, `new ThreatDetails` may have returned
a stale pointer.

This CL moves the problematic StartCollection() call out of the
constructor to avoid touching the ref count before its first proper
reference is made.

Bug: 866456
Change-Id: I82b83b9bb30cdc95cff60e3e22e79f0af17645a2
Reviewed-on: https://chromium-review.googlesource.com/1149777Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577962}

The first reference to ResourceRequestDetectorClient instance used to be made by
base::Bind in its constructor, and posted to another thread. If the PostTask call
failed, or the posted task ran immediately after the other thread, the RRDC instance
may destroyed before the construction is completed.

Though this does not actually causes a crash, as no one use the result of
`new ResourceRequestDetectorClient`, this hits an assertion that being added as
a false positive case.

This CL adds ResourceRequestDetectorClient::Start, and makes the constructor
private to ensure no one touches the fragile way.

Also, this converts legacy base::Callback to base::OnceCallback, as a drive-by.

Bug: 866456
Change-Id: Ifb3d8136f03e2e233cf4b0b2b0ee070db6b3093d
Reviewed-on: https://chromium-review.googlesource.com/1149779Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577961}

Code should use the scoped retain/release classes.

BUG=none

Change-Id: I0c538d7ae64127bba9b783fd08584f3164dc949d
Reviewed-on: https://chromium-review.googlesource.com/1148476
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577960}

This test was disabled with MSAN due to the race condition in
OnReceivedThreatDOMDetails. Repeated local runs with MSAN now succeed,
so I think it's safe to re-enable.

Bug: 860445
Change-Id: I4d01568c79562ac1125c4410dbe2c52c17056c2d
Reviewed-on: https://chromium-review.googlesource.com/1149260Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577959}

This was not being saved, resulting in new child RWHViewMacs having
their parent ui::Layer set to nullptr.

Bug: 859834
Change-Id: I8e66370381406d8cc1dfb2aac9d81397c1775831
Reviewed-on: https://chromium-review.googlesource.com/1148940Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577958}

Enable tests that were disabled because of this functionality missing.

Bug: 842325
Change-Id: I6f540460f4e5f81d7ff8dd36e4abf369f0bd4785
Reviewed-on: https://chromium-review.googlesource.com/1149612Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577957}

This reverts:
https://chromium-review.googlesource.com/c/chromium/src/+/1123169
https://chromium-review.googlesource.com/c/chromium/src/+/1141102

...which are the gpu and oop raster versions of the same change,
respectively.

There was some hope that by freeing fewer resources we would help with
input latency, but this does not appear to have the desired effect in
either UMA or on bots.

Because this is a 4mb regression on Android (and maybe 12mb in WebView)
revert these two changes.

Bug: 863756, 865617
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I64eb735700ed1b704e191281ff79a01bccaff4e5
Reviewed-on: https://chromium-review.googlesource.com/1149093Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577956}

This is essentially a part of InteractiveDetector, belongs
to the loader.

Bug: none
Change-Id: I05bcf109b352c8054113003fe57b9de120af2bc0
Reviewed-on: https://chromium-review.googlesource.com/1149275Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577955}

skia_paint_util* were split out from skia_util* last year.  Copy danakj@ as
owner since that's how skia_util* are set up.

Bug: none
Change-Id: I3bc5486932f0a7acfda1530f7b8ff5a85b71397c
Reviewed-on: https://chromium-review.googlesource.com/1149455Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577954}

Bug: 864565
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I8ae19f0318802404f354fc474a62299aad713afd
Reviewed-on: https://chromium-review.googlesource.com/1149582
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577953}

TBR: hajimehoshi
Bug: 867339
Change-Id: I7eedb205332e140722339707eb5fc4fc8f46b3c1
Reviewed-on: https://chromium-review.googlesource.com/1150289
Commit-Queue: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577952}

Bug: 866883
Change-Id: I03fa831e8f31162217407b969eef7b4abbe2cf57
Reviewed-on: https://chromium-review.googlesource.com/1150168Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Oleh Prypin <oprypin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577951}

With constexpr you make it slightly easier for the compiler to
optimize code, though the effect will be small.

Also, with constexpr types the compiler becomes better at telling
us when a variable is unused. This removes such variables.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I6b52edc7ef67167bf8b7864c97a5f57b50d85398
Reviewed-on: https://chromium-review.googlesource.com/1131509
Commit-Queue: Daniel Bratell <bratell@opera.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577950}

- The standalone headless_shell needs to invoke the Seatbelt server
  in its child processes.
- The --headless flag in Chrome needs to set up the CHILD_PROCESS_EXE
  override for finding the Helper.app. The --headless flag was incorrectly
  spawning the main app executable rather than the helper.

Bug: 866606, 689306
Change-Id: I0e4fec109fad5577263059fd0b62dea3bb966860
Reviewed-on: https://chromium-review.googlesource.com/1148478Reviewed-by: David Vallet <dvallet@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577949}

Fixes a few small format string bugs and makes the windows library
configuration #defines more friendly for chromium builds.

Based on original CL: https://codereview.chromium.org/2730473002

BUG=724399,b:70905156

Change-Id: If54c6cfc5c508744d2ee18f251677b2456acda72
Reviewed-on: https://chromium-review.googlesource.com/1145626
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577948}

The refresh token is updated to a new valid one in case of reauth. In this case
the old and the new refresh tokens have the same device ID.

When revoking a refresh token on the server, Gaia revokes all the refresh tokens
that have the same device ID.

This CL avoid revoking the old refresh token when to avoid Gaia revoking the new
token soon after a reauth.

Bug: 865189
Change-Id: I9c2a64f30e14a5376c530f3b511c212b70738f3a
Reviewed-on: https://chromium-review.googlesource.com/1145073
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577947}

On touch adjustment, we do a point-base hit test after the rect-base one
to make sure we find the correct target. This cl changes the point-base
hit test from the iframe to the root frame. Because when we have iframe
overlap by other elements, rect-base hit test might result an incorrect
target in the iframe. In-frame hit-test cannot find the correct target
that is outside the iframe. So, we should do the point-base hit-test on
root-frame to find the correct target.

Bug: 864849
Change-Id: Ib176a68e5c51eba40c504ad90190bec7fb66dccb
Reviewed-on: https://chromium-review.googlesource.com/1145477Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577946}

Bug: 806868
Change-Id: Id1204fad26029f7358d9628590d713b9c2af01f3
Reviewed-on: https://chromium-review.googlesource.com/1143895Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577945}

This is a preparation CL to remove animations when populating
the history TableView and when performing a search.

In order achieve that we need to reload all the content of the
TableView instead of inserting/removing specific entries. This
causes previously selected items to deselect when searching.
For this reason there's no purpose to searching while editing
is enabled, furthermore selecting the search bar will deselect
selected items, which can be frustrating for the user.

This CL disables the searchBar while the table is on Edit mode.
The user can still search something and edit the results of the
query, but it can't perform a new search query before exiting
edit mode. This is the behavior of the legacy implementation.

Screenshots:
Enabled
https://drive.google.com/open?id=1ZdplK968U4XgBE1cFSB9L4scblJwFeBN
https://drive.google.com/open?id=1dH47e9tPHmDd2eUuOUVIt-W3Nay4v_A1

Disabled
https://drive.google.com/open?id=1Gp4IXNawohaZnlwSnQTSJ0LLbvaFW6Iw
https://drive.google.com/open?id=1aDPPjOd3DqX99vncP2wNXNHx_XKRyGhM

Bug: 859736
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I705a936f8bb339ab29a1431d7d4d969d77337d71
Reviewed-on: https://chromium-review.googlesource.com/1148890Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577944}

Bug: webrtc:9532
Change-Id: Ia22b7976dc520ff968289d805de2ccc08635eb71
Reviewed-on: https://chromium-review.googlesource.com/1144149Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577943}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/58ea46ee..d729403c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I06b66ca92085d13d3fea0a10fa38da5161d5f601
Reviewed-on: https://chromium-review.googlesource.com/1149990Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577942}

All channels of Chrome should use the same preferences. This
updates two preference accesses that were not updated in the
original change.

BUG=866750, 831577

Change-Id: Ibd0f8d2895027eb85772b3f5308ffebaef3aff32
Reviewed-on: https://chromium-review.googlesource.com/1148473Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577941}

Remove Cocoa dependency from WebTextfieldTouchBar by moving
it from TabContentsController to BrowserWindowTouchBarController.

Hook up BrowserWindowTouchBarController to
AutofillPopupControllerImplMac on MacViews so that the
credit card touch bar can be updated.

Move the the logic that listens to WebContent changes to the
BrowserWindowTouchBarController. When the WebContents has
changed, BrowserWindowTouchBarController will update the
WebContents in BrowserWindowDefaultTouchBar and
WebTextfieldTouchBarController.

Modified SuggestedTextTouchBarController so that when its
WebContents has changed, it'll observe the new WebContents.

Bug: 856391
Change-Id: I9c29a371a0b38eb608bf8e32521abe22d5c664e0
Reviewed-on: https://chromium-review.googlesource.com/1135829Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577940}

Bug: 775415
Change-Id: I1184b1e058c80151cfb8226edfcb84558057bbb4
Reviewed-on: https://chromium-review.googlesource.com/1150150Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577939}

This CL eliminates NetworkingConfigDelegate by providing the
captive portal provider info in NetworkState directly.

This CL also:
* Adds NetworkState::ProviderInfo struct for both VPN and captive portal
* Renames NetworkingConfigDelegateChromeosTest ->
  NetworkingConfigChromeosTest since it wasn't testing the delegate
  per-se, but the functionality it was providing.

Bug: 651157

For trivial rename in arc_net_host_impl.cc:
TBR=hidehiko@chromium.org

Change-Id: Iab872220aaedbcf27b4228581931e39c43dbab97
Reviewed-on: https://chromium-review.googlesource.com/1141210Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577938}

https://skia.googlesource.com/skia.git/+log/42c1c03334c7..b284280be4cc


git log 42c1c03334c7..b284280be4cc --date=short --no-merges --format='%ad %ae %s'
2018-07-25 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 096c5296c3b0..2160821e16db (1 commits)
2018-07-25 mtklein@chromium.org temporarily disable t8888 config on *SAN bots
2018-07-25 benjaminwagner@google.com Revert "Blacklist hanging test."


Created with:
  gclient setdep -r src/third_party/skia@b284280be4cc

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I0b95381d5167f1c034b7c481cb00ac567652dabb
Reviewed-on: https://chromium-review.googlesource.com/1150049Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577937}

Currently calls to FindPolicyByGuidAndProfile produce an error when
called with an empty profile path. There are several places where this
can occur, but we recently added one to the system tray UI:

https://chromium-review.googlesource.com/c/chromium/src/+/1101204/12/ash/system/network/network_list.cc#813

Rather than ensure that we test for an empty profile path everywhere
(which just indicates a non favorite/saved network), just return nullptr
with no error when the path is empty.

Bug: None
Change-Id: I692babc10ae2472e8fa5dbfef1c8be170cc841b2
Reviewed-on: https://chromium-review.googlesource.com/1149096Reviewed-by: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577936}

ChildProcessCrashObserver.java serves a similar purpose as
CrashDumpManager.java did (which it will replace), except without the
need (or ability) to check for a minidump on the filesystem. Instead of
a minidump path, the process ID of the crashed child is passed to the
callback which it can use to identify the correct crash dump.

Bug: crashpad:30
Change-Id: I718e653acfa35b14ebaa17d0e8c76804f9856dfb
Reviewed-on: https://chromium-review.googlesource.com/1150202Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577935}

https://webrtc.googlesource.com/src.git/+log/e095b819400f..e71d1bb7fc22


git log e095b819400f..e71d1bb7fc22 --date=short --no-merges --format='%ad %ae %s'
2018-07-25 nisse@webrtc.org Delete obsolete file api/videosourceinterface.h.
2018-07-25 titovartem@webrtc.org Move g722 to proper third_party directory


Created with:
  gclient setdep -r src/third_party/webrtc@e71d1bb7fc22

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I08c055b641e6c5040002b2ff1ff3c2e9730d59d9
Reviewed-on: https://chromium-review.googlesource.com/1150047Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577934}

NestedSubscription is a ref-counted object, and its first reference used to
be made by base::BindOnce in its constructor. The reference is passed to
another thread, and released when the callback instance is destroyed.

However, if the PostTask failed or the posted task ran soon before the
constructor finished to construct the NestedSubscription instance, the
ref count is decremented to 0, and `new NestedSubscription` may return
a stale pointer.

This CL adds a static constructor to avoid that by splitting the ref-count
related set up out of the constructor.

Bug: 866456
Change-Id: Idf03b31b95b4a7ddee81fdebff78a594e52a62f8
Reviewed-on: https://chromium-review.googlesource.com/1149762Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577933}

In some languages, the translation is too long for the bottom toolbar to fit it and the "edit" button without truncating. Since we have little control over BarButtonItems, we should cap the length at 16em to allow for both to be readable.

Bug: 841289
Change-Id: I19e76002baac55c2ed3099e54dfb504862662597
Reviewed-on: https://chromium-review.googlesource.com/1148996Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577932}

Some methods like HttpURLConnection.getHeader() hide IOExceptions,
but later calls to getResponseCode() would then throw unexpected
IllegalStateExceptions. Instead getResponseCode() should rethrow
the previously hidden IOException.

Bug: 866911
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: Icc533d4a69875af5570a6f793463754d1bf477ab
Reviewed-on: https://chromium-review.googlesource.com/1148475Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577931}

CrashMetricsReporter::CrashDumpProcessed can be called multiple times
for the same process; see the comment in
ChildProcessCrashObserver::OnChildExit.

Previously we avoid duplicating collecting stats by checking that if
the dump is missing, meaning it has already been crashed before.

This mostly still works except for NotifyObserver call which is still
called under kMissingDump, so fix that.

Change-Id: I2145a0df8c604739f86fb9ab9cecf845168dcbfe
Reviewed-on: https://chromium-review.googlesource.com/1148558Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577930}

This patch manually snaps the omnibox dropdown popup widget window to
the physical pixel grid. On CrOS the popup is treated as a top level
window which is by default snapped to the root window.

This patch also lazily marks the root windows as snapped. The root
windows are snapped by default so marking them snapped makes sense.

Bug: 843250
Change-Id: I1dd20ea57522e4987d23ba7dcaa3ae891bbc7182
Component: Omnibox popup, desktop window tree host
Reviewed-on: https://chromium-review.googlesource.com/1139078Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577929}

Makes the method use TimeDelta instead of double to represent
duration.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id95aface04fa2b72bc919fd4ab52af062908f8df
Bug: 763980
Reviewed-on: https://chromium-review.googlesource.com/1140355Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577928}

This CL lands part of internal change 201519764.  The rest of that
change has been merged in https://crrev.com/c/1121700 (reviewed at
https://crrev.com/c/1121285).

Bug: 488484
Change-Id: I78b225c43af626eb7c6e3054b85e44018387b8cb
Reviewed-on: https://chromium-review.googlesource.com/1146664
Commit-Queue: Yang Song <yasong@chromium.org>
Reviewed-by: Yang Song <yasong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577927}

Currently the run_tests_rebaseline.sh script does not work as
intended due to the switch to AndroidJUnitRunner. This CL fixes
the script and makes it possible to rebaseline webview layout
tests as originally intended.

Change-Id: If055a4460925ea5e18d3996d927c8596b9027a7a
Reviewed-on: https://chromium-review.googlesource.com/1150160Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577926}

Bug: 847948,852341
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I77f63093d642a51193787641568a639f80d5c5e1
Reviewed-on: https://chromium-review.googlesource.com/1148796
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577925}

Previously I assumed -webView:didReceivedAuthenticationChallenge callback
is always called for the navigation associated with the current
WKWebView.URL value. In testing, it turns out in back/forward navigation,
this callback may be triggered for a subresource on the previous item
after WKWebView.URL has already been updated to the new item. As a result,
this DCHECK is incorrectly triggered when navigating back to NTP from a
web page before the web page finishes loading completely.

From code inspection, the implementation of this delegate call doesn't
depend on states associated with self.currentNavItem. This scenario
already exists between web pages. So the DCHECK is not protecting any
meaningful state corruption.

Bug: 864525
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I02a1678721e2db59ed1f288c9e4ec7139efc8632
Reviewed-on: https://chromium-review.googlesource.com/1147328Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577924}