- 14 Oct, 2020 40 commits
-
-
My Nguyen authored
Update as per http://go/cros-lang-settings-ux-writing Screenshot view: http://screen/9F2Fojjr8QvdVjL Bug: 1113439 Change-Id: I1f5ce8b827770a1d172bd4052e82670e3e868122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469916Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#816869}
-
Wenyu Fu authored
Due to issues in Android ViewPager, screen reader can lose a11y focus sometimes when switching between pages. As work around, this CL adds an interface for each FirstRunFragment to specify a11y focus when each page is populated on the screen. Bug: 1094064 Change-Id: I44a3162834744980bc0a2a72c192b465d3c2211f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458880 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Auto-Submit: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#816868}
-
Jamie Madill authored
Also separates out GLES 1 tests into its own definition. Bug: angleproject:5124 Change-Id: Id0936d7b5e835ac48f621df2ac0620b40e3e70a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469518Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#816867}
-
Nicholas Verne authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/16aafbd27d09..ebddc236e489 $ git log 16aafbd27..ebddc236e --date=short --no-merges --format='%ad %ae %s' 2020-09-29 nverne permission_broker: separate lifeline_fd for usb driver tracking. 2020-10-05 acostinas system_api: Go proto bindings for patchpanel 2020-10-08 yich cryptohome: add has_reset_lock_permissions in RPC 2020-10-05 yichengli system_api: Add method name to cancel user authentication dialog 2020-09-16 vovoy system_api: Rename GetMemoryMarginKB to GetMemoryMarginsKB 2020-09-23 yhong system_api: append USB removable info in runtime_probe's D-Bus response Created with: roll-dep src/third_party/cros_system_api Bug: 1128866 Change-Id: Ia13ad55a3c3ebb514533634e77d7e11f5c33a1b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469339 Auto-Submit: Nicholas Verne <nverne@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#816866}
-
Rakib M. Hasan authored
Several web platform tests do not have physical files checked into the WPT repository. Instead they are generated and mapped to test harnesses checked into the WPT repo. When those test harnesses are deleted then we should delete all tests mapped to those files. Only affects the behavior of the script when --clean-up-affected-tests-only is used. Bug: 1050760, 1110003, 801357 Change-Id: Id1c30b096c73974ed0ded2d74284fbe43005ee0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439417 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#816865}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e2893f2df8b2..6b8b2ea6be63 2020-10-14 mtklein@google.com move cfi stifle post-refactor If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1137652,chromium:1137958 Tbr: robertphillips@google.com Change-Id: I2878b278e9687861fde17b195722628f90c95e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469702Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816864}
-
Edward Lesmes authored
Add Generate DIR_METADATA files and remove metadata from OWNERS files for //extensions/browser/api. R=karandeepb@chromium.org, rockot@google.com, shend@chromium.org, tbarzic@chromium.org Bug: 1113033 Change-Id: I93f0000e3d7c657eddb8b077df18b26e01245dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468712 Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#816863}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a1f28a40. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I3c18112d8fa6fa2c11f93b2e4f19c3eb138ef326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469816Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816862}
-
Tomasz Tylenda authored
This changelist tackles code locations where the caller explicitly requires base::RepeatingCallback (or RepeatingClosure). BUG=764795 TESTED=build Change-Id: If4ab805076529ffbe76443849761bacda2b724af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463051Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Tomasz Tylenda <ttylenda@chromium.org> Cr-Commit-Position: refs/heads/master@{#816861}
-
Pilar Molina Lopez authored
Change expiration date of histograms: ConfigureDisplays.External.Modeset.Resolution ConfigureDisplays.Internal.Modeset.FinalStatus ConfigureDisplays.Internal.Modeset.RefreshRate Bug: 1130632,1121213 Change-Id: Ieb934bb15f48495f7832376d2b58fd5d875b2a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457046Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#816860}
-
Lukasz Anforowicz authored
content::PepperPluginInstance::Navigate was never called or referenced. Therefore, this CL removes this method and its overrides. Bug: 1064652 Change-Id: I20301b34f2d4775205cd9cedcf100457996966ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463852 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#816859}
-
Kenichi Ishibashi authored
The helper function can be replaced with BindLambdaForTesting. Using BindLambdaForTesting allows us to use references instead of raw pointers for out parameters. Bug: N/A Change-Id: I864cbb4a74054fe53d1c45c937d7b25f06b7222b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469919 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816858}
-
Sunny Sachanandani authored
TBR=zmo@chromium.org Bug: 1136971 Change-Id: I7cdb1c6e93f36a53a1e650ad2a1aff5da963adbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469899Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#816857}
-
Weilun Shi authored
This is a no-op for histogram generation but it brings a huge benefit for us to migrate suffixes to patterned histograms. i.e. '.' in the string placeholder is not supported in string.format(). This is generated by a script: histogram_suffixes.setAttribute('name', histogram_suffixes.getAttribute('name').replace('.', '_')) Bug: 758782 Change-Id: Ie0315911fc1d635fd5c697c198c013ee7a88037b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466900 Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by: -
Jamie Madill authored
This forces the test suite off of some one-off Android configs and some Linux configs. Re-enables the test suite on AMD 550 RX because it seems to be passing without issues. Bug: angleproject:5124 Change-Id: If36a2dd72499e852ff41041a2495f1f47bd02213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469956 Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Jamie Madill <jmadill@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#816855}
-
Alan Cutter authored
This reverts commit 2dbccf3e. Reason for revert: Flaky crashes on bots. external/wpt/webxr/xrStationaryReferenceSpace_floorlevel_updates.https.html STDERR: #4 0x55ea51c21abc blink::XRSession::UpdatePresentationFrameState() Bug: 1138047 Original change's description: > WebXR: add recommendedViewportScale > > This uses an estimated GPU utilization ratio from ArCoreGl. The goal is > to reduce the recommended viewport scale if the web app is unable to hit > a target framerate due to excessive GPU work, but not do so if it's slow > due to excessive JS computations or similar where reducing the viewport > wouldn't help. This is opt-in, the scale only takes effect if the app > calls view.requestViewportScale(view.recommendedViewportScale) followed > by xrwebgllayer.getViewport(view). > > (Dynamic viewport scaling is only available if WebXRIncubations is > enabled.) > > Spec link for context: > https://immersive-web.github.io/webxr/#dom-xrview-recommendedviewportscale > > Change-Id: I0a8598d8bd03f27fd1d2cc6c542ff79812825d74 > Bug: 1133381 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213113 > Commit-Queue: Klaus Weidner <klausw@chromium.org> > Reviewed-by: Sam McNally <sammc@chromium.org> > Reviewed-by: Piotr Bialecki <bialpio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816813} TBR=sammc@chromium.org,klausw@chromium.org,bialpio@chromium.org,elalish@chromium.org Change-Id: Ic34275b3c147c9428d7d57c1a876a91b172bc586 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469640Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#816854}
-
Weilun Shi authored
Add suffixes_to_varaints.py to support migrating all histogram_suffixes to new patterned histograms. The script currently only handles the simplest case, i.e. Suffixes with only one affected histogram to migrate to inline histograms. Bug: 758782 Change-Id: I32905df5df5d00310c3029674a95d2705dab2f7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464207Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5458f6cbefc1753e8ef1ec884409d48d5cc1f1ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469660Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a08dc37d19e5..095444c21262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I18465497dc89bdc231b01a9ba959a4714b7b59ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469402Reviewed-by:
-
Hiroki Sato authored
CL:2398438 changed the focus handling in ARC++ accessibility and when a user visits various windows in the same task, it intended to remember the last focused node for each window. However, there is a bug. ArcAccessiblityHelperService allocates chrome node id to each node and window, and that id is different if the root window id is different. As Android accessibility framework exposes only visible windows, even in the same task, the same chrome node id can be reused because visible root window can easily changes in a task. Thus, we should not have used chrome id to remember the last focused node, instead, we should use the android side window id. This change fixes the above issue. AX-Relnotes: n/a. Bug: b:169201305 (Initial focus issue in TextEditActivity) Test: tast arc.AccessiblityEvent (without CL:2467224) Test: unit_test AXTreeSourceArcTest Change-Id: If55058d9d66a636d54b73d3cd92a4bd2b5fea214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467738Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#816850}
-
Fergal Daly authored
Now, when the current frame is not live, creating a new frame for navigation also calls CommitPending to immediately commit the replacement. This happens when the current frame is - crashed - the very first main frame of the frame tree and navigation is requested before it becomes live, e.g. in a test that immediately navigates. This CL only addresses the crashed case. Support for this path has been causing various issues over time (most recently for RenderDocument, COOP/COEP, and bfcache), so removing it will make the navigation logic simpler and easier to reason about. The most complex part of this is handling the corner case of the commit failing. Things going on in this CL: - skip the early commit if requested - reset RenderViewHost's main frame back to the crashed frame if the navigation fails - reenable CrossOriginOpenerPolicyBrowserTest.CoopPageCrashIntoCoop - move ShouldCreateNewHostForCrashedFrame so that this feature can depend on it - handling the sad-tab We already have half of the desired behavior of not sitting around on a sad tab during slow navigations via SadTabHelper::RenderViewReady(), which clears the sad tab whenever we reinitialize the RenderView while showing the sad tab. Switching that to observe RenderFrameCreated should let us clear the sad tab on any new navigation, as well as edge cases where the renderer process might be reinitialized by a renderer debug URL. Cancelling the navigation also behaves sanely: it returns to a sad tab while updating the omnibox to show the previous URL. This is a port of https://crrev.com/c/2409886 that does not rely on the refactoring. Bug: 1072817 Change-Id: I3468c84f73354e4f0ad9bd747290feffe3349978 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426086Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
Previously RasterContextProvider kept raw pointers to SharedImageInterface and ContextSupport interfaces. These pointers were also passed to OutputMailbox instances, which may outlive the decoder. There as nothing to guarantee that OutputMailbox doesn't outlive the SharedImageInterface implementation. Updated the decoder to use a ref-counted pointer to RasterContextProvider interface. This allows to ensure that SharedImageInterface is not destroyed before the OutputMailbox instances that depend on it. Bug: 1133325 Change-Id: I60b664d89207535d968cf998488457c789c800c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441935Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816848}
-
Jorge Lucangeli Obes authored
Per the original design doc, the fd passed to the remote end needs to be the *read* end of the pipe: https://docs.google.com/document/d/1m5NKwLRleJUoZppKva4QLpnHRYFBBCd280IFHhgqhVg/edit int pipe_fds[2]; int ret = pipe(pipe_fds); // Write end of the pipe. int lifeline_local = pipe[1]; // Read end of the pipe. This gets passed as |lifeline_fd|, // wrapped as a D-Bus fd type. int lifeline_remote = pipe[0]; Bug: 1135721 Change-Id: Ia7eed8a47b63662c235078fe9b470215e030ebf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466151 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#816847}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bc2dd313cf94..ad80b184a00d 2020-10-13 jmadill@chromium.org Test Runner: List tests explicitly without GTest. 2020-10-13 syoussefi@chromium.org Vulkan: Fix command reordering on release to external 2020-10-13 Kyle.Griffiths@imgtec.com Add PowerVR Vendor ID & Vulkan GL Line Emulation Exclusion 2020-10-13 bsheedy@chromium.org Update IsARM64 2020-10-13 jmadill@chromium.org Broaden Clear test failure to all OSX. 2020-10-13 jmadill@chromium.org Capture/Replay: Embed ANGLE version in replay. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1132295,chromium:1135792,chromium:1136367 Tbr: ynovikov@google.com Change-Id: I372c655b6b085cfe47cf26db6cf14e5959d37d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469661Reviewed-by:
-
Will Harris authored
Add missing WIN10_19H2 entry, and update tests. BUG=1130738 Change-Id: Ia9208cebdd092c084468bf31482907afe56a4ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458328 Auto-Submit: Will Harris <wfh@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#816845}
-
Weilun Shi authored
We want to update histograms with tokens first before updating histograms with suffixes. As we're migrating to the new patterned histgorams, some based histograms will be generated from variants so _UpdateHistogramsWithTokens function need to be aware of that. Bug: 758782 Change-Id: I94910b384d8880b9ed314a8b70dbe831c58a9de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464431Reviewed-by:
-
Lambros Lambrou authored
This replaces a NOTREACHED() with a basic RTC log writer implementation that simply returns a protocol error to the client. The RTC log FileOperations class is meant to be download-only, but the file-transfer protocol permits the client to try to upload files to it. This code-path is never intended to be exercised - this CL simply prevents the host from crashing in this situation. Bug: 1122798 Change-Id: I838e575530a89b837f64f2fe28c29fd291a88820 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461225Reviewed-by:
Erik Jensen <rkjnsn@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#816843}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ie480e82698afba82b4a34cbef6bb717d707b7214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469696Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d87fc47381a..cae3bad79262 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com,marshallk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alancutter@google.com,marshallk@google.com Change-Id: Ia1592b0140b50f77a6a7de18a46fa05a9d906cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469657Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#816841}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/095444c21262..0150a791fcb7 2020-10-13 treehugger-gerrit@google.com Merge "docs: fix instructions for adb shell perfetto" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ife68d0e14a99d03a65cf378e3f61d21d68bb1433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469658Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1148dc0fdaad..ad59e7a16b5d 2020-10-14 jalyn@microsoft.com Show tooltips on keyboard focus If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:963183 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id3b446ef09ec3d4553deb9e2084c6bd80cc55982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469665Reviewed-by:
-
Alexandre Courbot authored
BUG=b:153935975 TEST=Chromium builds for arm-generic. Change-Id: I9d4fe6fc3345e6b78240e8218603e50a8dd7e1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2460528 Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#816838}
-
Avi Drissman authored
If the user attempts to open a file selection dialog but they are disabled by policy, the policy code attempts to show a warning infobar. Do not crash in the case where it is not possible to show an infobar. Fixed: 1137482 Change-Id: I64c02a42e8c84293e73ec3eefb3d72323c933a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469256 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816837}
-
Findit authored
This reverts commit 4363f493. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 816834 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQzNjNmNDkzNDNkZjgyZDNiOWJiMmZiYmI1NWJjNDQ0OGVhYmZmNGEM Sample Failed Build: https://ci.chromium.org/b/8866507600045542768 Sample Failed Step: compile Original change's description: > [PartitionAlloc] Zero on free. > > This CL 'zaps' (`memset`s) the allocated region on free. This may > help detect some instances of UAF, causing them to crash (with > nullptr deref). > > Rather than doing so on every free, we zap probabilistically to > reduce the performance impact. > > If the perf bots show an unacceptable regression, we'll revert this. > But, it might be acceptable. > > Bug: 1005070, 1013329, 1013326, 1013324 > Change-Id: Ia36ee17625290646216985dd6fdffabfa84a9ba2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873272 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#816834} Change-Id: I3ebcc5179fa0830faa5c9df8dae63a562cdb0b1b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1005070, 1013329, 1013326, 1013324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469840 Cr-Commit-Position: refs/heads/master@{#816836}
-
Gordon Seto authored
Remove the close button from the disable confirmation dialog as it duplicates functionality already in the cancel button. Remove the confirmation description as it repeats the title. Screenshots: Before: Autoclick: https://screenshot.googleplex.com/uB3ZhRSmVTGSLRg.png Switch Access: https://screenshot.googleplex.com/7WsEbWDBb77MwDg After: Autoclick: https://screenshot.googleplex.com/3DNmukRFCNQ6WoG.png Switch Access: https://screenshot.googleplex.com/3xveLtXSYo86cYL.png Bug: 1125247 Change-Id: Iaf0f008e7e3d6f8fa17ec58eaf7575c27df90303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466508 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#816835}
-
Chris Palmer authored
This CL 'zaps' (`memset`s) the allocated region on free. This may help detect some instances of UAF, causing them to crash (with nullptr deref). Rather than doing so on every free, we zap probabilistically to reduce the performance impact. If the perf bots show an unacceptable regression, we'll revert this. But, it might be acceptable. Bug: 1005070, 1013329, 1013326, 1013324 Change-Id: Ia36ee17625290646216985dd6fdffabfa84a9ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873272 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#816834}
-
Kenichi Ishibashi authored
To remove ServiceWorker{Registration,Version} dependencies from the test so that the test can be moved to the Storage Service. Bug: 1016064 Change-Id: Ic1653d69e432bcbcf4f50e725a7c3e70bf29f637 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467260Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#816833}
-
Joe DeBlasio authored
This CL prevents same-document navigations such as history.pushState and fragment navigations from resulting in a closed Safety Tip. Fixed: 1137661 Change-Id: Id0125055147d50c936c26a8763839e1f47244f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468189Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#816832}
-
yjliu authored
Throttling Android apps from ash through wayland protocol. This is done by manipulating the vsync updates intervals in exo. Because vsync is global for all android apps, we don't apply throttle if at least one android app shouldn't be throttled. Bug: 1107201 Change-Id: I39f761f9460120928687058732942739bb26c88b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389326Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Jun Liu <yjliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#816831}
-
Kenichi Ishibashi authored
The following test uses ServiceWorker{Registration,Version}. * InstallingRegistrationsAreFindable * OriginTrialsAbsentEntryAndEmptyEntry * AbsentNavigationPreloadState ServiceWorker{Registration,Version} can't be used from the Storage Service. Move the test to service_worker_registry_unittest.cc so that service_worker_storage_unittest.cc can be moved to the Storage Service. Bug: 1016064 Change-Id: I2b1f25c5ac0f0461d51cb2eeaa7d4ccf1f180a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2467303 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
