- 04 Oct, 2019 40 commits
-
-
Dominic Battré authored
Revert "Disable flaky ContentSubresourceFilterThrottleManagerTest.ActivateMainFrameAndFilterSubframeNavigation" This reverts commit c5ab8e6f. Reason for revert: Root cause is unrelated to this test. See crbug.com/1011275 Original change's description: > Disable flaky ContentSubresourceFilterThrottleManagerTest.ActivateMainFrameAndFilterSubframeNavigation > > TBR=battre@chromium.org > > Bug: 1010687 > Change-Id: I812d814b45c9ca6921f3d23bc2b11558e87d6472 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836297 > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Auto-Submit: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702678} TBR=battre@chromium.org,yoichio@chromium.org Change-Id: Ia7fd5899cdc4ce42ff7a66a81b6fd69597db082d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1010687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839952Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#702776}
-
Henrique Ferreiro authored
Convert the implementation and all users of the web_ui_test::mojom::TestRunner interface. Bug: 955171 Change-Id: Ied3de09b76642c99f42b4615ab6393f00b13bbf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833605Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Cr-Commit-Position: refs/heads/master@{#702775}
-
Arthur Hemery authored
Filtering the remaining failing tests on linux for the BackForwardCache. Bug: 1010870 Change-Id: I4f43fbb5c015f9ac58c32108ed566130e16049af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839673 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#702774}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5549ef0451f9..5a42da564fbe git log 5549ef0451f9..5a42da564fbe --date=short --no-merges --format='%ad %ae %s' 2019-10-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 44b32176ee48..8fa0f1a6567c (4 commits) 2019-10-04 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 7bc047326e06..135e3e35ea87 (1 commits) Created with: gclient setdep -r src/third_party/angle@5a42da564fbe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Bug: chromium:None,chromium:None Change-Id: I0280dcc3a4935305a02352470c65a90c1f641fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838984Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702773}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/94c33f91b3c2..aa4d8a75604d git log 94c33f91b3c2..aa4d8a75604d --date=short --no-merges --format='%ad %ae %s' 2019-10-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@aa4d8a75604d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: If3d94ceecc56c2d5b842f940b9fbb724cd8209cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839439Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5fb11187..ec261d9d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia6d29f079a7b6a0acf2b0e3399078ac3c8022fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839606Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702771}
-
Tetsui Ohkubo authored
TEST=Enable debug shortcuts and press Ctrl-Shift-Alt-W BUG=b:128650292 Change-Id: I463a74c8dadad39f1d2648c94e330b897f7fe67d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838844Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#702770}
-
Kenichi Ishibashi authored
After crrev.com/c/1832202 renderer startup traces has been recording correctly under the category "startup." Add the category to service worker background tracing config so that we can collect these traces. Bug: 561209 Change-Id: Ic27214be3f328dff47365083d8797dc7f36b3c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839278Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#702769}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e65131f1a930..6b5c3cdb7611 git log e65131f1a930..6b5c3cdb7611 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 vapier@chromium.org stringify exceptions to move away from Exception.message Created with: gclient setdep -r src/third_party/chromite@6b5c3cdb7611 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I087c275d722eea6e56f0a56eea2e14c82461115c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839253Reviewed-by:
-
Hiroki Nakagawa authored
TerminateAllWorkersForTesting() causes deadlock depending on timing. This CL replaces the function with a combination of TerminateForTesting() and WaitForShutdownForTesting() that are equivalent to TerminateAllWorkersForTesting() but don't acquire the lock. TerminateAllWorkersForTesting() on the main thread calls WaitableEvent::Wait() while that is holding the ThreadSetMutex(). The mutex is also referenced from the worker thread during worker startup in InitializeOnWorkerThread(). Deadlock happens when the main thread starts termination immediately before the worker thread tries to acquire the lock to insert itself in the thread set. Note: TerminateAllWorkersForTesting() is still used from LeakDetector. I'll try to remove/change it in a separate CL. Bug: 1003217 Change-Id: I7896057c1c65a830c621e120123558403a94c951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839224 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#702767}
-
Chih-Yu Huang authored
In CL:1824717, we separated media::VideoFrameLayout::Plane to media::ColorPlaneLayout. This CL also rename the correlated mojo struct to "ColorPlaneLayout". BUG=b:136716638 TEST=component_unittests --gtest_filter=VideoAcceleratorStructTraitsTest.* Change-Id: I8073594a342af294f942b47eb1982303284f7261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837315Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702766}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e0c233ff55db..fbdf48ecb204 git log e0c233ff55db..fbdf48ecb204 --date=short --no-merges --format='%ad %ae %s' 2019-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 61886adc..24e29940 (420 commits) Created with: gclient setdep -r src/third_party/skia@fbdf48ecb204 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None Change-Id: I6959ba66d9de1f5220f3def593e62076211e9fce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839023Reviewed-by:
-
Luca Hunkeler authored
After http://crrev/c/1808180 the bottom sheet is set up lazily. This allows us to start autofill assistant after CCT startup has completed, which makes our integration tests easier to setup and run. Bug: b/141838297 Change-Id: I729fd5e453d883b6124beb3d357d146b7bb79531 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837773 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#702764}
-
Eric Willigers authored
blink::mojom::DisplayMode replaces LaunchContainer in WebApp and AppRegistryController. Not yet updated: - sync_pb::WebAppSpecifics - InstallManager::InstallParams Bug: 1009909 Change-Id: I93ccbe29600ee1a3e017b5233eeca8e44f914d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839317 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#702763}
-
Arthur Hemery authored
Adding the test expectation file for layout tests to linux-bfcache-debug and adding a few filters. Bug: 1010870, 976218 Change-Id: I2b9d41d4fe39ffb2c2d85f5ea91a6fe199d1cf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837624Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#702762}
-
Kenichi Ishibashi authored
To generate better trace log for performance investigation. Bug: 1011213 Change-Id: Icc9f834f6f274fb97a818763657c59df6640c6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839218Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#702761}
-
Dominic Battré authored
Revert "Disable flaky */SubresourceFilterSafeBrowsingActivationThrottleScopeTest.ActivateForScopeType/*" This reverts commit ad5c2634. Reason for revert: Root cause is unrelated to this test. See crbug.com/1011275 Original change's description: > Disable flaky */SubresourceFilterSafeBrowsingActivationThrottleScopeTest.ActivateForScopeType/* > > TBR=battre@chromium.org > > Bug: 1011194 > Change-Id: Ibefb2fa2483c7d20633159a07180127cc15c8b00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838776 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Auto-Submit: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702701} TBR=battre@chromium.org,yoichio@chromium.org Change-Id: Ifdcd0894d8ce24b55891b23bc6b98dbd2dbe09ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839692Reviewed-by:
-
Shuo-Peng Liao authored
In V4L2Device::V4L2PixFmtToVideoPixelFormat(), V4L2_PIX_FMT_RGB32 maps to PIXEL_FORMAT_ARGB, which was wrong. V4L2_PIX_FMT_RGB32 is a 32bpp ARGB (byte-order) format, where PIXEL_FORMAT_ARGB is 32bpp BGRA (byte-order). V4L2_PIX_FMT_RGB32 should map to PIXEL_FORMAT_BGRA. However, it does not exist yet so we have to add it in media/base/video_types.h BUG=1010833 TEST=Pass CQ Change-Id: I027762c55dd5667f2b578a6874b912af81821af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837555Reviewed-by:
Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Shuo-Peng Liao <deanliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#702759}
-
Dominic Battré authored
This reverts commit ceeb83d8. Reason for revert: This is an infrastructure flake, see crbug.com/1011192#c4 Original change's description: > Disable flaky ContentPasswordManagerDriverTest.NotInformAboutBlacklistedForm > > TBR=dvadym@chromium.org > > Bug: 1011192 > Change-Id: If41454368e54755056d36ff2bf258b8a1decd2dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839275 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Commit-Queue: Yoichi Osato <yoichio@chromium.org> > Auto-Submit: Yoichi Osato <yoichio@chromium.org> > Cr-Commit-Position: refs/heads/master@{#702697} TBR=yoichio@chromium.org,dvadym@chromium.org Change-Id: I443f4bbb9cbcec2035e619cdc5ec0379db907bde No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011192 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839672Reviewed-by:
-
Thanh Nguyen authored
This CL: 1. Adds necessary code for inference. 2. Put the inference part under a flag in SearchResultRanker. Bug: 1006133 Change-Id: I4185cf77f55e6539b831dcebb9ec9b9da46667f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831730Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#702757}
-
Tsuyoshi Horo authored
To support history navigations and page reload in Bundled Exchanges file, this CL introduces BundledExchangesNavigationInfo class which keeps the BundledExchangesSource and the inner URL. This class is passed from BundledExchangesHandle to NavigationEntryImpl via NavigationRequest, and is used to create a BundledExchangesHandle for history navigations by BundledExchangesHandle::CreateForNavigationInfo(). And also this CL make BundledExchangesHandleTracker::MaybeCreateBundledExchangesHandle() call BundledExchangesHandle::CreateForNavigationInfo() to create a BundledExchangesHandle for reloading page of a Bundled Exchanges file. Bug: 995177 Change-Id: I23abe53ec4e64d01c255f388497ea2a6e33a8239 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831617 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#702756}
-
Mario Sanchez Prada authored
The README.md file was out-of-sync after recent migrations, let's fix it. Bug: 955171, 978694 Change-Id: I3d02f446a161309d54516d9f35bd4720fb40ec64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837911Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#702755}
-
Mario Sanchez Prada authored
Convert the couple of references of the blink::mojom::SurfaceEmbedder interface inside of Blink. Bug: 955171, 978694 Change-Id: I326ae1e5537e0670dd3346b57ceff705f61be6ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837611Reviewed-by:
-
Daniel Soromou authored
Based on the spec (https://github.com/whatwg/dom/pull/653), addEventListener after the first evaluation of the Service worker script should not throw. Change-Id: I46af276a67e021cf277a98195bf5c04583ad0b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838376Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Daniel Soromou <fosoromo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#702753}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/830565958d2b..813c3d43c4bd git log 830565958d2b..813c3d43c4bd --date=short --no-merges --format='%ad %ae %s' 2019-10-04 rmhasan@google.com [Typ] Create method to get the sub directory for artifacts Created with: gclient setdep -r src/third_party/catapult@813c3d43c4bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:982208 Change-Id: Ic3bce934d85110951c0fd68de894cef42a1b0ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838370Reviewed-by:
-
Patrick Monette authored
This will avoid starting a shared worker and immediately stopping it because the client is destroyed right after. The goal of this CL is to avoid sending a OnClientAdded notification to SharedWorkerService observers for a frame that is already destroyed. Bug: 993029 Change-Id: Idd075c13a751113a77b38474ff19e26bf8e9a1c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835164 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/35a60f622c58..e0c233ff55db git log 35a60f622c58..e0c233ff55db --date=short --no-merges --format='%ad %ae %s' 2019-10-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 5be09849424d..6021fbd09b1c (2 commits) Created with: gclient setdep -r src/third_party/skia@e0c233ff55db If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: chromium:None Change-Id: Ifa7eb35a726520fea438332ae795c855c5875f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839536Reviewed-by:
-
David Bokan authored
Add a UMA metric to measure the number of Agents[1] per process over time. Roughly speaking, all frames that can potentially script each other synchronously must share an Agent. i.e. they are same site. So a page example.com with subframes foo.external.com and bar.external.com will have 2 agents, one for example.com and one for the subframes. The metric here measures how much time each renderer spends in any given state. That is, a value of N in the 4th bucket means that renderers have spent N seconds having 4 Agents. The purpose of this metric is to analyze the effect of separating memory isolates per-Agent. Therefore, we collect the metric only for WindowAgents since workers already have a separate isolate. We also only consider Documents from ordinary Pages to prevent influencing the metric from poups, overlays, SVG images, and other non core Documents we wouldn't consider isolating. [1] https://html.spec.whatwg.org/multipage/webappapis.html#integration-with-the-javascript-agent-formalism Change-Id: I3ebe8e46b273e53f3107e70b1aace517e0d8b924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830465 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#702749}
-
Eric Willigers authored
In preparation for Minimal UI, we migrate AppRegistrar to using DisplayMode instead of LaunchContainer. Not yet done: Migrate WebApp to use DisplayMode. TBR=amistry@chromium.org TBR=dominickn@chromium.org Bug: 1009909 Change-Id: I6ef945fbc80196960b0ce73506876a89540efa88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835432 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/595c588d9706..872d2e9ffe7e Created with: gclient setdep -r src-internal@872d2e9ffe7e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Icb4db3767c7134d3e4135626927d5b4cfd1815bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839631Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702747}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 44f1ce3d. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" afc509ca "[WPT/common/security-features] Fix typo" df884b61 "[WPT/referrer-policy] Add worker subresource tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-multicol NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ia492808fdacbefcf6fbd3dc5ba6cf19b8e1252f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839551Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702746}
-
Darren Shen authored
We currently manually manage the lifetime of the engines in engine map. But we can use a unique_ptr instead. It automatically gets released when we remove an engine from the engine map. Bug: 1009903 Change-Id: I93874b0154b949ddceef29695fc000cacfef73cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837443 Commit-Queue: Keith Lee <keithlee@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#702745}
-
Lei Zhang authored
Change-Id: I3118c919f190e48de8399ac72c0f610f4bc2525d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839016 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#702744}
-
Maksim Sisov authored
The SkiaRenderer uses an image factory that creates anonymous images and native pixmaps. That means a GbmPixmapWayland does not receive an AcceleratedWidget that it will be attached to until a buffer commit request comes. With the implementation we have at the moment, that results in GbmPixmapWayland being a staging buffer without its counterpart created on the browser process side. However, when the SkiaRenderer feature is enabled, we want to create a GbmPixmapWayland with a null widget passed and create a dmabuf based wl_buffer for it. Let's call that buffer an "Anonymous buffer". But that slightly contradicts with the implementation of the GbmPixmapWayland and the WaylandBufferManagerHost classes. The problem is that the GbmPixmapWayland may not send requests to create dmabuf based wl_buffers if a widget is null. The manager simply fires a gpu termination callback if GbmPixmapWayland sends a request to create a wl_buffer for a null widget. To fix the problem, I had to change the implementation a little bit and allow it to create wl_buffers for null widgets. Now, the GbmPixmapWayland always asks the host manager to create wl_buffers regardless of the AcceleratedWidget's id. And to be able to process these requests, a new logic to store these wl_buffers has been added. Previously, the manager host always delegated creation of WaylandBuffers (which is an internal buffer representation) to surfaces. And whenever wl_buffers were created, AttachWlBuffer was called. Now, the manager may create WaylandBuffers by itself if there is no widget passed and it is impossible to know the surface that must own that buffer. When a CommitBuffer request comes, a surface searches for the buffer in its own container and if it is not found, it asks the WaylandBufferManagerHost to search for an anonymous buffer and pass the ownership of that buffer to that surface. Then, the normal flow continues. Bug: 1008364 Change-Id: I5c582381afc3e16b589d53ceb6ba774ac6da8f5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837614 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#702743}
-
Lei Zhang authored
This function takes a PrinterType and a separate boolean to indicate the printer is a cloud printer. This was likely written before enum PrinterType gained a |kCloudPrinter| enum value. Now that the |kCloudPrinter| value exists, just use that and get rid of the separate boolean. Change-Id: I14ca569167d49bf273c02e4d24cdaa6c17e9dc2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838624 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
dpapad authored
Before this CL, the supported types were only mentioned in comments, and were not programmatically enforced. As a result there were conflicting comments, as well as cases that were a seemingly unsupported type was used (for example 'url' type in chrome://bookmarks). Bug: 1010819 Change-Id: I3f52343220f2db2a3ed302a178efa1c0ca78db99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838975 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#702741}
-
Jay Harris authored
This is a prerequisite for adding file handling on Windows, MacOS and Linux. Example: ./chrome --profile-directory=my-profile --app-id=.. -- -- file1 file2 file3 Note: In future, the FileHandlerManager will infer the correct FileHandler for an app based on the files it is given. For now, it just opens the app's launch url. Bug: 938103 Change-Id: Ieaa136d109fc906c9c48a95cdbd194fb0622d3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819286Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#702740}
-
v.paturi authored
CSS filters such as invert, greyscale etc. are not available in DarkModeImageClassifier where the extraction of features happens. So we end up extracting the features on the original image which is not what is seen on the user's screen. Until we have a way to take the css filters into consideration while extracting the features, it's safer to just skip the feature extraction altogether when such filters do exist. Bug: 1007925 Change-Id: I1b082a628709178e64aed488bb4656dd7044386a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824051Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Aran Gilman <gilmanmh@google.com> Reviewed-by:
Prashant Nevase <prashant.n@samsung.com> Commit-Queue: Varun Chowdhary Paturi <v.paturi@samsung.com> Cr-Commit-Position: refs/heads/master@{#702739}
-
Lei Zhang authored
Fix lint errors along the way. Change-Id: If87c1c8c330d191e1ca0d422c4d2bce299b24ce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838709Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#702738}
-
Lei Zhang authored
Change-Id: Id64281b03e209469b14591849c97ff05feeb148a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838528Reviewed-by:
-
