- 05 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f48282d63366..60dcc070e823 Created with: gclient setdep -r src-internal@60dcc070e823 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3a94d92bf404271e29ea35c6ef416032414e7e27 Reviewed-on: https://chromium-review.googlesource.com/c/1317767Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605329}
-
Robert Flack authored
This patch implements a helper for defining Xmethods simply and example Xmethod implementations of useful functions on std::vector and std::unique_ptr which are normally inlined and cannot be invoked. This expediates debugging code, you don't have to remember which internal data members represent the vector contents or unique_ptr pointer value. For example, before: (rr) p ignore $1 = std::__1::unique_ptr<base::AutoReset<bool>> = 0x30f6a6b22ac0 => {scoped_variable_ = 0x30f6a6987880, original_value_ = false} (rr) p ignore.get() Cannot evaluate function -- may be inlined (rr) p *ignore Could not find operator*. (rr) p ignore->original_value_ Could not find operator->. (rr) p layers $2 = std::__1::vector (length=8, capacity=8) = {0x30f6a665a3a0} (rr) p layers.size() Cannot evaluate function -- may be inlined (rr) p layers[0] Could not find operator[]. After: (rr) p ignore $1 = std::__1::unique_ptr<base::AutoReset<bool>> = 0x30f6a6b22ac0 => {scoped_variable_ = 0x30f6a6987880, original_value_ = false} (rr) p ignore.get() $2 = (base::AutoReset<bool> *) 0x30f6a6b22ac0 (rr) p *ignore $3 = {scoped_variable_ = 0x30f6a6987880, original_value_ = false} (rr) p ignore->original_value_ $4 = false (rr) p layers $5 = std::__1::vector (length=8, capacity=8) = {0x30f6a665a3a0} (rr) p layers.size() $6 = 1 (rr) p layers[0] $7 = (cc::FakePictureLayerImpl *) 0x30f6a665a3a0 Bug: None Change-Id: Ia4b7495ca29568844d1e1c75ce6bcb3f1d8ba98e Reviewed-on: https://chromium-review.googlesource.com/c/1302697 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605328}
-
David Bokan authored
In https://crrev.com/9f54d240af5d366b1d6a4d9b84438192a9f0a11c we moved ScrollCustomization from using Elements to Node. This allows us to use Nodes in the scrolling code which is much more natural since the viewport scrolls using the LayoutView (document Node)'s scrollable area. The main change in this CL is letting the Document node be part of the scroll chain, instead of using the documentElement in its place. This removes some special-casing all the way through the scrolling pipeline. As a result the Global Root Scroller now sets the viewport scroll callback on the document node. Reland node: This relands the original patch with the fix reviewed in https://crrev.com/c/1302856. Originally landed patch is uploaded in Patchset 1 for easy comparison of changes. TBR=dcheng@chromium.org,kenrb@chromium.org,lfg@chromium.org Bug: 897288,899161 Change-Id: Ib6b61eb3a193877abb61f896a9d1de4747496514 Reviewed-on: https://chromium-review.googlesource.com/c/1307843 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605327}
-
Antonio Gomes authored
BUG=889867 Change-Id: I19a354a427ad67b8f1b8a5357b81f37dabdbb592 Reviewed-on: https://chromium-review.googlesource.com/c/1316934Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#605326}
-
Mike Klein authored
This is a reland of ea1a3ea1 TBR=fmalita@chromium.org Original change's description: > rebaseline SK_LEGACY_OP_COLOR_AS_BYTES > > This flag was repurposed... the real thing we're rebaselining > is https://skia-review.googlesource.com/c/skia/+/167264, which > affects situations with solid colors and unusual blend modes. > > Change-Id: I1da6486ca54d5f6c60bb0b04db05f6dc92487039 > Reviewed-on: https://chromium-review.googlesource.com/c/1316754 > Commit-Queue: Florin Malita <fmalita@chromium.org> > Reviewed-by: Florin Malita <fmalita@chromium.org> > Cr-Commit-Position: refs/heads/master@{#605216} Change-Id: Idefc08686ad0839f985b419b1ba3542e2741b763 Reviewed-on: https://chromium-review.googlesource.com/c/1316763 Commit-Queue: Mike Klein <mtklein@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#605325}
-
Antonio Gomes authored
BUG=889870,889869 Change-Id: I8cfb5456ec39e0846f5d6dc56bca8a1e73749137 Reviewed-on: https://chromium-review.googlesource.com/c/1316933Reviewed-by:
-
Sylvain Defresne authored
The member variable signin_allowed_ is initialized in the method Initialize. Call the method after creation of the SigninManager to ensure that IsSigninAllowed does not DCHECK when called. As constructing a PrefMember<T> acquires a handle to the current task runner, ensure that all tests have a properly set up task environment (either by moving the initialisation of the existing one to happen before the construction of SigninManager or by adding a new one using base::test::ScopedTaskEnvironment). Bug: none Change-Id: I27e40f628dcc638c7b1130f82962de05901b7771 Reviewed-on: https://chromium-review.googlesource.com/c/1302175 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Mike Reed authored
TBR=cjgrant Bug: skia:2664 Change-Id: Ie2b941409bcd84d61c3bdad22d57f45c7089af70 Reviewed-on: https://chromium-review.googlesource.com/c/1306513 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#605322}
-
David 'Digit' Turner authored
This is necessary to fix a bug that prevents loading the VR downloadable feature module with the Chrome app bundle. BUG=889592 R=agrieve@chromium.org,benmason@chromium.org,cjgrant@chromium.org,tiborg@chromium.org Change-Id: Id9504e383e218cbbaa10302635a50b822b440474 Reviewed-on: https://chromium-review.googlesource.com/c/1317570Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
David Turner <digit@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#605321}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/062174e3..62f18490 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifdf99c1bcacb51efeb45540abc5813b8f3872e77 Reviewed-on: https://chromium-review.googlesource.com/c/1317706Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605320}
-
Philip Jägenstedt authored
Bug: 709013 Change-Id: I2c68f9b37609e4fc5160d43dde9078fe6a66b33e Reviewed-on: https://chromium-review.googlesource.com/c/1317608Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#605319}
-
henrika authored
This CL is an attempt to reduce risk of crashes in GetPreferredAudioParameters which lately has added support for IAudioClient3. Adds version check and an improved usage of ComPtr::As. Bug: 898789 Change-Id: I3e8e58543cfd5d4d5029aa90668119acb411a867 Reviewed-on: https://chromium-review.googlesource.com/c/1312949Reviewed-by:
Oskar Sundbom <ossu@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#605318}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/51916083e752..e71e9ef311ba git log 51916083e752..e71e9ef311ba --date=short --no-merges --format='%ad %ae %s' 2018-11-05 kjlubick@google.com [canvaskit] Add catchException everywhere Created with: gclient setdep -r src/third_party/skia@e71e9ef311ba The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: Ib7125de1ba8d5f3b8bf9f425144570ff6a324a33 Reviewed-on: https://chromium-review.googlesource.com/c/1317766Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605317}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e7547d55453e..a1ead6f2ab75 git log e7547d55453e..a1ead6f2ab75 --date=short --no-merges --format='%ad %ae %s' 2018-11-05 sprang@webrtc.org Update EncoderProxy to use EncoderInfo 2018-11-05 landby@gmail.com Add IPv6 configuration parameters to iOS API 2018-11-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 4e7c87b5..c26ff44a (605184:605286) Created with: gclient setdep -r src/third_party/webrtc@a1ead6f2ab75 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9d901cfb3fa6823db32828a195029fcda02d7e05 Reviewed-on: https://chromium-review.googlesource.com/c/1317726Reviewed-by:
-
Bo Liu authored
This code came from when this class was the message filter and thus was per-process. It is now per-view so there is no need to have code that handles multiple begin frames. Change-Id: I76ed6bb9a6937168537d59901917285161d44e82 Reviewed-on: https://chromium-review.googlesource.com/c/1316769 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#605315}
-
Maks Orlovich authored
The latter should generally not be used in this layer; this is prep for wider work involving that. Bug: 875032 Change-Id: I9c0309445bf6fb599954b9239c8f7fb974f0a4ce Reviewed-on: https://chromium-review.googlesource.com/c/1316107Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#605314}
-
Marc Treib authored
Let's make sure all the raw pointers are properly nulled out rather than uninitialized. I'm not aware of any concrete problems caused by this, but better safe than sorry. Bug: none (AFAIK) Change-Id: Ifae536ad37858ae264e055106bf6c2d80c2567e3 Reviewed-on: https://chromium-review.googlesource.com/c/1317606Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#605313}
-
Peter K. Lee authored
After http://crrev/c/832942, these histograms are no longer being emitted Bug: 795802 Change-Id: I7dfdf2ab640e23795670ab6226bd1124ddff0b38 Reviewed-on: https://chromium-review.googlesource.com/c/1315672Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#605312}
-
Alex Clarke authored
This simplification is a step towards a lock-free main thread PostTask path. Split off from: https://chromium-review.googlesource.com/c/chromium/src/+/1304557 Bug: 897751 Change-Id: I6aa2fd98b000b634785f2fee94afa3b11e70423d Reviewed-on: https://chromium-review.googlesource.com/c/1317568 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605311}
-
Henrik Boström authored
This has been marked as flaky on multiple platforms before and more are affected. This is probably not platform-dependent. TBR=einbinder@chromium.org, caseq@chromium.org NOTRY=True Bug: 901314 Change-Id: I0eeb581368048fcd287ff0730a994a41ce9d8646 Reviewed-on: https://chromium-review.googlesource.com/c/1317849Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#605310}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f6ff6ce4e89d..f48282d63366 Created with: gclient setdep -r src-internal@f48282d63366 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id89731e2e65f41c5aa942f871108d27e660cfe77 Reviewed-on: https://chromium-review.googlesource.com/c/1317177Reviewed-by:
-
Marc Treib authored
This adds message handlers for a few things that were added semi-recently to the non-iOS version. Also includes a few tiny cleanups to the non-iOS message handler. Bug: 898439 Change-Id: I38dc6d643c1b9ad6fd3608d8a4ed799385d7d946 Reviewed-on: https://chromium-review.googlesource.com/c/1315209 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
Bottom containers and snackbars try to infer on their own how large the keyboard is. This CL makes them consider extensions and replacements as well -- long-term, we probably want to use a keyboard delegate there. Bug: 898468 Change-Id: Iae8a68b2f868015f64d8e1361fe46b1d7740921f Reviewed-on: https://chromium-review.googlesource.com/c/1309791Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#605307}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/9f878f6e97fa..e7547d55453e git log 9f878f6e97fa..e7547d55453e --date=short --no-merges --format='%ad %ae %s' 2018-11-05 nisse@webrtc.org Move MemoryStream to separate source files, and to a test target. Created with: gclient setdep -r src/third_party/webrtc@e7547d55453e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I46796fae4cfca5ce2758d2faf17f8a22d3f9eff2 Reviewed-on: https://chromium-review.googlesource.com/c/1317178Reviewed-by:
-
Bruce Dawson authored
SimpleThreadImpl::thread_manager_ is initialized in its thread's Run function which means that it is racy in relationship to the use. This change doesn't fix the raciness but it does initialize thread_manager_ to nullptr in the class declaration which is a good practice. Fixing the code to not use SimpleThreadImpl until Run() has completed the initialization is left for the owner. Bug: 897872 Change-Id: I50d38f10d4297334ae02698ecd43a0fbf44db374 Reviewed-on: https://chromium-review.googlesource.com/c/1316657Reviewed-by:
-
Mario Sanchez Prada authored
Migrated to the IdentityManager by relying on IdentityTestEnvironment, so that we can use MakePrimaryAccount() without needing to explicitly pass a ProfileOAuth2TokenService and a SigninManagerBase. Bug: 890825 Change-Id: I20e228e7d9f5d2c2154666d264e31b5154bdcff8 Reviewed-on: https://chromium-review.googlesource.com/c/1314635 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#605304}
-
BUG=762641 TBR=alemate@chromium.org Change-Id: I1c86a91b4dde77faf157c08f9be2406c64cd06b4 Reviewed-on: https://chromium-review.googlesource.com/c/1317378Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605303}
-
Xi Cheng authored
Change-Id: Ifd612cc9b4370c4fb2a9f7be54fd6528f7b4cda5 Reviewed-on: https://chromium-review.googlesource.com/c/1316711 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#605302}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fad38646..062174e3 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84145a1a8ffb72b8e6594425a41d643d06f22caf Reviewed-on: https://chromium-review.googlesource.com/c/1316344Reviewed-by:
-
Andy Paicu authored
Spec: https://w3c.github.io/webappsec-csp/#dictdef-securitypolicyviolationeventinit Bug: 897646 Change-Id: Id4c4947455a095c09aa34d16c7ff298ba4ba046e Reviewed-on: https://chromium-review.googlesource.com/c/1292566 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#605300}
-
Greg Thompson authored
This reverts commit e2a95639. Reason for revert: This breaks tests on account of fooling the Windows loader. See https://bugs.chromium.org/p/chromium/issues/detail?id=900121#c6 for details. Original change's description: > win: Make chrome.7z generation more deterministic. > > mini_installer.exe embeds chrome.7z, and chrome.7z contains timestamps > of all files in the archive. To make chrome.7z more deterministic, give > all files in it deterministic timestamps. > > Bug: 330260 > Change-Id: Ia251dd38177acbebdde288b86826986f441b2d4d > Reviewed-on: https://chromium-review.googlesource.com/c/1302393 > Reviewed-by: Gabriel Charette <gab@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603171} TBR=gab@chromium.org,thakis@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 330260 Change-Id: I261401c27226ab9e0cf30bc07a47ecf8399f491b Reviewed-on: https://chromium-review.googlesource.com/c/1317569Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#605299}
-
Marc Treib authored
This is the USS version of AutofillProfileDataTypeController. It is very similar to AutofillWalletModelTypeController, and only implements one bit of custom logic: Notifying the SyncService when autofill::prefs::kAutofillProfileEnabled changes, so that syncing of addresses will get turned on or off as appropriate. Bug: 895824 Change-Id: I932794f8a2d1c3556bdc1b7125743a2154eaf997 Reviewed-on: https://chromium-review.googlesource.com/c/1310393 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605298}
-
Justin Cohen authored
This is now required after dropping 32-bit. Bug: 894099 Change-Id: Ib2d546b8b862f9a0f123a6b0b46f902dfccb6fb4 Reviewed-on: https://chromium-review.googlesource.com/c/1316108Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605297}
-
Benoît Lizé authored
Records the size, latency and throughput of parkable strings at compression and decompression time. As these values are correlated, recording separate histograms is necessary, and as not all compressed strings are decompressed, separate histograms for compression and decompression are required. Bug: 877044 Change-Id: Iec53e6d4f249e109165b0b3be6e2e245fc2bfd40 Reviewed-on: https://chromium-review.googlesource.com/c/1307440Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605296}
-
Leszek Swirski authored
This reverts commit c564235f. No changes from the original, VR flakes are caused by issues with loadUrl and have been deflaked (see 894796 for details) Original change's description: > Revert "Reland "[blink] Control ScriptStreamer with ScriptResource"" > > This reverts commit dd9df78c. > > Reason for revert: Makes VR tests flaky (https://crbug.com/894796) > > Original change's description: > > Reland "[blink] Control ScriptStreamer with ScriptResource" > > > > This is a reland of 7bd91635 > > > > No changes from the original, revert reason is fixed with > > https://chromium-review.googlesource.com/c/1283037 > > > > Original change's description: > > > [blink] Control ScriptStreamer with ScriptResource > > > > > > Move the ScriptStreamer control logic from ClassicPendingScript to > > > ScriptResource. In the future, this will allow us to start streaming > > > a ScriptResource before the ClassicPendingScript is available, e.g on > > > preload. > > > > > > The ClassicPendingScript now only sends one "finished" callback, from > > > ScriptResource. This callback is either when the streaming completes, > > > or when there is no streaming and the ClassicPendingScript has told > > > the ScriptResource that it doesn't intend to start streaming. In the > > > long run, we want all scripts to go through the streaming interface, > > > and we want ScriptResource to control when streaming starts, so the > > > "no more streaming" call will disappear -- however it is necessary to > > > maintain the current behaviour, and be able to control it with a > > > runtime flag. > > > > > > Bug: chromium:865098 > > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#599148} > > > > TBR=kouhei@chromium.org,kinuko@chromium.org > > > > Bug: chromium:865098 > > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c > > Reviewed-on: https://chromium-review.googlesource.com/c/1286450 > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#601143} > > TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: chromium:865098 > Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2 > Reviewed-on: https://chromium-review.googlesource.com/c/1297138 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602310} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:865098 Change-Id: I9794fe5366aa8cfc9291d53271ed680465b29a76 Reviewed-on: https://chromium-review.googlesource.com/c/1317566Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#605295}
-
Justin Cohen authored
Bug: 894963 Change-Id: Id9ca2253208fc77672d05d037e7f777b89d15770 Reviewed-on: https://chromium-review.googlesource.com/c/1306236Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#605294}
-
Alexander Timin authored
- Implement DeletePendingTasks method. - Implement HasTasks method. - Implement SetTaskExecutionAllowed and IsTaskExecutionAllowed methods. - Allow TCwMP::SetTaskRunner to be called multiple times. - Reduce the frequency of ScheduleDelayedWork calls. R=alexclarke@chromium.org,skyostil@chromium.org BUG=891670 Change-Id: Ia5eaa7e7ec32e499b6c7e772f391144c2d836746 Reviewed-on: https://chromium-review.googlesource.com/c/1308194 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#605293}
-
Anders Hartvoll Ruud authored
Custom properties can currently not be represented by any subclass of CSSProperty, because we have no strategy for creating any such instances dynamically. (They all reside in static memory). This CL proposes a solution to this problem---hopefully ushering in a new and glorious era of code clean-ups and simplifications. In short, to obtain a CSSProperty reference for some property (be it standard property, custom property, or registered custom property), create a CSSPropertyRef object. This object will either point to one of the static instances (for standard properties), or will point to the embedded CustomProperty object (for both kinds of custom properties). For now, just IsInherited and the name functions have been implemented in CustomProperty. The plan is to complete the rest incrementally. Change-Id: I6905cbb23f67d0a3c1de0ecba03c9f0a18cb278c Reviewed-on: https://chromium-review.googlesource.com/c/1262638 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
-
Pavol Marko authored
If two exension managed schema policy properties (at different hierarchy levels) have the same id, the ADMX generator should not generate the same name attribute for the corresponding ADMX elements. If the name is reused, the GPO editor rejects the ADMX file. Use 'full name's instead, which are built from the names of all hierarchy levels. Bug: 900517 Test: manual Change-Id: Ief2edeb71defb15a768ea7df9e7366796bab728e Reviewed-on: https://chromium-review.googlesource.com/c/1311353Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#605291}
-
Jordan Demeulenaere authored
This CL replaces ObjectAnimators by ValueAnimators for the progress bar animations, allowing us to remove the properties introduced in http://crrev/c/1312477. Change-Id: I45565b4aa863880e8a16522b9160dc2c8d0c4559 Reviewed-on: https://chromium-review.googlesource.com/c/1314630Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#605290}
-
