GitLab

BUG=314284
NOTRY=true
R=noamsml@chromium.org

Review URL: https://codereview.chromium.org/58513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232865 0039d316-1c4b-4281-b951-d872f2087c98

BUG=312929

Review URL: https://codereview.chromium.org/51423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313854
R=zelidrag@chromium.org

Review URL: https://codereview.chromium.org/57433006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314905
R=pastarmovj@chromium.org
TBR=pastarmovj@chromium.org

Review URL: https://codereview.chromium.org/58183006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232861 0039d316-1c4b-4281-b951-d872f2087c98

ServerInstance rather than a mash of ad-hoc fake classes. When
APIListDataSource is a DataSource then that's what it will take, and an
upcoming change either needs to add more fake classes or convert to this.

R=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/58303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232860 0039d316-1c4b-4281-b951-d872f2087c98

This came out of a discussion with danno, machenbach, and jkummerow on how to improve the current V8 bisects. At the moment, the bisect checks if both end points of a v8 bisect are directly mappable to bleeding_edge revisions and bails if not. Instead, it will not try to search forward/backwards a few revisions to see if it can find a CL that is mappable to bleeding_edge and use that new range instead. In that situation, the bisect will generate a warning that it had to search for a new endpoint and the results might not be valid.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/50043003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232859 0039d316-1c4b-4281-b951-d872f2087c98

Allows ptr_type to be configurable.

BUG=

Review URL: https://codereview.chromium.org/49913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232858 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/49063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232857 0039d316-1c4b-4281-b951-d872f2087c98

contributing to too-long database keys. Most importantly, match whole words
when doing variable name replacement, not just character sequences. Minified
files with variable names like "a" were exploding. Secondly, don't cache the
title of links in reference resolver, it's pointless and leading to even
longer database keys. Thirdly, truncate database keys to avoid crashing the
server from this ever again; log error instead.

BUG=314102
R=jyasskin@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/55913003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232856 0039d316-1c4b-4281-b951-d872f2087c98

It is also be available for "unknown" channel, e.g. unbranded/dev builds. The flag is ignored for beta and stable channels.

The purpose of the flag is for app developer to easier debug RTP media related problems in WebRTC.

https://code.google.com/p/webrtc/issues/detail?id=491

This CL is based on https://codereview.chromium.org/27131004/ by perkj@.

TEST= 1) Start Chrome with the flag --disable-webrtc-encryption. 2) Setup a call using apprtc.appspot.com. 3) Open the JS console and make sure the SDP offer don't contain 'a=crypto:'.
BUG=304024

Review URL: https://codereview.chromium.org/37253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232855 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314826
R=ananta@chromium.org, ananta, cpu
TBR=sky

Review URL: https://codereview.chromium.org/57773004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314899
R=ikarienator@chromium.org
TBR=ikarienator@chromium.org

Review URL: https://codereview.chromium.org/58743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232853 0039d316-1c4b-4281-b951-d872f2087c98

(This is a re-land of https://chromiumcodereview.appspot.com/51113009/)

BUG=312380
TBR=jorgelo@chromium.org

Review URL: https://codereview.chromium.org/58693002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232852 0039d316-1c4b-4281-b951-d872f2087c98

necessary input args, instead of a whole AutocompleteInput.

We need a nonstatic instance of HistoryURLProvider to pass in anyway, so there's
no real win from this being static.  Not using an AutocompleteInput will be
useful in the future when I'll be adding a call to this from
OmniboxEditModel::OpenMatch(), which doesn't have an AutocompleteInput.

This also sets |trim_http| to false when called from AcceptInput(); there's no
need to trim the scheme here (since the user won't see the trimmed string) and
doing so is actively wrong if the user typed ctrl-enter on e.g. "http://google".

BUG=151044
TEST=none
R=msw@chromium.org

Review URL: https://codereview.chromium.org/54903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=286528
TEST=unit_tests
R=groby@chromium.org

Review URL: https://codereview.chromium.org/54303007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232849 0039d316-1c4b-4281-b951-d872f2087c98

Renames previous constants to make it clearer they are for Dev/Beta.

BUG=251830
NOTRY=true
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/56513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232848 0039d316-1c4b-4281-b951-d872f2087c98

OmniboxEditModel::OpenMatch().

I traced the origin of this weird code back to the days before OpenMatch() took
an AutocompleteMatch; back then, we constructed one so we could get at fields
like |fill_into_edit| that weren't provided to OpenMatch().  Now that we pass
this in, I believe the calculated match should always match the passed-in match.

BUG=none
TEST=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/47353005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232847 0039d316-1c4b-4281-b951-d872f2087c98

$ ./tools/resources/optimize-png-files.sh -o2 -r224739 chrome/browser/resources/
Processed 20 files (out of 432 files) in 00:52:13s
Result : 26157 => 21638 bytes (4519 bytes : 17 %)

BUG=313729
TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/57643008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314364
TEST=audio playback still works, just glitches in 48->44
R=ajwong@chromium.org

Review URL: https://codereview.chromium.org/49303008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229653
R=dgozman@chromium.org, robliao@chromium.org, vadimt@chromium.org

Review URL: https://codereview.chromium.org/56643002

Patch from Travis Skare <skare@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232844 0039d316-1c4b-4281-b951-d872f2087c98

Original images comitted in r226314 were corrupted in the commit queue.

BUG=311282
R=estade@chromium.org

Review URL: https://codereview.chromium.org/58613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232843 0039d316-1c4b-4281-b951-d872f2087c98

> Linux: add a Credentials class to handle Linux capabilities.
> 
> (This is a re-land of https://chromiumcodereview.appspot.com/51113009/)
> 
> BUG=312380
> TBR=jorgelo@chromium.org
> 
> Review URL: https://codereview.chromium.org/55603003

TBR=jln@chromium.org

Review URL: https://codereview.chromium.org/45923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232842 0039d316-1c4b-4281-b951-d872f2087c98

This adds dependencies on ui_unittests target to make iOS happy again.

BUG=299841
TEST=None
R=lliabraa@chromium.org, ben@chromium.org

Review URL: https://codereview.chromium.org/54583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232841 0039d316-1c4b-4281-b951-d872f2087c98

Attempting to restore this window does not work anyway as it does not have the associated web contents wired up.
This is the same behavior as on non AURA.

Fixes bug https://code.google.com/p/chromium/issues/detail?id=304138

BUG=304138
R=sky@chromium.org, sky

Review URL: https://codereview.chromium.org/51943007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232838 0039d316-1c4b-4281-b951-d872f2087c98

(This is a re-land of https://chromiumcodereview.appspot.com/51113009/)

BUG=312380
TBR=jorgelo@chromium.org

Review URL: https://codereview.chromium.org/55603003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232837 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't yet handle the case where the GPU becomes crashy. The
user would need to close and re-open Chrome, currently. That case
seems more complicated to handle because it's only down low that
we know that, not up at the chrome:: level.

This DCHECKs in https://code.google.com/p/chromium/codesearch#chromium/src/base/win/scoped_com_initializer.h&l=55
in debug, but I believe that's an unrelated problem at HEAD. (i.e. all
restarts are doing that currently.)

R=cpu@chromium.org
BUG=308736

Review URL: https://codereview.chromium.org/54093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232836 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds 2 new strings for the dialogs displayed when the user
signs in for the first time. The strings will be consumed by the
confirmation bubbles in a later CL, where we will need to increase
the bubble width in addition to consuming the new strings.

Strings:
IDS_ONE_CLICK_SIGNIN_BUBBLE_MESSAGE_NEW
IDS_SYNC_PROMO_NTP_BUBBLE_MESSAGE_NEW

New text:
Now that you're signed in, you can get your tabs, bookmarks and other
Chrome stuff across your laptop, phone and tablet. You will also receive
more relevant suggestions and features on Google services.

BUG=314805
TEST=No UI changes. This CL just adds new strings.
R=rogerta@chromium.org, rpop@chromium.org

Review URL: https://codereview.chromium.org/55143011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/58663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232833 0039d316-1c4b-4281-b951-d872f2087c98

> [Net] Assert that URLRequests with LOAD_IGNORE_LIMITS have MAXIMUM_PRIORITY
> 
> Also remove the priority juggling in ClientSocketPoolBaseHelper, and instead
> assert that any requests with ignore_limits = true also has priority =
> MAXIMUM_PRIORITY.
> 
> BUG=166689
> R=asanka@chromium.org, gene@chromium.org, joaodasilva@chromium.org, mmenke@chromium.org, simonjam@chromium.org
> TBR=benm@chromium.org, jamesr@chromium.org
> 
> Review URL: https://codereview.chromium.org/51683002

Broke PrerenderBrowserTest.PrerenderDeferredSynchronousXHR. Running locally I was hitting a check on url_request.cc:979.

TBR=akalin@chromium.org

Review URL: https://codereview.chromium.org/47563006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232832 0039d316-1c4b-4281-b951-d872f2087c98

Removed launch mode decision based on touch screen capability.

BUG=314818
R=ananta@chromium.org, ananta, cpu
TESTS=Please see bug description for steps.

Review URL: https://codereview.chromium.org/50883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232828 0039d316-1c4b-4281-b951-d872f2087c98

This removes PNaCl's RequestFirstInstall and its use of
the component updater OnDemand API. A different CL:
https://codereview.chromium.org/25713007/
will do the OnDemand calls internally.

This removes the async IPCs, callbacks, and observers that
were used to support the old code. The new code just
throttles/blocks the pexe URL request until OnDemand
installation is done.

Reverts: https://codereview.chromium.org/19863003/, plus
other CLs.

BUG=none
R=cpu@chromium.org, dmichael@chromium.org
TBR=jln

Review URL: https://codereview.chromium.org/55463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232827 0039d316-1c4b-4281-b951-d872f2087c98

R=rkc@chromium.org
BUG=314277

Review URL: https://codereview.chromium.org/56443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232826 0039d316-1c4b-4281-b951-d872f2087c98

The issue is that with Aura if something goes horribly wrong with the GPU, the user can get a 'black window' with no UI.

So for ConOps it is nice to have a way to start chrome with a set of flags that we know should get you a working chrome that they can troubleshoot.

To do this we add a hotkey combo to the start menu shortcut, in this case ctrl-shift-f10 which is not taken by windows. This shortcut can start chrome in this safe mode.

BUG=271719
TEST=see bug
R=robertshield@chromium.org

Review URL: https://codereview.chromium.org/57173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232825 0039d316-1c4b-4281-b951-d872f2087c98

This was on AutocompleteProvider because only providers needed it, but I'm going
to be calling this from OmniboxEditModel.  In the abstract, it probably makes
slightly more sense as a member of AutocompleteInput than AutocompleteProvider
anyway.

BUG=151044
TEST=none
R=mpearson@chromium.org

Review URL: https://codereview.chromium.org/55603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232821 0039d316-1c4b-4281-b951-d872f2087c98

This is a speculative revert to see if it's the cause of hanging renderers.

BUG=313112

Review URL: https://codereview.chromium.org/57783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232819 0039d316-1c4b-4281-b951-d872f2087c98

- Fix buggy path in Makefile and buggy template
- Don't auto-generate Yaml TOCs for now, but copy over _book.yaml with proper
  substitutions.

BUG=None
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/57923006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232818 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=gavinp@chromium.org

Review URL: https://codereview.chromium.org/57783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232817 0039d316-1c4b-4281-b951-d872f2087c98

This brings in the new libpcap2 package which was added
to the build script here:
https://codereview.chromium.org/51323006/

Also, remove support for install armel sysroot now that
all the builders are on armhf.

BUG=312380
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/55233006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232816 0039d316-1c4b-4281-b951-d872f2087c98

Just discovered that I broke the UMA stats during one of my recent refactorings. Here's what went wrong:

The interstitial is supposed to send a FOCUS event to indicate that page load timing should start. RecordSSLBlockingPageDetailedStats only records UMA stats if the page has a non-null page load time. At some point, I deleted the code that sent the FOCUS event, so the page load time was always null.

We don't need any of the timing stuff anymore, so I've gotten rid of all of it. This also fixes the bug.

BUG=314416

Review URL: https://codereview.chromium.org/57183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232809 0039d316-1c4b-4281-b951-d872f2087c98

ReferenceResolver, allowing for deleting APIListDataSource.GetAllNames.

R=yoz@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/56083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232808 0039d316-1c4b-4281-b951-d872f2087c98