- 11 Feb, 2019 40 commits
-
-
Marc Treib authored
- Make OnAutofillProfileChanged private. - Avoid some unnecessary copying. - Remove an unnecessary "mutable". - Remove unused |profiles_| member. Bug: none Change-Id: I4a65fc35b18dc962dc18bb77d09412a94e13bbbf Reviewed-on: https://chromium-review.googlesource.com/c/1458116Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#630714}
-
Christian Dullweber authored
History deletions from extensions are currently not propagated to synced history. This change will allow calls to history.deleteUrl(), history.deleteRange() and history.deleteAll() to remove urls from other devices and myactivity. There is currently no DeleteDirective to remove individual urls, so a new one is added. Old clients will just ignore the new directive. Bug: 395955 Change-Id: I0ad0e7f84a7a5e2028634ff60546887ce265ccf0 Reviewed-on: https://chromium-review.googlesource.com/c/1439303Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#630713}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/136cd7018a99..9a2169e84f25 git log 136cd7018a99..9a2169e84f25 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 gkaiser@google.com SkImage_GpuYUVA: Also sanity check height Created with: gclient setdep -r src/third_party/skia@9a2169e84f25 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I19d821a7d452edcbb8a0d234be1c8426156f3be4 Reviewed-on: https://chromium-review.googlesource.com/c/1462777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630712}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3c7ef7a3b16e..54496f14f521 Created with: gclient setdep -r src-internal@54496f14f521 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6ec5adb81dc47da38f3f6124ca07ccee74a81361 Reviewed-on: https://chromium-review.googlesource.com/c/1462776Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630711}
-
Mikel Astiz authored
We do this by introducing another layer, BrowserSyncClient, to minimize the code changes. Even in this humble form, the change substantially improves layering and already fixes some important issues like forward declarations being used to avoid build dependencies that would otherwise cause dependency cycles. The downside is that some extra boilerplate code is required to avoid dependencies selectively, as opposed to SyncClient being used as a big convenience bundle. This is arguably an improvement, though. In future patches, we should probably get rid of this new class altogether, but that requires more intrusive changes. Bug: 915154 Change-Id: Iaad6d54272bb1ccc00759ad039b313896acd4e34 Reviewed-on: https://chromium-review.googlesource.com/c/1458196Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#630710}
-
arthursonzogni authored
Similar to what is done with different-document navigations. If a same-document navigation commits into a pending deletion frame, it needs to be ignored. Regression tests added. Bug: 930132 Change-Id: Ib905197d30a754c3ac77b510d58741f40755a80f Reviewed-on: https://chromium-review.googlesource.com/c/1461023 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#630709}
-
Vaclav Brozek authored
So far, CSVTable understood any combination of CR and LF characters as the end of line. After a discussion linked to in https://crbug.com/923811, this CL changes that to explicitly only allowing CRLF and LF. Moreover, CRLF is no longer converted to LF inside quoted (escaped) strings. Performance impact, as measured with the benchmark from https://crrev.com/c/1459642: * Run time of the benchmark decreased from about 10s to about 9.5s * Peak memory consumption over 5 runs decreased from about 168700 kB to about 168350 kB Bug: 923811 Change-Id: I979d05e9f296f285db99dc22662bae29c907ea2a Reviewed-on: https://chromium-review.googlesource.com/c/1461042 Commit-Queue: Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#630708}
-
Raul Tambre authored
The former non-overloaded variants are deprecated. This is a mechanical change; there is no intended behavior change. Bug: 929827 Change-Id: I19be29e50c0d268b4280a6b0e572acdb0ac67af3 Reviewed-on: https://chromium-review.googlesource.com/c/1461385 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
This CL removes the static title if suggestions are available. Margins between suggestions are adjusted (according to mocks). It also fixes a minor bug: the back arrow wasn't mirrored in RTL mode. Bug: TBA Change-Id: I8a6e12c75418ee5c90ed6bd326ed075e8033bc8d Reviewed-on: https://chromium-review.googlesource.com/c/1458856 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#630706}
-
Marc Treib authored
If these functions need the Profile anyway, they can just grab any KeyedServices they require themselves. No need to make clients get them and pass them in. Bug: 911153 Change-Id: I31e9ecd3739e06fd2d4c9da00a1727cf9833e116 Reviewed-on: https://chromium-review.googlesource.com/c/1454539Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#630705}
-
Friedrich Horschig authored
This CL reenables all Autofill and Manual Filling Integration tests that previously flaked due to keyboard timing, unstable UI or were disabled because autofill chips were not yet available. Minor fix: Rescroll the chips when switching the focused field. Bug: 838922, 836027, 847959, 894428, 911056, 919988 Change-Id: I2fcfdc4016da5952cddf79f2d5c33180d89b7e1f Reviewed-on: https://chromium-review.googlesource.com/c/1459552Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#630704}
-
Victor Costan authored
This CL fixes member names that use the WebKit convention (m_name) to use the Google convention (name_). Where appropriate, the member names are wrapped in || so that they get code serachs' cross-reference navigation. Change-Id: I4d52de3b734cb28a998810bfb274f9f2716a4d79 Reviewed-on: https://chromium-review.googlesource.com/c/1462152 Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#630703}
-
arthursonzogni authored
This function is used by the ServiceWorker, but is not covered by tests. Add a comment to explain it is used. Bug: None. Change-Id: Iebf201e743debc01f16954e327f3abbe02f1bd40 Reviewed-on: https://chromium-review.googlesource.com/c/1455958 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630702}
-
Michael Giuffrida authored
Fixes the address of the chromium-mojo mailing list. Also makes it link to the Google Groups page for consistency with other Mojo docs. Bug: None Change-Id: Ic2230d996efab8b75c41c1a0d73f889d5c1124bb Reviewed-on: https://chromium-review.googlesource.com/c/1462147 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#630701}
-
Jochen Eisinger authored
The browser test predates the DCHECK, so instead of disabling a test that indicates that triggers a bug somewhere in surface management, we should temporarily remove the apparently incorrect DCHECK. BUG=823043 R=mohsen@chromium.org Change-Id: I03ad6259587b9367bd5940fc5c18da3698746dbe Reviewed-on: https://chromium-review.googlesource.com/c/1459628 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#630700}
-
Cecilia Ni authored
This CL integrates search view with dom-switch by letting selectedRouteId_ directly watch the existence of search term rather than delegating to reducer.currentPageState to handle search. This way, after users clear search, they will go back to the page they were on rather than main page. Bug: 906508 Change-Id: I75aabf2ccfdadc48093062b48adf85932c2b9606 Reviewed-on: https://chromium-review.googlesource.com/c/1459868Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Cecilia Ni <ceciliani@google.com> Cr-Commit-Position: refs/heads/master@{#630699}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4d85a1763c27..3c7ef7a3b16e Created with: gclient setdep -r src-internal@3c7ef7a3b16e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia19c8c79338b50825eca3e8de07149eaf17fe38f Reviewed-on: https://chromium-review.googlesource.com/c/1462676Reviewed-by:
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/13b2686c57be..dbbd7b449a7f $ git log 13b2686c5..dbbd7b449 --date=short --no-merges --format='%ad %ae %s' 2019-02-06 joelhockey system_api: add export pack stage 2019-01-31 kerrnel debugd: Implement core scheduler performance tuning. 2019-01-28 xiaochu dlcservice: migrate DLC module image path 2019-01-03 drcrash cryptohome, attestation: DBUS proto call to check attestation prep 2019-02-05 joelhockey system_api: update doc for export_path 2019-02-04 aoldemeier system_api: Add dbus constants for Start/StopVmPluginDispatcher methods. Created with: roll-dep src/third_party/cros_system_api Change-Id: Ibc92a6f0fa818ba401d0b750009eeed63bbe4829 Reviewed-on: https://chromium-review.googlesource.com/c/1460243Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#630697}
-
Alli Murray authored
removable partitions. Bug: 918795 Change-Id: I9538461a7d20d9b9d606e4d8f3462c71df018d32 Reviewed-on: https://chromium-review.googlesource.com/c/1460211 Commit-Queue: Alli Murray <alliemurray@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#630696}
-
Leo Zhang authored
Response from Mojo service is a dict with success as its key, which is defined in input_engine.mojom under chromeos/services/ime Bug: 837156 Change-Id: Ie33c5aaed27c3de8b995b8455b65074b6bbe2cba Reviewed-on: https://chromium-review.googlesource.com/c/1460656Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#630695}
-
Staphany Park authored
Bug: 611938 Change-Id: I451f543ac7d742a1eec692dfd924ed1f49d4feee Reviewed-on: https://chromium-review.googlesource.com/c/1462428 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#630694}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ef26fcb13fc6..136cd7018a99 git log ef26fcb13fc6..136cd7018a99 --date=short --no-merges --format='%ad %ae %s' 2019-02-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@136cd7018a99 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I267feb879913c9be4bde0ba42fe4f9c30d45eb66 Reviewed-on: https://chromium-review.googlesource.com/c/1462608Reviewed-by:
-
Chih-Yu Huang authored
In MojoVDService and some unittest we duplicate a simple implementation of VideoFrame::SyncTokenClient. This CL moved it to a separate file. BUG=522298 TEST=media_unittests Change-Id: I18009712977a12b31cc8136ef79a230b34667384 Reviewed-on: https://chromium-review.googlesource.com/c/1460741 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Auto-Submit: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#630692}
-
Staphany Park authored
Bug: 611938 Change-Id: I5231a54ef35fc2aee6d36e83d65b1674df58cbd0 Reviewed-on: https://chromium-review.googlesource.com/c/1462425 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
-
Cecilia Ni authored
This CL adds PWA Permission View tests that test 1) toggle status reflects permission status, and 2) click toggle will toggle the corresponding permission. Bug: 906508 Change-Id: I03f77afe2a75afc260c2d0dcdfe907e6d12dc9e8 Reviewed-on: https://chromium-review.googlesource.com/c/1445331 Auto-Submit: Cecilia Ni <ceciliani@google.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Cecilia Ni <ceciliani@google.com> Cr-Commit-Position: refs/heads/master@{#630690}
-
Joel Hockey authored
Change-Id: I6279cd2c62a937735a6f9b56fdbbde7d88dc53c8 Reviewed-on: https://chromium-review.googlesource.com/c/1460246 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ee1cb5959d7a..4d85a1763c27 Created with: gclient setdep -r src-internal@4d85a1763c27 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I28054cfc78edd5fe846017e2ed9ef4f56579c5f1 Reviewed-on: https://chromium-review.googlesource.com/c/1462596Reviewed-by:
-
Findit authored
This reverts commit 6d39702e. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 630682 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZkMzk3MDJlNzQ4YWUzMzg0MmU1MzlhZmNmNTVlYjI2MjM1ODJkODAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/19798 Sample Failed Step: non_single_process_mash_unit_tests Original change's description: > [Dolphin] Refactor in preparation for query-based predictions. > > - Extra methods added to RecurrenceRanker and RecurrencePredictor to accept queries. > > - Storage of targets has been moved from the RecurrenceRanker to individual > RecurrencePredictors. As a result, RecurrencePredictor must now handle targets > renames and removes themselves. Methods for this have been added to their API. > > This is necessary because query-based predictions will require a different data > structure to store target + query than zero-state predictions, which only require > a target. In order to keep the RecurrenceRanker usable for both tasks, choice of > data structure needs to moved into the RecurrencePredictors, where individual > predictors can use what's suitable. > > - The original FrecencyPredictor has been renamed ZeroStateFrecencyPredictor. > > - Some extra tests added. > > Bug: 921444 > Change-Id: I95a6dca135928726c779261ec6b1663b1023bf1f > Reviewed-on: https://chromium-review.googlesource.com/c/1459856 > Reviewed-by: Jia Meng <jiameng@chromium.org> > Commit-Queue: Tony Yeoman <tby@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630682} Change-Id: I9ac4e9efc7abf31d64e30cd9e3f5a1fa55bd9778 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921444 Reviewed-on: https://chromium-review.googlesource.com/c/1462426 Cr-Commit-Position: refs/heads/master@{#630687}
-
Melissa Zhang authored
This CL implements the uninstall method in arc_apps. BUG=916380 Change-Id: I2ea78604d3eeee68f72f1c5985eb6bc71371090d Reviewed-on: https://chromium-review.googlesource.com/c/1451497 Commit-Queue: Melissa Zhang <melzhang@google.com> Reviewed-by:
Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#630686}
-
Alexey Baskakov authored
The backend shouldn't know anything about the frontend (UI). It still uses PWAConfirmationView and ShowPWAInstallDialog/ShowBookmarkAppDialog under the hood. Bug: 901226 Change-Id: I3a22410005efe8ded469fa094069af3132456338 Reviewed-on: https://chromium-review.googlesource.com/c/1451501 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#630685}
-
Alexander Dunaev authored
The fuzzer no longer stops the server thread during the operation. R=msisov@igalia.com, rjkroege@chromium.org Bug: 928768 Change-Id: I80c5cad47d38563f00258a5a95a109784378da12 Reviewed-on: https://chromium-review.googlesource.com/c/1458445Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#630684}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: I9c503d7d12c1127af5353280d0e3fc9fb03c2f3e Reviewed-on: https://chromium-review.googlesource.com/c/1462210Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#630683}
-
tby authored
- Extra methods added to RecurrenceRanker and RecurrencePredictor to accept queries. - Storage of targets has been moved from the RecurrenceRanker to individual RecurrencePredictors. As a result, RecurrencePredictor must now handle targets renames and removes themselves. Methods for this have been added to their API. This is necessary because query-based predictions will require a different data structure to store target + query than zero-state predictions, which only require a target. In order to keep the RecurrenceRanker usable for both tasks, choice of data structure needs to moved into the RecurrencePredictors, where individual predictors can use what's suitable. - The original FrecencyPredictor has been renamed ZeroStateFrecencyPredictor. - Some extra tests added. Bug: 921444 Change-Id: I95a6dca135928726c779261ec6b1663b1023bf1f Reviewed-on: https://chromium-review.googlesource.com/c/1459856Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#630682}
-
Nico Weber authored
TBR=dvadym Bug: 926235 Change-Id: Ic78dd70b61df3c46e5fd7a56db4722fc4ebe0637 Reviewed-on: https://chromium-review.googlesource.com/c/1462206 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#630681}
-
Nico Weber authored
There's no good way to require a semicolon after this macro, so remove the semicolons after the macro instead. (Several places already had no semicolon there, so this does make things more consistent.) CL created by git grep -l DECLARE_EXTENSION_FUNCTION | xargs -n 1 perl -i -p0e 's/(DECLARE_EXTENSION_FUNCTION\([^)]+\));?/\1/g' TBR=seantopping Bug: 926235 Change-Id: Ia49fc64756ab1b50d3423f6c80ed0c2d44f4378b Reviewed-on: https://chromium-review.googlesource.com/c/1462207 Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#630680}
-
Nick Diego Yamane authored
As of [1], UTF characteres are correctly composed on Ozone/wayland, taking as input raw key events from InputMethod classes. That is possible thanks to previously ChromeOS-only CharacterComposer component. This patch fixes the preedit text handling in WaylandInputMethodContext, which basically properly support HEX_MODE in CharacterComposer. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1448136 R=rjkroege@chromium.org, shuchen@chromium.org Bug: 921947 Change-Id: I7cf750df2bf43273464f52a726719d50d74075f8 Reviewed-on: https://chromium-review.googlesource.com/c/1454297Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#630679}
-
Alexey Baskakov authored
All subsystems work with a generalized web app registry, hence any activities must be started in WebAppProvider::OnRegistryReady callback. Fix ExtensionServiceTestSimple.Enabledness unit test on ChromeOS: - Two TestingProfiles with TestExtensionSystem in each of them can not co-exist because they start two conflicting ScopedTestUserManager instances for user_manager::UserManager singleton. https://cs.chromium.org/chromium/src/chrome/browser/extensions/test_extension_system.cc?rcl=2e6a3bddac0aff89c5ff415e9c1cd4da804280ef&l=54 Bug: 920062 Change-Id: I18097d84ac9e27fdda9a7b5458cae9c4f5895273 Reviewed-on: https://chromium-review.googlesource.com/c/1454058 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL adds a feature flag for the new omnibox installation button for PWAs. Bug: 907351 Change-Id: I40aabe93b0bcdfb84160a5394b826f83b4a19cbe Reviewed-on: https://chromium-review.googlesource.com/c/1460206 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#630677}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e971cc3474b7..ee1cb5959d7a Created with: gclient setdep -r src-internal@ee1cb5959d7a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3118ede841395db2d6e402d40e98f5599671f4cd Reviewed-on: https://chromium-review.googlesource.com/c/1462542Reviewed-by:
-
Reka Norman authored
This CL adds a permission view for ARC apps, which involves making the permission-related functionality of the page more generic so that it works for different app types. It also fixes a problem which prevents the toggles in the notification view from actually changing permissions. Bug: 906508 Change-Id: I180beed57a5ad6009fb64e4f180002fba1369242 Reviewed-on: https://chromium-review.googlesource.com/c/1453218 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by:
-
