GitLab

Previously the host was not sending empty keep alive messages when
video stream is paused or when it's blocked on the encoder, this
triggers reconnect too often.
Refactored keep-alive logic in VideoScheduler so now it always
sends keep-alive messages when there is no other activity on the
stream.

BUG=376528,375568

Review URL: https://codereview.chromium.org/292373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272790 0039d316-1c4b-4281-b951-d872f2087c98

Previously the client was calling EnsureSSLServerSockets(), which
internally calls EnsureNSSSSLInit(). It's not necessary to initialize
server socket so that call was removed in r263951, and NSS is no longer
initialized, which sometimes breaks the client (see the bug). Also
removed the workaround.

BUG=364689

Review URL: https://codereview.chromium.org/297863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272789 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375568

Review URL: https://codereview.chromium.org/296703013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272788 0039d316-1c4b-4281-b951-d872f2087c98

It seems we can just pass |peer| directly to AddPendingRequest()
function and thus remove this variable, simplifying
IPCResourceLoaderBridge.

BUG=265753, 338338, 237249
TEST=content_shell + content_unittests
R=jam@chromium.org

Review URL: https://codereview.chromium.org/294043012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272787 0039d316-1c4b-4281-b951-d872f2087c98

App shims have been enabled by default for 3 milestones
(since r242711).

BUG=350161

Review URL: https://codereview.chromium.org/298953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272786 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fischman@chromium.org,scherkus@chromium.org
BUG=366158

Review URL: https://codereview.chromium.org/298063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272785 0039d316-1c4b-4281-b951-d872f2087c98

Sends TextInputTypeChanged from renderer to browser when UpdateTextInputState. UpdateTextInputState used to only work with Android, but r245932 made it work with both Android and Aura.

BUG=345080
TEST=Verified in sandbox.

Review URL: https://codereview.chromium.org/299793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272784 0039d316-1c4b-4281-b951-d872f2087c98

process_resources.py already implements almost everything from 
apk-codegen.xml so just use that instead.

BUG=359249,375324,375431

Review URL: https://codereview.chromium.org/295473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272783 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of https://codereview.chromium.org/294943006 after it's reverted in
https://codereview.chromium.org/284183014/.

BUG=368767

Review URL: https://codereview.chromium.org/299443017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272782 0039d316-1c4b-4281-b951-d872f2087c98

This provides a gypi action including well-defined variables, a python script, and a first client in ChromeVox (main and guest).

This generation code was born out of necessity as ChromeVox evolves and requires a varying set of manifests depending on such factors as compression strategy, debug/release builds, Chrome webstore releases, and ChromeVox next (version).

Review URL: https://codereview.chromium.org/295123002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272781 0039d316-1c4b-4281-b951-d872f2087c98

Updated the description of Device.info. Added Device.deviceName to be the same as Device.info.

R=kalman@chromium.org

Review URL: https://codereview.chromium.org/296003016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272780 0039d316-1c4b-4281-b951-d872f2087c98

Due to bugs with scaling and handling NULL regions.

BUG=376532

Review URL: https://codereview.chromium.org/296513022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272779 0039d316-1c4b-4281-b951-d872f2087c98

BUG=362881
TEST=Key events no longer crash in touchview.

Review URL: https://codereview.chromium.org/294033016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272778 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a test for the app list showing the correct view when it
hides and reshows. This tests the behavior introduced in
https://codereview.chromium.org/214423002/.

BUG=357058

Review URL: https://codereview.chromium.org/220393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272777 0039d316-1c4b-4281-b951-d872f2087c98

BUG=338887

Review URL: https://codereview.chromium.org/288053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272776 0039d316-1c4b-4281-b951-d872f2087c98

This is the GN version of build/java_cpp_template.gypi.

It defines a template that wraps an action_foreach that generates .java
files using the host C preprocessor.

The major difference in the GN version is that it takes all the
generated java files and zips them together in a single .srcjar. When
such a target is included in the srcjar_deps of a java library, the
.java files in the .srcjar will be treated much like files listed in
that libraries java_sources (particularly they will be compiled and
included in the .jar/.dex).

Depends on https://crrev.com/264773014/

BUG=359249

Review URL: https://codereview.chromium.org/264923007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272775 0039d316-1c4b-4281-b951-d872f2087c98

BUG=377338
TBR=sergiu@chromium.org

Review URL: https://codereview.chromium.org/295393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272774 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375910
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/295333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272773 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272772 0039d316-1c4b-4281-b951-d872f2087c98

Still failing - will need infra to take a look.

> Revert 272672 "Attempt #4: Change Skia DEPS to pull from googles..."
> 
> Waterfall Builder: iOS Simulator (dbg) is failing in bot_update since
> 
> http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/16396
> 
> Suspecting this. Will unrevert if not.
> 
> BUG=377342
> 
> > Attempt #4: Change Skia DEPS to pull from googlesource (git)
> > 
> > - Uploading from pure-svn and intending to commit manually to properly remove the directory from svn.
> > - Includes deps_whitelist change for new Skia DEP
> > - Attempt #3 failed due to Poppler license issue. This was resolved in https://skia.googlesource.com/skia/+/3056bdd2364fe1aa68f4ec7b0fe07740c3e8d123
> > 
> > R=mkosiba@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/296903004
> 
> TBR=borenet@google.com
> 
> Review URL: https://codereview.chromium.org/297303002

TBR=tapted@chromium.org

Review URL: https://codereview.chromium.org/297313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272771 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272770 0039d316-1c4b-4281-b951-d872f2087c98

Waterfall Builder: iOS Simulator (dbg) is failing in bot_update since

http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/16396

Suspecting this. Will unrevert if not.

BUG=377342

> Attempt #4: Change Skia DEPS to pull from googlesource (git)
> 
> - Uploading from pure-svn and intending to commit manually to properly remove the directory from svn.
> - Includes deps_whitelist change for new Skia DEP
> - Attempt #3 failed due to Poppler license issue. This was resolved in https://skia.googlesource.com/skia/+/3056bdd2364fe1aa68f4ec7b0fe07740c3e8d123
> 
> R=mkosiba@chromium.org
> 
> Review URL: https://codereview.chromium.org/296903004

TBR=borenet@google.com

Review URL: https://codereview.chromium.org/297303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272769 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Suspected for waterfall failures "gsignal.c:2459: signal `insert' is invalid" also possibly some obscure ASAN/LSAN errors

http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%282%29&number=46389
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/2531

[15124:15124:0524/063846:FATAL:browser_main_loop.cc(205)] GLib-GObject: /build/buildd/glib2.0-2.32.4/./gobject/gsignal.c:2459: signal `insert' is invalid for instance `0xcb71d63c0b0'
#0 0x7f91f99d3019 base::debug::StackTrace::StackTrace()
#1 0x7f91f9a4f139 logging::LogMessage::~LogMessage()
#2 0x7f920330e20d content::(anonymous namespace)::GLibLogHandler()
#3 0x7f91f3ab0f61 g_logv
#4 0x7f91f3ab1172 g_log
#5 0x7f91f3d7dd47 g_signal_connect_data
#6 0x7f91d9293efb <unknown>
#7 0x7f91d9294e8e <unknown>
#8 0x7f91d92961a8 dbusmenu_gtk_parse_menu_structure
#9 0x7f91d96af8fe app_indicator_set_menu
#10 0x7f91f8ac609b libgtk2ui::AppIndicatorIcon::SetMenu()
#11 0x7f91f8ac5e3a libgtk2ui::AppIndicatorIcon::SetImageFromFile()
#12 0x7f91f8ac92c8 base::internal::RunnableAdapter<>::Run()

==7567==ERROR: AddressSanitizer: heap-use-after-free on address 0x60800001e028 at pc 0x4cfb688 bp 0x7f4facffd2d0 sp 0x7f4facffd2c8
WRITE of size 4 at 0x60800001e028 thread T7 (CompositorRaste)

==14726==ERROR: LeakSanitizer: detected memory leaks
Direct leak of 116 byte(s) in 2 object(s) allocated from:
    #0 0x5758ab in __interceptor_malloc /usr/local/google/work/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75
    #1 0x7f52ed561a38 in g_malloc /build/buildd/glib2.0-2.32.4/./glib/gmem.c:159


Original issue's description:
> linux_aura: Add Trusty libappindicator.
> 
> BUG=374686
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272718

TBR=pkotwicz@chromium.org,erg@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=374686

Review URL: https://codereview.chromium.org/296393003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272763 0039d316-1c4b-4281-b951-d872f2087c98

Causing compile failures on Windows.  Possible comatability issue
with https://codereview.chromium.org/298703007

Sample errors:

FAILED: ninja -t msvc -e environment.x86 -- C:\b\build\goma/gomacc "C:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\ui\wm\core\wm_unittests.nested_accelerator_controller_unittest.obj.rsp /c ..\..\ui\wm\core\nested_accelerator_controller_unittest.cc /Foobj\ui\wm\core\wm_unittests.nested_accelerator_controller_unittest.obj /Fdobj\ui\wm\wm_unittests.cc.pdb 
c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(83) : error C2039: 'host' : is not a member of 'aura::Window'
        c:\b\build\slave\win\build\src\ui\aura\window.h(62) : see declaration of 'aura::Window'
c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(83) : error C2227: left of '->PostNativeEvent' must point to class/struct/union/generic type
c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(85) : error C2039: 'host' : is not a member of 'aura::Window'
        c:\b\build\slave\win\build\src\ui\aura\window.h(62) : see declaration of 'aura::Window'
c:\b\build\slave\win\build\src\ui\wm\core\nested_accelerator_controller_unittest.cc(85) : error C2227: left of '->PostNativeEvent' must point to class/struct/union/generic type
ninja: build stopped: subcommand failed.


> Refactor and move ash independent accelerator handling code in nested loop to ui/wm/core
> 
> I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them.
> 
> BUG=None
> 
> Review URL: https://codereview.chromium.org/298703007

TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/300093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272759 0039d316-1c4b-4281-b951-d872f2087c98

R=zty@chromium.org

Review URL: https://codereview.chromium.org/302433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272750 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272742 0039d316-1c4b-4281-b951-d872f2087c98

I also renamed classes to NestedAcceleratorXxx. I felt this is a bit more clearer than NestedDispatcher, especially in ui/wm/core. Please let me know if you disagree or have better suggestion. I'm happy to rename them.

BUG=None

Review URL: https://codereview.chromium.org/298703007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272740 0039d316-1c4b-4281-b951-d872f2087c98

This patch converts the following gyp targets to GN:
- favicon_base
- query_parser
- metro_viewer_messages -> metro_viewer
- native_theme

BUG=None
TEST=None
R=scottmg@chromium.org
TBR=ben@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/294423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272739 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/299313004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272738 0039d316-1c4b-4281-b951-d872f2087c98

BUG=45482
R=thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/293983023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272737 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/300633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272736 0039d316-1c4b-4281-b951-d872f2087c98

this change:
- changes border-color instead of opacity of checkboxes on hover
- makes checked and hovered checkboxes look more similar
- makes hovered rows more noticeable

And I touched a few more things that weren't really noticeable
before I changed the background color:
- checkbox vertical alignment
- added padding in front of checkboxes

BUG=351565
R=dmazzoni@chromium.org
TEST=visible checkboxes

Review URL: https://codereview.chromium.org/293303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272735 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/293963004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272734 0039d316-1c4b-4281-b951-d872f2087c98

This is rudimentary implemenatation of AttachmentDownloader along with fake for tests.

BUG=376073
R=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/296153014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272733 0039d316-1c4b-4281-b951-d872f2087c98

Identical logic change in both AudioSender and VideoSender: Send a sender
report just before each frame, up to the first 100 frames.  Then, they are
sent at ~1 second intervals thereafter.  However, if a receiver report
shows up, we halt the aggressive report sending immediately since we know
the data dependency (receiver side) has been satisfied.

Also, misc clean-ups:

1. RtpTimestampHelper threw away significant precision in its calculations
   (was truncating to millis).
2. Unit tests were using EXPECT with args in the wrong order (per gtest
   requirements).
3. Got rid of useless LocalRtcpXXXXXSenderFeedback class.

BUG=371482

Review URL: https://codereview.chromium.org/295603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272732 0039d316-1c4b-4281-b951-d872f2087c98

scoped_array is deprecated in favor of scoped_ptr[]
as of https://codereview.chromium.org/14081006

Review URL: https://codereview.chromium.org/291893010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272731 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/291153012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272730 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=michaelbai@chromium.org

Review URL: https://codereview.chromium.org/297183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272729 0039d316-1c4b-4281-b951-d872f2087c98

Also remove cruft and simplify code.

Review URL: https://codereview.chromium.org/297023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272728 0039d316-1c4b-4281-b951-d872f2087c98

For tests I'm creating a MessagePumpGlib on a thread, destroying it,
then creating another MessagePumpGlib on another thread. The DCHECK
fires in this case because it only remembers the first thread. I made
it so the thread id is cleared when the MessagePumpGlib is destroyed.

BUG=none
TEST=none
R=sadrul@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/289043010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272727 0039d316-1c4b-4281-b951-d872f2087c98