- 08 Jul, 2020 40 commits
-
-
Adam Langley authored
This reverts commit c6728c24. The credential is optional in the response when there's a single entry in the allowlist. Normally we wouldn't be sending silent requests in that case, but it can happen if the allow list had more entries before filtering or if there's an appid extension. This is a clean revert for merging purposes. Test changes and a fix will come later. BUG=1102777 Original change's description: > device/fido: only send the single matching credential ID. > > When prelighting credential IDs for getting an assertion, only send the > matching credential ID on the following up=1 request, rather than the > whole matching batch. > > Change-Id: I41534e82306b82c2332b44deb6466a9ee46c2905 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250893 > Commit-Queue: Adam Langley <agl@chromium.org> > Reviewed-by: Martin Kreichgauer <martinkr@google.com> > Cr-Commit-Position: refs/heads/master@{#780525} TBR=agl@chromium.org,martinkr@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I3779623933af956f2cd8ade9200d7e7165cc55fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287384Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#786332}
-
Lei Zhang authored
Add dependencies and friends to make gn check pass. While enabling the "//pdf/*" entry in //.gn, trim some excess blank lines in that file. Bug: 1100400 Change-Id: I00fb6e80a48a778ae79531e8c2a328b92e041702 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285325 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#786331}
-
Lukasz Anforowicz authored
Before this change, tests of raw output of the rewriter (i.e. tests run without passing --apply-edits to tools/clang/scripts/test_tool.py) might need to encode the full, absolute path in the test expectations. This meant that the tests wouldn't work on another developer's machine (where Chromium repo might be in a different location). After this change: - tools/clang/rewrite_raw_ptr_fields/tests/gen-*-expected.txt expectation files use paths delative to the rewrite_raw_ptr_fields/tests/ directory (rather than hardcoding a value of .../lukasza/src/chromium4/src/tools/clang/rewrite_raw_ptr_fields/tests - tools/clang/scripts/test_tool.py normalizes paths in the raw output (only if invoked without --apply-edits) to make the paths relative to the tests directory Bug: 1069567 Change-Id: I03c54374bb861904e439e677a271b0dec1502b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2282888 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#786330}
-
Guillaume Jenkins authored
Rather than having parent objects pass concrete delegates to their members, the idea of this change is to have one factory object that will create platform-specific delegates for all the enterprise reporting classes. That way, only the factory needs to be passed around, and each reporting class can use it to get the delegate they need. This helps encapsulation because delegates of parent objects don't need to know about their children and their delegates. For now, the concrete factory's life cycle is owned by ReportGenerator because BrowserReportGenerator is the only one using it so far. But over the course of the next few CLs, the factory will be owned by objects higher and higher in the ownership hierarchy, until it's owned by CBCMController. Bug: 1091916 Change-Id: I7eec88ab1b1fb1bbc4c24ab198cc91637b836093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2281031 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#786329}
-
Alexander Cooper authored
The VR Testapp was used to test the VR Browser, which is no longer supported, or possible to enter. As a result, this is effectively all dead code, and thus can/should be removed. Change-Id: Ibfb47a4cd6b1d7a2fccc290a82c85a2cdeb35dc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285397Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#786328}
-
Andrew Grieve authored
We should not rename libraries when not using crazy linker. Bug: 1103107 Change-Id: I24431c2818b596cd95b198d08b9670ba1750a380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287891 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#786327}
-
Victor Hugo Vianna Silva authored
The sole purpose of these APIs is to propagate the unsynced credentials computed in PasswordSyncBridge up to ManagePasswordsState, which will then own them until the user decides to save or discard. So this CL modifies the APIs to a pass-by-value/move scheme. This spares 2 copies: when posting the task to UnsyncedCredentialsDeletionNotifier; and when storing the credentials in ManagePasswordsState. Bug: None Change-Id: Ic2f0dc191700b55d74b199b130a55d71f61150a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283751Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#786326}
-
Lei Zhang authored
The 1-parameter version is simpler, and the 2-parameter version is deprecated. Bug: 1009837 Change-Id: I398fbf56c8d8201e665862d12b4dddece5691a0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285915Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#786325}
-
Alexander Dunaev authored
Running the drag loop in DesktopDragDropClientOzone::StartDragDrop caused issues in the X11 platform implementation. The platform needs to capture and dispatch events properly, which is typically handled by |X11WholeScreenMoveLoop| that runs its own run loop. This CL moves the drag loop to the platform level. Two existing Ozone platforms are affected: changes to Wayland are trivial, and X11 gets some code that duplicates a few bits of |DesktopDragDropClientAuraX11|. This is temporary and will be fixed soon when we finally obsolete the non-Ozone path and get rid of |DesktopDragDropClientAuraX11|. Also, a few minor things are fixed that had been proposed earier in CLs based on the previous approach: 1. The drag image is now created only on platforms that need it [1] 2. The ui::XDragDropClient is documented [2] [1] https://crrev.com/c/2264553 [2] https://crrev.com/c/2262612 Bug: 1014860 Change-Id: Iec8aa145a23e1002df06a788bbc8ecb73d04ec63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267378Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#786324}
-
Maria Kazinova authored
This test requires a PasswordController instance to handle set up for renderer ids with the proper timing. Bug: 1101971 Change-Id: Ifd97be2e8bcdbcef137f4d5b3c65a956c50ff469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283334Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#786323}
-
dpapad authored
This in in preparation of removing the Polymer1 core library from the repository. Bug: 1102485 Change-Id: I95ec3992b89a32489a957efaf26aef17d0808222 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283922Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#786322}
-
Alex Gough authored
Change-Id: I17c60ddb3294cc16dd41ff54d86ca95a741aff61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284209Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Adrian Taylor <adetaylor@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#786321}
-
Emily Stark authored
This is a reland of 65ac9625 Original change's description: > Clean up steady-state scheme/trivial subdomains elision flags > > These flags are enabled by default and expired since M76. > > I'm cleaning these up now because I'm starting to think about > uneliding scheme/trivial subdomains on hover (for the omnibox UI > simplified domain field trials), and it'll be simpler code if we don't > have to reason about these expired flags in both enabled and disabled > states. > > Bug: 797354 > Change-Id: I766a30c2f886ae1d651c2bf8eed0bc094664bde7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277880 > Reviewed-by: Michael Wasserman <msw@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785962} Bug: 797354 Change-Id: I0acc00e958e89263ac94a6a58155a9cf717fa48e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285515Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#786320}
-
Sylvain Defresne authored
This reverts commit 15168c9b. Reason for revert: Xcode display errors when running EG2 tests (see https://crbug.com/1103230). Original change's description: > [ios] Enable New Build System in generated Xcode project > > Since gn now generates a project that wraps the invocation > of ninja in a script converting relative paths to absolute > paths, there is nothing blocking the use of the New Build > System. > > Bug: 852522 > Change-Id: I9b4ca343dc9434efb64a3866ca88d6b7c4065760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276281 > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#785343} TBR=sdefresne@chromium.org,olivierrobin@chromium.org Bug: 852522, 1103230 Change-Id: I5f8825ebd8b08bd89f0013ac278295632a83e3e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287548 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#786319}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1402ed576596..fdad1302b17b 2020-07-08 bclayton@google.com Remove pushing / popping -fPIC for glslang (#1098) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I8973c3be09724e7932c111ed00151d62e6b972de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287778Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786318}
-
Pâris MEULEMAN authored
Make the failed output of Coop reporting tests more stable in order to use expectations Bug: 1099208 Change-Id: Ib1b516bc03295eb243d2db3c33ee4bc9db8b89df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279819 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#786317}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d07980440d45..e06b67c092bd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC huanzhong@google.com,mohsen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1098339 Tbr: huanzhong@google.com,mohsen@google.com Change-Id: Ibdc27dae527caef601809aa54a9abc01cc9034d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287776Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#786316}
-
Victor Costan authored
This is split off from https://crrev.com/c/2286475 to facilitate reviewing and any follow-up debugging. Change-Id: I35a61f4f0fea3465e70f7a08daf29b74f4161432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285925 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#786315}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594187879-6eac15fcdfb0a939dbcd47aeb2bfde0b77cd75b2.profdata to chrome-win64-master-1594209491-ef5df3b74524e456f9efc0fd239921f6b10d9a40.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I220ac36b334b5c998227550eb5a1f3267721a560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287772Reviewed-by:
-
K. Moon authored
Migrates all uses of pp::CompletionCallbackWithOutput in pdf/ to base::OnceCallback. As it turns out, the PDF viewer only uses this kind of callback to fetch passwords from the user, and all uses can be replaced completely by base::OnceCallback. Bug: 1101169 Change-Id: Icbdd8c996b12c7a37a0df4ade81cd4a1e0fbb347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285309Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#786313}
-
Ben Pastene authored
Now uses the new gclient var 'cros_boards_with_qemu_images' for DEPS hooks as well as for building the data_deps for CrOS tests in GN. Bug: 937821 Change-Id: Ifdd05f09a4200328a06028be86aeb22c8486c65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285361Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#786312}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594209491-cc6e4c4037ca65c106edfe531375742086a02040.profdata to chrome-mac-master-1594219033-e737395f4059a2d181f502d2cd1e2e733e308ff9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: I3de677dc06577d90a9eed5b3804e8ff67c67cf84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287781Reviewed-by:
-
Xiyuan Xia authored
CL:2253184 does not work when there are multiple animation sequences to abort. This CL fixes the problem by canceling report when the start_time of an aborted sequence is after the start_time of the first started sequence. Bug: 1021774, 1101084 Change-Id: I522b59a728f94584753b4234ea233b4ebe521d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276724Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#786310}
-
Lily Chen authored
Based partially on earlier draft by morlovich: https://crrev.com/c/1038245 Bug: None Change-Id: I98ad46c6b3ed83d2af5ad9a565008829cf5cdba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284134 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Steven Bingler <bingler@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#786309}
-
Jason Chase authored
As a follow up to cl/21773473 [1], there are now 3 code locations that get the current script url from the V8 stack. Each location had their own helper function with very similar logic. This CL extracts the equivalent logic into a reusable function, and uses the new function in all 3 locations. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2173473/13/third_party/blink/renderer/core/loader/http_equiv.cc#53 Bug: 1073920 Change-Id: I237144bc1cfa75f5beecc9977f522549d8c1fbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273599Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#786308}
-
Peter Kotwicz authored
This CL refactors ChromeStrictMode so that proguard removes the strict mode detection code in canary/beta/stable release builds. BUG=1038384 Change-Id: Ic03f6df3b479e023e7a63de5c8a386098968b793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280604Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cdb7febb0552..c103a111af91 2020-07-08 primiano@google.com Docs: fix typos 2020-07-08 treehugger-gerrit@google.com Merge "tp: store argv from ProcessTree in process table and show in UI" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Iae3d637e9655b0cd4747b828a250ea2edc715fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287774Reviewed-by:
-
ckitagawa authored
As I understood it, a local frame needed to be loaded to reach the point where an embedding token was requested in LocalFrameView::CapturePaintPreview(). However, canary crash reports suggest it is possible a token may gone at this point (either the frame is unloaded or had yet to finish navigating). As such, we should check for the token and if it is not present capture should proceed as if the frame could not be captured separately (this appears to be a very rare case). Bug: 1103157 Change-Id: I8a2d244cdf5e453807ef9a229a55671895a2231e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287811Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#786305}
-
Matthew Mourgos authored
Before this, the MessageCenterObserver was used to allow the ShelfModel to keep track of existing notifications. This allowed the ShelfModel to correctly update the apps that had a notification. In this CL, the ShelfController no longer observes the MessageCenter and instead observes the AppRegistryCache to get notification updates. With this method, the ShelfModel no longer needs to keep a map of existing notifications. Instead, the AppRegistryCache calls OnAppUpdate() whenever an app's notification badge status has changed. Also, in order to get the initial notification badge status for new ShelfItems, the ShelfControlelr observes changes to the ShelfModel. When a new item is added to the model, the ShelfController uses the AppRegistryCache to update the model with the current notification badge status. Bug: 1080827 Change-Id: I1c37626170387a8e81cec0f6f3c06026ac62a976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219164Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#786304}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0c87b32429bf..f8597f282852 2020-07-08 khokhlov@google.com [Telemetry] Only use Perfetto sync when all agents produce proto traces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1102378 Tbr: rmhasan@google.com Change-Id: Iab0c2a479bbc29580d7b333b336262813a14e9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287773Reviewed-by:
-
David Jean authored
Bug: 1079425 Change-Id: Ib39c9280714bd7f386d74979d9849f832957ad0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270063 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#786302}
-
Andy Lu authored
From the debugger, it was found that there were legitimate use cases where we would hit the DCHECKs (such as handling tab-opening intents from a cold start), causing a crash. Removing the DCHECKs fixes the issue. My feature that I am trying to implement: https://chromium-review.googlesource.com/c/chromium/src/+/2236243 Bug: 1102418 Change-Id: Ib0fe8ec238b271ec09d6ab3b6cfd8427555f5e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283575Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Andy Lu <andyhylu@google.com> Cr-Commit-Position: refs/heads/master@{#786301}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3444a49d77b0..e88c95e516b6 2020-07-08 hbos@webrtc.org [Stats] Add more rtc::Thread::ScopedDisallowBlockingCalls to getStats(). 2020-07-08 tommi@webrtc.org Remove unused GuardedAsyncInvoker class 2020-07-08 handellm@webrtc.org Revert "Migrate test/time_controller to webrtc::Mutex." 2020-07-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b5359525..a69b9c61 (785857:786202) 2020-07-08 hbos@webrtc.org [Stats] Optimization: Minimize number of thread-invokes in getStats(). 2020-07-08 mbonadei@webrtc.org Revert "Implement packets_(sent | received) for RTCTransportStats" 2020-07-08 handellm@webrtc.org Migrate modules/audio_device to webrtc::Mutex. 2020-07-08 handellm@webrtc.org VideoAnalyzer: remove lock recursions. 2020-07-08 handellm@webrtc.org Migrate test/pc/e2e to webrtc::Mutex. 2020-07-08 mbonadei@webrtc.org Add possibility to expand strings in the autoroller. 2020-07-08 handellm@webrtc.org Migrate test/time_controller to webrtc::Mutex. 2020-07-08 handellm@webrtc.org Migrate modules/congestion_controller to webrtc::Mutex. 2020-07-08 titovartem@webrtc.org Fix thread usage in PC level tests for getting to the IceConnected state 2020-07-08 handellm@webrtc.org Logging: reduce locking frequency by fixing TODO. 2020-07-07 handellm@webrtc.org Revert "Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex." 2020-07-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision fa6a9612..b5359525 (785707:785857) 2020-07-07 handellm@webrtc.org Migrate pc/ to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate video/ except video/end_to_end_tests and video/adaptation to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate modules/remote_bitrate_estimator to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate video/adaptation and video/end_to_end_tests to webrtc::Mutex. 2020-07-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5f083e73..fa6a9612 (785559:785707) 2020-07-07 handellm@webrtc.org Migrate modules/audio_coding, audio_mixer/ and audio_processing/ to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate media/ to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate common_video/ and examples/ to webrtc::Mutex. 2020-07-07 ivoc@webrtc.org Update default max nr of packets to 200. 2020-07-07 handellm@webrtc.org Migrate modules/rtp_rtcp to webrtc::Mutex. 2020-07-07 handellm@webrtc.org Migrate modules/video_coding to webrtc::Mutex. 2020-07-07 titovartem@google.com Implement packets_(sent | received) for RTCTransportStats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ida1605b68ce1bb4c568c7fddee238f84aeb98aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287775Reviewed-by:
-
Nate Fischer authored
This renames system_webview_pak_whitelist to system_webview_pak_allowlist. Fixed: 1101022 Test: build with `is_official_build = true` Change-Id: I56a11427132d8b3b143a830ba9dba098fe39d697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285504 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie5b8e90808748c59f7c03a2ccfa63eb1338b83e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287375Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/28159ee9c8e3..49a334846e76 2020-07-08 amaiorano@google.com Enable Kokoro LLVM 10 builds on Windows 2020-07-08 amaiorano@google.com Add llvm-10 configs for Windows 2020-07-08 amaiorano@google.com Copy and modify update.py for LLVM 10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6ff199ab3f09e2ccb0423809cee47a4a61cf055e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287770Reviewed-by:
-
James Cook authored
Clean up a couple items related to the (deleted) mojo pref service. sync_preferences::PrefServiceSyncable doesn't make mojo calls anymore. prefs::PersistentPrefStoreClient doesn't exist. Bug: none Change-Id: I7640290a94aa3c2697c825dc6929b239b9574f19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285920 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#786296}
-
Gavin Williams authored
Any local printer available to be printed to should always be present in CupsPrintersManager. So when requesting a printer status, if the requested printer is not available in CupsPrintersManager, return a Connecting to Device error. Bug: 1059607 Change-Id: I010545a57c896be4111e4e647ecb82bbb6804ae5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287376Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#786295}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9ad6107a3779a4f928cb4673acbabbf468c4f98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287374Reviewed-by:
-
Renato Silva authored
Add a feature flag for the PIN auto submit feature. Also add methods to store the user's PIN length in local state. Bug: 1075995 Change-Id: I2b307acefd5e39dd0deed747a0ef03c20be76899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287709 Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#786293}
-
