- 12 Dec, 2020 19 commits
-
-
Gordon Seto authored
Update nearby_contact_visibility visibility explanation strings. Screenshots: https://screenshot.googleplex.com/7Htyi2qu6qqvtkp.png https://screenshot.googleplex.com/BgxPKkMQ4tFywjt.png https://screenshot.googleplex.com/7sboMbzfBXK5Wc3.png Fixed: 1157633 Change-Id: I9ed1a85f24b35823d3e7487d2923bc4801f2ab5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586770 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#836335}
-
edchin authored
This test not only fails on simulator. It also fails on: https://ci.chromium.org/ui/p/chrome/builders/ci/ios-beta-device/2066/overview https://ci.chromium.org/ui/p/chrome/builders/ci/ios14-beta-device/710/overview TBR=eugenebut@chromium.org Bug: 1147654 Change-Id: I8a7c0927d00b33a62cb3806e13d502f1484bede7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587651Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836334}
-
Ali Juma authored
Now that there's no longer a WKBasedNavigationManagerImpl, this CL merges WKBasedNavigationManagerTests into NavigationManagerTests. Bug: 738020 Change-Id: I0ca38967d64ef8ebade2d808413b478b04c1bf56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581461Reviewed-by:
-
Victor Costan authored
https://crrev.com/c/2059752 introduced a dependency on //services/network/public/mojom/cross_origin_embedder_policy.mojom in //components/services/storage/public/mojom/service_worker_database.mojom This means the Storage Service's mojo interface now depends on the Network Service. This CL makes the dependency explicit. Bug: 994911 Change-Id: I1b9806d8f50183c3f551f071f01ed9a60625d591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587653 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#836332}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/84a26597..da7e8b6d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifd7f7dfdb165ff673cd3f7552d3e2085571cfec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587490Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836331}
-
Alex Moshchuk authored
This reverts commit 3da5569e. Reason for revert: Suspected to be causing widespread failures in PPAPI/Pepper tests on Win and Linux dbg bots: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/87226 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/93584 Sample failure output: [ RUN ] OutOfProcessPPAPITest.Instance_ExecuteScript [18698:18698:1211/141847.386588:INFO:content_main_runner_impl.cc(1027)] Chrome is running in full browser mode. DevTools listening on ws://127.0.0.1:37739/devtools/browser/565ba965-de40-4715-8905-11c22e1cfcca [18698:18811:1211/141848.175888:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18811:1211/141848.265958:WARNING:render_message_filter.cc(137)] Could not find tid [18698:18698:1211/141848.839793:INFO:CONSOLE(1)] "Uncaught Error: plugin exception", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.844552:INFO:CONSOLE(1)] "Uncaught TypeError: document.doesntExist is not a function", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (1) [18698:18698:1211/141848.855716:INFO:CONSOLE(176)] "ExecuteScript finished in 0.073 seconds.", source: file:///b/s/w/ir/ppapi/tests/test_case.html?testcase=Instance_ExecuteScript (176) Received signal 11 <unknown> 000000000000 #0 0x7f89c0dca89f base::debug::CollectStackTrace() #1 0x7f89c0b5409a base::debug::StackTrace::StackTrace() #2 0x7f89c0b54055 base::debug::StackTrace::StackTrace() #3 0x7f89c0dca36b base::debug::(anonymous namespace)::StackDumpSignalHandler() #4 0x7f8993ea2390 (/lib/x86_64-linux-gnu/libpthread-2.23.so+0x1138f) #5 0x7f89b142c419 std::__Cr::default_delete<>::operator()() #6 0x7f89b142c3ea std::__Cr::unique_ptr<>::reset() #7 0x7f89b142c379 std::__Cr::unique_ptr<>::~unique_ptr() #8 0x7f89b142c16d mojo::internal::AssociatedInterfacePtrState<>::~AssociatedInterfacePtrState() #9 0x7f89b142cb95 mojo::AssociatedRemote<>::~AssociatedRemote() #10 0x7f89b142afab content::PepperPluginInstance::~PepperPluginInstance() #11 0x7f89b2587d8e content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #12 0x7f89b2587e69 content::PepperPluginInstanceImpl::~PepperPluginInstanceImpl() #13 0x7f89b25350f8 base::RefCounted<>::DeleteInternal<>() #14 0x7f89b25350c5 base::DefaultRefCountedTraits<>::Destruct() #15 0x7f89b25350a3 base::RefCounted<>::Release() #16 0x7f89b2535069 scoped_refptr<>::Release() #17 0x7f89b253020a scoped_refptr<>::~scoped_refptr() #18 0x7f89b25ce3f3 scoped_refptr<>::reset() #19 0x7f89b25cd8dd _ZN13scoped_refptrIN7content24PepperPluginInstanceImplEEaSEDn #20 0x7f89b25cbe83 content::PepperWebPluginImpl::Destroy() #21 0x7f89a7414e41 blink::WebPluginContainerImpl::Dispose() #22 0x7f89a593f32d blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::PerformDeferredPluginDispose() #23 0x7f89a4f5d292 blink::HTMLFrameOwnerElement::PluginDisposeSuspendScope::~PluginDisposeSuspendScope() #24 0x7f89a4f58862 blink::ContainerNode::RemoveChild() #25 0x7f89a5111cbb blink::Node::removeChild() #26 0x7f89a70daabe blink::(anonymous namespace)::RemoveChildOperationCallback() #27 0x7f899e0c0780 v8::internal::FunctionCallbackArguments::Call() #28 0x7f899e0bedcd v8::internal::(anonymous namespace)::HandleApiCallHelper<>() #29 0x7f899e0bcfe5 v8::internal::Builtin_Impl_HandleApiCall() #30 0x7f899e0bcaa9 v8::internal::Builtin_HandleApiCall() #31 0x7f899dae513f Builtins_CEntry_Return1_DontSaveFPRegs_ArgvOnStack_BuiltinExit r8: 00000f84ee181f88 r9: 0000000000000000 r10: 0000000000000259 r11: 00007f8996194690 r12: 00007f89a70da600 r13: 0000132400000000 r14: 00007ffc8c8eef10 r15: 00007ffc8c8eef10 di: 00007f89b3e98918 si: 00007f89b3e98918 bp: 00007ffc8c8ee710 bx: 00007f89c0f52440 dx: 00000f84ee181f90 ax: 00007f89b2587db0 cx: 0000000000000000 sp: 00007ffc8c8ee6f0 ip: 00007f89b142c419 efl: 0000000000010206 cgf: 002b000000000033 erf: 0000000000000000 trp: 000000000000000d msk: 0000000000000000 cr2: 0000000000000000 [end of stack trace] Calling _exit(1). Core file will not be generated. ../../content/public/test/no_renderer_crashes_assertion.cc:101: Failure Failed Unexpected termination of a renderer process; status: 1, exit_code: 256 Stack trace: #0 0x55ec1877d394 content::NoRendererCrashesAssertion::Observe() #1 0x7f3d4cf1ead6 content::NotificationServiceImpl::Notify() #2 0x7f3d4d3a3986 content::RenderProcessHostImpl::ProcessDied() #3 0x7f3d4d3a46be content::RenderProcessHostImpl::OnChannelError() #4 0x7f3d60fa392d IPC::ChannelProxy::Context::OnDispatchError() #5 0x7f3d60fa987f base::internal::FunctorTraits<>::Invoke<>() #6 0x7f3d60fa97c1 base::internal::InvokeHelper<>::MakeItSo<>() #7 0x7f3d60fa9742 _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvvEJ13scoped_refptrIS5_EEEEFvvEE7RunImplIS7_NSt4__Cr5tupleIJS9_EEEJLm0EEEEvOT_OT0_NSE_16integer_sequenceImJXspT1_EEEE #8 0x7f3d60fa96ec base::internal::Invoker<>::RunOnce() #9 0x7f3d5ca3c0d1 _ZNO4base12OnceCallbackIFvvEE3RunEv #10 0x7f3d5cc03df2 base::TaskAnnotator::RunTask() #11 0x7f3d5cc49eba base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #12 0x7f3d5cc49685 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #13 0x7f3d5cc4a119 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #14 0x7f3d5caf69f1 base::MessagePumpGlib::HandleDispatch() #15 0x7f3d5caf7141 base::(anonymous namespace)::WorkSourceDispatch() #16 0x7f3d2f683197 g_main_context_dispatch #17 0x7f3d2f6833f0 (/lib/x86_64-linux-gnu/libglib-2.0.so.0.4800.2+0x4a3ef) #18 0x7f3d2f68349c g_main_context_iteration #19 0x7f3d5caf6b00 base::MessagePumpGlib::Run() #20 0x7f3d5cc4a740 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #21 0x7f3d5cb95d75 base::RunLoop::Run() #22 0x55ec187b836a content::RunThisRunLoop() #23 0x55ec187b831f content::RunMessageLoop() #24 0x55ec18760320 content::JavascriptTestObserver::Run() #25 0x55ec16a8b567 content::PPAPITestBase::RunTestURL() #26 0x55ec16a8b48e content::PPAPITestBase::RunTest() #27 0x55ec16a84f2a content::(anonymous namespace)::OutOfProcessPPAPITest_Instance_ExecuteScript_Test::RunTestOnMainThread() #28 0x55ec18719264 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #29 0x55ec1871cf2a base::internal::FunctorTraits<>::Invoke<>() #30 0x55ec1871cea1 base::internal::InvokeHelper<>::MakeItSo<>() #31 0x55ec1871ce37 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEvOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #32 0x55ec1871cddc base::internal::Invoker<>::RunOnce() #33 0x55ec157bbac1 _ZNO4base12OnceCallbackIFvvEE3RunEv #34 0x55ec18a331cc content::ShellBrowserMainParts::PreMainMessageLoopRun() #35 0x7f3d4c5f5282 content::BrowserMainLoop::PreMainMessageLoopRun() #36 0x7f3d4c5ff18a base::internal::FunctorTraits<>::Invoke<>() #37 0x7f3d4c5ff0a1 base::internal::InvokeHelper<>::MakeItSo<>() #38 0x7f3d4c5ff027 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserMainLoopEFivEJNS0_17UnretainedWrapperIS4_EEEEEFivEE7RunImplIS6_NSt4__Cr5tupleIJS8_EEEJLm0EEEEiOT_OT0_NSD_16integer_sequenceImJXspT1_EEEE #39 0x7f3d4c5fefcc base::internal::Invoker<>::RunOnce() #40 0x7f3d4c9d5b31 _ZNO4base12OnceCallbackIFivEE3RunEv #41 0x7f3d4d812b16 content::StartupTaskRunner::RunAllTasksNow() #42 0x7f3d4c5f3b8a content::BrowserMainLoop::CreateStartupTasks() #43 0x7f3d4c602df0 content::BrowserMainRunnerImpl::Initialize() #44 0x7f3d4c5f0d64 content::BrowserMain() #45 0x7f3d4e7bcbc6 content::RunBrowserProcessMain() #46 0x7f3d4e7be1e9 content::ContentMainRunnerImpl::RunBrowser() #47 0x7f3d4e7bdad7 content::ContentMainRunnerImpl::Run() #48 0x7f3d4e7bae05 content::RunContentProcess() #49 0x7f3d4e7bb79d content::ContentMain() #50 0x55ec18718d5a content::BrowserTestBase::SetUp() #51 0x55ec1865a9ac content::ContentBrowserTest::SetUp() #52 0x55ec16a8ba95 content::OutOfProcessPPAPITest::SetUp() #53 0x55ec17363a6b testing::internal::HandleSehExceptionsInMethodIfSupported<>() #54 0x55ec173547f7 testing::internal::HandleExceptionsInMethodIfSupported<>() Note the ~AssociatedRemote from ~PepperPluginInstanceImpl, which I think was introduced in this CL. This also seems to be the only plugin-related change in the blamelist (https://chromium.googlesource.com/chromium/src/+log/6828ef78f2200e4bac3280186c7520ab65b2d7f8%5E..21468f4304510a432e3376d9d72ec67962f39723?pretty=fuller&n=) Original change's description: > Add mojo interfaces for pepper plugins. > > This adds some base plumbing for pepper plugin instance handling. The > pepper renderer code allocates and manages the PepperPluginInstanceImpl, > this creates the correct encapsulation moving code out of RenderFrameImpl. > > On the browser side a PepperPluginInstance is created to handle the > messages and relay them to the WebContentsImpl which use to handle > the processing of Pepper messages. > > BUG=1157519 > > Change-Id: I24941bb7eecef56a90bbf961e6396101c8d3c785 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585627 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836239} TBR=dcheng@chromium.org,bbudge@chromium.org,dtapuska@chromium.org,arthursonzogni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iddd93694ebe0611abef6c74b57667554b51e26fc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587769Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#836330}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d9318acc24b0..8326b26a790f 2020-12-11 syoussefi@chromium.org Fix link validation with ambiguous instanceless interface blocks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: Iff599dccf2401f0a39ec5cca175207a873fac061 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587392Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836329}
-
George Burgess IV authored
This target comprises 1.95% of our total Chrome samples, but isn't optimized for speed except on ARM. It may be worthwhile to optimize it in this way. This includes a miscellaneous `git cl format`. Bug: 1143481 Change-Id: Ifa6a25a4f1954289a5f54fc3785e2e83de431c4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507572Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Felicia Lim <flim@chromium.org> Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#836328}
-
Domenic Denicola authored
This reverts commit 7e5912e8. Reason for revert: we're planning to launch this to M88+ using Finch instead. See https://docs.google.com/document/d/1bXwJwJAGP-2msI9IU6kbrZH9zBvQkTVNpjiKIxKZFhg/edit?ts=5fd309ef# for more details. Original change's description: > Reland "Origin isolation: enable by default" > > This reverts commit 0ea7d517. > > Reason for revert: A fix for the problem that lead to this revert has been landed in r831153 and we need to re-enable this change to test it. > > Original change's description: > > Revert "Origin isolation: enable by default" > > > > This reverts commit 824b062d. > > > > Reason for revert: Causing crashes with hosted apps in https://crbug.com/1141721. > > > > Original change's description: > > > Origin isolation: enable by default > > > > > > Intent to Ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/WW4fGjvroWI > > > > > > Further work on removing origin trial code and the flags is tracked in > > > https://crbug.com/1148056 and https://crbug.com/1148057. > > > > > > Bug: 1042415 > > > Change-Id: Icbeecd0b592c76d36e2111b8e4d8fe30dbb63343 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533145 > > > Commit-Queue: Domenic Denicola <domenic@chromium.org> > > > Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> > > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#826910} > > > > TBR=creis@chromium.org,alexmos@chromium.org,jochen@chromium.org,domenic@chromium.org,yoavweiss@chromium.org > > > > # Not skipping CQ checks because original CL landed > 1 day ago. > > > > Bug: 1042415, 1141721 > > Change-Id: I428b190fc4c6bdf39de5ffb43226ba91851e7544 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553209 > > Reviewed-by: Domenic Denicola <domenic@chromium.org> > > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > > Reviewed-by: Charlie Reis <creis@chromium.org> > > Commit-Queue: Charlie Reis <creis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#829937} > > TBR=creis@chromium.org,alexmos@chromium.org,domenic@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1042415 > Bug: 1141721 > Change-Id: I6cf3211dc675bd2351c8dc6831e8d3e2495d8c2e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560907 > Reviewed-by: James MacLean <wjmaclean@chromium.org> > Commit-Queue: James MacLean <wjmaclean@chromium.org> > Cr-Commit-Position: refs/heads/master@{#831175} TBR=creis@chromium.org,alexmos@chromium.org,domenic@chromium.org,wjmaclean@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042415 Bug: 1141721 Change-Id: I14fc536d9389f6706b15f241182e4a65b09f1a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587453Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/31cc1f148e42..4f90750776f8 2020-12-11 capn@google.com Implement VK_EXT_scalar_block_layout support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I67a47f0ad8b1dd308b85a77db0539797b6250d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587221Reviewed-by:
-
Roee Kasher authored
Fixing a bug where dragging text from one input element to another, and then trying to undo this change, makes first input element's value inaccessible. In order to fix this, the root editable element associated with a `SelectionForUndoStep` is calculated at construction time. It is important to do so at construction time as the base position of the selection might be disconnected from the document, thus we might not be able to compute the root editable element. Bug: 864941 Test: Drag text from one input element to another, and then undo this change. After undoing, try to use the first input element's `value` property, and verify it has the correct value. Change-Id: Ie0016f7459bad462e67e508b64e2686c39a66fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574954 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#836325}
-
Gavin Mak authored
Generate DIR_METADATA files and remove metadata from OWNERS files for directories under //ui. Bug: 1113033 Change-Id: Id5922f2b2a0a870048107d653cb78c2f05e942d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2583126Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Gavin Mak <gavinmak@google.com> Cr-Commit-Position: refs/heads/master@{#836324}
-
Chan Li authored
Bug: 1139149 Change-Id: I5c30134bd5467fa9e68d65605b23f72edc7cece2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587570Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Chan Li <chanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#836323}
-
Dale Curtis authored
Per discussion on https://crrev.com/c/2527025 no decoder used by Chrome requires this. Also, our current checks are incorrect while our test data uses non-compliant streams... so just remove! https://chromium-review.googlesource.com/c/chromium/src/+/2527025 R=wolenetz Change-Id: Ie10199182f4dcae18ea221a14623040517605173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587688 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#836322}
-
Yi Gu authored
We plan to ship the new CodeBrowser backend of WebOTP via Finch. This patch adds necessary code on the client side. Bug: 1153880 Change-Id: I550ff16d34ec638a0275007b2e1481dec8295115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580539 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#836321}
-
Ben Pastene authored
crrev.com/i/3462032 allocated 100 machines for this pool: http://shortn/_z6nSkdF9st That should be about enough according to http://shortn/_PPwEhxY2rU, especially since cache hit-ratios should be much better now after this. Bug: 1140727 Change-Id: Ic48d4f7fccde6aca434ffb1d7e1fc0f3381d757c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587558Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
-
dpapad authored
Bug: 844820,525224 Change-Id: I6f2f40c2dd7e03a570eba8e08654eb38c9897776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586100 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#836319}
-
Yi Gu authored
[CodeHealth] Convert chrome/browser/ui/views/frame from base::Bind and base::Callback to Once/Repeating Bug: 1152282 Change-Id: I77fce1eabfc0652828547d9b59c2517e74fc629f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585815Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#836318}
-
Guillaume Jenkins authored
Adds the remaining strings needed to finish the BrowserSignin policy implementation on iOS. Bug: 1155745 Change-Id: I530b4e23af0340d2851f0adb8b0f865d14bcd0e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586325 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#836317}
-
- 11 Dec, 2020 21 commits
-
-
Will Harris authored
Also, change a loop to range-based. Bug: 842296 Change-Id: I5bf10c0b3997e3ab7899217b68e9c06d265d3e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586848 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Ben Greenstein <bengr@chromium.org> Cr-Commit-Position: refs/heads/master@{#836316}
-
Alex Moshchuk authored
This test is failing on Mac and Win bots with an image diff, following the import at https://chromium-review.googlesource.com/c/chromium/src/+/2584498. Sample: https://ci.chromium.org/p/chromium/builders/ci/Mac10.14%20Tests/11475 Looks like the failure is due to "/opt" vs the expected "/b" in paths that appear in the error image. Bug: 626703 Change-Id: I4fe0f1a309bd397c9a1509e1d01010aec9512f3b Notry: true Tbr: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587654Reviewed-by:
-
John Lee authored
The previous failure of this test was caused by a tab that was not the pinned tab being tested changing its tracked status. The only way a tab element changes tracked status is because it intersects with the threshold in the IntersectionObserver, changes pinned state, or is added or removed from the DOM. This CL removes all tabs besides the tab being tested so to hopefully make the test more reliable. Fixed: 1156948 Change-Id: I36aae0861a8c4fb5f5520c229ee586c66c5727e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586092Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#836314}
-
Scott Lee authored
ResultDB for junit_tests was enabled on chromium.android at 30%, and 100% of the builds succeeded with resultdb. https://screenshot.googleplex.com/BvHH2VDXm7hGvCh There are only 3 builder groups with junit_tests in chromium. - chromium.fyi - chromium.android - chromium.clang If all builds on android and clang succeed after this CL, the next CL will enable ResultDB for junit tests on all builders at 100% rate. (Dec 14) R=gbeaty@chromium.org,chanli@chromium.org Bug: 1084332 Change-Id: Ie8aa34868b58a64e0f88e2099cb6ceef01256af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587495Reviewed-by:
Chan Li <chanli@chromium.org> Commit-Queue: Scott Lee <ddoman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836313}
-
Brian Sheedy authored
Adds support to mb.py for cases where an args.gn file uses import(...) to reference GN args in a .gni file, such as how board-specific CrOS args are specified. Change-Id: If11ad05cbc9605e89cc743e72f9178de016bdde1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587552 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#836312}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I71515dc3a742b119269953bd3faf696d5ce79212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587222Reviewed-by:
-
Kyle Horimoto authored
Records a metric upon connection via Bluetooth, then another metric upon bandwidth upgrade to WebRTC. Will be used to verify the success rate of WebRTC upgrades for the feature. Bug: 1150634, 1106937 Change-Id: I8a7e8b1ee26aa47fd681e089ab0bf13450754f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586374 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#836310}
-
Dale Curtis authored
This adds a SurfaceLayerForMediaStreams feature that is enabled by default. The expectation is that the Meet team will use this to evaluate the CPU usage and other performance characteristics. To disable surface layer for media streams you should launch Chrome with --disable-features=SurfaceLayerForMediaStreams R=liberato Bug: 1157671 Test: http://apprtc.appspot.com/ Change-Id: I89cca10f8a81939d4a742be4352dcd2075edc6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586513 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#836309}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/40dbba6dda38..0bf3f26cf343 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alexmos@google.com,eirage@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: alexmos@google.com,eirage@google.com Change-Id: I4c77bcc6813db587e897fdf402db5e213e264519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586965Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#836308}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7542517e29ce..0991ca17bab3 2020-12-11 ericlaw@microsoft.com [NetLog Viewer] Enable import of .ZIP files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1057782 Tbr: wenbinzhang@google.com Change-Id: I3eb60c8ef9b33f230c855b0685d2e6232aa8e3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587220Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74ccf7b62fc6..778b2c216924 2020-12-11 fmayer@google.com Merge "Default symbolizer to nullptr." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: If8d244c11b4d38feec1c760a3ca98a204184db19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587391Reviewed-by:
-
Andre Le authored
PhoneHub will only be available for primary user of the device. Bug: 1106937 Change-Id: Ic903a0f9d97bcd0a65afab8f5fd8a3ae8ed18d73 Fixed: 1155361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581691 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#836305}
-
David Dorwin authored
The tests fail in component builds because of the way the Safe Search code is built. Disable the tests in component builds until this can be resolved. Bug: 1147231, 1157909 Change-Id: Idac5bb566377d387bd0332d8d32e00bff8c742ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587492Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Commit-Queue: Sharon Yang <yangsharon@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#836304}
-
Gyuyoung Kim authored
This CL migrates AwViewHostMsg_UpdateHitTestData IPC message to LocalMainFrameHost interface because the IPC message has been used by 2 functions. So, this CL adds the message to LocalMainFrameHost interface instead of handling it as a reply callback. To support the parameter, this CL moves AwHitTestData struct and HitTestDataType enum to Mojo. - AwHitTestData -> android_webview::mojom::HitTestData - Type -> android_webview::mojom::HitTestDataType Then, all uses of the native struct and enum are replaced by the Mojo struct and type. Bug: 1146495 Change-Id: I906e00f1f5f3e18556613b39eedb90bf845b164c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574560Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#836303}
-
Guillaume Jenkins authored
When browser sign-in is disabled by policy, replaces the sign-in promo in the "Other devices" section of the Recent Tabs views with a message indicating that the feature has been disabled by the managing organization / administrator. Bug: 1155745 Change-Id: I496e7f7ec53d721748e8a49c9a01228aa9b43548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575260 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#836302}
-
David Black authored
Finishes the holding space view hierarchy refactor by renaming: - HoldingSpaceItemViewsContainer --> HoldingSpaceItemViewsSection - PinnedFilesContainer --> PinnedFilesBubble - RecentFilesContainer --> RecentFilesBubble Bug: 1154998 Change-Id: I621a8c76daf142ced35503fe78801dbfd09d4570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587611 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#836301}
-
Anqing Zhao authored
KioskAppExternalLoader is used to load apps and extensions for a Chrome App Kiosk session. It registers a callback and wait until app info is updated. This class should be only used in Chrome App Kiosk, but not in other two Kiosk types. But according to the current implementation, the loader is enabled unexpectedly and blocks the uninstallation of force-installed extensions when they are removed by admins. Therefore, the check logic should be limited to a proper scope. Bug: 1153440 Change-Id: I8bf79fa553dfbea5e271b7f06fc6ff0dffb33495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575118Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Commit-Queue: Anqing Zhao <anqing@chromium.org> Cr-Commit-Position: refs/heads/master@{#836300}
-
Christian Biesinger authored
R=ikilpatrick@chromium.org, mstensho@chromium.org Bug: 1152698 Change-Id: I55879a551671b5b9a87ad83c59cc10a055b4cf5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585814 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#836299}
-
Etienne Pierre-doray authored
Sampling profiler uses TimeTicks::Now in signal handler to get a timestamp associated with the sample. When called from signal handler, TimeTicks::Now occasionally crashes the following check: CHECK(clock_gettime(clk_id, &ts) == 0) In order to get good time precision in profiler, we'd like to get a timestamp while the sampled thread is paused. Since failures are rare, a solution is to allow clock_gettime to fail, and fallback to getting an 'async' timestamp after resume. To reuse some of the ConvertTimespecToMicros boilerplate common with TimeTicks::Now, this CL exposes subtle::MaybeTimeTicksNowIgnoringOverride() on posix, used in stack_coper_signal. Bug: 1155269 Change-Id: I4d8f5a3e050f5285b87297f13dfd29e888e40257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584603 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#836298}
-
Evan Stade authored
Bug: 1152276 Change-Id: I44471424b6f6a106a029a87b54b30eca1e17229c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2582818 Commit-Queue: David Trainor <dtrainor@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#836297}
-
Martin Barbella authored
Change-Id: If076a5431ed62f498f3098a29d65f5d616acd892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587357Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#836296}
-
