- 12 Jul, 2014 40 commits
-
-
chun.gao@intel.com authored
This is the first patch to move TTS implementation from browser layer to content. To move TTS to conent, the direct dependence of browser compoent should be eliminated from TTS classes first. BUG=347045 R=tommi@chromium.org, dmazzoni@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/374243004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282813 0039d316-1c4b-4281-b951-d872f2087c98
-
shadi@google.com authored
It broke browser tests. Probably need to update isolate files to fix it... > Have media content and chrome browser tests load data from media/test/data > > With media files copied over to media/test/data, this CL makes media related content browser tests and chrome browser tests load test data from one location. > > The location is common with media unit tests data forder; managed in one place in media/base/test_data_util.h > > BUG=379314 > > Review URL: https://codereview.chromium.org/357413002 TBR=shadi@chromium.org Review URL: https://codereview.chromium.org/383063009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282812 0039d316-1c4b-4281-b951-d872f2087c98
-
wfh@chromium.org authored
BUG=None TEST=Go to chrome://tracing, select only 'ETW Event Trace' catagory and start a new tab. Stop tracing, and check that StartProcessWithAccess does not say "Did Not Finish". Review URL: https://codereview.chromium.org/388513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282811 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
BUG= Review URL: https://codereview.chromium.org/388573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282810 0039d316-1c4b-4281-b951-d872f2087c98
-
qinmin@chromium.org authored
This call is no longer called by FullscreenController, blink change https://codereview.chromium.org/385943005/ Review URL: https://codereview.chromium.org/382423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282809 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
by many files outside src/net. R=eroman@chromium.org,mef@chromium.org BUG=393387 Review URL: https://codereview.chromium.org/385943004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282808 0039d316-1c4b-4281-b951-d872f2087c98
-
chrishenry@google.com authored
Cleanup while reading code: Move GetJavaScriptMarker to be a free function instead of static function. Rename logical_name -> label (matching ActionRunner API). Improve documentation. BUG= Review URL: https://codereview.chromium.org/386023004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282807 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=349436 Review URL: https://codereview.chromium.org/383903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282806 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
Synthesizing a mouse-move event during a drag can cause an inconsistent sequence of events to be dispatched (e.g. pressed, dragged, dragged, moved, dragged ... released). So do not synthesize mouse-move events when a drag is in progress. The alternate is to synthesize mouse-dragged event instead of a mouse-move event, but in multi-display/multi-host setting, the wrong dispatcher may end up synthesizing the event. So avoid doing that. BUG=389424, 369247, 366096 R=oshima@chromium.org Review URL: https://codereview.chromium.org/387863003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282805 0039d316-1c4b-4281-b951-d872f2087c98
-
cjhopman@chromium.org authored
TBR=darin@chromium.org Review URL: https://codereview.chromium.org/371903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282804 0039d316-1c4b-4281-b951-d872f2087c98
-
alexst@chromium.org authored
This creates an atomic plane to be updated during page flip. BUG=none Review URL: https://codereview.chromium.org/383193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282803 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282802 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
BUG=385289 TEST=none TBR=darin Review URL: https://codereview.chromium.org/383213006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282801 0039d316-1c4b-4281-b951-d872f2087c98
-
alekseys@chromium.org authored
- do not show user sign in promo - do not show cloud print dialog link - do not send COOKIES-based cloud printer search requests - do not add Save as PDF printer Related changes: - fix UI issues when no printer is selected - fix destination list sizing when one of the sections is empty BUG=370096 Review URL: https://codereview.chromium.org/387073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282800 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
None of the implementations if WindowTreeHosts do anything when the device-scale factor changes. So remove it. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/389663003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282799 0039d316-1c4b-4281-b951-d872f2087c98
-
xhwang@chromium.org authored
Do not call Pipeline::On{Audio|Video}RendererEnded() because it's pipeline's implementation detail and will go away. Instead, let the mock renderers call the ended_cb. Also rename several helper functions to reflect what they really do. BUG=392259 TEST=All current tests pass. Review URL: https://codereview.chromium.org/388763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282798 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Video renderers don't need the information as they are already making audio/video synchronization decisions based on a media timeline that already incorporates the current playback rate via the time callback. In particular, VideoRendererImpl only used playback rate to estimate a better duration to sleep until the current frame was ready ... except that in most cases we'd sleep for kIdleTimeDelta and wait until the media timeline had progressed past the current frame's timestamp. In other words, there's absolutely no reason to even try to estimate the sleep duration based on the playback rate. BUG=370634 Review URL: https://codereview.chromium.org/384943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282797 0039d316-1c4b-4281-b951-d872f2087c98
-
dmazzoni@chromium.org authored
Calling it with render_frame_host is wrong because that object might have been deleted above. Only dest_render_frame_host is valid at this point. BUG=393032 TBR=nasko Review URL: https://codereview.chromium.org/380413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282796 0039d316-1c4b-4281-b951-d872f2087c98
-
shadi@chromium.org authored
With media files copied over to media/test/data, this CL makes media related content browser tests and chrome browser tests load test data from one location. The location is common with media unit tests data forder; managed in one place in media/base/test_data_util.h BUG=379314 Review URL: https://codereview.chromium.org/357413002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282795 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
If an event is redirected to a different WindowTreeHost because the target window belongs to that, then make sure the event is in the WindowTreeHost's root-window's coordinate space. This is necessary to make sure that the target (and the pre/post-target handlers) see the event in the correct location. BUG=385770 R=sky@chromium.org Review URL: https://codereview.chromium.org/380343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282794 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282793 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
> Enable media in default GN build. > > Roll ffmpeg to pick up build fix. f620cda6 -> 04bb33e9 > > All hail GN. oRZ > > BUG=none > TBR=brettw > > Review URL: https://codereview.chromium.org/381903003 TBR=dalecurtis@chromium.org Review URL: https://codereview.chromium.org/387103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282792 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282786 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/386893004/tonyg@chromium.org authored
Reason for revert: Breaks speedometer. Should be a ListOfScalarValues. Traceback (most recent call last): _RunPage at tools/telemetry/telemetry/page/page_runner.py:534 test.RunPage(page, page_state.tab, results) RunPage at tools/telemetry/telemetry/page/page_test.py:247 self.ValidatePage(page, tab, results) ValidatePage at tools/telemetry/telemetry/page/page_measurement.py:62 self.MeasurePage(page, tab, results) MeasurePage at tools/perf/benchmarks/speedometer.py:36 tab.EvaluateJavaScript('benchmarkClient._timeValues'))) __init__ at tools/telemetry/telemetry/value/scalar.py:19 assert isinstance(value, numbers.Number) AssertionError Locals: important : True name : 'Total' page : <telemetry.page.page.Page object at 0x1d6e590> units : 'ms' value : [13237.9869999991, 13351.2720000012, 14052.7640000023, 14136.3950000013, 13685.9580000001, 14048.2879999999, 14010.3279999989, 13941.6210000018, 14087.0519999998, 13388.6279999983] Original issue's description: > Update speedometer to use results.AddValue > > BUG=391943 > TBR=nduca@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282750 TBR=nduca@chromium.org,nednguyen@google.com NOTREECHECKS=true NOTRY=true BUG=391943 Review URL: https://codereview.chromium.org/387953006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282784 0039d316-1c4b-4281-b951-d872f2087c98
-
gunsch@chromium.org authored
This allows using the VIDEO_HOLE outside of Android. R=xhwang,damienv1 BUG=392993 Review URL: https://codereview.chromium.org/375713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282783 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
The callback was not used Review URL: https://codereview.chromium.org/387123003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282782 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282781 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
Roll ffmpeg to pick up build fix. f620cda6 -> 04bb33e9 All hail GN. oRZ BUG=none TBR=brettw Review URL: https://codereview.chromium.org/381903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282780 0039d316-1c4b-4281-b951-d872f2087c98
-
tdanderson@chromium.org authored
The definitions of hit test masks and related logic have beed moved into MaskedTargeterDelegate, so remove HasHitTestMask(), GetHitTestMaskDeprecated(), and the HitTestSource enum from views::View. BUG=388838 TEST=ViewTargeterTest.HitTestCallsOnView Review URL: https://codereview.chromium.org/365263004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282779 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
Possible failure on Android ( http://build.chromium.org/p/chromium.linux/buildstatus?builder=Android%20Tests%20%28dbg%29&number=21495 ) > Change PhoneNumber::SetInfo to only apply formatting where there is none > > See discussion on https://codereview.chromium.org/347183005/ > > BUG=none > > Review URL: https://codereview.chromium.org/374053007 TBR=estade@chromium.org Review URL: https://codereview.chromium.org/383123011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282778 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=372212 R=mukai@chromium.org Review URL: https://codereview.chromium.org/372883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282777 0039d316-1c4b-4281-b951-d872f2087c98
-
eakuefner@chromium.org authored
We will be using the AsDict() call to support JSON output of Telemetry results. This CL adds the ability to output the important information associated with a page to the Telemetry Page class. BUG=375541 Review URL: https://codereview.chromium.org/388653002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282776 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
Replicates FFmpeg's behavior for frame allocation. They do not zero the frame on subsequent pool reuse, so I have not done so either. BUG=390941,390944,390945 TEST=new unittest. Review URL: https://codereview.chromium.org/383893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282775 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
R=thakis@chromium.org BUG=none Review URL: https://codereview.chromium.org/383543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282773 0039d316-1c4b-4281-b951-d872f2087c98
-
vabr@chromium.org authored
Currently, every single test case needs to check whether the infobar or tha password bubble is used, and do different checks accordingly. Even worse, auto-saving behaviour is different for those two, so people modifying existing tests are very likely to have false expectations. This CL creates a PromptObserver class by decoupling prompt observing from navigation observation. PromptObserver takes care of the differences between infobar and bubble automatically, and provides a clear API to check for the prompt being shown, and to instruct the prompt to save passwords, respectively. BUG=392144 Review URL: https://codereview.chromium.org/378643006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282772 0039d316-1c4b-4281-b951-d872f2087c98
-
erikchen@chromium.org authored
The new Handoff feature in OSX 10.10 only works with devices that support Bluetooth LE. Record metrics to determine the percentage of Chrome users that this affects. BUG=392166 Review URL: https://codereview.chromium.org/374203004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282771 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
The private key's the hard one, but this is a first step and can be independent of USE_OPENSSL_CERTS. BUG=362035 Review URL: https://codereview.chromium.org/383003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282770 0039d316-1c4b-4281-b951-d872f2087c98
-
lucinka.brozkova@gmail.com authored
This CL turns const by value return values into const by ref. Replacing const value by a const ref when a member variable is safe, because the member variable will live at least as long as the temporary object returned now. It can also be more efficient, because returning a ref can spare copying. BUG=393155 Review URL: https://codereview.chromium.org/382243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282769 0039d316-1c4b-4281-b951-d872f2087c98
-
haitaol@chromium.org authored
BUG=388506 Review URL: https://codereview.chromium.org/386093002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282768 0039d316-1c4b-4281-b951-d872f2087c98
-
rsleevi@chromium.org authored
This is so that callers can code against a TaskRunner interface directly, rather than converting message_loop_proxy() into a TaskRunner. BUG=391045 Review URL: https://codereview.chromium.org/389653005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282767 0039d316-1c4b-4281-b951-d872f2087c98
-