GitLab

DragDropDelegate implementations, such as WebContents, require that the
DragLeave event is fired before DragFinished when the DnD session ends
with no actual data transfer (cancelled), e.g: the drop happens on top
of a widget that does not accept the data being dragged. Otherwise, it
might lead to issues like crbug.com/1109324, where the whole web
contents view becomes unresponsive. This patch fixes it by making sure
OnDragLeave() is called just before OnDragFinished() when the session
ends with a cancellation.

R=tonikitoo@igalia.com

Test: ozone_unittests --gtest_filter='*DragControllerTest.StartAndCancel*'
Bug: 1109324
Change-Id: Idcbdb93ef0187847e2e779f3e4ac568bc594b90d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318511Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Antonio Gomes (GMT-4) <tonikitoo@igalia.com>
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#792471}

The disabled tests cover the effect of a WebContents' visibility on
its auto-reload behavior.

It turns out that visibility of WebContents within content_shell
behaves somewhat unexpectedly -- at least on Mac -- resulting
in the WebContents non-deterministically becoming visible during a
navigation, despite being explicitly hidden by test logic prior to
the navigation.

In order to avoid the resulting flakiness, this rearranges the test
logic so that forced visibility changes are imposed *after*
the relevant navigation rather than before it.

Fixed: 1110259
Change-Id: I38ab9d22a225018a8c5a1762cac15af45bf846e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324163Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#792470}

Bug: 1108637
Change-Id: I763b2fb13d03c85f716cdeeba70a5b16b96623fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318830Reviewed-by: Michael Spang <spang@chromium.org>
Commit-Queue: Rob Schonberger <robsc@chromium.org>
Auto-Submit: Rob Schonberger <robsc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792469}

The test was not added with the fix of bug because there were problems
with Mac and Windows.

R=kainino@chromium.org

Bug: chromium:1104580
Change-Id: Iafca0c9471f37d2897fd2b8fde1aae3c8c1fb38b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320274
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792468}

Also enables qrcode_generator_bubble_unittest for ChromeOS;
it was stuck in a no-{Android,CrOS} block.

Bug: 1110446
Change-Id: Iba92df1293d979a10a66c7e90e1f0eb0651888a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324807Reviewed-by: Kyle Milka <kmilka@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792467}

https://chromium.googlesource.com/angle/angle.git/+log/44bb4d7abee6..07cdf4214314

2020-07-28 tobine@google.com Vulkan: Add new validation skips
2020-07-28 nguyenmh@google.com Remove context id serialization

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC tobine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: tobine@google.com
Change-Id: I50661f1e37c340e48b3684ad1ccde09d6681cbfd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324651Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792466}

PrintParams should be of type base::DictionaryValue

Bug: chromedriver:3481
Change-Id: I4dae87d6e1a88585d592a1be85b757ff01d8d869
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324668
Auto-Submit: Shengfa Lin <shengfa@google.com>
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792465}

Move Point from viewport.js to constants.js and re-use in
open_pdf_params_parser.js and gesture_detector.js.

Bug: None
Change-Id: I743e6653055dc760f3f63472ffa7a4e8f2ee6bda
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322170
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792464}

This code should do nothing if error_html is null. This moves
the check earlier.

BUG=none
TEST=none

Change-Id: I568c5ece3c2e1aca23e91480918ce1a35a07fa55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324654
Commit-Queue: Scott Violet <sky@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792463}

No-Tree-Checks: true
No-Try: true
Ignore-CQ-Freeze: true
Bug: 1109999
Change-Id: I4474c8088d567a85873ccc79f8eb41a25e484447
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325192Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Cr-Commit-Position: refs/heads/master@{#792462}

ARM Mac bots have 'arm64' cpu dimension.
https://chromium-swarm-dev.appspot.com/bot?id=build201-a9

Adding Ignore-CQ-Freeze because this isn't for production.

Ignore-CQ-Freeze: true
Bug: 1103470
Change-Id: I3d3713909994a88224aec6c9eaf48e9d0890d2ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320714
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Cr-Commit-Position: refs/heads/master@{#792461}

Change:
* Move EnableUserInterfaceAfterPaymentRequestUpdateEvent,
shouldShowShippingSection into PaymentUIsManager.

Bug: 1102522

Change-Id: Ie56768af521987c0a181db550720296f02bfe583
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317565
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792460}

Uses automation 'find' function and also only searches
changed subtrees after the initial search. This seems to improve
performance ~4x of the back button and menu, noticeable when
autoscan is on and set to high scanning speeds.

4x improvement measured on a webpage with a lot of nodes using
devtools 'performance' tab:
Before: Just under 4000ms on the back button moveForward call on
en.wikipedia.org/wiki/cat
After: Just under 1000ms on the back button moveForward call on
en.wikipedia.org/wiki/cat.

AX-Relnotes: N/A
Bug: 1108619
Change-Id: I9bd4bb1b92cde455949558c621700a6b900f2579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324118Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792459}

Used to log metrics for NoStatePrefetch.

Bug: 1096088
Change-Id: I64e80dec98141ca46c55a5857b191c03d889685e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317349
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792458}

This CL adds information about CPU resource usage for non-ad content
in a page.  Previously we had total page usage along with aggregate ad
usage, but this was not sufficient to show us non-ad usage during
experiments that were taking the average of averages.  In addition, the
CL cleans up the helper functions for checking TotalUsage histograms,
which were overcomplicated due to histograms being removed previously
while the functions themselves stayed the same.

Note: A follow-up CL will also add these metrics for network usage
as required, or relocate them to this location if they exist elsewhere.

Change-Id: I225bbb0e4c663d0e011f40ea01c3bca3734c9183
Bug: 1109754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292802Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: John Delaney <johnidel@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792457}

Move timestamp calculation out of the loop by checking for empty
list first, then calculating the timestamp and changing the
loop to a do-while loop.

Change-Id: I4a07abe7b749c85854e75ffdf1d993b602344aae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323371Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Rob Buis <rbuis@igalia.com>
Cr-Commit-Position: refs/heads/master@{#792456}

(And to measure the entropy if so).

Bug: 1103288
Change-Id: Ied3f92e9948499b9ed5e36aa7bec05b19aefc9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209995
Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Sean Topping <seantopping@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792455}

Add a variant of CallPDFiumWideStringBufferApi() that distinguishes
between API call failure and empty string return values.

Change-Id: I4ec2c1ed16f9109854493f184acd597c8b622196
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322167Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792454}

Before we turn on TBMv3 metrics on all bots, we'd like to run it
on the FYI bots to make sure it's stable.

Ignore-CQ-Freeze: This CL doesn't impact CQ.
Bug: 1012687
Change-Id: Idf5f46f49d7719dc60f3e0b87022b864ab25dfbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317832
Commit-Queue: Deep Roy <dproy@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792453}

If a hang is detected in a thread critical to user responsiveness like
browser UI or IO thread then blocking execution in ~HangWatchScope() on
all threads makes sense because the program was already unresponsive.

It's desirable to keep the blocking to a minimum on the browser UI/IO
threads if they are not the hung thread. This CL achieves that
by only enforcing blocking in HangWatchScopes that were hung at the
moment of hang detection.

Bug: 1034046
Change-Id: I05aace41e272f1daef490be55902225363536396
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209330
Commit-Queue: Oliver Li <olivierli@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792452}

This was the result of a discussion with ellyjones@ regarding the best
way to handle features that could only easily be implemented in Views
that we needed for user education.

The decision was made that context menus in Top Chrome could be moved to
Views, but not for web contents and context menus on text fields, which
would remain in Cocoa to provide visual distinction and to provide
access to e.g. the system emoji chooser.

This CL adds a mechanism by which Top Chrome code can force a context
menu that would otherwise be rendered natively to use Views code
instead, and applies it to tabstrip context menus.

Bug: 1109256
Change-Id: Ib3c3970f56df0714687aaf87a1267d7ae8e2c17b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317809
Commit-Queue: Dana Fried <dfried@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792451}

Set project to "chromium" so it doesn't need to be specified for all
directories.

Bug: 1102997
Change-Id: I487ed21929db86c09d7b385343bee7a7243dd9b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320890Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792450}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I2b1b9408c47caa73b8792e2fd9a371f1157c7570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324117Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#792449}

This CL cranks up the HDR level multiplier from 3x to 4x so that the
bright areas of the videos are not overexposed, and maintain local
contrast. Tested on kohaku and my LG 4K HDR monitor.

Bug: 958166
Change-Id: I88d7661340c43c98f5bad43bce30e9f58142cd92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324949
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Auto-Submit: Miguel Casas <mcasas@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792448}

code_cache_host_mojolpm_fuzzer was missing the dependency on the ICU
data files, and the initialisation call for i18n.

Bug: 1105950
Change-Id: Ibfd6e1579c9bdc75764979db5c24feff3fd95ba7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324421Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Mark Brand <markbrand@google.com>
Cr-Commit-Position: refs/heads/master@{#792447}

The class had methods like GetDefaultWindowBoundsChromeOS() wrapped in
ifdef checks, with implementations in a different file.

Introduce a real subclass WindowSizerChromeOS. Move helper functions
there.

Bug: 846736, 1109050
Test: existing unit_tests
Change-Id: Ibf38eafe7955d086edcec653db4d2d17d5cfbc5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321946
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792446}

Updates the expires_after attribute for 25 histograms that have
been used to generate alerts in the past 90 days and do not already have
a date later than or within 60 days of 2021-01-24.

TBR=chromium-metrics-reviews@google.com

Change-Id: Ie20f7ab0fc14a1c3e1844b7e0896c636703f9cf4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323634Reviewed-by: Chrome Metrics Logs <chrome-metrics-team+robot@google.com>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792445}

A stub implementation for ShouldDispatchImeEventsToPepper was placed
on FrameWidget but was never implemented anywhere. Some methods called
the proper Client()->ShouldDispatchImeEventsToPepper code path, but
others ended up using the stub. Remove the dead code, call the right
method.

Fallout from https://crrev.com/23748d4a10c7a3cefb87851045250b8b86887938

BUG=1110131

Change-Id: I04884f4d86b1a07b56b65bb49711f3b9ca060b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324444Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792444}

In InlineTextBoxPainter and NGTextFragmentPainter, previously we
manually transpose the selection rect to convert it between the space of
the original space and the rotated space for vertical text. The code
might be inconsistent with the rotation transform. Actually
crrev.com/c/2319540 exposed the bug in InlineTextBoxPainter when the
vertical selection rect is wider than the text rect.

Now use the rotation transform to transform the selection rect to avoid
the inconsistency.

Change-Id: If75fa61539842cc32a9129391b1a32edbe631847
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324066
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792443}

It is not safe to make these calls from DLLMain as they might
require the delay load resolver to execute within the loader
lock.

See https://docs.microsoft.com/en-us/windows/win32/dlls/dynamic-link-library-best-practices

"Recommendations: Verify that no calls depend on another DLL
that may not have been fully loaded yet."

BUG=1110400

Change-Id: I5f582d98a31065a31b90fac09e42b4dffa4302fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324494Reviewed-by: Yusuf Sengul <yusufsn@google.com>
Commit-Queue: Will Harris <wfh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792442}

- Use built-in last shown notification timestamp to check whether to
show next one.
- Use built-in stats like number of throttle events to extend the
throttle interval.
- Remove all bridge/SharePref getter/setter methods that no longer needed.
- Add a max_interval as a ceiling to the throttle interval to avoid
unlimitted extension.

Change-Id: I9eaca883dac245d953351652d6782a4c13404fce
Bug: 1013685, 1043250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300632
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792441}

Collect additional data when network changes are detected:
0. # of sessions that has been active or created during the time period
   of speculative error.
1. # of sessions that (previously) degraded until a network change.
2. % of sessions that degraded of all tracked sessions since first
   session that detects degradation.
3. # of sessions that were closed due to QUIC_PACKET_WRITE_ERROR before
   degradation detection.
4. occurrence of sessions that detects a QUIC_PACKET_WRITE_ERROR after
   degradation detection.

Bug: 1090532
Change-Id: Ic61db8152ff46b9819ff2626869e96e7d69c388b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293617
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Auto-Submit: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#792440}

This CL draws/hides the focus rectangle around the PDF document based
on whether the PDF document has the focus or not.

The focus rectangle color is currently white. It's a placeholder for now
and will most likely change in future.

Fixed: 1069370
Change-Id: Ib8446a2326924ff0fed59d8fd2b04db462c1488c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211562
Commit-Queue: Ankit Kumar 🌪️ <ankk@microsoft.com>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792439}

This cleanup some things inherited from the previous implementation,
some properties were tracked multiple time (in the PageNode itself, in
the SiteDataWriter and in the NodeData object), this removes some of the
duplication and privileges using data directly from the PageNode.

This also renames the NotifySiteVisibilityChanged function to a pair of
NotifySiteForegrounded/NotifySiteBackgrounded function for consistency
with the other functions of the SiteDataWriter class.

Change-Id: I6412e2f79d8f330214567a439c33727e87210ce0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283297Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792438}

If an app has focus while overview starts, it can receive key events.
For apps like Chrome, this can result in visual glitches like fragments
of omnibox appearing during the overview startup animation.

To prevent this behavior, overview session now eats keys during the
start animation.

Test: OverviewSessionTest.EatKeysDuringStartAnimation
Bug: 951324
Change-Id: Ic0f4c0cef94477ea56846eb7d7f115fc74fbcc79
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323741
Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792437}

Bug: 591981
Change-Id: I8b5cb4ae18c7081d3733521926125aed2995aeb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314268Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792436}

This migrates:

 defined(OS_MACOSX) -> defined(OS_APPLE)
 defined(OS_MACOSX) && !defined(OS_IOS) -> defined(OS_MAC)
 !defined(OS_MACOSX) || defined(OS_IOS) -> !defined(OS_MAC)

Bug: 1105907
Change-Id: I29e66db0baaa7cf1aa6e16a385f99b6d398bcde6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321211
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792435}

When running Pinpoint, and CQ Dry Runs of the GpuMemoryAblationExperiment
being enabled-by-default, a few issues were uncovered:
  - GrContexts cannot always be initialized (crbug.com/1103780)
  - Nested changes to GLContext during initialization fails
    (crbug.com/1104316)
  - Nested deletion crashes in mutually-exclusive ways
    (crbug.com/1106926)

This change looks to address these by restructuring how GpuMemoryAblationExperiment
performs its initialization and context switches.
  - The feature will now disable itself for Mock/Stub GL impls. This will
    prevent attempting to create GrContext in tests where it will always
    fail.
  - For initialization and allocation a ui::ScopedMakeContext will be
    used. This allows resetting of previous state so that GLContexts can
    properly initialize.
  - Deletion will now be done on a PostTask. While some deletion errors
    can be addressed by resetting the context. Resetting the context
    itself can lead to accessing partially deleted objects. Setting a
    a null Surface instead of a scoped context would address these cases,
    but do not address deletion paths that need their context set the
    entire time.

This update to initialization and context handling did help uncover other
issues (1107497, 1107502, 1107509, 1107512) however those are either
platforms we are not running Pinpoint on, or tied to specific test
suites. The root causes of these failures will be investigated
separately.

Bug: 1103780, 1104316, 1106926

Change-Id: Ibf3c9a3a560912f5505f99870b848878a99da5ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300183
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792434}

This reverts commit 3e86bdd3.

Reason for revert: Issue was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2321237.

Original change's description:
> [lacros] Exclude ui_base_unittests
> 
> Exclude ui_base_unittest from linux lacros builders due to a compile
> failure.
> 
> Bug: 1110072
> Change-Id: Ia228c2d6959d4821c2258d68bccb0a34d02bf02e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321244
> Reviewed-by: Sven Zheng <svenzheng@chromium.org>
> Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#792134}

TBR=liaoyuke@chromium.org,svenzheng@chromium.org

Change-Id: If91ef1a30c259cf819e0b4e8e5e85dec851ce7e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1110072
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324407Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792433}

* Add fade in/out animation for ambient mode
* When showing ambient mode, fixed the first black screen issue
* When idling on lock screen and ambient mode returns, fixed the
  first image quickly flashes problem

This CL enables the default window animations, it also creates the
window only when images are successfully downloaded.

Bug: None
Change-Id: Ideb5683aefe92b5f375f06515db822bfd3cb7678
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321714Reviewed-by: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#792432}