GitLab

Previously, the test converter assumed that input files are always valid utf-8;
this change makes the converter also support utf-16 files. There are some files
in the wpt repo that are not valid utf-8 but are valid utf-16, e.g.
web-platform-tests/html/infrastructure/urls/resolving-urls/query-encoding/utf-16be.html.
BUG=463001

Review-Url: https://codereview.chromium.org/2037743002
Cr-Commit-Position: refs/heads/master@{#397775}

Previous CL forgot to set the value of always_show_context_menu_on_touch.
This CL fixes that.

BUG=616971

Review-Url: https://codereview.chromium.org/2037923002
Cr-Commit-Position: refs/heads/master@{#397774}

BUG=612498,543268
TEST=Added the files blimp/science.cc, blimp/science_unittest.cc, blimp/science2.cc, blimp/science2_unittest.cc, blimp/science_browsertest.cc, and science.cc. Verified that blimp/science.cc was flagged for missing unit tests.

Review-Url: https://codereview.chromium.org/2005023002
Cr-Commit-Position: refs/heads/master@{#397773}

This will be needed by the cc::CompositorFrameMetadata StructTraits.

BUG=611802

Review-Url: https://codereview.chromium.org/2040483003
Cr-Commit-Position: refs/heads/master@{#397772}

This patch converts the usage of CanonicalCookie's constructor in
CreateMonsterFromStoreForCG() to CanonicalCookie's Create() method.

We are doing this because Create() is more robust, as it does
validation of the parameters and return NULL as an error signal
if they fail to comply with the checks.

BUG=57061
TEST=net_unittests
R=mmenke@chromium.org

Review-Url: https://codereview.chromium.org/2030233002
Cr-Commit-Position: refs/heads/master@{#397771}

This moves another step performed by gyp-mac-tool into a standalone script.

BUG=616813
R=sdefresne@chromium.org

Review-Url: https://codereview.chromium.org/2033503003
Cr-Commit-Position: refs/heads/master@{#397770}

This is a trivial change to make Event.SelfRemovableParameterRunnable final.

BUG=615277

Review-Url: https://codereview.chromium.org/2033573002
Cr-Commit-Position: refs/heads/master@{#397769}

https://chromium.googlesource.com/skia.git/+log/2cee902847a9..adf5afa628ad

$ git log 2cee90284..adf5afa62 --date=short --no-merges --format='%ad %ae %s'
2016-06-03 robertphillips Add SampleApp slide with animating lightmapped objects & transparency
2016-06-03 herb Add gm for displaying different variants of 8888 bitmaps and fix a small rejection case for sprite blitters.
2016-06-03 caryclark fix windows assert
2016-06-03 scroggo Fix undefined behavior in libpng
2016-06-03 halcanary SkPDF: handle unpremul right
2016-06-03 csmartdalton Abandon offset support with texel buffers
2016-06-03 liyuqian Add Softkey UIState to Viewer
2016-06-03 csmartdalton Support ARB extensions for indirect drawing

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2037753004
Cr-Commit-Position: refs/heads/master@{#397768}

Fixes 'undeclared identifier __NR_access/__NR_open' compile errors.

__NR_access and __NR_open don't exist on ARM64. So, like the earlier
code in same file, added __NR_access and __NR_open case under
!defined(__aarch64__) check.

BUG=613452

Review-Url: https://codereview.chromium.org/1996273002
Cr-Commit-Position: refs/heads/master@{#397767}

This patch adds the following new histograms:
Renderer4.GpuImageDecodeState
=============================
This records the state of the software decode used for gpu upload.
Specifically, it identifies whether the decode was used or not used and
whether it was used/wasted once or several times. The possible states
are all combinations of those values:
- Used, once
- Wasted, once
- Used, relocked
- Wasted, relocked

Renderer4.GpuImageDecodeState.FirstLockWasted
=============================================
This indicates whether the first lock of the decode described above was
used. This is important, since if we waste the first decode, we lose
the guarantee that we can relock and upload this without doing more work

Renderer4.GpuImageUploadState.Used
==================================
This indicates whether the uploaded image was used in raster.

Renderer4.GpuImageUploadState.FirstRefWasted
============================================
This indicates whether the uploaded image was used during the first
ref. In other words, if the ref reached 0 for the first time without
the image being used, this would record "true, it was wasted".

R=ericrk
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2036553002
Cr-Commit-Position: refs/heads/master@{#397766}

BUG=605340

Review-Url: https://codereview.chromium.org/2035863002
Cr-Commit-Position: refs/heads/master@{#397765}

This function is more closely related to the code in test_result_writer.py than the code in rebaseline.py; however it wouldn't be simpler to make this function a method of TestResultWriter, since the TestResultWriter constructor takes several arguments which are not relevant to the baseline_name function.

Review-Url: https://codereview.chromium.org/2021743002
Cr-Commit-Position: refs/heads/master@{#397764}

The buildGradient() method can just create and return a Gradient instead
of populating the GradientData struct it's being passed.
Also make calculateGradientTransform() use the return value rather than
an out variable, and make it const qualified. Make
platformSpreadMethodFromSVGType static and use Traversal<> sugar in
SVGGradientElement::buildStops.

BUG=614368

Review-Url: https://codereview.chromium.org/2031053004
Cr-Commit-Position: refs/heads/master@{#397763}

There is no longer a need to filter out ECDSA.

BUG=none

Review-Url: https://codereview.chromium.org/2037883002
Cr-Commit-Position: refs/heads/master@{#397762}

BUG=615588

Review-Url: https://codereview.chromium.org/2018243002
Cr-Commit-Position: refs/heads/master@{#397761}

There are pages that attach click handlers to elements that are found inside links, and screen readers might try to click such elements. Our existing doDefaultAction logic wasn't handling this possibility.
For example, there might be a graphic inside a link and the screen reader might invoke the default action on the graphic.
BUG=615904
TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2030413002
Cr-Commit-Position: refs/heads/master@{#397760}

. It is necessary to send the --use-mus-in-renderer flag to the renderer.
. Allow content_browser to connect to the renderer and get a handle to
  a RenderWidgetWindowTreeClientFactory.

BUG=none

Review-Url: https://codereview.chromium.org/2037533002
Cr-Commit-Position: refs/heads/master@{#397759}

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2030833003
Cr-Commit-Position: refs/heads/master@{#397758}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/37cec23b5d25..80132ac6935a

$ git log 37cec23b5..80132ac69 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2040483002
Cr-Commit-Position: refs/heads/master@{#397757}

Add removed code from https://codereview.chromium.org/1495623008
that changes the position of the viewer when it hides/unhides.

Added logic that calculates the x and y position offset of the dialog
when it unhides.

BUG=611603

Review-Url: https://codereview.chromium.org/2034993002
Cr-Commit-Position: refs/heads/master@{#397756}

RenderWidgetHostViewMac is careful about creating ui::Compositor and so
currently only does this in Show and SwapCompositorFrame.  However, if
it the RenderWidgetHostView is created while the RenderWidgetHost is
visible, then Show will early out and never create a ui::Compositor.

This causes problems with begin frame scheduling, which wants to have
the Display (which is created as part of creating the ui::Compositor's
output surface currently) own the real begin frame source that drives
everything.  In that world, if no ui::Compositor exists, no frames ever
are sent or swapped.  So, the ui::Compositor needs to be created first.

Also, if the ui::Compositor is correctly created during Show (or the
constructor), then there's no need to ensure that it exists during
swap compositor frame, and so that can be safely removed.

R=asvitkine@chromium.org,ccameron@chromium.org

Review-Url: https://codereview.chromium.org/2005013002
Cr-Commit-Position: refs/heads/master@{#397755}

Whitelist pointer event manual tests in the import process

Using update-w3c-deps in Chromium c517903e.

BUG=612924

Review-Url: https://codereview.chromium.org/2020083002
Cr-Commit-Position: refs/heads/master@{#397754}

BUG=
TBR=stgao@chromium.org

Review-Url: https://codereview.chromium.org/2039533002
Cr-Commit-Position: refs/heads/master@{#397753}

Add tests and Win10 expectations for color emoji.
Also fix an expectation for emoji fallback test to look for the color
emoji font first, which will be present on Win10, but not on Win7.

Skia change to enable color emoji on Win8.1+: https://codereview.chromium.org/1984943002/

BUG=333011

Review-Url: https://codereview.chromium.org/2003853002
Cr-Commit-Position: refs/heads/master@{#397752}

This change moves the close button to the far right in the Physical Web
ListUrlsActivity.

BUG=603132

Review-Url: https://codereview.chromium.org/2027033002
Cr-Commit-Position: refs/heads/master@{#397751}

BUG=584660

Review-Url: https://codereview.chromium.org/2032943003
Cr-Commit-Position: refs/heads/master@{#397750}

BUG=546019

Review-Url: https://codereview.chromium.org/2036643004
Cr-Commit-Position: refs/heads/master@{#397749}

BUG=616265
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2037033004
Cr-Commit-Position: refs/heads/master@{#397748}

BUG=616633

Review-Url: https://codereview.chromium.org/2037093002
Cr-Commit-Position: refs/heads/master@{#397747}

The raw pointer overload of ListValue::Append() is deprecated and will
be removed. Instead, code should just write:
- ListValue::AppendBoolean()
- ListValue::AppendInteger()
- ListValue::AppendDouble()
- ListValue::AppendString()

BUG=581865

Review-Url: https://codereview.chromium.org/2037703004
Cr-Commit-Position: refs/heads/master@{#397746}

In order to allow Chrome on iOS to use build/mac/tweak_info_plist.py,
add options required to control the format of the generated plist file
(--format), the product reported to breakpad (--platform) and a way to
override some portion of the version string (--version-overrides).

This is required to allow Chrome on iOS to migrate from it old fork of
tweak_info_plist shell script and to incorporate tweak_info_plist.py
in the GN build.

BUG=502295

Review-Url: https://codereview.chromium.org/2037043002
Cr-Commit-Position: refs/heads/master@{#397745}

As compositor will no longer know tree hierarchy information, it is
expected to dump a layer list instead of a layer tree to chrome tracing.

The value root_layer is also deleted because it is used to judge whether
the dumped layer_tree_impl has a list or not on the FrameViewer side.

Chrome://tracing will show a layer_tree_impl without depth, this is
expected.

This CL is blocked by Issue 1947553002, and potentially influenced by
the LayerTreeImpl's JSON issue.

Devtools need to deal with the new format information. On the devtools
side, we make the first drawsContent layer "contentRoot" and treat all
other layers as the contentRoot's child.

BUG=605940
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1945813002
Cr-Commit-Position: refs/heads/master@{#397744}

(based on patch from skyostil@, also sets default window size to 800x600 to enable basic snapshot support)

With the --screenshot option, headless shell will save a PNG screenshot
of the loaded page.

patch from issue 2000723002 at patchset 1 (http://crrev.com/2000723002#ps1)

BUG=546953

Review-Url: https://codereview.chromium.org/2035733002
Cr-Commit-Position: refs/heads/master@{#397743}

This test is causing problems for the ANGLE CQ.

BUG=617148
R=kbr@chromium.org,zmo@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2032413002
Cr-Commit-Position: refs/heads/master@{#397742}

The original DomCode+flags->DomKey mapping causes issue when the application
generates mismatched keyCode + scanCode, or missing scanCode entirely.
(e.g. keyboard-rewrite softwares that only modifies keyCode)

A better solution is to use VK+flags->DomKey mapping (for both printable
and non-printable keys).

This CL is the first step for the non-printable keys, where a fixed table
for general non-printable keys was introduced. And there will be follow up CLs
to handle other language-specific cases and printable keys.

BUG=612749

Review-Url: https://codereview.chromium.org/2025733002
Cr-Commit-Position: refs/heads/master@{#397741}

BUG=616710

Review-Url: https://codereview.chromium.org/2032713004
Cr-Commit-Position: refs/heads/master@{#397740}

Add wallpaper.mojom for ash_sysui<->chrome interaction.
Implement WallpaperController in ash_sysui UserWallpaperDelegateMus.
Implement minimal new ChromeWallpaperHelper in chrome.
(lets chrome set mash wallpaper, mash trigger chrome wallpaper picker)

Add SetWallpaper helper for WallpaperManager to work in mash too.
Remove sysui_application.cc debug wallpaper initialization.
Bail early on WindowStateManager::[Minimize|Restore]InactiveWindows.
Workaround DesktopBackgroundController shell usage.

TODO: Fix picker regression from codereview.chromium.org/2009853002
TODO: Fix wallpaper_manager.cc's other Shell::GetInstance uses.
TODO: Fix DesktopBackgroundController display size checks in Mash.
TODO: Implement window hide/restore for wallpaper picker.
TODO: Implement missing UserWallpaperDelegateMus functionality.

BUG=557405,613657,613707
TEST=Chrome OS wallpaper works with or without --mash flag; right click mash desktop -> "Set wallpaper..." works.
R=jamescook@chromium.org,sky@chromium.org,dcheng@chromium.org

Review-Url: https://codereview.chromium.org/1984433002
Cr-Commit-Position: refs/heads/master@{#397739}

This change allows 1 additional frame of pipelining in
ImageTransportSurfaceOverlayMac by switching from a glFinish based
approach to a glFence based one.

Tested for CA framerate regressions - the following cases starve CA
when used with a simple glFlush. This solution (and the previous
glFinish) appear to successfully prevent CA starvation:

Animometer - bouncing png images:
https://trac.webkit.org/export/HEAD/trunk/PerformanceTests/Animometer/developer.html?test-interval=20&display=progress-bar&controller=adaptive&frame-rate=50&kalman-process-error=1&kalman-measurement-error=4&time-measurement=performance&suite-name=SVGsuite&test-name=SVGbouncingPNGimages&complexity=200
Both glFinish and glFence produce ~50 fps in CA/Chrome.

WebGL Liquid Face:
http://alteredqualia.com/xg/examples/liquid_face.html
For liquid face, note that with the glFinish, CA framerate is slightly
higher than Chrome reported framerate (20 vs 15) - with the new
approach, they match more closely (16 vs 15). This may be a negative,
but is still much better than the starvation which is seen with glFlush (5
vs 15).

Improvements:
Telemetry smoothness.top_25_smooth: This change produces good
improvements in first_gesture_scroll_update_latency,
mean_input_event_latency, and mean_main_thread_scroll_latency,
without any significant regressions. See:
https://drive.google.com/file/d/0B2nwXDxTDpGGU215X2xYTE9Bdnc/view?usp=sharing
Animometer Benchmark: This change produces good improvements in a
number of animometer benchmarks. See:
https://docs.google.com/spreadsheets/d/1qK6LfDVMKydbKfkGEi1DuGoSqY2wPJAjPiAL1CCUW-4/edit?usp=sharing

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2028303002
Cr-Commit-Position: refs/heads/master@{#397738}

1. merge ignored containers and ignored leaf nodes into one predicate
2. only visit containers that are also visited by the provided predicate. For example, an element will match against a focusable toolbar, but a line won't.
3. scan the initial subtree of a node when moving to the next node if either of the following are true:
the node is a container or
the node doesn't match the predicate (e.g. element).
This takes care of syncing when the current range is on an arbitrary position in the tree.
When moving backwards, the leaf predicate restricts how deeply the backwards movement syncs downwards in the tree.

BUG=613473
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2028173003
Cr-Commit-Position: refs/heads/master@{#397737}

https://chromium.googlesource.com/skia.git/+log/9d19cc6ca4de..2cee902847a9

$ git log 9d19cc6ca..2cee90284 --date=short --no-merges --format='%ad %ae %s'
2016-06-03 msarett Add color correction benchmark - with comparison to qcms
2016-06-03 msarett Fix uses of SkImageInfo in BRD to preserve color space info
2016-06-03 jcgregorio skiaserve: Add a flag to control hosted mode, i.e. when running on debugger.skia.org.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=herb@google.com

Review-Url: https://codereview.chromium.org/2037033003
Cr-Commit-Position: refs/heads/master@{#397736}