GitLab

BUG=137767

Change-Id: I695459f8b60ecdce8d0b476d7eb373464c5e4be7
Reviewed-on: https://chromium-review.googlesource.com/1112775
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570292}

Logic was previously in AssistantInteractionController.

Bug: b:80542452
Change-Id: I3e92d2ed8cbf1afa3577a7180eef5260a592f8d6
Reviewed-on: https://chromium-review.googlesource.com/1112656
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570291}

Bug: 827648
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I75f2ebe01cd6a0af212b7d4a2d823d16f2cbba8b
Reviewed-on: https://chromium-review.googlesource.com/1102085
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570290}

LayoutTextTest and LayoutTextFragmentTest do not set font-size
when SetAhemBody is used. This caused DCHECK failures added in
CL:1111895 due to too much rounding errors.

This patch fixes that by setting the font-size to 10px.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I6e945a6f07902c50bbfcbca4014d324ba1ae1d0a
Reviewed-on: https://chromium-review.googlesource.com/1113697Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570289}

https://pdfium.googlesource.com/pdfium.git/+log/8c955c9d3072..76fb29d5ebae


git log 8c955c9d3072..76fb29d5ebae --date=short --no-merges --format='%ad %ae %s'
2018-06-25 thestig@chromium.org Clean up CPDF_StreamContentParser::AddTextObject().


Created with:
  gclient setdep -r src/third_party/pdfium@76fb29d5ebae

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Idcc5ad4ff3b25f66ab34efce1909a826325f113f
Reviewed-on: https://chromium-review.googlesource.com/1113827Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570288}

Bug: 855286
Change-Id: I35b3fcce765c41f7b845ec3e5ec7924750b8a1c2
Reviewed-on: https://chromium-review.googlesource.com/1114334Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570287}

When piping Chrome stdout/stderr through asan_symbolize.py, we want it
to output every line immediately. Python line iterators buffer multiple
lines, so switch to using readline() directly instead.

Change-Id: I90d712c14094929e411b395d0a8d3ae00c0e9d05
Reviewed-on: https://chromium-review.googlesource.com/1114308Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570286}

This cl changes several specs of TabbedPane in highlight vertical mode:
1. Max row length should be capped at 192, with right padding of 8px.
For long text, truncate with ellipsis.
2. Change active color from #4285F4 to #1A73E8.
3. Do not show MdTab border when focusing in highlighted mode. Instead
hightlighing with darker blue.

Bug: 822382
Test: manual.
Change-Id: I455aa2ecdf6d07c4aa34a2438af1dca1266030a3
Reviewed-on: https://chromium-review.googlesource.com/1114288
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570285}

Feature is landed in M66. Now we can remove the flag in M69.

Bug: 778438
Test: manual
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Icd56cda2c4cd61677f4724c11ccf4b946eae24ae
Reviewed-on: https://chromium-review.googlesource.com/1113077Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#570284}

This reverts commit 987fd487.

Reason for revert: need to change module of the mojom

Original change's description:
> [SWOnionSoup] Move dispatch_fetch_event_params.mojom into Blink
> 
> BUG=789846
> 
> Change-Id: I1866746cd240b26d2d059a64309aa595eccb9cac
> Reviewed-on: https://chromium-review.googlesource.com/1113203
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Han Leon <leon.han@intel.com>
> Cr-Commit-Position: refs/heads/master@{#570278}

TBR=kinuko@chromium.org,shimazu@chromium.org,leon.han@intel.com

Change-Id: Idced63d7ae3902f94304fdddb76371da9de3c5fd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 789846
Reviewed-on: https://chromium-review.googlesource.com/1113847Reviewed-by: Han Leon <leon.han@intel.com>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#570283}

Move to a separate header in preparation for adding a matching
RenderWidgetHostNSViewRemote.

Bug: 821651
Change-Id: Iefeca67957e7810a2e057f77eeb8e61db2d96643
Reviewed-on: https://chromium-review.googlesource.com/1111036Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570282}

Fix chopped text and missing dropdown image in the account select
in the destinations dialog.

Bug: 855012
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I577f471c17d1889e82468f05aeb8cdda62753d6e
Reviewed-on: https://chromium-review.googlesource.com/1111457
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570281}

So far seems to be working fine and not becoming overloaded.

Bug: 702625
Change-Id: I1a83fc0594f1b1ac69ff0b70f9997b59c08db3c8
Reviewed-on: https://chromium-review.googlesource.com/1114318Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570280}

We found out that the hardware split gamma mode
doesn't do interpolation of the values, which led
to some bad side effects such as ugly banding in
blur effects.

This CL removes all the default gamma tables, and
uses the newly exposed data to identify if the
hardware does color correction in linear gamma
space or not. This lets us select which type of
matrix to apply.

BUG=851156,749250
TEST=Expanded tests

Change-Id: I0342b6e4a0257e833c7d13690930dfd32ce89fe7
Reviewed-on: https://chromium-review.googlesource.com/1112734Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570279}

BUG=789846

Change-Id: I1866746cd240b26d2d059a64309aa595eccb9cac
Reviewed-on: https://chromium-review.googlesource.com/1113203Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Han Leon <leon.han@intel.com>
Cr-Commit-Position: refs/heads/master@{#570278}

On History/Download/Bookmarks, if we set close icon to "always" shown
as action, the other items can be collapsed into an overflow menu that
appears to the right of the close icon. We should temporarily set the
showAsAction back to "ifRoom" until we figure out a better way to
customize collapsing the items into an overflow menu.

Bug: 849849
Change-Id: Ic94f8d9071dc0295ec5adc10e36ab74eb4a2150b
Reviewed-on: https://chromium-review.googlesource.com/1114307Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570277}

Certain packages, like services and runners, are not meant to be
run directly from the command line.

This CL introduces a flag "--install-only" which copies packages
to a device, but does not run them.

Change-Id: Ibb53f04a8ef6a93cc39d31b651666512a42b3c6a
Reviewed-on: https://chromium-review.googlesource.com/1114292
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570276}

In crrev.com/c/1098869, new category of input method id, ArcImeId was
introduced.
Before this CL, enabled ids of ARC IMEs are stored in
kLanguagedPreloadEngines, but they should be stored
kLanguageEnabledExtensionImes because the former pref is for component
extension IMEs, which is pre-installed system IMEs.

Bug: 845079
Test: Unit tests are added.
Change-Id: I62d509895359284df8162c2852ca7ccae40ca7ff
Reviewed-on: https://chromium-review.googlesource.com/1109441Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570275}

The "send detected values" experiment was launched in M65 and has been
default-enabled at ToT for a while now.  We've delayed removing the flag code
because it (correctly) resulted in a QPS increase for Payments, but things have
gone well, so I'm now removing the flag and making the behavior default.

Bug: 855788
Change-Id: If34db8ac090732cbdc44cfec17f2530d22b00e04
Reviewed-on: https://chromium-review.googlesource.com/1112753
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570274}

Bug: 850479
Change-Id: Id1e953e3416f1f971f981bc5e5247fa40233538e
Reviewed-on: https://chromium-review.googlesource.com/1114256Reviewed-by: apacible <apacible@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570273}

https://webrtc.googlesource.com/src.git/+log/d5b8ee1e175e..111fdfd73204


git log d5b8ee1e175e..111fdfd73204 --date=short --no-merges --format='%ad %ae %s'
2018-06-25 steveanton@webrtc.org Refactor RtpSender to take the sender ID as a constructor argument


Created with:
  gclient setdep -r src/third_party/webrtc@111fdfd73204

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I50e42012d5c6e505fdc12c472a61a47dc7ce66c2
Reviewed-on: https://chromium-review.googlesource.com/1114042Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570272}

Change-Id: I9e2e1be12907bc93a2e2b9f60a1a406878b4c7e6
BUG: chromium:533481
Reviewed-on: https://chromium-review.googlesource.com/1114259Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#570271}

BUG=137767

Change-Id: If68b726d3f007e2144856bdf691c070c5d1533c1
Reviewed-on: https://chromium-review.googlesource.com/1112770
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Xiangjun Zhang <xjz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570270}

Also removes iannucci@, since he doesn't work on these scripts anymore.

Change-Id: Id6191a752a1a22f48714f96eb767c2a92552e82b
Reviewed-on: https://chromium-review.googlesource.com/1114183
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570269}

Before Screenshot: https://drive.google.com/file/d/18YJwgnQAsZ2c0YV2fDVx_p8oDwOPAUPy/view?usp=sharing
After Screenshot: https://drive.google.com/file/d/1_V8gJ9lD76oCwC95T-_ZK16ThncguFnI/view?usp=sharing

Change-Id: I7d57917ae1e330c6d109d5676b84eb5d87f3ff2d
Reviewed-on: https://chromium-review.googlesource.com/1114140Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570268}

Even before RLS landed, this functionality appears only to have been
accessed by an obsolete internals API.

BUG=823365
R=skobes@chromium.org,pdr@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I599103f2ba4ff4270eddfa11bef2eb016e612484
Reviewed-on: https://chromium-review.googlesource.com/1114067
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570267}

A pending frame with no deadline can never activate if it refers to
a future surface ID from a deleted sink. This blocks future valid frames
to be generated, causing a deadlock.

This CL makes SurfaceDependencyTracker to unblock dependencies to
all future surface IDs for a deleted frame sink.

BUG=667551,672962

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I90ecd75d575b41211cfd104184657f5c89ffb266
Reviewed-on: https://chromium-review.googlesource.com/1111273Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570266}

This reverts commit 7e1ee3f6.

Reason for revert:
Sheriff is reverting on suspicion of causing build failures in Linux-chromeos-dbg.
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/6482

BrowserTestBase received signal: Segmentation fault. Backtrace:
#0 0x0000030708cc base::debug::StackTrace::StackTrace()
#1 0x000002a06b85 content::(anonymous namespace)::DumpStackTraceSignalHandler()
#2 0x7f1b84f32cb0 <unknown>
#3 0x000001b623b4 chromeos::OobeUIDialogDelegate::GetOobeUI()
#4 0x000001b5e99e chromeos::LoginDisplayMojo::LoginDisplayMojo()
#5 0x000001b58e56 chromeos::LoginDisplayHostMojo::LoginDisplayHostMojo()
#6 0x000001b5e397 (anonymous namespace)::ShowLoginWizardFinish()
#7 0x000001b5dcc3 chromeos::ShowLoginWizard()



Original change's description:
> cros: Views-login prevent gaia from being dismissed.
> 
> Sometimes the dialog should not be dismissed, such as when there are no users.
> 
> Bug: 839583
> Change-Id: Iee275fb636e5842ba2e99b799b8c04539ea1c3bd
> Reviewed-on: https://chromium-review.googlesource.com/1093882
> Commit-Queue: Jacob Dufault <jdufault@chromium.org>
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570105}

TBR=xiyuan@chromium.org,jdufault@chromium.org

Change-Id: I031f7ab7e627f1aedea76fb24f8ad4b2f97eb804
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839583
Reviewed-on: https://chromium-review.googlesource.com/1114048Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570265}

Use the TestBrowserThreadBundle RunUntilIdle to flush all tasks at the
end of the test, rather than base::Runloop::RunUntilIdle, which caused
flakes on the MSAN/ASAN bots.

Test: unit_tests --gtest_filter=FileManagerFileWatcher*WatchLocalFile
Bug: 813483
Change-Id: I867e5d914074e6c9d389a5f932836cd6cd8a627c
Reviewed-on: https://chromium-review.googlesource.com/1113399Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570264}

CL [1] propagates the FONTCONFIG_FILE environment variable to subprocesses and
thus ensures, child/utility processes receive the correct fontconfig testing
environment.  This means adding a command line switch to indicate a testing
environment for fontconfig is no longer necessary.

R=drott,thestig
BUG=849923

Change-Id: I2234802904e9f725fa0b221fd65aced4885e0023
Reviewed-on: https://chromium-review.googlesource.com/1112768
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570263}

The function makes a DCHECK(IsValid()) thus causing it to crash in debug.

BUG=848398

Change-Id: I3af4495edeffff652507637e914da61dac5c5476
Reviewed-on: https://chromium-review.googlesource.com/1114182Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570262}

BUG=835398

Change-Id: I7c34d074403767b45d2f26398ec97e37f0edacb9
Reviewed-on: https://chromium-review.googlesource.com/1114177
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570261}

Change-Id: I9da70ff3b1f1199e46d536196057d6de76cfe804
Reviewed-on: https://chromium-review.googlesource.com/1114303Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570260}

https://chromium.googlesource.com/catapult.git/+log/7d423fc5614b..8d2c28ec7666


git log 7d423fc5614b..8d2c28ec7666 --date=short --no-merges --format='%ad %ae %s'
2018-06-25 bpastene@chromium.org telemetry: Fix cros_interface_unittest.testGetFileNonExistent.


Created with:
  gclient setdep -r src/third_party/catapult@8d2c28ec7666

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:836447
TBR=sullivan@chromium.org

Change-Id: I0e98c2e411d82aed75acfcd7d5fb44cc6ad82b80
Reviewed-on: https://chromium-review.googlesource.com/1113821Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#570259}

Bug: 851163
Change-Id: Ic533e231e5b4f7b2d6f5df06a05cd0433efc304d
Reviewed-on: https://chromium-review.googlesource.com/1114239Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570258}

1.) The repost form warning should use dismissAllowingStateLoss
    for the tab destroy call as it can happen in the background.
    For this dialog in particular, we do not want to restore
    it in the event of a restart, so loss of UI state is not
    only acceptable, but likely what we want always.

2.) Handle the case of tabbed activities in the process of startup
    when clicking the incognito notification.  This just kills
    any tabbed activities that aren't fully running because it
    has sync issues with incognito tabs that might have been read
    already.

BUG=856320

Change-Id: Ic3506d20d42cb915328394f18dcad5574d8dca7e
Reviewed-on: https://chromium-review.googlesource.com/1114279Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570257}

One of our compiler changes means that the Chrome symbols now contains
references to enums as symbols in a way that makes them show up as
duplicated variables in ShowGlobals.exe reports, despite occupying no
space. This change filters out globals that aren't statics, which avoids
this problem.

This change also updates the .vcxproj file to VC++ 2017 and the 17134.0
SDK.

This tool is discussed in the Windows Binary Sizes page:

https://www.chromium.org/developers/windows-binary-sizes

Change-Id: I73a2a7924107b5027bf68a928954e4480e5b5af5
Reviewed-on: https://chromium-review.googlesource.com/1114291
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570256}

According to the spec[1], if an overflowing snap area covers the
snapport in one axis and the distance between the previous snap
position and the next snap position is larger than the size of the
snapport, the current scroll position is a valid snap position.

This patch also rewrites the data structure of SnapAreaData and
SnapContainerData so that they only keep the rect and calculate the
snap points, visible region, overflow condition only when scroll
occurs.

[1] https://drafts.csswg.org/css-scroll-snap-1/#snap-overflow

Bug: 826359
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iec1ebe48abe8d2653128ac2af4e6137a14c05502
Reviewed-on: https://chromium-review.googlesource.com/1075558
Commit-Queue: Sandra Sun <sunyunjia@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570255}

Bug: 844299
Change-Id: I73aa4e92c0f56377a2f012f5a6224cb5335d495c
Reviewed-on: https://chromium-review.googlesource.com/1112735
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570254}

The settings-basic-page is designed under the assumption that all
settings-section elements are direct children of the
settings-basic-page. As a result, our previous design of the
settings-multidevice-section-container
(now settings-multidevice-page-container) was very fragile because it
put the multidevice settings-section inside the container. See
https://chromium-review.googlesource.com/c/chromium/src/+/1105185 for
context and
https://chromium-review.googlesource.com/c/chromium/src/+/1107168 for
an example of a bug fix required by this problem.

This CL maintains the settings-multidevice-page-container's ability
to hide the entire multidevice settings-section and avoid attaching
the settings-multidevice-page while putting the settings-section where
the settings-basic-page assumes it is.

Manual checks (all successful) included
    (a) the section appears immediately after loading
    (b) the mode_ property of settings-multidevice-page-container
        toggles the section's presence (including the title) multiple
        times
    (c) the section disappears when other subpages are opened (i.e. it
        does not undo the fix from CL 1107168)
    (d) other animations (e.g. opening subpages) run smoothly
    (e) the correct mode is passed to the settings-multidevice-page,
        displaying the appropriate content
    (f) all buttons work as intended after toggling, including the Set
        up" button opening the multidevice setup dialog

Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I10470e8c655a55f69d6a14afa4a719d2050e2bda
Reviewed-on: https://chromium-review.googlesource.com/1109310Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jordy Greenblatt <jordynass@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570253}