GitLab

With this CL, recursive custom element constructions are no
longer allowed. I.e. this will now only run the constructor once:
  class extends HTMLElement {
    constructor() {
      super();
      customElements.upgrade(this);
    }
  }

Previously, the code and spec had a bug which caused the above
code snippet to infinitely recurse. In [1] the spec has changed,
to set the custom element state to "failed" before the constructor
is called. With this change in place, recursive calls will
early-out at step #2 (of [2]), and avoid the recursion.

[1] https://github.com/whatwg/html/pull/5126
[2] https://html.spec.whatwg.org/multipage/custom-elements.html#upgrades

Bug: 966472
Change-Id: I76e88c0b70132eee2482c304ef9e727ae1fe8fc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931644Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727841}

Creating RadioButtonWithEditText to achieve entering customized URL in a radio
button group. By extending RadioButonWithDescription, this new UI widget
shared most of the margin and style with the original button.

Bug: 1036470
Change-Id: I395120490303e4a2f150248c551a8f1e952c4c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966355
Auto-Submit: Wenyu Fu <wenyufu@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727840}

There were several performance regressions after [1] consolidated some
NodeType bits from individual flags to a bitmask. This CL attempts to
optimize back some of that performance.

[1] https://chromium.googlesource.com/chromium/src/+/196a45a23b1e0c1ad89c125a0877ce367b6b4bf3

Bug: 1036088, 1036089
Change-Id: I24b263cc7360c0178b76d759268406630f99a5cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978913
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727839}

This change limits the number of hosts that are requested
requested by the prediction model fetcher from the remote
optimization guide service and is finch controllable. This will
improve the request latency and load on the remote optimization guide
service. It will also limit the total number of host model features
maintain on the client. Additionally, only hosts that are not already
in the host model features cache will be included in the request.

This change also implements a least-recently-used in-memory cache for
the host model features that the prediction manager maintains.
The maximum size is controllable via finch and the default is set
to hold 95% of all users hosts without needing to evict any host model
features.

Bug: 1036399
Change-Id: Ice9ab7c3c3505fc970ab72e1c78f5d628cd5157b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981632
Commit-Queue: Michael Crouse <mcrouse@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727838}

This is used in place of the tab-icon loading indicator as the favicon is
not visible when the tab strip is hidden.

Bug: chromium:1027377
Change-Id: I40c6e6b38023bfae4b5e9993bd9c9f4c8b2bbb3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1959340
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727837}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I917a989fd45bcfaf90cd9258e74d001d2122de12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984688Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#727836}

https://chromium-review.googlesource.com/c/chromium/src/+/1980478/3..4/chrome/browser/ui/views/web_apps/web_app_frame_toolbar_view.cc#b479
unintentionally removed a line.  That line will eventually be removed later, but
for now removing it is a regression.  Undo the removal.

Bug: 1033922
Tbr: estade
Change-Id: If1f37f3549d8870191051b6b2e661afedc0ea044
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984747Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727835}

Add WebContentsPresentationManager, which is an interface that can be
observed to obtain the default PresentationRequest and MediaRoutes
associated with a WebContents.

Make PresentationServiceDelegateImpl implement
WebContentsPresentationManager, and have MediaRouterViewsUI observe it
through the interface instead of observing directly.

Bug: 1031672
Change-Id: I28034b11bf3b94c15c8af55fa68e532eb87e833e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939844
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727834}

Migrates some directories off of deprecated base::Bind, base::Callback,
etc, and onto the newer APIs.

Specifically this covers components/data_reduction_proxy/

Fixed: 1007681
Change-Id: I9c137caef120d3a0d50b905456cdc13543029056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979140
Auto-Submit: Ken Rockot <rockot@google.com>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727833}

This CL sends ActivationSequence info on extension load
(through ExtensionMsg_Load IPC) to renderers. Therefore, worker
notifications from renderer now carry the sequence back to
browser process / ServiceWorkerTaskQueue. This makes renderer
notifications deterministic-ally map-able to an extension load sequence,
as opposed to guessing an ActivationSequence (esp. when an extension is
deactivated and then activated).

This CL also drops the knowledge of a WorkerState upon extension
deactivation as we can safely ignore expired renderer notifications
arriving after that.

RendererExtensionRegistry stores ActivationSequences for all
worker based extensions.

Bug: 1022247, 1003244
Change-Id: I1f1bc013f0993bbb3927674576f2844d6354777f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970854Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727832}

The python script attached to the bug was used to generate version
strings for all images.

BUG=chromium:728134
TEST=None

Change-Id: I41757a934436542bef3990b4984fa06ad406392f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983355Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Vadim Bendebury <vbendeb@chromium.org>
Auto-Submit: Vadim Bendebury <vbendeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727831}

Bug: none
Change-Id: Id5b32079003f1357e53ab7747fa1f8529cb41b48
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983455
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727830}

Filtered out the non-Crostini app window in crostini_tracker, otherwise,
MultiUserWindowManagerHelper could set the owner for Chrome apps, and
cause the window showing issue for the second user.

BUG=1011235

Change-Id: Ia5f6ce67ebe869442bbf079ed58cb3c9a57a2ee2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983108Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727829}

This not only simplifies the code, it allows moving the SeparatorView class to
be a private member, which will allow it to access a private data member of
IconLabelBubbleView in a future CL.

Bug: 1033922
Change-Id: Ic1fe818e997b36dd3c96c082c8de0de4faaf2e25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983454
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727828}

This CL prevents read access to uninitialized SharedImages. For cases
where read/write access is reqeusted, the CL requires that the caller
specifically request uninitialized access if required.

Bug: 1003686
Change-Id: I52230217cd7f17e0cd9d4a82036ae6c72d3b1ea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974630
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727827}

Bug: None
Change-Id: Iefa78813c3c6e2bf72ff76ff932da50242fe06e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984531Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727826}

Bug: 853360
Change-Id: I016ec6669df8cb5c198d6a8a4151356aa3374f52
Tbr: xiaochengh@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984679
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727825}

Some bots have non-standard output directories but set the CHROMIUM_OUTPUT_DIR
environment variable to the corresponding path. We make use of this fact
to find trace_processor executable.

Bug: 1028612
Change-Id: I50ddf0061e892fa9383497c10e23a6ee1607f9ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984302Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Cr-Commit-Position: refs/heads/master@{#727824}

This object should make it easier to write out lists of benchmarks and
to abridge benchmarks on specific platforms.

Bug: 1030840
Change-Id: Ib811d5b1823c1895175e5cf94e45f58d4ce78f1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980479
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727823}

https://bugs.chromium.org/p/chromium/issues/detail?id=921353#c13 for explanation.

Bug: 921353
Change-Id: Iabdf3565ab6d7d4428e03d7541d3021394530c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984560
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Auto-Submit: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727822}

This new field represents whether a host resolution error resulted
directly from a DNS-over-HTTPS attempt. It will be used in future cls to
prepare the error page for secure DNS errors and to trigger captive
portal probes. Note that if a result was obtained from the cache this
field will be false, regardless of whether the result was originally
obtained securely, because this field is intended to identify secure
DNS *network* failures.

Bug: 1037899
Change-Id: I21b8afaeb103f12d7d572f8cf8b29d2e1228d007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978106
Commit-Queue: Katharine Daly <dalyk@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727821}

And test if it works fine on the builder android-pixel2-perf-aab-fyi
Needs crrev.com/c/1975037 to land first

Bug: 986990
Change-Id: I26e492803eceb8bebc56e1e1b778cd6c4ebe04a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982234Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#727820}

Rename BrowserActionTestUtil and all its related friends to
ExtensionActionTestHelper. This is more accurate, since it applies to
all types of extension actions, not just browser actions.

Bug: 1037658
Change-Id: I71e5437100fe9fe089f5dfc4afadd4d838d2d62b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980937
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727819}

By default, the ink drop color now maps to this color, which makes sense (most
views want to use the same text/ink drop color).

This doesn't yet help remove duplicated code, since the goal of this CL is to
not change any behavior (yet), and thus the affected bits mostly just move
from one class to another.  As with the parent CL, the real motivation is to
break the fix for bug 1033922 into easily-reviewable pieces, and in addition
to enabling that fix, this will also enable some later cleanup.

Bug: 1033922
Change-Id: Ie68d1cd0ed71f0e52c9b2d290c2ed839d5c2631c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980478
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727818}

Clarifies that access continues until a call to
glEndSharedImageAccessDirectCHROMIUM, or until the texture is deleted.

Change-Id: I8b4e6ec39b5730534b1da27d8d998c965c935bef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984467Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727817}

Fix enum value indices that were off by one.

Bug: 1033591
Change-Id: Iba24bba68091071d8b9da5495f3a40997ec45f59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984469
Auto-Submit: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727816}

Frequently one class implements several subclass delegates; in that case, it
makes sense for all the delegates to use the same ink drop base color (and
that's what everyone does in practice today anyway).  This consolidates
duplicated code.  No intended behavior change.

The true motivation for this change is to introduce the
IconLabelBubbleView::Delegate class, which can then be used in a subsequent CL
to fix various location bar color bugs.  This splits a large amount of ugly
plumbing off into its own, more easily-reviewable CL.

Bug: 1033922
Change-Id: I28d0d1e3d3aa559c4ce369626371dd7f01dc3761
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983339
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727815}

Bug: 973211
Change-Id: I4e1ae4c40492456d09d93638d732ed68a2befbb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977777Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Auto-Submit: Kelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727814}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/139deb3609b0..c7539abc143c

git log 139deb3609b0..c7539abc143c --date=short --first-parent --format='%ad %ae %s'
2019-12-30 brgoddar@microsoft.com Profiler: update start/stop to retain focus on press

Created with:
  gclient setdep -r src/third_party/devtools-frontend/src@c7539abc143c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:963183
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I889232e872b3b8d919d49b9715d751de79fff7e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984424Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#727813}

Change-Id: I8e92fc59bc59c307d39c77b53e191273d905cb12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978044
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727812}

Roll airmont AFDO profile from 81-3987.0-1577100150-benchmark-81.0.4011.0-r1 to 81-3987.18-1577702544-benchmark-81.0.4011.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-airmont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Iece68e34a5aff557fbbe2ba2613dd3266da31ff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984433Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#727811}

Bug: 1038398
Change-Id: I7f3701fdd633b641b19f3e520faf588a19d4d969
NoTry: True
Tbr: eugenebut@chromium.org, sczs@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984434Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727810}

Roll silvermont AFDO profile from 81-3987.0-1577099071-benchmark-81.0.4009.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4011.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-silvermont-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I41979a59b7ba68b1d918df1b7e96756ac9d36a3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984431Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#727809}

https://swiftshader.googlesource.com/SwiftShader.git/+log/59465799210b..10a900e5ffaf

git log 59465799210b..10a900e5ffaf --date=short --first-parent --format='%ad %ae %s'
2019-12-30 chrisforbes@google.com Add assert in GenericValue constant access

Created with:
  gclient setdep -r src/third_party/swiftshader@10a900e5ffaf

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I4a45f1d664e417ce5b4f9ee75bb98b2b2840ab6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981497Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#727808}

Roll broadwell AFDO profile from 81-3945.86-1577097374-benchmark-81.0.4011.0-r1 to 81-3987.18-1577704324-benchmark-81.0.4011.0-r1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/cros-afdo-broadwell-chromium
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: Iae04dfa45c248429bcf9d516c4dba180eae4252f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984429Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#727807}

Bug: 1038388
Change-Id: I3289e4f71d76237dd9e12afb8b4280c930a5b9cd
Tbr: xiaochengh@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984425Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727806}

Update SubresourceFilter tests to use WebContentsConsoleObserver
instead of ConsoleObserverDelegate. This allows us to observe
console messages added without overriding the existing delegate of the
WebContents.

Change-Id: I162619e272ef9a9bc2e7b903b002c1aab46b0e1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983194Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727805}

This final status is defunct.

Bug: 1038060
Change-Id: Ifda6bfb18ef3cbcaad8c41b92efacc28ff33efa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984345
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727804}

This reverts commit 8d05b03b.

Reason for revert: This definitely fixes the function to do what it's supposed to do, but apparently the incorrect behavior is deeply baked in.

Bug: 1038278

Original change's description:
> MacViews: Fix NativeWidgetMac's GetTopLevelWidget
> 
> This function never returned a top level widget, rather, would just
> return the root widget.
> 
> Bug: 957362
> Change-Id: I8d757fecfd8eddd02d92200516a21c3576eb4468
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982682
> Reviewed-by: Leonard Grey <lgrey@chromium.org>
> Commit-Queue: ccameron <ccameron@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#727575}

TBR=ccameron@chromium.org,lgrey@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 957362
Change-Id: I877c8176e5ffa69b197825e642f3b60e723371c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984346Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727803}

Redefine the macro for color ids so it maps the new id to the old id
in system without color pipeline feature. Also add a porting macro for
color provider to help the transition to use color pipeline feature.

BUG=1003612

Change-Id: I7f69fd689b8574fb93c6354b246c997b3b34483e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939838Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#727802}