- 16 Sep, 2020 40 commits
-
-
Mike Dougherty authored
Bug: 1128463 Change-Id: I32f05328e590ad7e8772cec8119e6d253d456853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412448 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807473}
-
Friedrich Horschig authored
This CL fixes the broken fade-in animation and adds an overshoot animation for the arriving suggestions (see linked bug for screenrecording). The animation is density-independent and works in RTL by mirroring the movement. Bug: 1124720 Change-Id: I3d93a610c66404ac0cfa6db5b277b0b210a62250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411938Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#807472}
-
Reda Tawfik authored
This CL adds a search view to the bottom sheet and filters the credentials list with every newly typed character. Screenshot: https://bugs.chromium.org/p/chromium/issues/detail?id=1104132#c18 Bug: 1104132 Change-Id: Ib9528abcc8ffa3981f37fe3d7334156aa71ff0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391132 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#807471}
-
arthursonzogni authored
Soon, the reports will contains URLS about the other document: - openeeURL - openerURL - otherDocumentURL - referrer - initialPopupURL Depending on whether they are same-origin or cross-origin with the reporter document, they might be reported or not. This patch add a same-origin/cross-origin variant for every type of accesses. Bug: 1090273 Change-Id: Ieeb396f6220877a2a61541cb33a964261e5f4070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407314Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#807470}
-
Jose Dapena Paz authored
GCC fails to build with this: ../../pdf/thumbnail.cc:116:1: error: function ‘chrome_pdf::Thumbnail::Thumbnail(chrome_pdf::Thumbnail&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ 116 | Thumbnail::Thumbnail(Thumbnail&& other) noexcept = default; | ^~~~~~~~~ ../../pdf/thumbnail.cc:118:12: error: function ‘chrome_pdf::Thumbnail& chrome_pdf::Thumbnail::operator=(chrome_pdf::Thumbnail&&)’ defaulted on its redeclaration with an exception-specification that differs from the implicit exception-specification ‘’ 118 | Thumbnail& Thumbnail::operator=(Thumbnail&& other) noexcept = default; | ^~~~~~~~~ Problem is that Skia SkBitmap move constructor and assignment operators are not noexcept (and after some discussion it is going to be kept this way). So the default implementation of move constructor and assignment operator of pdf::Thumbnail is noexcept, as SkBitmap is a member. The fix just removes noexcept declarations. Bug: 819294 Change-Id: I8e6d914e4850707fbfcb51200b2a80d185cd1c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411656Reviewed-by:Jochen Eisinger <jochen@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#807469}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/5453e7b7795f..3018d5e57091 2020-09-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from e59713d4edda to f105898a102f (6 revisions) 2020-09-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 726af6f78f80 to e8ce4355ae1c (9 revisions) 2020-09-16 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from dc552fcef1fe to b33e0b36a08c (6 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: Id26dbefab6a7f2840d4e644edac3a93ca35c613e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807468}
-
Alex Ilin authored
Avatars displayed in webUI should have their size multiplied by the device scale factor. Otherwise, the avatars look blurry when Chrome is running with device scale factor > 1. Fixed: 1128102 Change-Id: I9a3f5e38b5bf9e8c14889bbef619f2a6eae565b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413948 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#807467}
-
Elly Fong-Jones authored
This reverts commit 8bb77f95. Reason for revert: not a proper fix per mark's comments Original change's description: > base: extend ImmediateCrashTest.ExpectedOpcodeSequence for mac arm64 > > This test needs a case for what clang does on Mac Arm64, so add that. > > Bug: 1128436,1121871 > Change-Id: I5d57f99f7d041bc91d9fc862c1d10ddc1b48f540 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412552 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807243} TBR=ellyjones@chromium.org,thakis@chromium.org Change-Id: I32e706cd2544cd91974a39dc37f54438fe6822c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128436 Bug: 1121871 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413562Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#807466}
-
Hazem Ashmawy authored
Add tests for the different testable scenarios where the dev UI is launched from a WebView package that is different from the current system provider. Fixed: 1128628 Test: run_webview_instrumentation_test_apk -f "*android_webview.devui*" Change-Id: I5c59d2351fbb1ec10fb11919fada1a953c39070a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411984 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#807465}
-
Stephen Nusko authored
This reverts commit f4886cba. Reason for revert: This causes unintended throttling of TouchMoves if the page is at the overflow already. Fix will land in next release. See crbug/1123304 for details. Original change's description: > Ensure that TouchEvents are always async after scrolling has started. > > Currently we can flip flop back and forth between TouchMoves being sent > async or sync which can cause some pretty noticeable cases of jank. This > ensures that we are always consistently scrolling after deciding > TouchMoves can be async. > > Bug: 1072364 > Change-Id: I3ef1ed6715d4b1fd2d3e1377ebd6b0c8bcc02872 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182426 > Commit-Queue: Stephen Nusko <nuskos@chromium.org> > Auto-Submit: Stephen Nusko <nuskos@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#776487} TBR=bokan@chromium.org,nuskos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1072364,1123304 Change-Id: I7645aa130ddaf5214bde77a8cbcdd239e48f729c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413491 Auto-Submit: Stephen Nusko <nuskos@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#807464}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b09e7729..49c0daeb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I10372035655d28c09fa64019c60725d1670adc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414012Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807463}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I3d05a5636400c1b1333ee8384403f80f1bbe4c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414149Reviewed-by:
-
Nazerke Kalidolda authored
This reverts commit 05a62e89. Reason for revert: causes regression (crbug.com/1128292) Original change's description: > [ios] UI Polish Omnibox - Badges in the Location bar. > > Current behaviour: > The animation to enter fullscreen makes the Incognito badge next to the > security icon appear as if it comes from the left. The animation to enter > fullscreen makes icons on the far right (Share icon/ Mic icon) and left > (Message badge/ Incognito badge) move towards the center before fading out > completely. > > Intended behaviour: > There should be no x translation, when the Incognito badge appears, but > instead it should start animating from a scale of 0, while maintaining > the current fade behaviour. The icon should not move towards the centre, > but instead combine the current fadeout with a scale translation > towards 0. > > Bug: none. > Change-Id: Ie4b4c6844aa0618366d16bacb5b29adc26e8e03e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336837 > Commit-Queue: Nazerke Kalidolda <nazerke@google.com> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797237} TBR=stkhapugin@chromium.org,nazerke@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I54e05a062d4c5c7677145c24bd8581966b3ccf26 Fixed: 1128292. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414229Reviewed-by:
-
Jamie Madill authored
The original argument is needed by WebRTC. Bug: angleproject:3162 Bug: 931731 Change-Id: I98c8dbb054ce5cd3c989c8fdd55195e4cf4a7c69 Cq-Do-Not-Cancel-Tryjobs: true Tbr: dpranke@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412371Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#807460}
-
Renato Silva authored
Replace future_on with supported_on since the feature is ready. Bug: 663982 Change-Id: Iacf856f105eb9e95baa0df3387db595b0627ce6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410043 Commit-Queue: Renato Silva <rrsilva@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807459}
-
Jonathan Wright authored
https://chromium.googlesource.com/chromium/deps/libjpeg_turbo.git/+log/8ca19625de30..d5148db386ce $ git log 8ca19625d..d5148db38 --date=short --no-merges --format='%ad %ae %s' 2020-09-09 jdapena GCC: fix NEON type casts 2020-07-02 jonathan.wright Implement accurate DCT using Arm NEON intrinsics 2020-09-11 hidehiko Expand is_linux to is_linux || is_chromeos. Created with: roll-dep src/third_party/libjpeg_turbo Bug: 922430 Change-Id: Ibae73477f7aa156f4722a5eea3bf4554d71ad844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412734Reviewed-by:
Leon Scroggins <scroggo@google.com> Commit-Queue: Jonathan Wright <jonathan.wright@arm.com> Cr-Commit-Position: refs/heads/master@{#807458}
-
Javier Fernández García-Boente authored
This is a reland of 1cb4c9a7 Rebaselined a few tests for mac 10.14 and 10.15. Original change's description: > New TextBreakIterator's default behavior breaks after space run > > Before this change, we were considering breaking opportunities before > space runs. This approach allowed us to avoid re-shaping in many cases, > which has an important advantage in terms of performance. > > However, the Unicode spec (UAX#14) state that breaking before a space > character is not allowed [1], so we had to implement this logic after > our TextBreakIterator had already determined the best breaking > opportunity. This approach has been working fine so far for regular > spaces (white-space, tabs, ...), but it doesn't work correctly for > other BA [2] class characters; in the CSS Text specification, these are > known as "other space separators" [3]. > > In order to implement the correct behavior for any kind of space, we > would need to change our TextBreakIterator implementation so that > matches the Unicode rules, considering breaking opportunity after > space runs. This change should also consider the performance impact > of the extra re-shaping operations required to deal with trailing > spaces. > > In order to prevent performance regressions, we'll store the position > of the 'end of non-hangable run', which will be used in case of items > with styles dictating rules to collapse trailing spaces. > > [1] https://unicode-org.atlassian.net/browse/ICU-20843 > [2] https://www.unicode.org/reports/tr14/tr14-39.html#BA > [3] https://drafts.csswg.org/css-text-3/#other-space-separators > > Change-Id: Ie4a3890c75a3faff1a0155d4a40bcaa85bc6ac06 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047943 > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806928} Change-Id: I9b5204f0b2e49367ab7d7a2107900763844fd2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412307 Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#807457}
-
Jose Dapena Paz authored
GNU libstdc++ std::vector explicitely forbids creating an std::vector of const types. Though, recent changes in FidoDeviceAuthenticator added two usages of them. This fixes it just removing the const for the contained type. Bug: 957519 Change-Id: I55dde64617704707d0a4edb36fc676a2ee5409ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412137 Commit-Queue: José Dapena Paz <jose.dapena@lge.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#807456}
-
Friedrich Horschig authored
The updated specs require a 80dp scroll shadow to give a stronger hint that the bar is scrollable. Screenshots before/after are linked in the bug. Bug: 1124722 Change-Id: I94dffc2b9375816997cae6c8492c21094a487f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410134Reviewed-by:
-
Stephen Nusko authored
For example for AcceptOnProxyThread and AcceptSyncMessage both would show up in a trace as a single slice just saying it was posted from Accept() in the ipc_mojo_bootstrap.cc file. However you couldn't tell if it was Sync or OnProxy and what mojom interface was being run. These trace events illuminate these facts. Fix some minor formatting issues in simple watcher since I noticed it and this CL isn't large Bug: internal b/162939995 Change-Id: I2925e6c11dfc3bb2bb8e67bf6aa1ff2bf4037890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377926Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#807454}
-
Victor Hugo Vianna Silva authored
AndroidSyncSettings exposes a few test methods that take a callback as a parameter, so it is possible to wait for an account update operation to finish. Before this CL, the callback was passed a boolean representing whether syncability was changed. This boolean return value was being used by a single test and can be queried in other ways, so this CL converts the callback into a closure. Apart from this, the CL also: - Adds inline initialization for some members in the test fixture. - Simplifies the waiting mechanism so that individual tests don't have to refer to CallbackHelper directly. - Replaces android.os.StrictMode with org.chromium.base.StrictModeContext in AndroidSyncSettings, which uses a simpler try-with syntax and is already used by some parts of the class. Bug: None Change-Id: Ie7909eba57e171569fc565a02f2ed8afc487e285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410390Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#807453}
-
Jose Dapena Paz authored
In the method to assign a CrossThreadWeakPersistent<U> to a CrossThreadPersistent<T>, there is a call to the parent class implementation of Get. It uses Parent, that is, in CrossThreadPersistent<T> an alias to its parent. GCC resolves it as that, but that's wrong, and it should resolve to the parent of CrossThreadWeakPersistent<U>. To avoid the problem, we define in that method ParentU resolving to the right parent, and use a static cast to it. Bug: 819294 Change-Id: I0152dac92d4a28eb1f1abbc56473204b62f33797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412138Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#807452}
-
Mohamed Heikal authored
third_party/gvr-android-sdk:controller_test_api_java has errprone annotations that conflict with the doubledown rolled version of material design. Exclude from jar. Bug: 1110346 Change-Id: I7580aed9bc4aff65893f7cf7e65c5e925c70f555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412638 Auto-Submit: Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#807451}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/588efd970283..b87e7b7d3b0b 2020-09-16 changhaohan@chromium.org TypeScriptify elements/MetricsSidebarPane.js 2020-09-16 yangguo@chromium.org Fix corner case in sortAndMergeRanges If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1093296 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I802f39fca7eb6aacf9e4590d2ffcf1b9631c9b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412445Reviewed-by:
-
Liquan (Max) Gu authored
Purpose: In order to compute merchantSupportsBasicCard(), the business logic , in //components, I am moving it from AutofillPaymentAppFactory into BasicCardUtils, and move BasicCardUtils into //components. Bug: 1106563 Change-Id: Ie245648b585dea807c28bb0029388286cc1398b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407238 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#807449}
-
Benoit Lize authored
Bug: 1029320 Change-Id: Ia58e3c4c381fe34922888fb5d7cbb4282ccafda3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412293 Commit-Queue: Benoit L <lizeb@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#807448}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600192792-36de61e8f764b4ecaec9d88047348ce6694afdaf.profdata to chrome-linux-master-1600257341-cdcb93ba007df24b60057506da5b299c67d8a739.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ib8eaaa1c0585cf998c4f600ede382a3891bb800a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414151Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5e931ebb24fb..38f0f40310d6 2020-09-16 treehugger-gerrit@google.com Merge "Fix broken default query." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I943df1513159462ec6c1f62ea980cc234e563e26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412442Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b10d4a612b87..08574aeb4454 2020-09-16 mbonadei@webrtc.org Revert "Reland "Switch from "rtc_ios_xctest_test" to "rtc_test"."" 2020-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision dfb9023b..1519d2c4 (807259:807375) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I20d45f2c79abf690bb4caee7eac4749af1abe764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412440Reviewed-by:
-
Mohamed Amir Yosef authored
Before this patch: PasswordReuseDetectorConsumer has only one method OnReuseFound() which is invoked when there a reuse is found. When no password reuse is found, the consumer isn't informed. After this patch: PasswordReuseDetectorConsumer now has a method OnReuseCheckDone() that gets invoked whether a password reuse is found or not. A new parameter is added |is_reuse_found| to indicate whether a password reuse is found or not. This change is necessary to support password reuse check for both the profile and account store since it gives the consumer a clue when both\ stores have responded and it's possible to start processing the data. Bug: 1119286 Change-Id: Iab6fcc01a7dc27e3c8a478c7e5d6e62805c0c76a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410248 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Reilly Grant authored
This disables the macOS Core Location backend when running tests which are meant to exercise NetworkLocationProvider. Bug: 1051591 Change-Id: I0bbf10b9852e165b5eea2ceb9185adbca2eda1b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413247 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#807443}
-
Alice Wang authored
This CL adds AccountConsistencyPromoAction metric for the web sign-in flow. Bug: 1120334 Change-Id: Ib75a28808a1ebaf963fe4e2ef038662b4f3ec4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404848 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807442}
-
Swapnil authored
ForceInstalledMetrics::ReportMetrics is a large method and it would be good to break it down into smaller sub-methods. This CL adds a new method to report current stage for force installed extensions which are in progress of installation. Bug: 1127901 Change-Id: Ia55903f4db71be268ca2cfc2b5a57cb086aa6399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410398 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#807441}
-
Victor Hugo Vianna Silva authored
Flipping the condition to refer to exception thrown by its branch makes the method more readable. Bug: None Change-Id: I7b7d0bff7f9a43cc2664ee0f31d5a25767439ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414035Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#807440}
-
Rune Lillesveen authored
When trying to add ColorScheme to a mojo struct sent between frames, presubmit reported dependency errors between common and platform. Move ColorScheme type from blink/public/platform to blink/public/common/css where also the ForcedColors enum lives. Bug: 1058822 Change-Id: I684847d406b47cf0d4f323eb8bce1e239e53a9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410238Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#807439}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2595f13f7e0c..5c4c28f111eb 2020-09-16 tikuta@chromium.org [recipes] remove is_luci specification 2020-09-16 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-16 tandrii@chromium.org tandrii: switch OWNERS to @google.com account. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1128847 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I3a47cbc423c71f10d41758f786a964189ca5330d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412438Reviewed-by:
-
Frédéric Wang authored
This was reverted because the frac-1 test is failing on all windows platform not just Win10. Original change's description: > Revert "[mathml] Use post.underlineThickness for the default fraction rulethickness" > > This reverts commit d01e1075. > > Reason for revert: <breaks win7 bots - https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%281%29> > > Original change's description: > > [mathml] Use post.underlineThickness for the default fraction rulethickness > > > > MathML Core currently defines fallback values to use when no MATH table > > is available. This CL performs the remaining work to ensure fractions > > align with the specification. It also adds WPT test to check these > > fraction fallback parameters, although testing them extensively is > > difficult. > > > > Bug: 6606, 1058369 > > Change-Id: Ic916c0c4b925674d526d78989988e57d8735bf4e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410384 > > Commit-Queue: Frédéric Wang <fwang@igalia.com> > > Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#807083} > > TBR=ikilpatrick@chromium.org,fwang@igalia.com,rbuis@igalia.com > > Change-Id: Ia8857539d69bbbafda2be5501ac1b766488be77d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 6606 > Bug: 1058369 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412750 > Reviewed-by: David Bienvenu <davidbienvenu@google.com> > Commit-Queue: David Bienvenu <davidbienvenu@google.com> > Cr-Commit-Position: refs/heads/master@{#807144} Bug: 6606, 1058369 Change-Id: I2fefb18b84c9604fcd40a013617a51aeadf56602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414029Reviewed-by:
Rob Buis <rbuis@igalia.com> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#807437}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I4816ad77f817026030d89c91efb9cb8977e23d99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412439Reviewed-by:
-
Saurabh Nijhara authored
The policy value creation login is currently duplicated in the tests that need to set DeviceMinimumVersion policy. This CL extract that logic along with other common elements into a test helper class that could be used by multiple test classes. This test helper class would also be useful when the update required notification unit tests are extracted into a separate unit test class which should be placed closer to c/b/chromeos/ui/update_required_notification.cc. Bug: 1128413 Change-Id: I0952c9c4f99af348e6de40154b57cf2a777ef07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410255 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#807435}
-
Henrik Boström authored
This function is only used by video_capture_device_avfoundation_mac.h and unittest. By moving this to the modern capture implementation, it makes sense to not longer take "Class implementation" as argument. This function now only works with the intended implementation. Bug: chromium:1124647 Change-Id: Ia3a3802ddd523fd6501f00333e0fbaf7e9a5956b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410035 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Cr-Commit-Position: refs/heads/master@{#807434}
-
