- 10 Nov, 2020 40 commits
-
-
Antonio Gomes authored
.. window_properties.h. Also kFrameInactiveColorKey. This is the last step before moving default_frame_header.cc|h to //chromeos/ui/frame/. BUG=1113900 R=jamescook@chromium.org TBR=oshima@chromium.org Change-Id: I2355f497bd94a9569d9a35ff3f95c70c436201cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521114 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#825811}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I7c2726770e4364b6c2ebd716f61d0a7d4d6fc346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529170Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825810}
-
Zhenyao Mo authored
BUG=1117185 TEST=bots Change-Id: If904ab785166485812438a9bc2f2bedf16fec2aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525853 Auto-Submit: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#825809}
-
Marc Treib authored
The existing versions of these histograms (without "2") are recorded for all users, whether they're opted in to the account-scoped store or not, so they contain a lot of useless entries. The new version "2" histograms are only recorded for opted-in users. The old histograms are *not* deprecated yet, in case we want to compare some numbers from M87 (which only has the old versions) with numbers from later Chrome versions. Bug: 1145971 Change-Id: I633769d4b77fbefef17014d613b83a45c3580b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526064 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#825808}
-
Olle Liljenzin authored
We see an increased number of crashes caused by uncaught exceptions indicating the camera was used after release. The reported crash is also reproducible on one of our test devices by opening certain chat pages in the Opera browser. Using the camera after release() was called is an error, but this would still happen if Camera#getParameters() fails with an exception because we would then call release() without nulling the reference to the released camera instance. Later on we will use the released instance to close the camera preview, causing a new exception that will crash the browser as it is not caught. This change fixes the use-after-release crash by nulling the camera reference after a failure, to prevent any further usage after the camera was released. Bug: 1125083 Change-Id: Ibbf3099636f3e25692fae4799255d04f2cfd4e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527138Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Markus Handell <handellm@google.com> Commit-Queue: Olle Liljenzin <ollel@opera.com> Cr-Commit-Position: refs/heads/master@{#825807}
-
Sigurdur Asgeirsson authored
Replace ScopedObserver with base::ScopedObservation in /content/browser/site_per_process_browsertest.cc. ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=kenrb@chromium.org Bug: 1145565 Change-Id: I2f7b5f2f7892d2ffa57f5e964e0427842698c90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526166Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825806}
-
Shakti Sahu authored
This CL adds : 1 - Show a context menu item for Read later 2 - A New label to be shown until user clicks on the menu item Bug: 1145825 Change-Id: Ie0ccb1d56a76d3e6bf6ae38075d0a7bcbba6a6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520278 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825805}
-
arthursonzogni authored
Previous patch removed functions non referenced by a caller: https://chromium-review.googlesource.com/c/chromium/src/+/2523114 Pulling the string further, this caused more functions not to have a any callers, which are removed here. Bug: 1146469 Change-Id: Ic82c95c07523d10e6d88d45ea2fa392562f05501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521190 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#825804}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604966213-470516c2fd4e526d214b1511f3d83ecfab2ce340.profdata to chrome-linux-master-1605009236-ea4b3e0cf6b6eb37089f063eb3b9762bfdc69494.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6aad459037da3c455f6d32726d3f101a61264510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529173Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4e32eb5788c..090c3b6d15c4 2020-11-10 sigurds@chromium.org Remove deepElementFrom{Event,Point} from prototypes 2020-11-10 aerotwist@chromium.org [unit test] Remap Elements tests to use entrypoint 2020-11-10 tvanderlippe@chromium.org Typecheck lighthouse/LighthouseReportRenderer.js with TypeScript 2020-11-10 tvanderlippe@chromium.org Typecheck timeline/EventsTimelineTreeView.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I1f088e43d14c68db6749e537fd147cefaee055b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528207Reviewed-by:
-
Rakina Zata Amni authored
We're seeing some OOMs and want to investigate what's happening. Bug: 1147081 Change-Id: I9101462643783ea2e6fac50357b2c4043c8c808c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528556 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#825801}
-
Yutaka Hirano authored
This CL introduces ReadableTransferringOptimizer and WritableTransferringOptimizer for the Transferable Streams optimization described in the following design doc. https://docs.google.com/document/d/19WpamKCysWHYGA6jIrlwZIYxhBrsHCDHYNd98Zl1u5w This CL doesn't change the behavior. Bug: 1146396 Change-Id: If19841e27594fa43442f24805e380b23bb0abb67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522805Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#825800}
-
Maria Kazinova authored
Previously it was possible to generate a password on a password field outside the form tag but it was not filled, since formless fields were ignored in this flow. This CL fixes that. Bug: 1146005 Change-Id: I5bf6347c9666b6b7e4f1d796418597f27d5e8f86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527144Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#825799}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1604955437-61247d42a6140f126d61086b5421948904b6ffb0.profdata to chrome-win32-master-1604987499-d58c7c50ae14a2e4ca32a9270333a79aabab2447.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I69df425274f8405eb1818ecea1d2b9450039f6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528917Reviewed-by:
-
Torne (Richard Coles) authored
Don't take ownership fo the local ref returned by ANativeWindow_toSurface; just wrap it in a JavaParamRef to satisfy the interface temporarily. This is a speculative fix for the StrictMode crash; the introduction of this Adopt appears to be the only functional change in the culprit CL, so avoiding it might work; if so we can find a real solution afterward. Bug: 1146071 Change-Id: Ie817bfbfa7dc531b6e4ddacde42ee5c021948451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527563 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#825797}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/eba8b028ddbc..38f3d771bd8e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5f450872598e10a8d6b103cbc864a50844415a2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528618Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/139be0697741..c7c5d0ecc59d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hbos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1123216 Tbr: hbos@google.com Change-Id: I6072350a009840f75952db5dfdef893990c5b829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529169Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825795}
-
Polina Bondarenko authored
Add SnapshotHoursPolicyService to handle policy changes. BUG=b:170187468 TEST=components_unittests Change-Id: I1918d55d6e53b0085473f7bf650cf949767ed4b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514148Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Polina Bondarenko <pbond@chromium.org> Auto-Submit: Polina Bondarenko <pbond@chromium.org> Cr-Commit-Position: refs/heads/master@{#825794}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=falken@chromium.org Bug: 1145565 Change-Id: If3dc3daa800da2d45c6a10e7561862eeb1368bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526922 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825793}
-
Sylvain Defresne authored
Refactor in https://crrev.com/c/2498546 incorrectly used the same value for -rpath for both applications and application extensions. This caused the CPE extension to fail at runtime to load the ChromeSSOInternal dylib. Use the correct value for -rpath for the application extension. Bug: 1147070 Change-Id: Id46a33c99b77e44f1874680a27bb04f56a1f347e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529111 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825792}
-
Nico Weber authored
The bugs preventing this are now fixed. Bug: 1143946 Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng Change-Id: I043d209e3ec41b708a2834c4a904dea79f9ffeb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527884Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#825791}
-
Asami Doi authored
According to the spec, "Window clients and worker clients with a blob URL can inherit the active service worker of their creator document or owner". https://w3c.github.io/ServiceWorker/#control-and-use-worker-client In this CL, DedicatedWorker created from a blob URL inherits its creator document's ServiceWorkerContainerHost. The creator's ServiceWorkerContainerHost is stored in SWMainResourceHandleCore. A container host inherits a controller from creator's host in SWMainResourceLoaderInterceptor if the URL is a blob URL and the creator's host exists. Bug: 1017034 Change-Id: I07599794c3a49d91898caa18a4cbfe395754085d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409472Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#825790}
-
Alexander Surkov authored
Bug: 1133330 Change-Id: I9103d0116c5822a0f9dc291a7a87bd5f902a4efa AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519755 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#825789}
-
Sigurd Schneider authored
Bug: chromium:1057090 Change-Id: I0f405d987558016178fff710044e4a8657c470a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526346 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#825788}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1604966213-11b581102b343c7a1c3accf4f99e5d9072414c62.profdata to chrome-win64-master-1604987499-9d0e7b1f2ad8a8a8d61e84a818ba5c2f2988369e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I44b59e20f34ac241704e5b7152d8b2b102383b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528920Reviewed-by:
-
Kent Tamura authored
Currently it seems to result in invalid sticky state. Bug: 1128479, 1146925 Change-Id: I62f7b5519e2851d6d804be5937a8bded0a7985f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525468 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#825786}
-
Vasilii Sukhanov authored
Fixed: 1144810 Change-Id: Id1ab4f2860d7b6a0f68ddd1309d46619162a34dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521530Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825785}
-
Jan Wilken Dörrie authored
This change removes base::STLIsSorted and replaces existing usages with the equivalent base::ranges::is_sorted. TBR=dcheng Bug: None Change-Id: I2edbcdb7e27a95b42db31c5789c5891ca46c3e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526090 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825784}
-
Christoph Schwering authored
Sectioning was the last remaining user of AutofillField::unique_name(), which is the concatenation of FormFieldData::name, "_", and a form-scope counter. This CL replaces the latter with unique renderer IDs. Bug: 896689 Change-Id: I27bbabf03c3ae316c29b1b6c82c6739b94e73338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414237Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#825783}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I4e10a21c929e76850236506ad66789f6df3fa33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527696Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I03e1c461d4f3b548f90e87a3b846ce91b7798a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528954Reviewed-by:
-
Matt Jones authored
This patch adds the LayoutManager interface which extends the LayoutStateProvider to provide more functionality around adding components (SceneOverlays) on top of the visible layout. This interface adds the following methods - addSceneOverlay(...) - createCompositorModelChangeProcessor(...) The existing LayoutManager has been renamed to LayoutManagerImpl and should no longer be used by feature code. Bug: 1070281 Change-Id: I76839f056ace90b39f7f3008f438d94585d9e096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525849Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#825780}
-
Jason Lin authored
See the bugs for why we are doing this. Notes: * `tab_id` is removed. `TerminalPrivateAckOutputFunction::Run()` used to use `tab_id` to figure out whether it should actually acknowledge the output on the process --- it should only do so if the sender owns the terminal id. Now that we store the terminal id in the web contents, we don't need it anymore. * We change the signature of api `ackOutput`. It is not going to break anything because only `.../externs/terminal_private.js`, which is also updated in this CL, but not "libapps" is supposed to call it. * Potentially, we should kill the renderer if the validation fails, but we cannot do it for now because libapps might send a invalid ID before it receives a valid one. * `SetLastActiveTerminal()` is used for setting the CWD for a new terminal, but due to a bug, it has been effectively disabled. We don't want this CL to change the CWD behavior so we explicitly disable it here. We will soon have a follow up CL to deal with the CWD feature. Also see https://crbug.com/1113207. Fixed: 1145053, 1144625 Test: new browser tests, and manual tests Change-Id: I0f39c544a28e23df3aeefe98b626c2b94b973af7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519182Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Commit-Queue: Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#825779}
-
Manuel Rego Casasnovas authored
This patch stores a boolean instead of the NGConstraintSpace in NGOutOfFlowLayoutPart. That way container_space.HasBlockFragmentation() is only called once for each NGOutOfFlowLayoutPart element. BUG=1091797 Change-Id: I7cb19821e20503210d247e2167b7994308db7dea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526421 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825778}
-
Stephane Zermatten authored
Before this change, CheckOnTop would only check the current frame. While this could detect the case where an element covers the goal element, this did not detect the case where an element covers the iframe containing the element. With this change, CheckOnTop requires the target element as well as any iframe containing the target element to be on top (not covered by another element). Bug: b/171463353 Change-Id: I3d32fdff3cb55724fd096de18034e9b4e002cab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523172 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#825777}
-
Arthur Hemery authored
Correcting an inversed condition for recording isolated vs non isolated SharredArrayBuffer constructions. Bug: 1143191 Change-Id: Ibd51e5eb13a3228732c1dad34405101fe824eb40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527059Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#825776}
-
Ilya Nikolaevskiy authored
This replaces VideoFrameFeedback member in VideoFrame, which was used before to pass resource utilization to the capturer. The follow-up CL would decouple VideoFrameFeedback from media::VideoFrame. Bug: chromium:1134073 Change-Id: I55697a98c0c04d150dae70c53ddd9348f36c4038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495022 Commit-Queue: Ilya Nikolaevskiy <ilnik@chromium.org> Auto-Submit: Ilya Nikolaevskiy <ilnik@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825775}
-
Roman Aleksandrov authored
Bug: None Change-Id: I33f8caecc9123a377ded08c1ae5fba25d17e2955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521191Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bc5c4781..aee5f31f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie2bca10b907003d0ec372289342462db6559f071 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528923Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825773}
-
Alexander Surkov authored
Keep tree formatters generic. Each consumer defines filtering directives on its own: dumptest operaters with platform specific directives and dumptools have own directives. Keep directives logic in consumers AX-Relnotes: n/a Bug: 1133330 Change-Id: I411237bb0a5539bc2642ed29a013648acd003b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517542Reviewed-by:Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
