- 09 Dec, 2020 40 commits
-
-
Ben Wagner authored
This is a reland of 9c270678 Fixed invalid unit and improved the error message for an invalid unit. `./tools/perf/run_benchmark run webrtc --browser=system` passes locally on Mac. Original change's description: > Mark some WebRTC perf measurements as biggerIsBetter > > Change-Id: I95a145f0380b0f413a71ef5a9bbacf840eb20b9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577205 > Commit-Queue: John Chen <johnchen@chromium.org> > Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> > Reviewed-by: Mirko Bonadei <mbonadei@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834889} Change-Id: Id7220dafb11faab2cb3e28b36aed3c6a526575c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580072Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Ben Wagner aka dogben <benjaminwagner@google.com> Cr-Commit-Position: refs/heads/master@{#835200}
-
Thomas Lukaszewicz authored
This CL sets initial focus for the TaskManagerView dialog to |table_view_|. Currently this is set to nullptr and this means screen readers are unable to navigate the UI without first having to manually assign focus via the tab button. This change allows for screen readers to navigate the UI as soon as the dialog opens without needing to tab to assign focus. Bug: 1106544 Change-Id: I6f96b0ae024eee8e99d66f7a34c609d063e1cb36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580137Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#835199}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org, sebsg@chromium.org Bug: 1144462 Change-Id: I308ab745a5bfac1696be89e181b100d33db5d602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580026Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#835198}
-
Justin Donnelly authored
Bug: 1107581, 1056384 Change-Id: I2bad60bde8f5ccffeb7e63dedc22e123c74011ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580065Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#835197}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202012090600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ZueO-HxBTDWZN-HMbvrJcn0XYxqL_NdiiGI2U_5ui9IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/158963860,b/167637550,b/169112730,b/174421354 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia34e36225758d849b566acd5bd0d19e57c013fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581880Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835196}
-
Jeremy Roman authored
This was wrong but probably harmless (both because it has zero length and because it's in a NOTREACHED path), but was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2562819 Spotted by jdoerrie@ using bugprone-dangling-handle: https://docs.google.com/document/d/1LxxcYJSQGcc2dxdLAjpyZt6Rar00i_du7cfvX0UBtP4/edit Change-Id: I49722848a159bb8330362b5932199bff23cc476b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580086 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#835195}
-
edchin authored
This was originally created in Nov 2017 in this CL: https://chromium-review.googlesource.com/760036 This metric is no longer being used and has already expired since M77. Per go/histogram-expiry-guidelines: "If the histogram is not in use now, but might be useful in the far future, remove it." Change-Id: Ic8e899f850f8cea0774500eabe43e87f0aaf87d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581003 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#835194}
-
Mohsen Izadi authored
To be able to report main thread event dispatch breakdowns for EventLatency metrics, this CL adds relevant timestamps to cc::EventMetrics. The actual breakdowns will be added to UMAs and UKMs in follow-up CLs. Bug: 1054009 Change-Id: Ia78d2614d4a3e2e4e5de75e2305e16888acbeeb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568936Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#835193}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2523885b..7e546be6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I111ed178f0e22739afdc39f7297eb74ce363b65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581445Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835192}
-
Eugene But authored
There is a significant discrepancy between number of UKM records uploaded to google servers and numbder of UKM.LogSize.Success records. This either means that UMA data was not written to disk or that app was terminated after server received the data, but before UMA was recorded. Data loss caused by failure to write on disk is highly plausible if the app is running in the background. This CL adds another metric, which counts the number of times UKM.LogSize.Success is emitted. The counter is stored in NSUserDefaults (hence have higher chance to persist). The counter is recorded as UMA when the app starts or foregrounded, hence have higher changes to get written to disk. Bug: 1154678 Change-Id: Ifa71355e02f568713f9d87f45692ae70fd496b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576077 Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#835191}
-
kylechar authored
There is a bug where SkiaRenderer doesn't handle the nearest_neighbor flag set on quads correctly. If the quad is in a render pass that is bypassed then SkiaRenderer will draw the quad directly using a higher filter quality than nearest-neighbor. There can actually be two different scaling operations, one when the quad is copied into the render pass with nearest-neighbour scaling and the second when the render pass is copied into the framebuffer (or other another render pass) most likely with bilinear interpolation. If there are two scaling operations at different qualities, it's not going to be possible to bypass the render pass without changing the resulting pixels. To simplify things, don't bypass a render pass where the only quad specifies nearest-neighbour scaling. Bug: 1155338 Change-Id: If476bfb2ce027772aaa6a153ba108d341c354423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577706Reviewed-by:
Michael Ludwig <michaelludwig@google.com> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#835190}
-
Yi Gu authored
For privacy, metrics from inner frames are recorded with the top frame's origin. Given that WebOTP is supported in cross-origin iframes, it's better to indicate such information in the |Outcome| metrics to understand the impact and implications. e.g. does user decline more often if the API is used in an cross-origin iframe. UKM collection review: https://docs.google.com/document/d/12-cSbZ2_ztM4u2USo7cVBlZ5rIiQefkdGxz-XdQfa7Q/edit# Bug: 1136506, 1127397 Change-Id: I08d9f720ab8b3832bb47d1fb3575ef7093d8fc57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576588Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835189}
-
Mirko Bonadei authored
TBR=jansson@chromium.org Bug: 1033483 Change-Id: I8c13d4c5be855176d0ce2efa5d36d0d7ab758161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579968 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#835188}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bb1a28de3cf1..d7808f1c464a 2020-12-08 landrey@webrtc.org Add DVQA support for scenarios with new participants joining 2020-12-08 alessiob@webrtc.org RNN VAD: GRU layer optimized 2020-12-08 philipp.hancke@googlemail.com sdp: log unhandled lines at LS_VERBOSE level 2020-12-08 gustaf@webrtc.org AEC3: Prevent diverging coarse filter from influencing the refined filter 2020-12-08 kron@webrtc.org Change LS_ERROR to LS_WARNING for unsupported decoder formats 2020-12-08 phancke@nvidia.com use [35,65] rtp payload type range for new codecs 2020-12-08 hta@webrtc.org Don't log errors on a=rtcp lines 2020-12-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3d828369..2be5b61c (834461:834670) 2020-12-08 henrika@webrtc.org Removes spammy SDP log 2020-12-08 peah@webrtc.org Make the static variable kChunkSizeMs constexpr 2020-12-08 philipel@webrtc.org Clean up RtpVp9RefFinder unittests. 2020-12-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision eb89725d..3d828369 (834328:834461) 2020-12-07 hta@webrtc.org Stop threadjumping to get RTP transport in channel.cc 2020-12-07 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c24aab83..eb89725d (834189:834328) 2020-12-07 phancke@nvidia.com allow dynamic payload types <= 95 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1155477 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie20f4b1daf046a350b4543cf74096d27f4477e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580000Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835187}
-
Roman Sorokin authored
This CL introduces new screen which extracts locale from identity manager for Gaia users. For public session users it gets locale from the prefs which is set by locale chosen in the login pod. The screen switches the system language and reloads OOBE strings. This is done right after the login (Gaia or public session pod). Bug: 1141289 Change-Id: I235598b5524a1983336980301c4c9ab2833562ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523206Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#835186}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I6c7b0a25ff78e651f32fbaa2fb32afdc8c92a453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581402Reviewed-by:
-
Nohemi Fernandez authored
Because MockSyncSetupService is defined within the iOS libraries we can define a static initializer that constructs a KeyedService using the BrowserState. This will reduce the overhead for adding Sync services to tests in iOS. Bug: N/A Change-Id: Ia142c70ebc605029c8677285f994151a1e1bc961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575029Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#835184}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b1f0d11f4233..34e5f31b2cb0 2020-12-09 alexrudenko@chromium.org Click on a tree element to make sure the element is focused If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5aa69733ca57ec5ab319ee51f1ab8263b9fccb33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581416Reviewed-by:
-
Rodney Ding authored
Bug: 1124361 Change-Id: I3a901dc1f77e59783406043a7bded2c983e9b6d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542597 Commit-Queue: Rodney Ding <rodneyding@google.com> Reviewed-by:
Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#835182}
-
Alexander Surkov authored
mac tree formatter class Bug: 1133330 Change-Id: I826a1844302e294d7f1758fd078d467574749d63 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568988 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835181}
-
Dominic Mazzoni authored
I wanted to see those to compare against the colindex: and rowindex: attributes (which expose ARIA only) but they weren't being printed. No actual bug here, just adding a bit of test coverage. Bug: 1078623 Change-Id: I1e4079b61adf7c5d0e0f8b3320e05cae930a0db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580443 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#835180}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/016711efbb5d..d19d663924f1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: Ie15928a4ca5aca3e07f4c24ff8de03ea175f668c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581414Reviewed-by:
-
Guido Urdaneta authored
When the promise of a getUserMedia() call is settled, it can result in the detachment of the execution context. The idenfiability metrics for getUserMedia() require a valid execution context and therefore should run before the getUserMedia() call ends. Bug: 1156510 Change-Id: I29975c9d779858b1574506f5d60ecfe4ae6a1690 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580070 Auto-Submit: Guido Urdaneta <guidou@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#835178}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607493425-af0aa6c36468b9d0e6f03a33932dae6d4017f80e.profdata to chrome-mac-master-1607515179-092361bc7a185424dad74bccdfea645817af1d61.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4a1f73e54f5a5c7eae2dfc0912ead8004840a97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581415Reviewed-by:
-
Omar Morsi authored
Bug: 1148294 Change-Id: I24ab19370a6453b464d453284d216fd062da2006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550798 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#835176}
-
Nektarios Paisios authored
We should not be returning a text marker range with NULL AXPositions whenever there is nothing selected on the webpage. Instead, like with all other text marker related attributes, we should return nil. Returning an AXRange with NULL AXPosition objects, makes VoiceOver hold onto and try to utilize NULL AXPositions in later API calls. Such API calls inevitably fail due to the fact that they are correctly considered invalid by our AXTextMarker deserialization logic. AX-Relnotes: n/a. R=abigailbklein@google.com, dmazzoni@chromium.org Change-Id: Iafa561e21f44a44deca4b5fa1e1d83ced02f1cd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581298 Auto-Submit: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
-
Antonio Sartori authored
A Web Platform Test was failing because it was missing the 'sub' suffix in the file name, so template substitution was not performed by the web platform http server. This change fixes that. Bug: 1021462,1149272 Change-Id: Ic665aab61912002edf6a1cbfded4ff1ca3340c46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577778 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#835174}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607493425-c73fec691091cf0b277c9f5003730e7d0a079735.profdata to chrome-linux-master-1607515179-f1c33f017a68d1555043f7e4b5e6f959b5d2d5d2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I95dc91cbc47250e0a8eb1c6f9e0bdd6f04e96340 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581412Reviewed-by:
-
Bill Budge authored
- Adds a new feature that turns off SharedArrayBuffer and WebAssemblyThreads features, so developers can more easily test sites with SABs and COOP+COEP site isolation restrictions. Bug: chromium:923807 Change-Id: I76984b13e1994c297a6d3811abe0fefa6f1b6530 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579721Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#835172}
-
Alex Ilin authored
Some assistive technologies don't handle correctly the case of one button nested inside of another one. This is the case for the profile-card-menu button that is nested inside of the profile-card button. This CL puts those buttons next to each other in DOM as siblings which fixes the problem. Bug: 1156067 Change-Id: I9342f0608231a7cf3f1a6d6329eb213118c82084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580800 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#835171}
-
Anastasiia N authored
Add kInlineLoginWelcomePageSkipped pref and don't show welcome page if the pref is set to true. Test: browser_tests --gtest_filter="*InlineLoginBrowserTest*" Test: browser_tests --gtest_filter="*InlineLoginWelcomePageBrowserTest*" Bug: 1144114 Change-Id: I4c153a1d7410390e708ed81d0b6e62dc9729db24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549226 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#835170}
-
Victor Vianna authored
This reverts commit c547b0cd. Reason for revert: We wish to merge a fix for this logic back to M88. Let's fix the logic and only then fork the method. Original change's description: > Fork SyncController.isSyncingUrlsWithKeystorePassphrase() in PSS > > SyncController will soon disappear, so we start moving this method to > ProfileSyncService. The SyncController method is still exposed for the > moment because it's called in downstream code. > > There should be no behavior change in the only call site: > SyncController.get() is null iff ProfileSyncService.get() is null. > > Bug: 1156620 > Change-Id: Ida792cb92702f932aad3023d05e048be8aee94e8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577227 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Victor Vianna <victorvianna@google.com> > Cr-Commit-Position: refs/heads/master@{#834745} TBR=treib@chromium.org,victorvianna@google.com,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ied87d4f89b58db0dc286eab80c345711654c67d1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1156620 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581483Reviewed-by:
Victor Vianna <victorvianna@google.com> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#835169}
-
Artem Vazhinskiy authored
This CL returns change from https://codereview.chromium.org/214603010 which was reverted at https://codereview.chromium.org/426713002. Without this change user input to omnibox is not recognized as a "user-gesture-triggered" event in terms of handling of external protocol URLs. So, HistoryURLProvider will not provide URL_WHAT_YOU_TYPED result for URLs with external protocol until the user performs some action on the page. Although the omnibox input should also be considered as a user action. Bug: 1143632 Change-Id: I0b70fe641e3a28dc4c9570b037487ca68de2d19a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2479166 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#835168}
-
Tim van der Lippe authored
These are replaced by Karma tests in https://crrev.com/c/2577572 R=aerotwist@chromium.org Bug: 1024752 Change-Id: I6faf792691cdfc0bd9aa657c3be0e6b159f254f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577473 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#835167}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d57b1168772..b1f0d11f4233 2020-12-09 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I473b159c22da0de6a999f288614f60692128dcd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2581408Reviewed-by:
-
Juanmi Huertas authored
This CL tries to optimize the Offscreencanvas usage in WebGL. It will try to create a new CanvasResource that will receive mailbox, sync_token and the destruction callback for a resource. The idea is to try and let the compositor access the ExternalCanvasResource that will contain all the relevant data to render the frame, and then send it back to the WebGL part. Even though I plan to move it to smaller CLs, currently, this CL adds a new RGBX format to be processed inside CanvasColorParams. Once this CL works and it makes sense I will submit this other CL first https://chromium-review.googlesource.com/c/chromium/src/+/2567978 Bug: 998951 Change-Id: Ib2d178cf489007357b7861f9ed27af1fc2a22da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535012 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#835165}
-
Yoav Weiss authored
This CL adds a test that verifies that empty iframes correctly create a Resource Timing entry. Bug: 933858 Change-Id: I1d5ae7d8c0fe5fb60ebcf92ebd8f4a51e5fd1d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580069Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/516d20deb974..016711efbb5d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tnagel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tnagel@google.com Change-Id: I269a07109d188b2fb4eab3add271e34625527d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580553Reviewed-by:
-
Philipp Hancke authored
Deactivate the rtp-payloadtype WPT to allow the fix to roll in. Reactivate the rtp-demuxing WPT. BUG=None Change-Id: I776cbc388596a242f376de03747f4cf216d2ca93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580806Reviewed-by:
-
Anastasiia N authored
Bug: 1148246 Change-Id: Ic08ea92381fb8a5c60945380ca508b649af461ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563299 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#835161}
-
