- 08 Oct, 2018 40 commits
-
-
Roman Sorokin authored
Also capitalized MACHINE_NAME placeholder for NativePrinters BUG=chromium:875876 Change-Id: I0270db0e970665db155248d75db54da353bd8720 Reviewed-on: https://chromium-review.googlesource.com/c/1245792Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#597547}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9fcb424b..d42baee1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id402e8ea8c8fcd65f8234899137c3559f88f1499 Reviewed-on: https://chromium-review.googlesource.com/c/1267825Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597546}
-
Greg Daniel authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I67e0f6017e84d964af316cef1f912dd58d050ce4 Reviewed-on: https://chromium-review.googlesource.com/c/1264922Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Greg Daniel <egdaniel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597545}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /content/browser. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=boliu@chromium.org, mkwst@chromium.org Bug: 890902 Change-Id: I06146497aa7a8cba7516eb17497ca33454141b2a Reviewed-on: https://chromium-review.googlesource.com/c/1257909Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#597544}
-
Manuel Rego Casasnovas authored
The method LayoutBoxModelObject::RelativePositionOffset() was not considering the case of grid items, where the containing block is the grid area. The patch modifies the method so the new code uses OverrideContainingBlockContentLogicalWidth|Height when required. Two new tests are added, the first one does not use percentages and is already passing. The second one has the very same output but using percentages which was not working before this patch. BUG=835607 TEST=external/wpt/css/css-grid/grid-items/grid-items-relative-offsets-001.html TEST=external/wpt/css/css-grid/grid-items/grid-items-relative-offsets-002.html Change-Id: Icb76f4a521566ad36f87924835b21ae450f2cb24 Reviewed-on: https://chromium-review.googlesource.com/c/1238726Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#597543}
-
Noel Gordon authored
The FilesApp QuickView PDF browser test crashes the MSAN bot. Disable the test in MSAN. Tbr: slangley, lucmult No-Presubmit: true Bug: 768070,891150 Change-Id: I262418dd3b79df11824810c42749cd1b6d78edee Reviewed-on: https://chromium-review.googlesource.com/c/1267597Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#597542}
-
Morten Stenshorne authored
NG needs to produce a rectangle with the block-axis offset relatively to block-start of the container, just like legacy does. Using purely physical coordinates is wrong. This fixes issues with scroll anchoring, and possibly other things too. One test had to be rebaselined, due to a rounding change. LayoutText::DebugRect() calls LinesBoundingBox(), which now flips the block-axis coordinate for vertical-rl. This affects rounding of the size of the rectangle. Bug: 889449 Change-Id: I7053ed7fe05ce443f53a128660d60f27fea7f8b3 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1264596 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597541}
-
Douglas Creager authored
This will allow us to add a new implementation that uses data_decoder to safely parse the untrusted JSON headers in a utility process. This patch just adds the new delegate interface and a default implementation that provides the existing behavior of parsing in-process. Bug: 892148, 811485 Change-Id: Ida8027ce44163c7f35535a3327343b7bf94ea854 Reviewed-on: https://chromium-review.googlesource.com/c/1262595 Commit-Queue: Douglas Creager <dcreager@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#597540}
-
Marc Treib authored
This is done for two reasons: 1) It'll allow us to move a Wallet-specific special case from the general datatype-agnostic code into the Wallet-specific controller (once that exists). 2) It's actually less misleading: Directory data types actually ignore this value, i.e. passing CLEAR_METADATA didn't actually clear data for them. Bug: 889941 Change-Id: I4e660e41b17142480eb8b03569077686cedaab6c Reviewed-on: https://chromium-review.googlesource.com/c/1264695Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#597539}
-
Christopher Lam authored
This CL hides the location bar for System PWAs. It also plumbs better bookmark app manifest validation into ExtensionBrowserTest. Bug: 836128 Change-Id: Ife1ec3962edd57a0f5ea7c44ff359894a9d0d7cf Reviewed-on: https://chromium-review.googlesource.com/c/1256467 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#597538}
-
Michael van Ouwerkerk authored
This reflects the implementation of setTopBarView. Bug: 882404 Change-Id: I0c4b39e3db96dd626f2207b87fa0c4a1dd4ecfa2 Reviewed-on: https://chromium-review.googlesource.com/c/1267501Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#597537}
-
Boris Sazonov authored
Before this CL, asynchronous methods in AccountManagerFacade were using AsyncTask to avoid blocking the main thread if account list cache hasn't been populated yet. However, this approach has two major drawbacks: 1. Every call to these methods blocks one thread from thread pool until the cache is populated. 2. Even if the cache is already populated, call still creates AsyncTask, incurring unnecessary allocations and thread hops. This CL introduces AccountManagerFacade.runAfterCacheIsPopulated that keeps a list of callbacks to execute after the cache is populated. If the cache has already been populated, this method just posts the callback to the main thread. All asynchronous account-related methods in AccountManagerFacade are reimplemented using runAfterCacheIsPopulated. Bug: 887969 Change-Id: I856b6c7f9395a70857d079dedfbf3f4f6403f901 Reviewed-on: https://chromium-review.googlesource.com/c/1238559 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#597536}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I550b09fdfdd3b1a76cb28ddd582002a52e680991 Reviewed-on: https://chromium-review.googlesource.com/c/1264588Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#597535}
-
Morten Stenshorne authored
TBR=eae@chromium.org Bug: 892817 Change-Id: I5bf3d4caa0637863c329fffda7a8f27175256b12 Reviewed-on: https://chromium-review.googlesource.com/c/1268196Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#597534}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/38537edf5979..2e00abc98e59 git log 38537edf5979..2e00abc98e59 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 yvesg@webrtc.org Reland "[cleanup] Remove useless includes." 2018-10-08 nisse@webrtc.org Move EncodedImage class to api/video/ Created with: gclient setdep -r src/third_party/webrtc@2e00abc98e59 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I29cd4055efe8c6929f37f71d44549214713eb9f4 Reviewed-on: https://chromium-review.googlesource.com/c/1267684Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597533}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I7dd274d816f8833bdabe890628b92f701612ffed Reviewed-on: https://chromium-review.googlesource.com/c/1264659Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9b74746414c7..5a279e61ff38 Created with: gclient setdep -r src-internal@5a279e61ff38 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I4bf4f83df1456b62db4d022bdea3f5b37f2d9e40 Reviewed-on: https://chromium-review.googlesource.com/c/1267683Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#597531}
-
Olga Sharonova authored
This reverts commit 53c52480. Reason for revert: FindIt thinks it caused flakiness of virtual/android/fullscreen/video-fixed-background.html. Speculative revert. Bug:893097 Original change's description: > [Media Controls] Remove overlay play button on desktop > > This CL updates the media controls on desktop to have the standard > play button in the bottom left corner instead of the overlay play > button in the center. > > As part of this change, the play button is given a disabled state > when appropriate, which also applies to the audio player. This fixes > a separate issue where the audio player wasn't giving proper feedback > with a broken source. > > Bug: 890078, 839101 > Change-Id: Ifbc8b3c216d3537c657b04ff6fc53506b886c48f > Reviewed-on: https://chromium-review.googlesource.com/c/1252846 > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597483} TBR=aleventhal@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I4f405126f603bd2c8df849c3c210a5d8efedd74e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 890078, 839101 Reviewed-on: https://chromium-review.googlesource.com/c/1268197Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#597530}
-
Morten Stenshorne authored
Corrected ref imported in https://chromium-review.googlesource.com/c/chromium/src/+/1259943 Fixed by aethanyc@gmail.com in https://bugzilla.mozilla.org/show_bug.cgi?id=1495875 TBR=vmpstr@chromium.org Bug: 874124 Change-Id: I58d7b2117217197b6240655a1d4b32b34b120895 Reviewed-on: https://chromium-review.googlesource.com/c/1268137Reviewed-by:
-
Tibor Goldschwendt authored
If the WebView provider is a split APK on Android O, WebView crashes at initialization (see crbug/889954). A considered work around relies on reflection and we are unsure whether that works for all devices. Therefore, measure via UMA if the fields used by reflection exist. Caveat: Only logs for Chrome processes, not for WebView ones. Bug: 891452 Change-Id: Iaecedb061106a67da440ef53039cd6148d64f9cc Reviewed-on: https://chromium-review.googlesource.com/c/1261916 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#597528}
-
Henrik Grunell authored
Bug: 807547 Change-Id: Ibf1d9dc10da2b25cd1197020f2301cf8cfeb6552 Reviewed-on: https://chromium-review.googlesource.com/c/1258165Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597527}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: If95d9fc73619e626e4e82189a63284706a664ffb Reviewed-on: https://chromium-review.googlesource.com/c/1264586Reviewed-by:
-
Michael Lippautz authored
Work around the problem where second pass callbacks are fired during teardown. Previously, these callbacks where just dropped which is not correct for other reason, e.g., when components keep a state per process and not just per Isolate. Bug: chromium:890631 Change-Id: I1fd66f9ffee86c5c7bff053303c741c4dedefdb0 Reviewed-on: https://chromium-review.googlesource.com/c/1253782Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#597525}
-
Sergio Villar Senin authored
Change-Id: I95ff9e86821169fc1ffccb84dbf32f1e09b1e7a4 Reviewed-on: https://chromium-review.googlesource.com/c/1261202 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#597524}
-
Philip Jägenstedt authored
Using wpt-import in Chromium 45c36ac2. With Chromium commits locally applied on WPT: 65d72632 "Make DTMF tone change more deterministic" Based on https://chromium-review.googlesource.com/1267823 which failed due to issue 893079. TBR=robertma@chromium.org Bug: 893079 Change-Id: Icb44160333c6949809e8312abb0da2866aab29b6 No-Export: true Reviewed-on: https://chromium-review.googlesource.com/c/1268155Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#597523}
-
Mirko Bonadei authored
This change only affects component builds. Since //media/webrtc is a component, it will statically link WebRTC code when `is_component_build = true`. WebRTC is going to support Chromium component builds soon, and in order to make it happen WebRTC symbols are being tagged with RTC_EXPORT. This CL temporarily defines WEBRTC_LIBRARY_IMPL also when compiling //media/webrtc in order to avoid to expand RTC_EXPORT to __declspec(dllimport) since WebRTC code is still statically linked into the //media/webrtc component. This will be removed as soon as Chromium will depend on a unique WebRTC component. Bug: webrtc:9419 Change-Id: I731bf55414a64f80bee4dbe276a556a3a289629a Reviewed-on: https://chromium-review.googlesource.com/c/1261398Reviewed-by:
-
Philip Jägenstedt authored
This adapts to "Reject non-thenable values" upstream: https://github.com/web-platform-tests/wpt/pull/12898 This is blocking updating LayoutTests/resources/testharness.js. Bug: 892613 Change-Id: Ifbc91824c0a5687a74cc6f16e02457da60dc4e85 Reviewed-on: https://chromium-review.googlesource.com/c/1264585 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#597521}
-
Rayan Kanso authored
downloadTotal was being updated instead of downlaoded, yielding incorrect values when queried. Change-Id: Id527ed6296081c491d106ef041adedc9260e55dc Reviewed-on: https://chromium-review.googlesource.com/c/1265258Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#597520}
-
Mario Sanchez Prada authored
Migrate from using ProfileOAuth2TokenService and SigninManager to using the IdentityManager instead, and remove the related includes. Bug: 882862 Change-Id: I5fb46927ffba508e6987f615ed22bc1a90155607 Reviewed-on: https://chromium-review.googlesource.com/c/1255624Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/343f4144bee5..38537edf5979 git log 343f4144bee5..38537edf5979 --date=short --no-merges --format='%ad %ae %s' 2018-10-08 mbonadei@webrtc.org Fix visibility of api/units build targets. Created with: gclient setdep -r src/third_party/webrtc@38537edf5979 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iae03139a2686a23b284608af3602b3ff46892282 Reviewed-on: https://chromium-review.googlesource.com/c/1267682Reviewed-by:
-
Daniel Bratell authored
image_paint_timing_detector.cc and text_paint_timing_detector.cc are similar and had identically named helper functions. This broke some jumbo builds. This patch renames the helper functions to have unique names. Bug: 869924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0a42ef4f647ea0b5bfb80bf9dc363a0650424efd Reviewed-on: https://chromium-review.googlesource.com/c/1268135Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#597517}
-
Mikel Astiz authored
All changes to the in-memory sync metadata should be reflected in persisted sync metadata, and a bug in the implementation prevented that. The end result is that all sync entities would be refetched on every restart, for the experimental pseudo-USS codepath (behind feature toggle). Given that we've already done some experimentation on canary channel, we introduce the logic to recover cleanly from the resulting inconsistent state, which seems like a desirable safeguard anyway. Bug: 870624 Change-Id: I28b170a6ff62ecb78c94c7026796df56687507dc Reviewed-on: https://chromium-review.googlesource.com/c/1267498 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#597516}
-
mrefaat authored
It seems like with the switch to the new tab grid, this feature stopped to function properly. it used to use the rootview controller to present dialogs & views. using the base view for now to present the loading screen as a quick fix. The whole class should be refactored in the future to get a base view controller instead. Bug: 892839 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4eea25b3d3c5c329dd54865de1fbae68e05304e1 Reviewed-on: https://chromium-review.googlesource.com/c/1266205Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#597515}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/edb48955..9fcb424b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ifa32d1c0f741eee5f17e6357ca4e157f395ae406 Reviewed-on: https://chromium-review.googlesource.com/c/1267737Reviewed-by:
-
Sergey Silkin authored
Bug: webrtc:9803 Change-Id: Ic9bf1f9a615d769ce8fd93caea01c40ac819843e Reviewed-on: https://chromium-review.googlesource.com/c/1257925Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 887936 Change-Id: I0d26f044019b6a73f4fcec7f5b6a88d707cc7c15 Reviewed-on: https://chromium-review.googlesource.com/c/1268115Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#597512}
-
Kamila authored
Permissions UI in Android is being modified, in order to introduce new functionalities and fix existing bugs. This cl adds an experimental flag for Android Permissions UI changes, associated with the bug below. Bug: 882382 Change-Id: I2a332b312a228deb7b257f68cdb16b65495959b3 Reviewed-on: https://chromium-review.googlesource.com/c/1256564 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#597511}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I5acd367734d70359367369961cf66e7945482e6f Reviewed-on: https://chromium-review.googlesource.com/c/1264583Reviewed-by:
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/networking_private/networking_private_service_client_apitest.cc. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 809610 Change-Id: I26aafd6d9606d08a4052fada37728aeb7a513975 Reviewed-on: https://chromium-review.googlesource.com/c/1258907Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#597509}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/extensions/api/passwords_private. This CL was uploaded by git cl split. R=stevenjb@chromium.org Bug: 809610 Change-Id: Ic7e228270788db02035262b532fcc2eee8cebf0f Reviewed-on: https://chromium-review.googlesource.com/c/1258355Reviewed-by:
-
