GitLab

Adds several new histograms for Contextual Search to track:
The total number of taps before ever opening the promo panel,
the number of times the promo panel was opened, the number
of taps since any panel was opened, and information about the
search term resolution (protocol, and single/multi-word).

There's a downstream CL dependent on this change: https://chrome-internal-review.googlesource.com/#/c/216388/

BUG=477827

Review URL: https://codereview.chromium.org/1131653005

Cr-Commit-Position: refs/heads/master@{#330841}

Also adds DISALLOW_COPY() to Request.

BUG=475153

Review URL: https://codereview.chromium.org/1131173005

Cr-Commit-Position: refs/heads/master@{#330840}

The header checker will now automatically accept any headers not known in the
current toolchain. The previous code would do this but required it to not be
present in any toolchain in the entire build.

See the long comment added in header_checker.cc for details.

Adds a dependency fix for the Android build in base.

BUG=

Review URL: https://codereview.chromium.org/1142423004

Cr-Commit-Position: refs/heads/master@{#330839}

BUG=489751

Review URL: https://codereview.chromium.org/1146813003

Cr-Commit-Position: refs/heads/master@{#330838}

glGetIntegerv with GL_GPU_DISJOINT_EXT causes GL_INVALID_ENUM error
which leaked into the FeatureInfo's Initialize.

BUG=462553

Review URL: https://codereview.chromium.org/1150463003

Cr-Commit-Position: refs/heads/master@{#330837}

In document mode, the current task could be removed after a market Intent
is started.
So, we should start it in a new task.

BUG=487295

Review URL: https://codereview.chromium.org/1149863003

Cr-Commit-Position: refs/heads/master@{#330836}

See cr/94026893 for context.

BUG=489929

Review URL: https://codereview.chromium.org/1148713004

Cr-Commit-Position: refs/heads/master@{#330835}

The HSTS/HPKP preload set is pre-normalized at construction time.
Since the queries come from the GURL, not from the DNS layer,
we need to normalize the hostname before scanning for preloads.
This used to be handled by CanonicalizeHost(), which used the
same mechanism as the resolver, but the storage of the preloads
has changed to be more efficient, and thus no longer uses the
resolver-normalized form.

BUG=461481
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/1149753002

Cr-Commit-Position: refs/heads/master@{#330834}

For example, if the certificate is expired.

BUG=442930

Review URL: https://codereview.chromium.org/1148743002

Cr-Commit-Position: refs/heads/master@{#330833}

Revert of Changes caching logic of mojo java apps (patchset #5 id:80001 of https://codereview.chromium.org/1149813002/)

Reason for revert:
Broke windows build.

Original issue's description:
> Changes caching logic of mojo java apps
>
> Previously we would extract all necessary files every time we ran the
> app. This is obviously unnecessary for any bundled apps. Now we
> extract only as necessary.
>
> R=ben@chromium.org, jcivelli@chromium.org
> BUG=none
> TEST=none
>
> Committed: https://crrev.com/128f7a0181634a89a35f681baab1d086d100e377
> Cr-Commit-Position: refs/heads/master@{#330824}

TBR=ben@chromium.org,jcivelli@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1147203002

Cr-Commit-Position: refs/heads/master@{#330832}

When an extension is force-installed by policy and cannot be removed, show the
enterprise policy icon in the context menu, and change the string from
"Remove frome Chrome..." to be "Installed by your administrator".

BUG=486228

Review URL: https://codereview.chromium.org/1140763003

Cr-Commit-Position: refs/heads/master@{#330831}

BUG=429153

Review URL: https://codereview.chromium.org/1126083005

Cr-Commit-Position: refs/heads/master@{#330830}

Due to crbug.com/489468, detection of re-written key combinations
(e.g. Search+Backspace->Delete) were being mis-treated as modifier
key combinations (i.e. Search+Backspace->Search+Delete).

Since the spurious mouse event causing this has the same x and y
coordinates as the previous mouse event, it can be filtered to
suppress the unwanted keyboard event.

BUG=484329

Review URL: https://codereview.chromium.org/1143943002

Cr-Commit-Position: refs/heads/master@{#330829}

Summary of changes available at:
https://boringssl.googlesource.com/boringssl/+log/96600327..a7997f12

This pulls in the 1024-bit minimum DH group size restriction.

BUG=490240

Review URL: https://codereview.chromium.org/1144363002

Cr-Commit-Position: refs/heads/master@{#330828}

R=ajuma@chromium.org

Review URL: https://codereview.chromium.org/1149843004

Cr-Commit-Position: refs/heads/master@{#330827}

BUG=487491
TBR=miu@chromium.org

Review URL: https://codereview.chromium.org/1146933004

Cr-Commit-Position: refs/heads/master@{#330826}

This is more robust against re-entrantly run MessageLoops.

BUG=none

Review URL: https://codereview.chromium.org/1142843002

Cr-Commit-Position: refs/heads/master@{#330825}

Previously we would extract all necessary files every time we ran the
app. This is obviously unnecessary for any bundled apps. Now we
extract only as necessary.

R=ben@chromium.org, jcivelli@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1149813002

Cr-Commit-Position: refs/heads/master@{#330824}

BUG=none

Review URL: https://codereview.chromium.org/1124223012

Cr-Commit-Position: refs/heads/master@{#330823}

Companion CL: https://codereview.chromium.org/1067233002/

R=nduca,davidben,jam
BUG=466769

Review URL: https://codereview.chromium.org/1115343002

Cr-Commit-Position: refs/heads/master@{#330822}

BUG=452726

Review URL: https://codereview.chromium.org/1146243003

Cr-Commit-Position: refs/heads/master@{#330821}

This patch cleans up some more recycled twin information. In particular,
it removes it from the picture layer tiling set. This makes it possible
to remove one of the functions that gets the recycled twin from the
layer.

R=enne, danakj

Review URL: https://codereview.chromium.org/1149843002

Cr-Commit-Position: refs/heads/master@{#330820}

Test targets are defined in BUILD.gn, so it would be convenient to be
able to review CLs here.

BUG=NONE

Review URL: https://codereview.chromium.org/1148113003

Cr-Commit-Position: refs/heads/master@{#330819}

This fixes two places where we directly access property tree indices
rather than using their accessors.

BUG=489725

Review URL: https://codereview.chromium.org/1144343002

Cr-Commit-Position: refs/heads/master@{#330818}

Some of the changes below may have a functional effect, but I don't _think_ they will, if they do it should be minor, and I don't know another way of finding out than trying to make this change and seeing what happens.  (Besides simplification, this change is also intended to unblock https://codereview.chromium.org/1139823006/ , which doesn't want to affect infobar behavior but without this change might do so.)

* Moved the check for "!details.did_replace_entry" from ConfirmInfoBarDelegate up to the base class.  Very few people subclass the base class anyway, and for those who do, there's no obvious reason not to do this.  I actually suggested doing this in a review several years ago but it never happened.

* Removed InfoBarDelegate::ShouldExpireInternal(), which didn't seem to be doing much useful.  I think the unique ID check was basically doing the same thing as the "is_navigation_to_different_page" bit that was already checked in ShouldExpire() (which didn't exist when the unique IDs were added long ago).  So if we got to ShouldExpireInternal() at all, that would be true regardless, and thus that helper would always return true.  (Incidentally, reloads _are_ treated as "navigations to a different page", so we still dismiss infobars by default on reload.  If this wasn't true we'd have already been broken anyway, since ShouldExpire() would have early-returned false.)

* Removed ProtectedMediaIdentifierInfoBarDelegate::ShouldExpireInternal().  I discussed this with kkimlabs@, the original author, and neither of us can understand why it was necessary to begin with.  We both think this should be removed.

* Removed the wonky TranslateInfoBarDelegate::ShouldExpire().  Long ago, this used to check a bit called "is_auto", because it was trying to allow the infobar to be dismissed even for automatic navigations, whereas other infobars wanted to only be dismissed for user-driven ones.  However, the "is_auto" bit was later removed, and the replacement code didn't really work the same way, and besides this, the conditional didn't really make sense, since "!details.is_main_frame" implies "!details.is_navigation_to_different_page".  So we basically had a function that would call InfoBarDelegate::ShouldExpireInternal() for all main-frame navigations.  But since, as I said above, I think the unique ID check there was functionally the same as checking for a "navigation to a different page"... I think all this ended up just doing the same thing as the original base function.  And I couldn't check because the translate infobar no longer exists for views anyway.  So whatever.

* Removed copy-and-pasted code that wasn't needed.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1142153002

Cr-Commit-Position: refs/heads/master@{#330817}

With 1 win32 timer we can only get a callback every 10ms, and since the callback only processes one message, that means the queue could keep growing if delayed tasks are posted faster than that rate, even if they're processed very quickly. To prevent that, schedule a kMsgHaveWork if there's 0ms until the next delayed task should run, and run a delayed task in the kMsgHaveWork handler.

BUG=454333
TEST=chrome resizes smoothly

Review URL: https://codereview.chromium.org/918473002

Cr-Commit-Position: refs/heads/master@{#330816}

This patch removes lazy_background_task_queue accessor from ExtensionSystem.
It can be its own browser context keyed service.
It can be built by its new factory.

Review URL: https://codereview.chromium.org/1129063011

Cr-Commit-Position: refs/heads/master@{#330815}

Review URL: https://codereview.chromium.org/1141453005

Cr-Commit-Position: refs/heads/master@{#330814}

Add option in display settings page to switch the mode

BUG=489809
TEST=manual + DisplayManagerTest.UnifiedDesktopBasic

Review URL: https://codereview.chromium.org/1126933004

Cr-Commit-Position: refs/heads/master@{#330813}

I noticed that HistoryQuick provider's also-do-HUP-like-scoring mode
did some score-capping to prevent a non-inlineable match from showing
first.  This is no longer necessary now that we have reorder mode
(a.k.a. the allowed_to_be_default_match field).

BUG=

Review URL: https://codereview.chromium.org/1144273003

Cr-Commit-Position: refs/heads/master@{#330812}

Android emulators miss many EGL extensions required for
webview hardware accelerated rendering, so fallback to
a slow software mode when running in emulator.

BUG=490354

Review URL: https://codereview.chromium.org/1145273003

Cr-Commit-Position: refs/heads/master@{#330811}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/6bd0043..a240d64

TBR=szager@chromium.org,leviw@chromium.org,samli@chromium.org

Review URL: https://codereview.chromium.org/1149823002

Cr-Commit-Position: refs/heads/master@{#330810}

This will handle destroying the owned tab models, which will in turn
destroy the owned tabs.

BUG=473594

Review URL: https://codereview.chromium.org/1147153002

Cr-Commit-Position: refs/heads/master@{#330809}

By doing the following:
1) Avoid deferring commits until draw if not drawing soon.
2) Don't send BeginMainFrame if swap throttling will block commit.

As a side-effect, some of the changes will also help release
the main thread sooner in some cases where we were holding on to
it for too long.

Additional scheduler deadlock tests added to verify existing
and future operation.

This should also enable us to more easily avoid unconditionally
setting active_tree_needs_first_draw_ to false in
SchedulerStateMachine::UpdateStateOnInvalidateOutputSurface
in followup patches if we want to.

BUG=479671, 477082

Review URL: https://codereview.chromium.org/1139613003

Cr-Commit-Position: refs/heads/master@{#330808}

This fixes StyleLabel layout in languages that don't have word breaks
(e.g. Japanese).

BUG=479859

Review URL: https://codereview.chromium.org/1140083002

Cr-Commit-Position: refs/heads/master@{#330807}

This prevents in-process discardable shared memory instances
from requiring an open file descriptor.

BUG=489174
TEST=base_unittests --gtest_filter=DiscardableSharedMemory.Close

Review URL: https://codereview.chromium.org/1146103002

Cr-Commit-Position: refs/heads/master@{#330806}

This CL removes some unneeded //chrome dependencies in password manager utilities. The goal is to make those files movable to the password manager component. The move will happen in a separate CL.

BUG=486739

Review URL: https://codereview.chromium.org/1141413002

Cr-Commit-Position: refs/heads/master@{#330805}

Revert of Roll DEPS to class-dump 3.5 (patchset #4 id:60001 of https://codereview.chromium.org/1106993002/)

Reason for revert:
Breaking https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/7076

Original issue's description:
> Roll DEPS to class-dump 3.5
>
> Removes some build warnings.
>
> Moves the class-dump repo to a github auto-mirror instead of a mirror
> that needs to be manually updated.
>
> This also requires that the class-dump.gyp file move from the
> third-party repo into the main source tree. Note that the file
> structure of the class-dump source changed so the .gyp had to be
> updated. For comparison, the old .class-dump.gyp can be found at
> https://chromium.googlesource.com/chromium/deps/class-dump/+/master/class-dump.gyp
>
> BUG=318160
>
> Committed: https://crrev.com/1c80791ce7c29a29fc816d89d1a5fa2ac6503b3e
> Cr-Commit-Position: refs/heads/master@{#330798}

TBR=justincohen@chromium.org,rohitrao@chromium.org,lliabraa@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=318160

Review URL: https://codereview.chromium.org/1147163003

Cr-Commit-Position: refs/heads/master@{#330804}

This forks the code from //services/files/ in the mojo repository at
commit af91be731e321b06f5f88a25ff42199feb578691.

BUG=490237

Review URL: https://codereview.chromium.org/1147083002

Cr-Commit-Position: refs/heads/master@{#330803}

This CL prevents sync from updating the "last updated time" for bookmark
favicons each time that Chrome is started. The "last updated time" determines
when the favicon is redownloaded from the web (in case it has been updated).

Sync calls HistoryBackend::MergeFavicon() for each bookmark favicon on startup.
This CL stops HistoryBackend::MergeFavicon() from updating the "last updated
time" when MergeFavicon() is called with the same bitmap data as already stored
in the database (no new bitmap data).

BUG=481414
TEST=TwoClientBookmarksSyncTest.SC_UpdatingTitleDoesNotUpdateFaviconLastUpdatedTime

Review URL: https://codereview.chromium.org/1128343004

Cr-Commit-Position: refs/heads/master@{#330802}