- 25 Oct, 2019 40 commits
-
-
Ryan Sleevi authored
CertStatus contains additional information than contained solely within a net::Error, and so converting from a Status -> Error -> Status loses that fidelity, even though it's "safe" to go Error -> Status -> Error. This also corrects a few unittest CertVerifiers flagged during review which have no functional impact. Bug: 618799 Change-Id: I6a098c70c2a870f4f9c22801f24d906a4faf04ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879852Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709467}
-
Matt Menke authored
We want to make server auth cache respect the NetworkIsolationKey, but need that capability to be able to be toggled during runtime (and possibly per profile) so enterprises can disable it. Loading enterprise configurations while in the middle of copying server auth credentials gives us non-deterministic behavior configs when this setting is toggled, and copying it between two profiles with different settings is also pretty weird. The simplest solution is just to only copy proxy credentials, which are what the copying logic is only really intended for, anyways. Bug: 993806 Change-Id: I26d4f0f92e695e844ff72ec5df83eeaefd9f1b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875271Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#709466}
-
Jinsong Fan authored
In the current implementation, always use the selection rect fully between the handles to calculate the location of the context menu, but the selection rect may be clipped, so in this case, the position of the context menu will be far from the clipped selection rect. The CL computes the clipped selection rect for showSelectionMenu. Bug: 1015274 Change-Id: I7aaf27337c7009eb9fef78f3a1ee92e521de8cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868575Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#709465}
-
Vasilii Sukhanov authored
The two probable reasons for the flakiness were: - we didn't wait until the keystrokes were processed in the renderer. See crbug.com/955455 - we don't wait for the password store returning some results after navigation. Both are fixed in the CL. Let's observe the pass rate. Bug: 1013743 Change-Id: Ic328afbe2cd652119a773c28d49ff450cf0d5405 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879237Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#709464}
-
Robert Ma authored
Instead of relying on PATH, we explicitly call the luci-auth binary (or luci-auth.bat on Windows) in blinkpy. Bug: 1017404 Change-Id: Ic44afadad52d17370db4ada910d6c02e37a95289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879559Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#709463}
-
Kenichi Ishibashi authored
A brief summary of this plumbing is below: blink::ServiceWorkerContainer::registerServiceWorker() -> (IPC from a renderer to the browser) -> content::ServiceworkerContextCore::RegisterServiceWorker() Start a registration job asynchronously Create a ServiceWorkerVersion and set the passed settings object -> content::ServiceWorkerVersion::StartWorker() -> (IPC from the browser to a renderer) -> WebEmbeddedWorkerImpl::StartWorkerContext() -> ServiceWorkerGlobalScope::FetchAndRunClassicScript() (Note that renderer processes of above don't have to be the same.) This CL has behavioral changes. The 'Referer' header of the request triggered by register() in a document will be changed. Before this CL it was the url of the top-level script but after this CL it is document's url. This behavior is consistent with the spec. Bug: 937177 Change-Id: I4c137d10b7d5204151ae7eff8bfd8fdeb34fb365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861294 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#709462}
-
Dan Elphick authored
Add a v8_maybe_snapshot dependency to generate_v8_context_snapshot so it is rebuilt when the v8 snapshot changes. Without this change, in component builds v8 changes would cause libv8.so to rebuild but would rarely trigger a v8 context snapshot build. Fixed: 865389 Change-Id: Ib35b564bc28147fcb090c3b7f7fa852c11846684 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878249Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#709461}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/24a409611f24..a7f3157ac012 git log 24a409611f24..a7f3157ac012 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 herb@google.com Only scale fallback font if it is too big Created with: gclient setdep -r src/third_party/skia@a7f3157ac012 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I86e7a4de908f34d8f9dbdcb820e21a381f828a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709460}
-
Robbie Gibson authored
Bug: 1014702 Change-Id: Ie3b0e41a11a36bddd41be0dfbeb86423ae235847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879236Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#709459}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4f2783b9fe77..16cec3be2c96 git log 4f2783b9fe77..16cec3be2c96 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 philipel@webrtc.org Added allow_codec_switching parameter to RTCConfig. 2019-10-25 hbos@webrtc.org Revert "[PeerConnection] Use an OperationsChain in PeerConnection for async ops." 2019-10-25 danilchap@webrtc.org Cleanup PacketBuffer tests to use immediate result Created with: gclient setdep -r src/third_party/webrtc@16cec3be2c96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I6ba84d5eefe5239bd1e88d5e9889de1ee3ccd0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881168Reviewed-by:
-
Sebastien Marchand authored
This is unlikely to happen in practice, but there's still a tiny race possibility that could cause this if we ever decide to immediately freeze tabs after they're being sent to background. Change-Id: I33fbd9f31692e3e1c8c2c269da01f83c9d672363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869721 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#709457}
-
Thomas Tangl authored
Mocks: https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZS4C13RU2slZ/files/MCEJu8Y2hyDScSRec_gUtrkQDjJvcy3ALJI Bug: 1017241 Change-Id: I4a06b95fb6d93de04c3c031674ef7f422da99bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879917 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#709456}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I201d491e379e473196343ee07d2ccc7c08b98544 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880700Reviewed-by:
-
Sebastien authored
This is triggering a Finch warning when trying to make changes to the GCL file. (cl/275848776) Change-Id: Id95ed8dd6e34ab48f171ec8e3ec8614567ea0519 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879867Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#709454}
-
Olle Liljenzin authored
SysUtils has to be in main dex file since child processes use SysInfo::IsLowEndDevice() which depends on it. Bug: 1018167 Change-Id: I61c2a040e1ccb78725c852bcabe31cf45f217522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879896 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#709453}
-
Sigurd Schneider authored
This test adds a regression test for breakpoints in inline scripts with #sourceURL=. Bug: chromium:1017738 Change-Id: Id5c58cf7e8346879b1ad37a79262d4516708b580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878652 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709452}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/57b9fe40c414..e0f4b5423da2 git log 57b9fe40c414..e0f4b5423da2 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 mmortensen@google.com Improve error handling in determine_android_package for portage errors. Created with: gclient setdep -r src/third_party/chromite@e0f4b5423da2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I7094aef96ab9573e1b7b0e2f1c5efe87c02b501e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880803Reviewed-by:
-
sandromaggi authored
Some sites require a format of MM/YY which was previously not available for required fields. Bug: b/143266929 Change-Id: I68bc11b752d00a088e1514a7c0db1edfd4b7ff74 Bug: b/143266929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879892 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#709450}
-
Peng Huang authored
With this change, --gr-context-type=Vulkan or --enable-features=Vulkan will enable vulkan compositing. If the --use-vulkan=impl_name is used, the specified vulkan implementation will be used otherwise the native vulkan implementation will be used by default. Bug: 1009029 Change-Id: I7730f48ab000b7edf6db892ac63bc585383d4fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878529 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#709449}
-
Thomas Tangl authored
Bug: 1018191 Change-Id: I2db59d17037f4933751545a85ea372841241d010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879295 Auto-Submit: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Tim Volodine authored
In this patch: - add the abstract GmsBridge class and its corresponsing upstream implementation (GmsBridgeImpl.java). GmsBridge class manages functionality related to Google Mobile Services (GMS). - add the initialization of safebrowsing handler on WebLayer startup. - add .gn build deps and targets needed for the relevant upstream targets. In the future a different GmsBridgeImpl class will be compiled-in depending on whether an internal clank/ checkout is present. BUG=1015418 Change-Id: I5a45023a0ab6f31ce6db1daa7f62bf7c2579a84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876032Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#709447}
-
Boris Sazonov authored
Disables DirectActionAvailabilityTest#testCoreDirectActionInWebappActivity as it has been flaking a lot. Failed build link: https://ci.chromium.org/p/chrome/builders/ci/test-n-phone/8984 TBR=szermatt@chromium.org Bug: 1018183 Change-Id: I0812cff148432b0990a66411f94d9d2415531e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879898Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a446a6f7..0e0b9a97 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I03456adddc1830a3a0b84a8c08c754345d5628b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880054Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709445}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1dddaa1a8433..4f2783b9fe77 git log 1dddaa1a8433..4f2783b9fe77 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 phoglund@webrtc.org Speculative Revert: "Use FakeRenderer when fuzzing" 2019-10-25 gustaf@webrtc.org Cleanup of EchoControl interface after downstream fixes 2019-10-25 saza@webrtc.org Add APM test of pre-amplifier gain 2019-10-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 64883b3e..3c5165be (709283:709394) Created with: gclient setdep -r src/third_party/webrtc@4f2783b9fe77 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:1015797,chromium:952606,chromium:1009077,chromium:1009073,chromium:b/130016532,chromium:None Change-Id: Ic6a298f17bfbcba42dd33a1d811994514e0f42c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879193Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/480809720bfa..208c36706ef6 git log 480809720bfa..208c36706ef6 --date=short --no-merges --format='%ad %ae %s' 2019-10-25 treehugger-gerrit@google.com Merge "traceconv: add --full-sort option" 2019-10-25 eseckler@google.com Merge "processor: Add ProtoImporterModules for android + system probes" Created with: gclient setdep -r src/third_party/perfetto@208c36706ef6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I073059aee791c0ba6917ccfdbb7c112ba2f43859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880590Reviewed-by:
-
Yuki Shiino authored
This is a reland of b3a546fe It turned out that it's not going well to output v8_example.cc under bindings/scripts/bind_gen/, so reverted the path to out/Default/gen/... as same as before. Added some asserts in example.py. Original change's description: > bind-gen: Support generation of function definitions. > > This is just a first step to support the code generation > of bindings callback functions. > > Introduces CodeGenerationContext for convenience, and > also demonstrates make_common_local_vars(). > > Bug: 839389 > Change-Id: I9ff49b4bfc6bd98e6b29687cc01f986c2baa01fa > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855325 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709389} Bug: 839389 Change-Id: I57ff27abdf2a01a9cc926bbf27d1a0c8ceb5ce88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880991 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#709442}
-
Miyoung Shin authored
This CL converts AudioInputStreamClient{Ptr, Request} in chrome, components, content and media to the new Mojo type, and uses pending_receiver<pending_receiver> in resource_provider.mojom. Bug: 955171 Change-Id: Ib7856c3c65ff70f658b9e6c56b72a9a2b73648e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866709 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Ken Rockot <rockot@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
This reverts commit b27f6c3c. Reason for revert: Fixed the compilation issue. Two different targets where stubbing the same app interface, which caused duplicated symbols. Now the stubbing happens on its own .mm file. Original change's description: > Revert "[iOS][MF][EG2] Migrate credit card tests" > > This reverts commit 919aab84. > > Reason for revert: Suspected of breaking compile for xcode-ios-bots - https://ci.chromium.org/p/chromium/builders/ci/ios-device-xcode-clang/113639 > > Original change's description: > > [iOS][MF][EG2] Migrate credit card tests > > > > Consolidate Manual Fallback matchers in one place. > > Consolidate credit card Autofill helpers in the respective app > > interface. > > > > TBR= eugenebut@chromium.org > > > > Bug: 1017685, 1016367 > > Change-Id: Ib91e2baba9e72f6e065e8ebf08fdd5f5d3c0c9bb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878197 > > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#709020} > > TBR=stkhapugin@chromium.org,javierrobles@chromium.org > > Change-Id: I644e9e91acab68e69d7cba86af2037fd43603b36 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1017685, 1016367 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878911 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709028} TBR=stkhapugin@chromium.org,smcgruer@chromium.org,javierrobles@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017685, 1016367 Change-Id: I8cf4fe3a3f7960a0ff27459003884a7ba08a455a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878490Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#709048} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878772Reviewed-by:
-
Yoshifumi Inoue authored
This patch formats "FlagExpectations/enable-blink-features=LayoutNGFragmentItem" for ease of updating it by tool[1]. [1] http://crrev.com/c/1880898 TBR=kojii@chromium.org NOTRY=true Change-Id: Ie723c1d235ec068badeb6843bcd069f103dc59d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880998Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes |AbstractLineBox| to utilize |NGInlineCursor| to reduce usage of |NGPhysicalLineBoxFragment| for prepration of migrating |NGFragmentItem|. Note: To reduce patch size, following patch will introduce |NGInlineCursor| version of |ClosestLeafChildForPoint()|. Bug: 982194 Change-Id: I539b940509ae608f0068a013670889bfc16dd4ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877499 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#709438}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/33455d1c48..d3ddd33257 TBR=aerotwist@chromium.org Change-Id: Ibf69370cfd87c5a74975ef33c04978bb34005049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879939Reviewed-by:
Paul Lewis <aerotwist@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#709437}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I040c2ecf60da17ad6e7cd6fe52423bcae7a8bdcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880053Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709436}
-
Felipe Andrade authored
Kerberos credentials manager should notify observers exactly once when it finishes adding a list of accounts. This CL removes the flag that was blocking notifications in case of failure because, even in this cases, managed accounts might have been added and observers should be notified. Change-Id: Idf07f4f755cc5f81aa1788f28c416bfed0fec106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878251 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#709435}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/5ebd4c5ebf28..38f98ead10af git log 5ebd4c5ebf28..38f98ead10af --date=short --no-merges --format='%ad %ae %s' 2019-10-25 perezju@chromium.org [Telemetry] Remove support for output formatting Created with: gclient setdep -r src/third_party/catapult@38f98ead10af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:921000 Change-Id: Ic61238ca03e7c18276316800f8a09eceeae92698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880665Reviewed-by:
-
arthursonzogni authored
Generated using: ~~~ #! /bin/bash --utf8 directories="content chrome components" regex="DisableForRenderFrameHost(\(([^\(\)]++|(?1))*\))" label=$(grep -Pzoh $regex -r $directories \ | tr -d '\000' \ | grep -Po '\"[^"]+"' \ | tr -d '"' \ | sort -u ) echo "<enum name=\"BackForwardCacheDisabledForRenderFrameHostReason\">" for i in $label do hash=$(echo -n $i | md5sum | tr -d ' -') hash=${hash^^} hash=$(echo $hash | head -c 16) hash=$(echo "ibase=16; $hash" | bc) hash=$(echo "($hash + (2^31)) % (2^32) - 2^31" | bc) echo " <int value=\"$hash\" label=\"$i\"/>" done echo "</enum>" ~~~ Bug: 1001087 Change-Id: I4f9bc9b9c50eb1a27642f0afa900dac300890e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879937Reviewed-by:Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#709433}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cfa4b4a65a57..480809720bfa git log cfa4b4a65a57..480809720bfa --date=short --no-merges --format='%ad %ae %s' 2019-10-25 tneda@google.com Merge "Adding heap profiling to the record page" 2019-10-25 lalitm@google.com Merge "trace_processor: switch to creating ranged RowMap when filtering" 2019-10-25 lalitm@google.com Merge changes I7b4e3667,Ie36db4d9 Created with: gclient setdep -r src/third_party/perfetto@480809720bfa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: If5724b02487c621eda7e706b042806dad9a083fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880664Reviewed-by:
-
Clemens Arbesser authored
Currently, autofill assistant does not validate the set of basic card networks sent by the autofill assistant backend. In the UI, this can lead to crash due to an assert. This CL adds the missing validation and terminates the action with INVALID_ACTION for unsupported cards. Bug: b/143136284 Change-Id: If248fa0edd671078ef6459de34228e392f542800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871700 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709431}
-
Minggang Wang authored
This CL moves ThrottlingURLLoader and its unit test into Blink. Bug: 860403 Change-Id: I25429971608737c9f37ff126dbbb5ef40ccdc794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865142 Commit-Queue: Minggang Wang <minggang.wang@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709430}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/24fd62c5..a446a6f7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie5fd99091faf3499a5adc65e201ae39e65472088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880052Reviewed-by:
-
Kent Tamura authored
The table at https://html.spec.whatwg.org/C/#focusable-area says: > the element is either not a shadow host, or has a shadow root > whose delegates focus is false; is a requirement of focusable area. That is to say, shadow hosts with delegatesFocus can't be focusable. This CL has two behavior changes: * A shadow host with delegatesFocus and tabIndex doesn't get focus even if its shadow tree contains no focusable elements. * tabIndex IDL attribute for a host with delegatesFocus returns -1 if tabindex content attribute is invalid or missing, instead of 0. Implementation: Element::Is*Focusable() don't return true any longer for shadow hosts with delegatesFocus. This CL adds delegatesFocus checks to some of Is*Focusable() callsites. focus_controller.cc assumed shadow hosts with delegatesFocus and no tabindex attribute return 0 for tabIndex(). This CL updates AdjustedTabIndex() to return 0 in such case, and replaces raw tabIndex() calls with AdjustedTabIndex(). Change-Id: If1b06dc727134f834df4ebc00fc78c72b77c4a2e Bug: 1014094 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880494Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#709428}
-
