- 30 Mar, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
No behavior changed, this is a preparation to introduce B4P's conflict resolution logic for password generation. We modify the API to take matches instead of the form fetcher so that the multi-store save manager can later pass only local matches to it in an overriden method. Change-Id: Ib0eecb11b63fa23908e74a52116335433270468f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124455Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#754501}
-
Michael Ershov authored
TBR=dtseng@chromium.org Bug: 1065877 Change-Id: I7e225dc134f8b5cb55214dacca63dbdd65be57a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126990Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#754500}
-
Maggie Chen authored
Atomic32 |arm_disarm_counter_| can be accessed from multiple threads. The watchdog calls NoBarrier_AtomicIncrement() to increase this counter. Now add volatile qualifier to this class member according to the function declaration, Atomic32 NoBarrier_AtomicIncrement(volatile Atomic32* ptr, Atomic32 increment) Bug:885066,885066 Change-Id: Id842b6de190bbcfb4ecc15293d790b62216700cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126571Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#754499}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9bc857b39c2..46de36f99362 git log e9bc857b39c2..46de36f99362 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 mtklein@google.com simpler immediates Created with: gclient setdep -r src/third_party/skia@46de36f99362 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I86f97fbff5c4cb971dffd3280be6189ee145c472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127129Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754498}
-
Javier Ernesto Flores Robles authored
Adds equality to ArchivableCredential based on recordIdentifier. Bug: 1045456 Change-Id: Ibe38c04745d1cefda3526267005ad24007e92215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124499 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#754497}
-
Sebastien Marchand authored
Change-Id: Id32ab0a774dc45ca4459e2b709ff82d54389b3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124949 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#754496}
-
Roger Tawa authored
Bug: 1065009 Change-Id: Icc01e48b583d9e41e1a9523315ed1f66629092c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122477 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Cr-Commit-Position: refs/heads/master@{#754495}
-
Friedrich Horschig authored
This CL replaces hard-coded English strings with translated IDs. IDS_PASSWORD_MANAGER_OPT_INTO_ACCOUNT_STORE.png: https://storage.cloud.google.com/chromium-translation-screenshots/8f84fa679e3583eb4bc1cadd68e4fd91b4952016 IDS_PASSWORD_MANAGER_OPT_INTO_ACCOUNT_STORED_GENERATION.png: https://storage.cloud.google.com/chromium-translation-screenshots/bc24abb9b5fceb28199f375ee3643b1b8d02f6e9 Bug: 1062344 Change-Id: I9b8485e760f5f41f9638f01ec3ef999c95b8d3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126987Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#754494}
-
Abigail Klein authored
chrome/browser/ui/views/accessibility. Move caption_bubble.h and .cc from chrome/browser/accessibility to chrome/browser/ui/views/accessibility. The CaptionBubble is a View so it should be in the ui/views directory. The CaptionBubble has as its anchor view the contents_web_view from BrowserView. BrowserView is in ui/views, so CaptionBubble too should be limited to only OS's that include ui/views. Bug: 1055150 Change-Id: If2c291ce25c5020fa8bd1e222fccb345626b4078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119758Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#754493}
-
Patrick Monette authored
This is an optimization to avoid unnecessarily creating a worker if it's going to be immediately destroyed. In addition, the PerformanceManager can not handle a dedicated worker whose render process is dead because that means the frame that created the worker is also already gone. Bug: 993029, 1064772 Change-Id: Id4ffbcfd34f2c23ad7e3381b92358cf543bae6c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124536 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#754492}
-
DongJun Kim authored
This patch is step 3 in [1] and we adds a new RequestDestination field in the structs / params where only RequestContextType is used. If we are finish current step then RequestContextType field will be deprecated. [1] https://docs.google.com/document/d/1kXXnH_27aJYGqjwbXLW6Bs9fW2xFhvZs8gJcXb4xnhQ/edit Bug: 889751 Signed-off-by:
DongJun Kim <djmix.kim@samsung.com> Change-Id: Iedf80fc00e20e73d6780e0e6deb5ced83d04d13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106708Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#754491}
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: I3c76b0bc60dba08dd87a9fe3ab25c0cf37f679f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126567 Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#754490}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0ccd8de267fe..3fffd0d4592e git log 0ccd8de267fe..3fffd0d4592e --date=short --first-parent --format='%ad %ae %s' 2020-03-30 tvanderlippe@chromium.org Remove unused global references from ui-legacy.js 2020-03-30 tvanderlippe@chromium.org Use built-in Map instead of object map Created with: gclient setdep -r src/third_party/devtools-frontend/src@3fffd0d4592e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I16dd1528b4e69badc502935c5bad95a8a5c0ccf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127127Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754489}
-
Timothy Gu authored
This addresses a follow-up to 15c60c50. Fixed: 1061139 Change-Id: Icf29c63041d5ab54be4f3a545e6835fe535acbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114584 Commit-Queue: Timothy Gu <timothygu@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#754488}
-
Andrey Zaytsev authored
Bug: 1015841 Change-Id: Iaff5e19ffc5e1e89064a98ff581c16b7e3924ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124713 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#754487}
-
Etienne Pierre-Doray authored
This reverts commit 665132b2. Reason for revert: Causes Jobs tests (e.g. StaleConcurrency) to flakily timeout. Original change's description: > [Jobs]: Boost WaitForConcurrencyIncreaseUpdate timeout to 30sec. > > To avoid flaky failures with slow running tests. > > Bug: 1046343 > Change-Id: Iafb6d15c08fb8c97eaa36d802cee5f993eceacd8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107602 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#751380} TBR=gab@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1046343, 1064953 Change-Id: I6d9e3bbede1c85098ec2bdbca3f25b48a2909e94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124527Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#754486}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d19513f3ffbb..7bd282acce65 git log d19513f3ffbb..7bd282acce65 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 phoglund@webrtc.org Remove phoglund as root owner. 2020-03-30 sprang@webrtc.org Fixes issue where dynamic pacer could pace audio. 2020-03-30 olka@webrtc.org Revert "Add interface_id to rtc::Network" 2020-03-30 sprang@webrtc.org Add ability to disable padding prioritization. 2020-03-30 mbonadei@webrtc.org Fix -Wunreacheable-code on Mac. 2020-03-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 40e53740..dfa4a7a6 (754268:754373) 2020-03-29 mbonadei@webrtc.org Fix msvc bots build. 2020-03-29 kron@webrtc.org Reland "Distinguish between send and receive codecs" 2020-03-28 mbonadei@webrtc.org Revert "Trigger CI bots." 2020-03-28 mbonadei@webrtc.org Add more missing targets to gn_isolate_map.pyl. 2020-03-28 mbonadei@webrtc.org Trigger CI bots. 2020-03-28 mbonadei@webrtc.org Add missing xctest targets to gn_isolate_map.pyl. 2020-03-28 phoglund@webrtc.org Remove the histogram flag and all Chart JSON code. 2020-03-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c9f47595..40e53740 (754134:754268) 2020-03-28 deadbeef@webrtc.org Enforce "comprehension-required" STUN rules. 2020-03-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 7e5c10d3..c9f47595 (753978:754134) 2020-03-27 phoglund@webrtc.org Don't double import protobuf code. 2020-03-27 natim@webrtc.org Audio egress implementation for initial voip api in api/voip. 2020-03-27 jonaso@webrtc.org Modify IceControllerInterface::SelectConnectionToPing - step 3 2020-03-27 phoglund@webrtc.org Reland "Flip histograms to true by default, fix unit in isac_fix_test." 2020-03-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1ca2dc5c..7e5c10d3 (753877:753978) 2020-03-27 phoglund@webrtc.org Add PYTHONPATH entry for proto internal. 2020-03-27 phoglund@webrtc.org Reland: Add in missing protobuf code. 2020-03-27 jonaso@webrtc.org Implement Connection::ForgetLearnedState() 2020-03-27 phoglund@webrtc.org Revert "Add in missing protobuf code." 2020-03-27 jonaso@webrtc.org Modify IceControllerInterface::SelectConnectionToPing - step 2 2020-03-27 phoglund@webrtc.org Revert "Flip histograms to true by default, fix unit in isac_fix_test." 2020-03-27 phoglund@webrtc.org Add in missing protobuf code. 2020-03-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2d4ff360..1ca2dc5c (753737:753877) 2020-03-26 phoglund@webrtc.org Use = in flags from flags_compatibility.py. 2020-03-26 crodbro@webrtc.org Allow setting a bandwidth cap for relayed connections. 2020-03-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 43d15e14..2d4ff360 (753631:753737) 2020-03-26 phoglund@webrtc.org Partial revert of flag simplification. 2020-03-26 phoglund@webrtc.org Flip histograms to true by default, fix unit in isac_fix_test. 2020-03-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c145d480..43d15e14 (752799:753631) 2020-03-26 danilchap@webrtc.org in RtpExtension constructors pass strings by string_view rather than by value 2020-03-26 phoglund@webrtc.org Fix low bw test. 2020-03-26 jonaso@webrtc.org Modify IceControllerInterface::SelectConnectionToPing - step 1 2020-03-26 sprang@webrtc.org Make BitrateProber::IsProbing() inline. 2020-03-26 phoglund@webrtc.org Add debug info to low bw test. 2020-03-26 mbonadei@webrtc.org Revert "Roll chromium_revision c145d480..73b2f9fe (752799:753151)" 2020-03-26 mbonadei@webrtc.org Revert "Roll chromium_revision 73b2f9fe..83822ea8 (753151:753288)" 2020-03-26 mbonadei@webrtc.org Revert "Roll chromium_revision 83822ea8..57d80a05 (753288:753397)" 2020-03-26 mbonadei@webrtc.org Revert "Roll chromium_revision 57d80a05..e8ae36de (753397:753511)" 2020-03-26 crodbro@webrtc.org Handle extended route information in TransportFeedbackAdapter. 2020-03-26 phoglund@webrtc.org Reland "Switch low bw audio test to histograms." 2020-03-26 phoglund@webrtc.org Revert "Switch low bw audio test to histograms." 2020-03-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 57d80a05..e8ae36de (753397:753511) 2020-03-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 83822ea8..57d80a05 (753288:753397) 2020-03-25 alito@webrtc.org Implement AudioEncoder::GetFrameLengthRange() for all audio encoders. 2020-03-25 agrieve@google.com Chromium refactor: Replace "resources_dirs" with "sources" 2020-03-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 73b2f9fe..83822ea8 (753151:753288) 2020-03-25 saza@webrtc.org Remove unused dependency on APM in audio mixer 2020-03-25 mbonadei@webrtc.org Compile ADM pulse code by default. 2020-03-25 mbonadei@webrtc.org Prefix ALSA and PULSE macros with WEBRTC_. 2020-03-25 phoglund@webrtc.org Switch low bw audio test to histograms. 2020-03-25 danilchap@webrtc.org Make all RtpExtension uris constexpr rather than just const 2020-03-25 jonaso@webrtc.org Add interface_id to rtc::Network Created with: gclient setdep -r src/third_party/webrtc@7bd282acce65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1024965,chromium:1029452,chromium:1029737,chromium:1051927,chromium:1062263 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I38ea675897c3f1725a965d1a17aa4f6e88d1c6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127128Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754485}
-
Colin Blundell authored
This CL adds integration tests of launching an external intent from a link to WebLayer. The tests exercise both launching the intent in the same tab and launching the intent in a new tab. To enable these tests, this CL adds some infrastructure: - InstrumentationActivity now has basic support for multiple tabs. - InstrumentationActivityTestRule's returning of the display URL was changed to return that of the URL view in InstrumentationActivity. The previous logic (returning the URL of the current navigation entry in the active Tab) does not account for the case where there are no committed entries in the Tab but there is a pending entry (a case being tested in this CL). Bug: 1031465 Change-Id: I6261bd063e9a73ef0f274c8a311021a286c204ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127088Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#754484}
-
Richard Knoll authored
Sender and receiver flows of a WebRTC transfer for Sharing messages have different characteristics. This splits the metrics between them so we can better understand the histograms. Bug: 1048630 Change-Id: I72d1a64c60afce3acfd370754758576003ead76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117754 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#754483}
-
Bo Liu authored
This reverts and rewrites r654240. The old implementation caused issues in focus / layouts. This implementation simply avoids sending size down on entering fullscreen since the newly created FullScreenView is guaranteed to be 0x0. Generally FullScreenView is resized directly to its final size, so there is need for more complex workarounds. Bug: 1061837, 1065173 Change-Id: Id182d28b4731f6a3bc097076804e7305b4d8f951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124948Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754482}
-
Dominique Fauteux-Chapleau authored
TBR=boliu@chromium.org Bug: 1065585 Change-Id: Id912c8c6abc3681f58a2e5b4f52e1349e3321b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127426Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#754481}
-
Yi Gu authored
The flaky tests are not related to worklet animations because it's the reference file that is not painted correctly. Mac scrollbars have their own painting path and they paint greedily. There might be a race condition on the order of painting that caused the scrollbar being completely black. Bug: 946534 Change-Id: I5e2fab05e7a5ee5ec09dcab2a03606ca5ce1fd0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124296 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#754480}
-
Maksim Sisov authored
The SoftwareOutputDeviceOzoneTest.CheckCorrectResizeBehavior should only test SoftwareOutputDevice and it doesn't matter if ozone platforms support that or not. Thus, add a test impl of ozone canvas so that we don't have to check what platform the test is run on and we don't have to expose the platform's name. Change-Id: I3263a0267580df125c0b6ea8348cad6ef3a0461a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124374Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#754479}
-
Marc Treib authored
This updates MultiStorePasswordSaveManager to call ComputePendingCredentialsState twice; once for the credentials from each store. MultiStorePasswordSaveManager then decides based on the two results which action(s) to take in each store. Bug: 1012203 Change-Id: I0084c4c1a54e0df9da125904fa1d834a61115725 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120497 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#754478}
-
Torne (Richard Coles) authored
Downstream can now set `define_upstream_webview_targets` to cause the upstream version of the WebView targets to always be defined, even when `public_android_sdk` is false. To make the target continue to have the same dependencies as when it was defined downstream, depend on the downstream code required to support the R SDK if the build is targeting R and the SDK is not yet public. Bug: 760187 Change-Id: Iadb62e4da95f8760e420bc264c780d27ba70d35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125068 Commit-Queue: Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#754477}
-
Ewann authored
This CL moves privacy related files in a common folder. Bug: 1064961 Change-Id: I3ebae63794c64951790ad1eb8ebb115da5b60a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121262Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#754476}
-
Denis Kuznetsov authored
Change-Id: Id5ba62b0f42faa2847cfcd0db39534b4c236d12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127086Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#754475}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I847353814c1082a3badb60a162a912355f8fcf26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127130Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754474}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5269c313..056e6aee Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia8d16d06ee210ffb5f9041695bbe899dfd2532e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127347Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754473}
-
Dave Tapuska authored
full-screen-iframe-not-allowed.html isn't required anymore there are sufficient WPT tests to cover this. Also why it was failing is that Chromium allows fullscreen for the same origin. Adjusted video-controls-fullscreen-iframe-not-allowed to ensure fullscreen is disallowed for the same origin frame. BUG=718155 Change-Id: I3576467606cd5f9621ba4ca7f94259a79e69a967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118756Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#754472}
-
Alex Ilin authored
This histogram will be useful for the upcoming browser consent flow experiment. Fixed: 1063927 Change-Id: Ic861cefd048ab35fdb8a44d17d7b52a524ae2f76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127208 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#754471}
-
Dominique Fauteux-Chapleau authored
This reverts commit a7b569e6. Reason for revert: Closed the tree Original change's description: > Enable -Wunreachable-code in iOS builds (except for internal builds). > > This requires replacing EARL_GREY_TEST_DISABLED with DISABLED_ prefixes > in cases where the call to EARL_GREY_TEST_DISABLED is unconditional. > earl_grey/disabled_test_macros.h, which defines EARL_GREY_TEST_DISABLED, > says: > > This macro should be used when the configuration for which the > test should be disabled can only be determined at runtime. > Disabling at compile-time is always preferred. > > So this matches the official guidance, and there are many > egtests that use DISABLED_ already. > > Bug: 346399 > Change-Id: Ibe51463ec0e6afbd1b3bef629406163118efa64c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125878 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754468} TBR=thakis@chromium.org,sdefresne@chromium.org Change-Id: Ib0ccce331d5063a2f22ed9c25ebdf40bf3bd19d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 346399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127487Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#754470}
-
Mark Cogan authored
When the BVC owned the CommandDispatcher instance, it made sense for it to be responsible for setting up application-layer dispatch. Now that Browser owns the command dispatcher instances, it's possible to remove this responsibility from the tab-scoped objects (BVC and BVCoordinator). This CL instead has the BrowserViewWrangler set up dispatch to the application and browsing data removing objects; sine this is where these objects are injected into the tab-scoped object graph, this removes two layers of object forwarding. (In the near future, when SceneController and BVWrangler are unified and cleaned up, another layer of object passing will disappear). Change-Id: I37747e349aed98501d133310ae50662aab2577df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124381 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#754469}
-
Nico Weber authored
This requires replacing EARL_GREY_TEST_DISABLED with DISABLED_ prefixes in cases where the call to EARL_GREY_TEST_DISABLED is unconditional. earl_grey/disabled_test_macros.h, which defines EARL_GREY_TEST_DISABLED, says: This macro should be used when the configuration for which the test should be disabled can only be determined at runtime. Disabling at compile-time is always preferred. So this matches the official guidance, and there are many egtests that use DISABLED_ already. Bug: 346399 Change-Id: Ibe51463ec0e6afbd1b3bef629406163118efa64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125878 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#754468}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be1957b9b903..8df96b104065 Created with: gclient setdep -r src-internal@8df96b104065 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9e3a044413d9a5c973629489ff2940bbfb361426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126731Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754467}
-
Samuel Huang authored
To accommodate .aab files and TriChrome, we'd like SuperSize to handle multiple "containers" and store data in a single .size file. This CL performs refactoring archive.py to prepare for extending SuperSize for multiple containers. Details: * Move temp-file extraction logic with |args.minimal_apks_file| depper, into _DeduceMainPaths(). * Remove |args.extracted_minimal_apk_path|. * CreateSizeInfo(): * Change params to take lists of {metadata, section_sizes, raw_symbols}. * Implementation TODO; keep old behavior by simply using the first element of the above. * _DeduceMainPaths(): * Change to a generator that yield multiple param sets, one for each container. * Resolve |apk_prefix| and |apk_path| as separate concepts. * Move most of the logic to _Inner() function. * Split out _DeduceAuxPaths(). * Run(): * Merge with _RunInternal(). * Main action changes: * Visits param sets generated from _DeduceMainPaths(). * Potentially create multiple {metadata, section_sizes, raw_symbols}, now stored into |*_list| variables. Bug: 900259, 1040645 Change-Id: Ib158f3d5c8b11567f09826fd0c0b31729f4e065c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125388Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#754466}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/47e3be4efd27..50a47bd99229 git log 47e3be4efd27..50a47bd99229 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 55f01953d6e9..9a0f2d99fd5d (4 commits) 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 02e15b249b12..1c29477aa06e (19 commits) 2020-03-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src cc481ef27631..b0c27ce32864 (2 commits) Created with: gclient setdep -r src/third_party/angle@50a47bd99229 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I7030f1176bc428a313c07aaababa6310f381b883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127126Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754465}
-
Peng Huang authored
Tested with swiftshader on Windows 10. Bug: 1065499,963988 Change-Id: Ibce9fbca12332aec8fbc98ed838dfcc9d457ac21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125302Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754464}
-
Viktor Semeniuk authored
This change adds Show/Hide password functionality to the compromised credentials list menu. Bug: 1061054 Change-Id: I4823aa4edf6f9690f2e17d977123d82b75c245d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116178 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#754463}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/81431f5034b4..29d712f9de99 git log 81431f5034b4..29d712f9de99 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 natlee@microsoft.com D3D12 Immediately release pending commands Created with: gclient setdep -r src/third_party/dawn@29d712f9de99 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Iee0a2812545c1d55bcced7d116670107d7750d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126733Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754462}
-