- 03 Jun, 2020 40 commits
-
-
Evan Stade authored
Bug: 1007826 Change-Id: I5bc7931f3e9f7009f6566f03028c07df3ae1695a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225486 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#774457}
-
Sunny Sachanandani authored
Extend the GPU.DirectComposition.OverlaysSupported and OverlaysUsed histograms by a year. Bug: 1088821 Change-Id: Ie27e5a9cc157c8e88326434eb9dc3fbfd508222d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227314Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#774456}
-
My Nguyen authored
To meet Accessibility's contrast requirement of 4.5:1 minimum. Using kGoogleGrey700, contrast should be 5.91 Screenshot view: https://screenshot.googleplex.com/8oODpaXk02Y Bug: 1042084 Change-Id: I7c9980527fe915cb30a34a83f100073d0db4030b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224424Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774455}
-
Tomasz Wiszkowski authored
Change-Id: I4a598f87ca7b853ee93f02087945808e65ffef0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223263 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#774454}
-
Jochen Eisinger authored
Bug: 927509 Change-Id: Ic33449cf8f72637578f33b8ec21293866c5b45be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225719 Commit-Queue: Jochen Eisinger <jochen@chromium.org> Auto-Submit: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4af57c9c55fd..579c295b6bdb 2020-06-02 reed@google.com Android test to depend on icu and harfbuzz. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I2787ab4395d582b0943baf07a28f4980cf4f26cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774452}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bbbe9134378d..f2f4d5482a04 2020-06-03 dberris@chromium.org refactoring: Split file_bug into two components If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087803 Tbr: wenbinzhang@google.com Change-Id: I7ec4df8c787d030c13581f0d095fd2ca64ab85e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227569Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1591127928-6ca3eedb8c11f1c6551de9c000f330ab07bf1259.profdata to chrome-mac-master-1591142315-2ba0a5e7527dc77b459b1e931964833ae1598a98.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I63f7b381d96c8d3b0d0eecf2fe44ac547622afa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227575Reviewed-by:
-
Nate Fischer authored
No change to logic. This swaps "Android.WebView.DevUi.SessionDuration" for "Android.WebView.DevUi.SessionDuration2" to capture sessions up to 1 hour (by using recordLongTimesHistogram100). Fixed: 1087152 Test: None Change-Id: Ie0289f6303ea286494c84466beacb189e2d5bf43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225820 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
-
Behnood Momenzadeh authored
Target Embedding at times matches top domains that are embedded with a wrong TLD (e.g. google-info-foo.com). If the embedded TLD does not match the top domain's TLD and it is a ccTLD, we trigger a Safety Tip instead of a Lookalike Interstitial. The reason behind this decision is that, ccTLDs are short TLDs and are often used as locales, which can lead to more false positives. Bug: 1087636 Change-Id: I2dfe76c037070c98649df1399c8948f004c2bdf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225747 Commit-Queue: Behnood Momenzadeh <behnoodm@google.com> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#774448}
-
Giovanni Ortuño Urquidi authored
This reverts commit 98d00374. Reason for revert: Both of these are failing on MSAN: SigninReauthViewControllerBrowserTest.CancelReauthDialog SigninReauthViewControllerBrowserTest.ConfirmReauthDialog https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests https://ci.chromium.org/p/chromium/builders/ci/Linux%20MSan%20Tests/24165 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878588233120522160/+/steps/browser_tests/0/logs/Deterministic_failure:_SigninReauthViewControllerBrowserTest.CancelReauthDialog__status_CRASH_/0 Original change's description: > [signin] Add browser tests for the reauth dialog > > This CL adds tests for the first step of the reauth flow, the reauth > confirmation dialog. The tests check that clicking on all buttons > produces expected results. > > The tests for the second step of the reauth flow will be added in > follow-up CLs. > > Bug: 1045515 > Change-Id: I4266f29ea03080d3d6612099a0b9a49cff5cdf09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219897 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774122} TBR=droger@chromium.org,alexilin@chromium.org Change-Id: I08bfa073e1b51c4dbb3125232cc4b60880deb293 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227932Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#774447}
-
Sujie Zhu authored
When nickname management is disabled, hide the new error message. When nickname management is enabled, we will hide the legacy error message, and use the new expired error message format. When expired, display error message below the dropdown. Also change the expiration date label's color when expired. Note that for valid expiration, we don't hide the message, we set visibility of the error message to hidden in order to reserve the space. (Same behavior as the cr-input). Bug: 1082013 Change-Id: Id61262ea315bce62ffa5aa4b3bffa26aff3f2632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223151 Commit-Queue: Sujie Zhu <sujiezhu@google.com> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#774446}
-
Hitoshi Yoshida authored
IDL dictionary provides a way to check if a member is missing or not. This CL fixes a wrong way of the check in ServiceWorkerContainer. Bug: 839389 Change-Id: I7134bbcdfb290db26fca14aeaa903d165215097d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224421 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774445}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ce9a17d4..b952659f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I693e52569582c7474fed0fd5705268fa4b8ddc7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225550Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774444}
-
zhaoyangli authored
Will observe if there are issues from the experiment then set code coverage as default in iOS CQ builders. Bug: 1090188 Change-Id: I77e58aefbfc4964f63de61cef7bd7a351d11bfc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227236 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#774443}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/70b11675ddaf..9172a9f05054 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dmazzoni@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1047629,chromium:1085419,chromium:1087057,chromium:1090082,chromium:1090105,chromium:1090456 Tbr: dmazzoni@google.com Change-Id: I7ca1a2a09cb8262ea1aefde9dd1d8c5d15be9827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227287Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774442}
-
Mason Freed authored
It makes more sense to count this feature at the usage site, which is Element::AttachDeclarativeShadowRoot. Bug: 1042130 Change-Id: I53ffbf6821b56e964dc5ab1eae84a0ed566a96e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227338 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#774441}
-
Nick Harper authored
Change-Id: Ibfaaccad7eb871fdeeefa93274b39496ea4b6ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227173 Commit-Queue: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#774440}
-
Sinan Sahin authored
Bug: 1088069 Change-Id: I37b24a8f374d36f6d49d306748f59187b21e23d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225552Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#774439}
-
Mason Freed authored
This connects the RuntimeEnabledFeature to a base::Feature to allow this feature to be Finch tested. Bug: 901056 Change-Id: I337c46ed04361abb05913678c265489b01038da5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227100 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#774438}
-
Ian Wells authored
Bug: 1044139 Change-Id: Ib06335cd3ac0f85a0c44a21094457b65585fca64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220228 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#774437}
-
Kent Tamura authored
This CL ports LayoutRubyRun::GetOverhang() to LayoutNG. Overhang values are represented as negative margins of ruby run boxes. Bug: 1069817 Change-Id: I487a633982d40211ee672d71caf00fadd88a07e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224895 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774436}
-
Giovanni Ortuño Urquidi authored
This reverts commit 6c7cfb00. Reason for revert: Causing media-unittest failures on win-asan https://ci.chromium.org/p/chromium/builders/ci/win-asan/12503 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8878571776794508208/+/steps/media_unittests_on_Windows-10-15063/0/logs/Deterministic_failure:_D3D11VideoDecoderTest.DoesNotSupportEncryptionWithFlagOn11_0__status_CRASH_/0 ==12148==ERROR: AddressSanitizer: heap-use-after-free on address 0x11f0e8b56314 at pc 0x7ff697ff598f bp 0x00d00939e830 sp 0x00d00939e878 READ of size 24 at 0x11f0e8b56314 thread T0 #0 0x7ff697ff59b8 in __asan_memcpy C:\b\s\w\ir\cache\builder\src\third_party\llvm\compiler-rt\lib\asan\asan_interceptors_memintrinsics.cpp:22 #1 0x7ff69882a563 in media::GetSupportedD3D11VideoDecoderResolutions C:\b\s\w\ir\cache\builder\src\media\gpu\windows\supported_profile_helpers.cc:222 #2 0x7ff69881fa44 in media::D3D11VideoDecoder::GetSupportedVideoDecoderConfigs C:\b\s\w\ir\cache\builder\src\media\gpu\windows\d3d11_video_decoder.cc:912 #3 0x7ff695f9192c in media::D3D11VideoDecoderTest::CreateDecoder C:\b\s\w\ir\cache\builder\src\media\gpu\windows\d3d11_video_decoder_unittest.cc:189 Original change's description: > Refactor GetResolutionsForDecoders() to support AV1. > > Does the following: > - Internalizes h264 and min resolution details. > - Sets the minimum resolution to 64,64 for both decoders. > - Only loops through the video device profiles once. > - Switches away from an std::pair to a named struct. > - Adds AV1 GUID values and uses them in DXVA decoder. > - Stops D3D11VideoDecoder for enumerating unsupported profiles. > - Stops using the DXVA2_Intel_ModeH264_E for enumeration. > - Gives all resolution tests a square resolution; e.g., 4k x 4k. > - Doesn't test or indicate support for a duplicate portrait resolution. > > R=liberato, tmathmeyer > > Bug: 1073252 > Test: Updated unittests. > Change-Id: I8013e89104c96fad845fdbaecdb1d4b239f9a380 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223261 > Commit-Queue: Frank Liberato <liberato@chromium.org> > Reviewed-by: Ted Meyer <tmathmeyer@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774317} TBR=dalecurtis@chromium.org,liberato@chromium.org,tmathmeyer@chromium.org Change-Id: Idb9d7d61938860c46ed72cd588d48fb5eeedadf0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1073252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227710Reviewed-by:
-
tby authored
The plan for integration testing in the launcher is roughly as follows: 1. Give search providers a method to identify themselves with a search result type (<- this CL). 2. Use the getter to inform the Mixer _which_ search provider is triggering a OnResultsChanged call. 3. Add hooks into the Mixer allowing a RunLoop to wait until a list of providers have created results and called OnResultsChanged. 4. Use the RunLoop hooks to build integration tests that inspect the result of a query after all relevant providers have completed. This CL adds a getter method that lets each SearchProvider identify itself with a particular search result type. Two providers, SettingsShortcutProvider and ArcAppDataSearchProvider, don't appear to have enum entries for their result types. I've given them kUnknown for now, and we can update them if they ever need to be integration tested. Due to the asynchrony of the search backend, we need this kind of "wait until providers are done" system in order to know how long to wait for in a browser test, as browser tests don't support ScopedTasksEnvironments and the like. In future we could use this system to optimize search ranking, as we would know which results are new, and could avoid re-ranking already ranked results. Bug: 1086713 Change-Id: Icac3efaaf963a4b5e445dd0a0de8fd435fd27f61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214736Reviewed-by:Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#774434}
-
Yuichiro Hanada authored
ArcImeService provides the method, SetArcWindowDelegateForTesting() to inject a fake instance of ArcWindowDelegate for testing. However, the instance of ArcWindowDelegate was generated in the constructor and used in the constructor, so that usage cannot be faked. This CL adds a new constructor for testing to ArcImeService to fix it. Bug: b:148193316 Test: component_unittests Change-Id: Ia3b6c68bbc66fd4d5bc640ecdabbb707143cfff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224943 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#774433}
-
zhaoyangli authored
This is to only instrument CL affected files for iOS coverage try builder for efficiency. Bug: 1090188 Change-Id: I386dcafef9ee174a7b22cbc0073ee58118f4ed6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227305Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#774432}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fc0efae149cb..a40746d97615 2020-06-02 treehugger-gerrit@google.com Merge "trace_processor_shell: don't quit on CTRL-C" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic408846d2fd2243b9688572b514bc6e5905f07f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227283Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/907433b9f820..e817aaa40954 2020-06-02 bclayton@google.com libVulkan: Use new marl::Scheduler::Config API. 2020-06-02 bclayton@google.com Kokoro: Test LLVM 10 backend for macos 2020-06-02 bclayton@google.com Merge changes I5eaceebc,I4d78c011,I7d01a3c8 2020-06-02 caio.oliveira@intel.com Update VkStringify for VK_EXT_subgroup_size_control 2020-06-02 caio.oliveira@intel.com Update Vulkan headers to version 1.2.141 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I52a4d194907046bada444db98c853ef199aeb072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227275Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/76a2918f55cd..cf77d6e387b6 2020-06-02 vapier@chromium.org repo: update to 2.8 launcher If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Test: Test: `repo sync` still works Change-Id: I4d6b3983bda93e662507076df2a4ad9781810b7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227281Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/88bc40da7991..9f2374511ab3 2020-06-02 chrche@microsoft.com Add customization to i18n.js 2020-06-02 cjamcl@chromium.org Update the fallback revision for remote modules. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I55982b72cb119c3db08625d8ce4f287a086a88e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227284Reviewed-by:
-
Robert Liao authored
Change-Id: Ia30b175784474592469f9a862592125416d15726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227310 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#774427}
-
Yuwei Huang authored
Currently ftl_echo_message_listener_ is never explicitly freed, and it calls `signal_strategy_->RemoveListener(this)` in its dtor, while signal_strategy_ is freed in HostProcess::OnHostOfflineReasonAck. This causes a use-after-free issue when the ftl_echo_message_listener_ is explicitly freed, which means the host would crash in shutdown and soft restart. This CL frees ftl_echo_message_listener_ before signal_strategy_ is freed. Bug: 1090595 Change-Id: Ie546a9084fdf21545ecd9158b9830cc93335ecb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227265 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#774426}
-
Peter Kasting authored
This simplifies some code that no longer needs to worry about whether they're supported. Bug: none Change-Id: I728fb9a93373d6cb3674c5dbaecccce341774780 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227101 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774425}
-
Tina Wang authored
- Add customized item and cell for settings which has a toggle switcher once not managed by policy. - Apply to "Save Password" setting. - Add corresponding method to handle click action of the info button. Screenshot: https://screenshot.googleplex.com/6doUPsk0Dmj Bug: 1087223 Change-Id: I3140c7cfb99dbaf46f8679c4e675b9ab0002d6c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219569 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#774424}
-
Bo Liu authored
Change-Id: I975b7d0bbd7bc7c002954939563d5e54cdcbc1f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227375Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774423}
-
Scott Violet authored
To fully support onScrollOffsetOrExtentChanged() comes at a performance cost. As very few places actually need this, this creates a new interface with onScrollOffsetOrExtentChanged() and converts the places that need it to the new interface. BUG=1087480 TEST=none Change-Id: I1f54bdf74ee0b6006fc92284bc761ed6992a0d55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225548 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774422}
-
Sammie Quon authored
Test: added test Bug: 1077922 Change-Id: Id596f604a24e230c818fa81c930782c9fa4841eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227289Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#774421}
-
Rouslan Solomakhin authored
Before this patch, Android integration tests for payment handler capabilities used the internals of ServiceWorkerPaymentApp.java, which prevented moving the payment handler logic from Java to the C++ service_worker_payment_app.cc. This patch replaces one Android integration test for capabilities with a cross-platform browser test. After this patch, fewer tests depend on ServiceWorkerPaymentApp.java internals, so its logic can be moved from Java to C++ easier. Design: https://bit.ly/cross-platform-pay-app-factory TBR=yusufo@chromium.org Bug: 1022512 Change-Id: I5d2bd943f079f501a681a5ef03d12329d3d91d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223650 Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Brandon Maslen authored
This change adds telemetry to the Storage Access API with the goal of tracking the utilization of the API and how the API is being used. This includes the following metrics: - UseCounter for document.hasStorageAccess and document.requestStorageAccess methods. - Histogram API.StorageAccess.AllowedRequests to track how often requests for storage access are allowed/blocked and specifically allowed due to the API. - Histogram API.StorageAccess.GrantIsImplicit to track how often requests generate an implicit vs explicit grant. - Histogram API.StorageAccess.RequestStorageAccess to track how the main method for the API is utilized and how frequently usage is successful or fails for various reasons. Various tests have been added where possible to validate the associated telemetry items have been fired. Bug: 989663 Change-Id: I44ecf8240ccfd50fee445e1782e9a578354ab68a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211135 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#774419}
-
Yoichi Osato authored
This CL relands the patch crrev.com/c/2172724, which was reverted as crrev.com/c/2224218 due to 1. linux-blink-cors-rel failure 2. http/tests/loading/bad-server-subframe.html failing on mac bots I fixed #1 by updating FlagExpectations/disable-features=OutOfBlinkCors. For #2, it is reported flaky: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyTwsSBUZsYWtlIkRjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAaHR0cC90ZXN0cy9sb2FkaW5nL2JhZC1zZXJ2ZXItc3ViZnJhbWUuaHRtbAw (guessed crrev.com/c/2219088 the culprit). Now this CL passes the bots. Bug: 688906 Cq-Include-Trybots: chromium/try:mac10.10-blink-rel,mac10.11-blink-rel Change-Id: I9d64f917014096f79b224369fc719e9743086b45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226103Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#774418}
-
