- 11 Oct, 2019 40 commits
-
-
Christopher Cameron authored
This was the result of an infinite loop wherein - RWHVMac::OnFirstResponderChanged(true) would eventually call - (bunch of views::Views stuff) - RWHVMac::Focus() - Making the RWHVCocoa first responder, calling - RWHVMac::OnFirstResponderChanged(true) Early-out of redundant calls to RWHVMac::Focus, to break this loop. Bug: 998123 Change-Id: Iacf9abb6b03c07d11bd1168a7d9d7459a69fc554 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848893Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#704986}
-
Hayato Ito authored
This reverts commit 8f8c19f0. Reason for revert: flakiness again See https://bugs.chromium.org/p/chromium/issues/detail?id=1000251#c25 Original change's description: > Revert "[Sheriff] Disable BookmarkBarInvisibleOnShutdown on Linux" > > This reverts commit 2e452bbf. > > Reason for revert: https://crbug.com/1000251 is fixed. > > Original change's description: > > [Sheriff] Disable BookmarkBarInvisibleOnShutdown on Linux > > > > TBR=weidongg@chromium.org > > > > Bug: 1000251 > > Change-Id: I8e3372766ab9e560c9f47f7c2f8292ebc8af644c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782637 > > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#692666} > > TBR=jdoerrie@chromium.org,weidongg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1000251 > Change-Id: Id9af5a221f5ca04873ce30737c2a9be58afd9fb3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844854 > Reviewed-by: kylechar <kylechar@chromium.org> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: kylechar <kylechar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703303} TBR=kylechar@chromium.org,jdoerrie@chromium.org,weidongg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000251 Change-Id: I5f798d35aee20756268151c510c27a7a5bcf5515 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855245Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#704985}
-
Yoshifumi Inoue authored
This patch implements |NGFragmentItem| version of selection painting by using |NGInlineCursor| to share logic with |NGPaintFragment| version. Bug: 982194 Change-Id: I44bd0e1b93db611fb03459179dda0bf5d350167d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832843 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704984}
-
Jeremie Boulic authored
When creating new folders from the directory tree, the new entry was sometimes added in the wrong spot due to the way labels were compared. The folders were then immediately reordered, causing the new folder to lose its renaming state with the corresponding input box. Issue fixed using the util.compareName function. Test to be added. Bug: 1004717 Change-Id: I1005e1061b099b195ea87d4b50b0a121f17d593b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855145 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#704983}
-
David Staessens authored
CL crrev.com/c/1831728 introduced extra command line options to the video_decode_accelerator_tests. Unfortunately this change caused the video_decode_accelerator_perf_tests to ignore the '--output_folder' parameter. This is causing all tast.video.DecodeAccel(VD)Perf* tests to fail. TEST=./video_decode_accelerator_perf_tests --output_folder=test_folder BUG=b:142515248 Change-Id: I8ec751a89e0809de320965215d2dea31333e0bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855242Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#704982}
-
Nick Harper authored
Change-Id: I8e6a7aa26662bbd65443c05808c499f956be8917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854527 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704981}
-
Dmitry Gozman authored
These two mean the same: client navigation should be aborted, most likely because a new one has started, or frame has been detached, or due to window.stop() call. This also adds missing RFO::DidFailProvisionalLoad call to AbortClientNavigation. Previously, we notified about the navigation start, but if it was aborted we did not notify RFOs. This corresponds to the step 7.h from the doc linked to the bug. Bug: 855189 Change-Id: I9a643870fd2f70645156bc6e5cc46da9c60a6c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802521Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704980}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I02f2654aff00e45e41997f8a2e15349116f1d2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854920Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704979}
-
Julie Jeongeun Kim authored
This CL converts TrialComparisonCertVerifierConfigClient and TrialComparisonCertVerifierReportClient from trial_comparison_cert_verifier.mojom using PendingReceiver, PendingRemote, Remote, RemoteSet, Receiver, and ReceiverSet. Bug: 955171 Change-Id: Ib2c97b143d2ee0a631531ee24e66007b91e80b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847411 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#704978}
-
Sammie Quon authored
Keeps this behind a flag, support for old wallpaper blur still exists. Copies the wallpaper layer to a layer which is blurred and kept alive for the duration of overview. Test: manual Bug: 1012829 Change-Id: I74046bb522d0751304cadd5aa5dd361f70b2831c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842698Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#704977}
-
Fergus Dall authored
Bug: 1011858 Change-Id: I9a151ceeb42326ca500d2f0a5a16d5aa9d6c16b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847705 Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#704976}
-
Ahmed Fakhry authored
- Remove Attempt Enter/Leave TabletMode() which was scattered and used all over the place. - Make a clear distinction between a device physical tablet state (which is affected by device events such as lid angle changes, tablet EC switches, ... etc.) and a UI tablet state (which is whether the UI is currently in tablet or clamshell modes). - Gather all the inconsistent and scattered logic that affects the device and UI states into consolidated, and clear functions that get invoked whenever the state needs to be updated. This CL is a prerequisite work for the auto-rotation work coming up soon. BUG=925087 TEST=No behavior change, all tests must pass. Change-Id: If4c2777f434a09f3c70b32bb60367cfb118102b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851286 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
-
Noel Gordon authored
Our tree.css file is derived from cr.ui.Tree tree.css file, and should follow it rule-for-rule (mostly). The directory-tree section-start CSS rule is specific to FilesApp: move it to file_manager.css. Bug: 992819 Change-Id: I2fbfaaf539219da0f448fbeb1b6192b59b66c18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851627Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#704974}
-
Hayato Ito authored
Disable flaky SingleClientBookmarksSyncTest.ApplyRemoteUpdateWithValidGUID on all platforms. TBR=mmoskvitin@google.com Bug: 1012223 Change-Id: I7712d8010a2d54ac96315f0f704d161f45a94c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855144Reviewed-by:
-
chrome://settings/siteDataS. Ganesh authored
The underlying root cause for the bugs is that the javascript callbacks are not called for the handler cases where the cookies tree model is recreated. Also made some misc minor fixes and substitution of deprecated calls. Fixed: 795611,877082,1011734,845245 Change-Id: If94f701008dac9e0ddde3a85e7953b9b45f75934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851229 Commit-Queue: S. Ganesh <ganesh@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#704972}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/788d15f52867..284b45288355 git log 788d15f52867..284b45288355 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 crouleau@chromium.org [Telemetry] Support environment argument to enable chromium-side change. Created with: gclient setdep -r src/third_party/catapult@284b45288355 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:985103 Change-Id: I083842801593b8c846b9742f519ad9ba61386810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854509Reviewed-by:
-
Hayato Ito authored
Mark the following tests flaky. - external/wpt/fetch/cross-origin-resource-policy/fetch.https.any.sharedworker.html - virtual/omt-worker-fetch/external/wpt/fetch/cross-origin-resource-policy/fetch.https.any.sharedworker.html TBR=creis@chromium.org BUG: 1012599 Change-Id: I7212bea927e0fbc170e5905cb7bf1f0137c768c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855060Reviewed-by:
-
Antonio Gomes authored
... and the respective unittest, rtc_rtp_receiver_unittest.cc This CL works out phase 7.1 on the design document [1]. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ In order to avoid colliding files and classes names with existing homonyms in renderer/modules/peerconnection, the following renames were performed: - rtc_rtp_receiver.cc -> rtc_rtp_receiver_impl.cc - rtc_rtp_receiver.h -> rtc_rtp_receiver_impl.h - rtc_rtp_receiver_unittest.cc -> rtc_rtp_receiver_impl_test.cc Also, RTCRtpReceiver became RTCRtpReceiverImpl. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I4e13b647da1f329868dadd7e59cc13cdc8963797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819801 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704969}
-
Leo Zhang authored
Bug: 937152 Change-Id: Iecba7262a97ae67d2cf76ffa8fa3100f1628f864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852348Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Auto-Submit: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#704968}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/11dd6af79212..88c57b498266 git log 11dd6af79212..88c57b498266 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@88c57b498266 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Id0d02848664bacc430553488ce367410a9860682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854887Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I1b06a4540c13b6e4628dec999fdda454f7a393a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855220Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704966}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=wolenetz@chromium.org Bug: 1007760 Change-Id: Iae662b1ee6021c4c0332df55b3775348309df4bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849484 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704965}
-
Darin Fisher authored
This CL converts more callsites over to the new form of WindowToViewportScalar that takes a LocalFrame* parameter. Some callsites remain that will be converted in a follow-up CL, enabling the old version of the function to be removed. Bug: 1006919 Change-Id: I6be0dbfe261407f4ccf2780ac31b874f8eac1d14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823418Reviewed-by:
-
Kenichi Ishibashi authored
Allows callsites of this helper function to pass RegistrationOptions. It will be useful for testing module service workers. Bug: 824647 Change-Id: Idc9a5c012144da46dfc4d692ce26df9f604a6ea1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851624 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#704963}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/3273b5efd40c..e6f9bd000949 git log 3273b5efd40c..e6f9bd000949 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d66030f8..3fcb9481 (704779:704895) Created with: gclient setdep -r src/third_party/webrtc@e6f9bd000949 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ib98a171a6a0dc5aa6416ba678094486180eb67db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854886Reviewed-by:
-
Mikolaj Walczak authored
Create boilerplate for changing density in ARC++ applications on user input (CTRL +/CTRL -/CTRL 0) to simulate the behaviour of the chrome native apps. BUG=b:142100473 TEST=Manual Change-Id: I1e58e1b03b2cc07dfeaff22b0e49436936cbc228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847032 Commit-Queue: Mikolaj Walczak <walczakm@google.com> Reviewed-by:
-
Mandy Chen authored
Change-Id: Ie80d2017d76133359eedf50218a88fe60266c6a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854788Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704960}
-
Julie Jeongeun Kim authored
This CL converts FuchsiaCdmProvider from fuchsia_cdm_provider.mojom to new Mojo types using PendingReceiver and Remote. Bug: 955171 Change-Id: Ica239f58ea2fed59098144d300f454d3e22cb5cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849748 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#704959}
-
John Lee authored
Bug: 989131 Change-Id: I6ff22ccbbfc876dc6f43a757b700fecd901b2325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848481 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#704958}
-
David Staessens authored
This CL removes all buildbots that are using the deprecated video_decode_accelerator_unitest binary. These tests have been replaced by the video_decode_accelerator_tests and the video_decode_accelerator_perf_tests binaries. These buildbots are all run on the Windows platform, even though the video_decode_accelerator_unitest doesn't properly support this. A fake video decoder is used to run the tests, so we won't lose much functionality by removing them. crbug.com/952068 is used to track adding the new video decoder tests to the buildbots. note: the chromium.gpu.fyi.json file was generated by running the testing/buildbot/generate_buildbot_json.py script. TEST=running associated buildbots BUG=933034 Change-Id: Id02968f20db6ce49df4185bd23524f77aeb84f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851791Reviewed-by:Kenneth Russell <kbr@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#704957}
-
Zhenyao Mo authored
This is because we mostly return unsized internalformat. For example, for F16 images, we return RGBA as internal_format, and use utility function to get format/type, ending up with RGBA/UNSIGNED_BYTE, which is totally wrong. BUG=1009762 TEST=bots R=sunnyps@chromium.org,ericrk@chromium.org,kbr@chromium.org,ccameron@chromium.org,dalecurtis@chromium.org Change-Id: Id635d4970b824a35000b6efa5cbfee76a217599c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842516 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#704956}
-
Alexey Baskakov authored
Erase WebAppDatabase::BeginTransaction and WebAppDatabase::CancelTransaction. The contract "There can be only 1 update at a time" is tracked by the WebAppSyncBridge::is_in_update_ flag anyway. Get rid of this redundancy. Bug: 860583 Change-Id: Ib330014773509c9f2201f8e51eb7eccbde2b1705 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851626 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#704955}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3fcb9481. With Chromium commits locally applied on WPT: 23748e60 "Change text directive to text=" 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic5bfd3578d7914ea7b788988f2acd86e3be4e098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853952Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704954}
-
Antonio Gomes authored
This CL allows phase 7 in the design document [1], to be executed, and including the respective unittests. [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I0bfca719bc5de9392aaddf54c1fe4ebe21085e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819405 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Victor Costan authored
This CL removes blink.mojom.CookieStore from the list of browser interfaces provided via service_manager, and adds it to the list of interfaces provided via BrowserInterfaceBroker. This CL also expands interface availability from ServiceWorker-only to ServiceWorkers + Frames, in anticipation of an upcoming API change that will land in https://crrev.com/c/1837146 Bug: 729800 Change-Id: I93774e0297f8bb9fccd03e5d4ccc16b5dbc0f8af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852644 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Auto-Submit: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#704952}
-
Manu Cornet authored
Also: make presubmits happy by replacing NULL with nullptr. The artificial divide between the app list presenter and the rest of the app list code, due to a different namespace, doesn't need to exist anymore. The presenter code can be placed at the same level and be gradually merged with the rest, thereby removing some unnecessary complexity. Bug: None Change-Id: Ib5264453949fcbe6c00be7853c561264c32e1cdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854861 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
-
Canon Mukai authored
Vector named out_buffer_ was not freed, so I added out_buffer_.clear() in Flush. Bug: 999091 Change-Id: Id3bb458a126d4df61f42a6c43113368a89fcb889 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855058 Commit-Queue: Canon Mukai <canonmukai@google.com> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#704950}
-
David Staessens authored
This reverts commit 3c8fa0a5. Reason for revert: This change breaks the DecodeAccelSanityVP91 test. The CHECKS also don't print the associated message in release builds, but only "Trace/breakpoint trap (core dumped)" which makes them useless. Original change's description: > media/gpu/test: Change DCHECKS to CHECKS in video decoder test code. > > This CL changes some of the DCHECKS in the video_decode_accelerator_(perf_)tests > code to CHECKS, so they are also performed in release builds. This will make it > easier to debug some test-related issues. > > Ideally we would use the dcheck_always_on GN argument, but as the tests are > build as part of the Chrome binary this would greatly increase Chrome build time > as most libraries would have to be build twice. > > TEST=./video_decode_accelerator_tests on eve > > BUG=905520 > > Change-Id: I207abf4d53a5a3d1d5684fd5cd2a045e401bc9ad > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826297 > Commit-Queue: David Staessens <dstaessens@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703581} TBR=acourbot@chromium.org,dstaessens@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 905520, 1013439 Change-Id: I56cb5bb2cb7496d993e0fd3015cd7dc8c4a11add Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855141 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#704949}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b2b51418596e..8e57b4bc55c0 git log b2b51418596e..8e57b4bc55c0 --date=short --no-merges --format='%ad %ae %s' 2019-10-11 maruel@chromium.org python3 improvements 2019-10-11 ehmaldonado@chromium.org depot_tools: Add httplib2 to .vpython Created with: gclient setdep -r src/third_party/depot_tools@8e57b4bc55c0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182,chromium:1002153 Change-Id: I28503fa6f9155366de59d933e2a9dca1d68bf665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854567Reviewed-by:
-
danakj authored
RenderWidget is never entered by IPC when undead or provisional, not by C++ outside of Close() when undead. Branches can go away. R=avi@chromium.org Bug: 419087 Change-Id: Iebcd2501b60d3836d66acd6d64787d41322e8641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854522 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
-
