GitLab

TBR=fdoray@chromium.org

Bug: 857418
Change-Id: I70afce6260e3510fda0707cf36c5c5c21e07bc7b
Reviewed-on: https://chromium-review.googlesource.com/1118173Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571082}

The callback thread thread check may trigger if the
SilentSinkSuspender sets in.

Drive-by update the other thread check of this class to use a macro
and add missing includes.

Bug: 854774
Change-Id: I79f7c56886acd7f1ad56c466eb0c2825d1d8ec16
Reviewed-on: https://chromium-review.googlesource.com/1114973Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571081}

This bug occurs when painting NG child inside non-inline vertical-rl parent
with scrollbars.

Root cause is extra scrollbar offset that Paint applies to Legacy painting that
is not needed for NG.

The fix is hacky: NG applies reverse offset.

This fix does not make any additional tests pass or fail.

Bug: 852395
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I7dda2cdbf682485ab30c048987ae683981731886
Reviewed-on: https://chromium-review.googlesource.com/1115863
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571080}

This change implement adding new entry points for the new Autofill Home.
Also it adds the required icons. Both of these changes are gated behind
a flag.

Bug: 854562
Change-Id: Iee5b029045b59875ad4d98bffb856ddc9945171a
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1111853
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571079}

Move the test from TestExpectations to NeverFixTests, where all other
clearkey-mp4-playback-* tests are.

TBR=robertma, jrummell

Bug: 857271
Change-Id: Id1931c5049d297b2dd70c6388e9369f4aa5ae94f
Reviewed-on: https://chromium-review.googlesource.com/1118166Reviewed-by: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa (CET) <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#571078}

Adds a simple tool writing random data to a file, then reading it. The
file is optionally evicted from the OS page cache between the read and
write. This is used to assess device IO performance locally.

From an Android Go device (Gobo) running O MR1 with 360MB free on /data:

Without the OS page cache:
$ adb shell /data/local/tmp/io_benchmark /data/local/tmp/test 1
Size = 4096
 Write 4096 = 50.0us (81.92MB/s)
 Read 4096 = 1489.0us (2.75MB/s)
Size = 8192
 Write 8192 = 61.0us (134.30MB/s)
 Read 8192 = 1486.0us (5.51MB/s)
Size = 16384
 Write 16384 = 81.0us (202.27MB/s)
 Read 16384 = 1602.0us (10.23MB/s)
Size = 32768
 Write 32768 = 145.0us (225.99MB/s)
 Read 32768 = 1877.0us (17.46MB/s)
Size = 65536
 Write 65536 = 215.0us (304.82MB/s)
 Read 65536 = 2656.0us (24.67MB/s)
Size = 131072
 Write 131072 = 468.0us (280.07MB/s)
 Read 131072 = 4531.0us (28.93MB/s)
Size = 262144
 Write 262144 = 642.0us (408.32MB/s)
 Read 262144 = 5041.0us (52.00MB/s)
Size = 524288
 Write 524288 = 1219.0us (430.10MB/s)
 Read 524288 = 8949.0us (58.59MB/s)
Size = 1048576
 Write 1048576 = 2466.0us (425.21MB/s)
 Read 1048576 = 13606.0us (77.07MB/s)
Size = 2097152
 Write 2097152 = 4908.0us (427.29MB/s)
 Read 2097152 = 25840.0us (81.16MB/s)
Size = 4194304
 Write 4194304 = 9502.0us (441.41MB/s)
 Read 4194304 = 76867.0us (54.57MB/s)
Size = 8388608
 Write 8388608 = 20814.0us (403.03MB/s)
 Read 8388608 = 119062.0us (70.46MB/s)

With it:
$ adb shell /data/local/tmp/io_benchmark /data/local/tmp/test 0
Size = 4096
 Write 4096 = 56.0us (73.14MB/s)
 Read 4096 = 172.0us (23.81MB/s)
Size = 8192
 Write 8192 = 65.0us (126.03MB/s)
 Read 8192 = 23.0us (356.17MB/s)
Size = 16384
 Write 16384 = 101.0us (162.22MB/s)
 Read 16384 = 35.0us (468.11MB/s)
Size = 32768
 Write 32768 = 134.0us (244.54MB/s)
 Read 32768 = 57.0us (574.88MB/s)
Size = 65536
 Write 65536 = 229.0us (286.18MB/s)
 Read 65536 = 109.0us (601.25MB/s)
Size = 131072
 Write 131072 = 348.0us (376.64MB/s)
 Read 131072 = 170.0us (771.01MB/s)
Size = 262144
 Write 262144 = 721.0us (363.58MB/s)
 Read 262144 = 354.0us (740.52MB/s)
Size = 524288
 Write 524288 = 1895.0us (276.67MB/s)
 Read 524288 = 783.0us (669.59MB/s)
Size = 1048576
 Write 1048576 = 2405.0us (436.00MB/s)
 Read 1048576 = 2872.0us (365.10MB/s)
Size = 2097152
 Write 2097152 = 4688.0us (447.34MB/s)
 Read 2097152 = 3398.0us (617.17MB/s)
Size = 4194304
 Write 4194304 = 10358.0us (404.93MB/s)
 Read 4194304 = 6556.0us (639.77MB/s)
Size = 8388608
 Write 8388608 = 19040.0us (440.58MB/s)
 Read 8388608 = 17753.0us (472.52MB/s)

TBR=digit@chromium.org  # per tools/OWNERS

Bug: 837659, 857070
Change-Id: I33fe4aeb287a5c5910c941a580093d9fecf8f758
Reviewed-on: https://chromium-review.googlesource.com/1116700
Commit-Queue: Benoit L <lizeb@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571077}

This reverts commit deb6bb60.

Reason for revert: This causes much crash on clusterfuzz.
Original change's description:
> Let SelectionPaintRange iterator iterate on a flat tree.
> 
> SelectionPaintRange::Iterator iterated LayoutObjects using layout order
> but we marks SelectionStatus on flat tree order.
> This causes invalidation leak if they are not same order.
> Ruby element is a reported example for that.
> 
> This patch changes SelectionPaintRange::Iterator iterate on a flat tree
> considering first-letter.
> 
> Bug: 843144
> Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
> Change-Id: I02cbad86e64d0a7781f8fb37e2d13c7aa00228fb
> Reviewed-on: https://chromium-review.googlesource.com/1063521
> Commit-Queue: Yoichi Osato <yoichio@chromium.org>
> Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569168}

TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 843144, 855026
Change-Id: I745ab57ed70bd10e59bac20cf4f6fd591e170abd
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/1118098Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571076}

DCHECK_EQ now supports enum classes.

Change-Id: I1b53aa3e2398bcc46b388448a73e700a74cd8602
Reviewed-on: https://chromium-review.googlesource.com/1116961
Commit-Queue: Sharon Yang <yangsharon@google.com>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571075}

https://webrtc.googlesource.com/src.git/+log/968b1dd0d7b4..64b17c2aca96


git log 968b1dd0d7b4..64b17c2aca96 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 danilchap@webrtc.org Remove StreamStatistician::IsPacketInOrder


Created with:
  gclient setdep -r src/third_party/webrtc@64b17c2aca96

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I06c2861a657c6663f77eca48bf7d699361eb59d5
Reviewed-on: https://chromium-review.googlesource.com/1117943Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571074}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/c03de9ae4eef..3511a8352adf


git log c03de9ae4eef..3511a8352adf --date=short --no-merges --format='%ad %ae %s'
2018-06-28 ayatane@chromium.org sysmon: Count gs_offloader processes


Created with:
  gclient setdep -r src/third_party/chromite@3511a8352adf

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:853842
TBR=chrome-os-gardeners@chromium.org

Change-Id: Id9712d304039ae9816dd6a7f134e566e130663cd
Reviewed-on: https://chromium-review.googlesource.com/1117939Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571073}

 from the text.

Previously RemoveSpellingMarkersUnderWords could clean markers totally.
After this action RepaintMarkers did not triggeren on text nodes that
 had empty markers list, or  there were no possible markers of
 spellcheck type at all.

Now we invalidate each node we remove marker from.

R=yosin@chromium.org

Change-Id: I57b86134198b2cb40ab04c52859db4164d6e8555
Reviewed-on: https://chromium-review.googlesource.com/1114961Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571072}

https://android.googlesource.com/platform/external/perfetto.git/+log/3f423e75215c..bd16a937023d


git log 3f423e75215c..bd16a937023d --date=short --no-merges --format='%ad %ae %s'
2018-06-28 hjd@google.com Merge "Create the directory structure"
2018-06-27 michaschwab@google.com Create the directory structure


Created with:
  gclient setdep -r src/third_party/perfetto@bd16a937023d

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: If13219d24a257652aae1e1022dcaf5e13d2e8489
Reviewed-on: https://chromium-review.googlesource.com/1117942
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571071}

IdentityProvider currently has baked-in knowledge of OAuth2TokenService
for functionality that is shared between ProfileIdentityProvider and
DeviceIdentityProvider. However, as we will be converting
ProfileIdentityProvider to talk to IdentityManager rather than
OAuth2TokenService, this baked-in knowledge needs to be moved out of
IdentityProvider; ultimately, it will end up only in
DeviceIdentityProvider.

This CL takes the first step along that path by moving
ActiveAccountAccessTokenFetcherImpl, which fetches access tokens via
OAuth2TokenService, out of identity_provider.cc into its own file. The
next CL will have ProfileIdentityProvider and DeviceIdentityProvider
each implement FetchAccessToken() rather than having IdentityProvider do
so directly.

Bug: 809452
Change-Id: I664c4da998cf90d0a398dc2c9e309425f95515a3
Reviewed-on: https://chromium-review.googlesource.com/1114604Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571070}

There are a number of ways for selecting an element in a tested html page, and those involve
injecting javascript. This class is intended to be used for abstracting this js generation
to diminish the proliferation of ad-hoc code.

Bug: None
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ifbe1ba8be509dfe3ab02ff8b7ddca6cefc3761ff
Reviewed-on: https://chromium-review.googlesource.com/1118160
Commit-Queue: Eric Noyau <noyau@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571069}

GLSurfacePresentationHelper::CheckPendingFrames could be called by
PostTask. In that case, the context_ may not be the current, so we need
call MakeCurrent.

Bug: 853600
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I39a8b9b82a66b9fabe4c06ed67d0f90c8e78599b
Reviewed-on: https://chromium-review.googlesource.com/1117118Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571068}

BUG=762641
TBR=xdai@google.com

Change-Id: I0e0473385c38d15d8f62b5283a965801773977d6
Reviewed-on: https://chromium-review.googlesource.com/1117909Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571067}

Bug: 775415
Change-Id: Ic00cbdcf4b1ecd2f616dae59dc40d7e4127a7081
Reviewed-on: https://chromium-review.googlesource.com/1115127Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Elad Alon <eladalon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571066}

In order to avoid confusion between DOMException and ES Error object,
this patch uses enum classes for DOMExceptionCode and ESErrorType.

DOMExceptionCode and ESErrorType are now incompatible with each
other or type int (including ExceptionCode).

This patch includes a lot of fixes on call sites, too.

Change-Id: I832f7ffc45c2cfbc922443bcf50a171bfc9fa828
Reviewed-on: https://chromium-review.googlesource.com/1117158Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571065}

Setting the tooltip on a HoverHighlightView also sets the tooltip on all
its children. Otherwise, the tooltip won't show on hovering above the
HoverHighlightView.

Bug: 845842
Change-Id: I2f3cb31a7b3053eaa42d677e9c967f67781472eb
Reviewed-on: https://chromium-review.googlesource.com/1113437Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571064}

LocationBarDecoration is defined as a struct in
chrome/browser/ui/views/location_bar/location_bar_layout.h
and as a class in
chrome/browser/ui/views/location_bar/location_bar_layout.h.
When building using jumbo this causes a conflict.

This commit solves the issue by renaming the struct to
DecorationInfo.

Bug: 773275
Change-Id: Iaeece5319fe66b335cf1dcda01f3d984f0cc5f7a
Reviewed-on: https://chromium-review.googlesource.com/1116797Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#571063}

https://webrtc.googlesource.com/src.git/+log/42f0d78f1ee8..968b1dd0d7b4


git log 42f0d78f1ee8..968b1dd0d7b4 --date=short --no-merges --format='%ad %ae %s'
2018-06-28 srte@webrtc.org Use field trial parser for BBR Experiment.
2018-06-28 deadbeef@webrtc.org Adding "is_standardized" flag to RTCStatsMember.
2018-06-28 steveanton@webrtc.org Add steveanton@ as api/ and ortc/ OWNER
2018-06-27 shampson@webrtc.org A new PeerConnection level perf test.


Created with:
  gclient setdep -r src/third_party/webrtc@968b1dd0d7b4

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ib9adbc71b172c710290d5a88f1aff1411cf07f12
Reviewed-on: https://chromium-review.googlesource.com/1117941Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571062}

The bug happens when the current document data has been loaded, but the
parser is still processing it. Then a new navigation happens and cancels
the current document's parser. The issue is that the Document was not
marked to be 'loaded' at this step. Then if the navigation turns to be
download, it is dropped and there is no more chance for the frame to be
marked as 'loaded'.

Bug: 855033
Change-Id: I572470dd1ad53d9905b3604f6a91ce6f4bd53952
Reviewed-on: https://chromium-review.googlesource.com/1109974
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571061}

https://crrev.com/c/1113746 introduced a GetDisableReasons which
replaces it. This CL updates all remaining callers to use the new
GetDisableReasons instead.

Bug: 839834
Change-Id: Ia872998df4675e2e9de7241617d46af7c4672330
Reviewed-on: https://chromium-review.googlesource.com/1116706
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571060}

https://crrev.com/c/1113746 introduced a GetDisableReasons which
replaces it. This CL updates all callers to use the new
GetDisableReasons instead.

Bug: 839834
Change-Id: If832ffb12f24308e08890a7c073d5827c0ef44a7
Reviewed-on: https://chromium-review.googlesource.com/1114959
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571059}

This reverts commit add11c4c.

Reason for revert: Breaks egtests when UIRefresh is disabled.

Test Case '-[RecentTabsTableTestCase testRecentTabSigninPromoReloaded]' started.
../../ios/chrome/browser/ui/authentication/signin_earlgrey_utils.mm:39: error: -[RecentTabsTableTestCase testRecentTabSigninPromoReloaded] : Exception: NoMatchingElementException
Exception Name: NoMatchingElementException
Exception Reason: Cannot find UI Element.
Exception with Assertion: {
  "Assertion Criteria":  "assertWithMatcher:isNotNil",
  "Element Matcher":  "((respondsToSelector(accessibilityIdentifier) && accessibilityID('kSigninPromoPrimaryButtonId')) && matcherForSufficientlyVisible(>=0.750000))",
  "Recovery Suggestion":  "Check if the element exists in the UI hierarchy printed below. If it exists, adjust the matcher so that it accurately matches element."
}
Exception Details: Error Trace: [
  {
    "Description":  "Interaction cannot continue because the desired element was not found.",
    "Error Domain":  "com.google.earlgrey.ElementInteractionErrorDomain",
    "Error Code":  "0",
    "File Name":  "GREYElementInteraction.m",
    "Function Name":  "-[GREYElementInteraction matchedElementsWithTimeout:error:]",
    "Line":  "124",
    "TestCase Class":  "RecentTabsTableTestCase",
    "TestCase Method":  "testRecentTabSigninPromoReloaded"
  }
]

Original change's description:
> [ios] Creates SigninPromoView UIRefresh styling.
> 
> - Updates SigninPromoView to support a new UI Layout based on UIRefresh Phase 1 flag and a new
> flag received on init.
> - Some minor refactoring to stop calling self on init in SigninPromoView.
> 
> Screenshots:
> https://drive.google.com/open?id=1FnR436FEX9_3GwFbIIrJsQ8qHZOdqJpl
> https://drive.google.com/open?id=1__aPHb1ye3WkiHKHJp9kIyJ6hhABq1Y6
> https://drive.google.com/open?id=1ibjz3nnXHBrO_akJm4e9tgghpD85f3u0
> https://drive.google.com/open?id=1dCVkiMW1IMQjWkxcegVxi8r1PLh5ZCqM
> 
> Bug: 805188
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I1268388da06c57eb9c1610c3547314929bb8c107
> Reviewed-on: https://chromium-review.googlesource.com/1107216
> Commit-Queue: Sergio Collazos <sczs@chromium.org>
> Reviewed-by: edchin <edchin@chromium.org>
> Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570864}

TBR=rohitrao@chromium.org,jlebel@chromium.org,edchin@chromium.org,sczs@chromium.org

Change-Id: I2bf65f4e8848786eb3d60c2db4adb768eed3692b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 805188
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1118178Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571058}

This patch fixes a failure to create inline box fragments
when they contain only bidi controls.

A pair of PrepareForReorder() and UpdateAfterReorder()
re-establishes relationship between inline boxes and its
children after bidi reorder. When inline boxes have only
bidi controls, the relationship was not re-established
correctly, resulting DCHECK failures and incorrect
positioning of such inline box fragments.

Found in r570132 (CL:1108509) thanks to xiaochengh@.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I2fbbd60e230fea872af38d6c133bb26a50e67e4e
Reviewed-on: https://chromium-review.googlesource.com/1116415
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571057}

Currently we don't read the cached metadata (= blob's side data) at the
subresource loader. This patch is to read it and send it back to the client.

Bug: 856521
Change-Id: I8ba4010e6551ba32ff227e47390d974c64bfbfdc
Reviewed-on: https://chromium-review.googlesource.com/1116630Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571056}

https://chromium.googlesource.com/catapult.git/+log/d96c63379000..ac9c7e7edefa


git log d96c63379000..ac9c7e7edefa --date=short --no-merges --format='%ad %ae %s'
2018-06-28 benjhayden@chromium.org Fix order of min_start_revision, min_end_revision in Anomaly.QueryAsync.


Created with:
  gclient setdep -r src/third_party/catapult@ac9c7e7edefa

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I447b8b0cce75847d5f4ff56cb90e5432255f2d79
Reviewed-on: https://chromium-review.googlesource.com/1117978Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571055}

This fixes two tests, but will also eventually benefit
floats-wrap-inside-inline-00[1234].htm in fast/block/float/, which are
currently passing because the absolutely positioned box in the test forces
its container to have block children. There's special-code for NG (which we
should remove) in LayoutBlockFlow::AddChild() that forces this (and causes
other problems).

Added a new test, to make it clear what this fix is about.

Bug: 734554
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia2c0e0b2ab61999207114fdf935880fabc2e677c
Reviewed-on: https://chromium-review.googlesource.com/1116959Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571054}

Bug: 801985
Change-Id: I8ccb1f7d351c143008e0f66bcf06b8561669a006
Reviewed-on: https://chromium-review.googlesource.com/1088697Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571053}

TBR=jonann@chromium.org

Bug: b/110714442
Change-Id: I0db647ea3df6c897b6cc367c045842e19bf62162
Reviewed-on: https://chromium-review.googlesource.com/1117690Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571052}

serialized_script_value.h is used in 2,000+ compilation units, and this
CL reduces its pre-processed size from 5.11MB to 1.79MB.

Also, this CL removes unnecessary #includes for
serialzied_script_value.h.

Bug: 242216
Change-Id: I8bbd09c96461d658770abe40df782d37871d3847
Reviewed-on: https://chromium-review.googlesource.com/1116410Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571051}

BUG=None
TEST=third_party/depot_tools/watchlists.py components/policy/resources/policy_templates.json

Change-Id: I8cc5c168f5d374c141456c02db3cc9e43de1eddc
Reviewed-on: https://chromium-review.googlesource.com/1114843Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571050}

Converting code base away from direct useage of components/signin.
In this case the 4 include files were unused.

Also added include of signin_metrics.h, directly used in method
AddGlobalErrorMenuItems, but only included indirectly previously.

Bug: 797897
Change-Id: Ifa9af45e12da9651bab558d2c898f8ce6fa56299
Reviewed-on: https://chromium-review.googlesource.com/1057332Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Jean-Denis Muys <jdmuys@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571049}

The new binary for traffic_annotation_auditor after the change in
crrev.com/c/1117264 is rolled.

Bug: 856884
Change-Id: I76523df5e58ace767ac19c619c9bb32da5a25674
TBR: georgesak@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1117686Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571048}

By crrev.com/c/1102224, VDA is actually deleted in TearDownTiming test case.
Before deleting decoder and VDA client's state becomes CS_DESTROYED, VDA can
invoke PictureReady and those are processed after DeleteDecoder(). At that time,
state is CS_DESTROYED and thus LOG_ASSERT(state < CS_RESET) throws an exception.
The LOG_ASSERT should be executed only if VDA is not deleted.

BUG=chromium:834170
TEST=VDA unittest at veyron_minnie

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I1d18ca4f48f6c0e7129f7364e8d7b0ea083b513f
Reviewed-on: https://chromium-review.googlesource.com/1118081
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571047}

Following bot results are included.
7176 7178 7183 7190 7194 7196 7205 7215 7218 7223 7250 7261
7264 7270

3 lines were removed and 0 lines were deflaked by consecutive
results since 7183.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I95462370070f876dcc6302bd010c2e166438678a
Reviewed-on: https://chromium-review.googlesource.com/1114878
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571046}

This reverts commit 3ebcc06d.

Reason for revert: Could be breaking unit_tests on Linux. It's the only suspicious CL I can find. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/50975

Original change's description:
> Implement and wire in NetworkServiceClient::OnFileUploadRequested.
> 
> This checks ChildProcessSecurityPolicy before opening the requested
> files for upload.
> 
> Bug: 845612
> Cq-Include-Trybots: luci.chromium.try:linux_mojo
> Change-Id: I16538e38bcb0a44acaf8c6dab4342dea8872f81f
> Reviewed-on: https://chromium-review.googlesource.com/1098150
> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#570986}

TBR=jam@chromium.org,mmenke@chromium.org,rmcelrath@chromium.org

Change-Id: I00955100281cb36567b570e04742eece69367cf7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 845612
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1118118Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571045}

Move the logic from shouldOpenURL in tab.mm to ShouldOpenURL in crw_web_controller.mm
ShouldOpenURL method should be entirley removed from tab.mm and preload_controller.mm
once crbug.com/546402 is addressed.

Bug: 850760
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia7f017942c2095e9ed12e58fe3a790aa53551d35
Reviewed-on: https://chromium-review.googlesource.com/1112646Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571044}

When building using Jumbo unnamed namespaces gets merged
and variables with the same name conflict. This happens
when building in Chrome OS for the variables
kErrorNotAvailable in:
chrome/browser/extensions/api/input_ime/input_ime_api.cc
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc

This commit solves the issue by renaming the variables to
something more file specific. It also renames other variables
in the same namespace, so the naming is locally consistent.

Bug: 850484
Change-Id: Id2282be73d75c76bb820c0946fc1caf09aeca8a4
Reviewed-on: https://chromium-review.googlesource.com/1116698Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#571043}