GitLab

This is a reland of c19f615e

Original change's description:
> [Autofill Assistant] Attempt to recover pre-interrupt state.
> 
> When an interrupt script is run, it can modify anything, which makes the
> main script with allow_interrupt=true hard to write. This change propose
> to reset some state automatically after an interrupt to make this
> easier.
> 
> It recovers the status message and attempts to set a reasonable scroll
> position. It sets it to either the element WaitForDom was waiting for,
> for a successful WaitForDom. For an unsuccessful WaitForDom, it scrolls
> to the last element focused on (if it still exists.)
> 
> Change-Id: Ie9c0022eebc10e0711c82d83b943e0de152af1fd
> Reviewed-on: https://chromium-review.googlesource.com/c/1346451
> Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
> Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610412}

Change-Id: If45ba47d26f29102388e35d3454c5d8f48911944
Reviewed-on: https://chromium-review.googlesource.com/c/1349212Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610586}

This includes two small UX changes - one a word change and one
disabling the persistent notification.

TWAs will still be behind a flag (which is on by default).

Bug: 908052
Change-Id: I3ddb16bc425a437d9fed215e4285c5eba2d20ba0
Reviewed-on: https://chromium-review.googlesource.com/c/1349337Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610585}

Bug: v8:7279, v8:8238
Change-Id: I0dc237e75557470d38d670cefe760f19378a5740
Reviewed-on: https://chromium-review.googlesource.com/c/1349338Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610584}

Bug: None
Change-Id: Ida04d468cb03943b7f3ae9539059a5fffe4beed3
Reviewed-on: https://chromium-review.googlesource.com/c/1346298Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610583}

https://android.googlesource.com/platform/external/perfetto.git/+log/2da0d123402a..e92c674abcb9


git log 2da0d123402a..e92c674abcb9 --date=short --no-merges --format='%ad %ae %s'
2018-11-22 hjd@google.com Fix merged perfetto trace
2018-11-22 treehugger-gerrit@google.com Merge "SockSend: remove extraneous msg_controllen assignment + micro nit fixups."
2018-11-22 taylori@google.com Add generic ftrace event
2018-11-21 treehugger-gerrit@google.com Merge "Collect ftrace protos into one file per group"
2018-11-21 fmayer@google.com Print PID in parent process.


Created with:
  gclient setdep -r src/third_party/perfetto@e92c674abcb9

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:117471443
TBR=perfetto-bugs@google.com

Change-Id: Icbe137084b670295623061db598b4a99c677ef56
Reviewed-on: https://chromium-review.googlesource.com/c/1348835Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610582}

Similarly to [1], this CL replaces the Use of OAuth2TokenService,
OAuth2TokenService::Consumer and SigninManager APIs with the
corresponding IdentityManager counterparts.

The unittests could not be only minimally adapted, and converted on a
follow up pass, given that CL needed to replace the uses of
FakeProfileOAuth2TokenService with IdentityTestEnvironment upfront.

[1] https://crrev.com/c/1348670

BUG=907526

Change-Id: I59c2a49d20341ddadff15a28c7ad81e3056161e6
Reviewed-on: https://chromium-review.googlesource.com/c/1348671
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610581}

Almost all have been reported as flaky. Disable all to avoid having
reports coming in from whichever subtest was not reported yet. Caused a
lot of red jobs on the Fuchsia x64 bot.

TBR=wez@chromium.org

Bug: 907804
Change-Id: I2fb4da79bf1e4251e14900ef4cabb890b7b3380d
Reviewed-on: https://chromium-review.googlesource.com/c/1349315Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610580}

Looks like something got wrong in
https://chromium-review.googlesource.com/c/chromium/src/+/1335007

TBR=wangxianzhu@chromium.org

Bug: 906591
Change-Id: I9d0f19d74dc209994aa6ba335b92effee7abf685
Reviewed-on: https://chromium-review.googlesource.com/c/1349254Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610579}

This CL reodrers members and renames some fields in SigninManager
without any behavioral changes.

Bug: None
Change-Id: I408ef5cf78d712d212fec342c9b8fc028771207d
Reviewed-on: https://chromium-review.googlesource.com/c/1348037Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610578}

Before this CL on saving manual fallback:
1.User keystroke happen
2.FormData received in PasswordManager for manual fallback
3.Corresponding NewPasswordFormManager (NPFM) is found
4.NPFM is cloned.
5.The FormData is passed to the cloned NPFM.
6.The cloned NPFM is sent to UI

The problem with that approach that PasswordManager has no information
about user input, which might be used for offering save prompt.
The similar logic is implemented in the renderer (where it's called
Save on provisional load start). But because of the site isolation the
renderer path will disappear soon.

But we can do everything from browser process, just by swaping steps 4
and 5, namely to pass FormData to NPFM and then to clone. It's
implemented in this CL. As result PasswordManager always has the last
user input and can propose saving when the password form is disappeared
after navigation (that's basically the same as now but with the renderer
path).

Along the way SetSubmittedFormIfIsManaged renamed to
ProvisionallySaveIfIsManaged since now it's called on each typing not
only on submit.

Bug: 842643, 831123
Change-Id: If47c5cb3aa5e411818c49e359cd10732a0131ce3
Reviewed-on: https://chromium-review.googlesource.com/c/1348060
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610577}

This change updates the protocol used to control the PromptAction to
make it more powerful and more in-line with the current protocol:

 - the suggestion and element existence results are merged into one list
 of choice.

 - the string result is replaced by an opaque server_payload result,
 which allows the server to include whatever data it wants.

To make that work, this changes forwards the data proto as an opaque
byte array between layers instead of a single UTF8 string that was used
for both message and result.

Bug: 1343266
Change-Id: I601c31504bd231ef9904bced92fc350a939b6f9d
Reviewed-on: https://chromium-review.googlesource.com/c/1346461
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610576}

In order to avoid future issues like the one fixed recently in
https://chromium-review.googlesource.com/c/1348090, let's improve type
safety by adopting net::HttpStatusCode wherever possible.

This affects mostly server-related code (LoopbackServer and FakeServer).
Other layers are harder to change because URLFetcher itself handles ints
rather than enums.

Variable names have been updated accordingly.

Bug: 774180
Change-Id: Ic65a8efde4038ce56bbd2dedebad8a7c890e1197
Reviewed-on: https://chromium-review.googlesource.com/c/1349310Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610575}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/282ab96433a0..38ec294c9aeb


Created with:
  gclient setdep -r src-internal@38ec294c9aeb

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Id80404d94b0e37ca0a60d0db43e8334bb25eca5c
Reviewed-on: https://chromium-review.googlesource.com/c/1349430Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610574}

https://webrtc.googlesource.com/src.git/+log/f40150d87487..5f2ffeec22d1


git log f40150d87487..5f2ffeec22d1 --date=short --no-merges --format='%ad %ae %s'
2018-11-23 saza@webrtc.org Clean up deprecated APM stats


Created with:
  gclient setdep -r src/third_party/webrtc@5f2ffeec22d1

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I2c6d38315f4266543554f134dff200834408cccc
Reviewed-on: https://chromium-review.googlesource.com/c/1349429Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610573}

The temp tracing file is deleted in an AsyncTask, so poll for it to
complete instead of directly asserting the file deletion.

TBR=twellington@chromium.org

Bug: 907913
Change-Id: I5c31ed9b0154756ce711bcaea0b166173a0a196f
Reviewed-on: https://chromium-review.googlesource.com/c/1349256Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610572}

This reverts commit ead171ec.

Reason for revert: Test is still flaky.

Original change's description:
> [Sync] Re-enable a flaky testUploadMovedBookmark() test
> 
> The test
> org.chromium.chrome.browser.sync.BookmarksTest#testUploadMovedBookmark
> has been disabled for long time due to
> flakiness.
> 
> This CL does the following:
> 1- Adds an assert() that's missing from the test start up.
> 2- Enables the test.
> 
> The plan is to enable it again to get measurements for how long it
> takes to fail and pass to rule out a time-out problem.
> 
> The flakiness dashboard has been replaced with a newer one since the
> reporting of the attached bug.
> 
> TBR=mastiz@chromium.org
> 
> Bug: 823484
> Change-Id: I827ff84ad953c56f01619b4aa07643714d0ffc6f
> Reviewed-on: https://chromium-review.googlesource.com/c/1348116
> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610449}

TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org

Change-Id: I0d56f7d5f7590e9c15abbd4392ebfd75c987ca6c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 823484
Reviewed-on: https://chromium-review.googlesource.com/c/1349333Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610571}

This change updates the text of the warning that shows up on Android
when multiple downloads are attempted without user interaction.

This is to shorten the message, align it with other similar warning
messages on Android, and also align it with the warning text on Desktop.

Bug: 906628
Change-Id: Ie7e46ee8fa0251268b8db63322becf24b07207a0
Reviewed-on: https://chromium-review.googlesource.com/c/1341842Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610570}

Culprit[1] didn't revert cleanly.

[1] https://crrev.com/995a2bf6456a8296032a11fe02a05f51e0c33ea0

TBR=rmcelrath@chromium.org

Bug: 908012
Change-Id: I68bbbafeaa19a6c245fec5346c558aaf487dc9cd
Reviewed-on: https://chromium-review.googlesource.com/c/1349258Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610569}

Using wpt-import in Chromium 3298bb1a.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org:
  external/wpt/fetch

NOAUTOREVERT=true
TBR=markdittmer

No-Export: true
Change-Id: I6d365b3dcadf17fab132294aba552650863a0fcb
Reviewed-on: https://chromium-review.googlesource.com/c/1348741
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610568}

Story in v8.browsing_mobile-future is flay on Pixel 2.

NOTRY=true
TBR=nednguyen@google.com

Bug: 865400
Change-Id: I90c2f93787341b19a680a590df370fb978313f32
Reviewed-on: https://chromium-review.googlesource.com/c/1349311Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610567}

Adds support for RTL.

Bug: 845472
Change-Id: Iefc3aeb4d0d6a5d951be43e5337f5bda0328015c
Reviewed-on: https://chromium-review.googlesource.com/c/1348332Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610566}

Change-Id: I9588c47db13e24edd46d27dacab77a4e433fe78a
Reviewed-on: https://chromium-review.googlesource.com/c/1346299Reviewed-by: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610565}

Supporting lazy subscriptions modes for FCM subscription has been fully
implemented.

This CL enables the lazy mode for invalidations.

Bug: 882887
Change-Id: I47ab65b4895fed35dfdfd291ce155dc0928a14d5
Reviewed-on: https://chromium-review.googlesource.com/c/1347359Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610564}

The obsolete code used to check the fullscreen state which is irrelevant.

Bug: 908009
Change-Id: Ide457470aa4226843d611d043260dfef420087e7
Reviewed-on: https://chromium-review.googlesource.com/c/1349216Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610563}

If the HTTP request returns some status code other than 200, we treat
it as error in most relevant cases, e.g. in
ServerConnectionManager::PostBufferToPath().

We must do the very same in SyncBridgedConnection::Init() because we
otherwise enter an inconsistent state for errors like 3xx (redirects),
leading to DCHECK failures.

Bug: 774180,907896
Change-Id: I6019442d0d30ee7d7e177d72974cec0eadb9a38f
Reviewed-on: https://chromium-review.googlesource.com/c/1349252Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610562}

Bug: 905657
Change-Id: I4c535ba13c2a8e97fbaf217aebafd222b791cd3c
Reviewed-on: https://chromium-review.googlesource.com/c/1344055Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: David Jean <djean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610561}

This is a reland of fadba0e6

Original change's description:
> 🤝 Return to verified origin when close button pressed.
> 
> When a TWA leaves the verified origin, the Custom Tabs top bar is
> displayed and the user can see a close button. This close button would
> on a normal custom tab close the Activity.
> 
> On Trusted Web Activities, this should return us to the verified
> origin instead.
> 
> Bug: 907535
> Change-Id: I9f652a3255afdd23072b32c44db5680172ea33f2
> Reviewed-on: https://chromium-review.googlesource.com/c/1346463
> Commit-Queue: Peter Conn <peconn@chromium.org>
> Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610399}

Bug: 907535
Change-Id: If6e17630d50ac283e91809f9f1b497b73e466e6b
Reviewed-on: https://chromium-review.googlesource.com/c/1348469Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610560}

Change-Id: Ie3fe872b9113d545d12bbb042c611cf93a996216
Reviewed-on: https://chromium-review.googlesource.com/c/1348450Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610559}

DemoExtensionsExternalLoaderTest.LoadApp is flaky on ChromeOS as well.
Disabling for all platforms.

TBR=wzang@chromium.org

Bug: 904644
Change-Id: I072c84e40f339b9715d020657c0d8139abb35586
Reviewed-on: https://chromium-review.googlesource.com/c/1349215Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610558}

Rewrite the header as per the after-landing suggestions in CL1346093.

Bug: 907995
Change-Id: Iaecf3cd6257846f2012c7b42b97ffb844f4b45d7
Reviewed-on: https://chromium-review.googlesource.com/c/1349250Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#610557}

TBR=chiniforooshan@chromium.org

Bug: 908002
Change-Id: I41ac2754d26f726c4249b5b1a9db42e4c20f633c
Reviewed-on: https://chromium-review.googlesource.com/c/1349255Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610556}

It was never finished or launched, hasn't been touched in years, and is
unowned.

Bug: 898957, 182649
Change-Id: I8b5d04c7ac271031b7fb84235fd6c12def3b5fa7
Reviewed-on: https://chromium-review.googlesource.com/c/1348089Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610555}

The bots will be even more useful if they run relevant tests.

Bug: 904452
Change-Id: I70182572d9508e519c000187194f443eeda82500
Reviewed-on: https://chromium-review.googlesource.com/c/1333808Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610554}

This reverts commit 4d820bcd.

Reason for revert: causes flakiness in browser_tests (907981).

Original change's description:
> Reland "Unify input delay computations"
> 
> This is a reland of 5d945012
> 
> Original change's description:
> > Unify input delay computations
> >
> > This CL unifies the timestamp computations for FID as reported to UMA and FID as
> > exposed in the Web Perf API. It moves the UMA reporting from the
> > PageWidgetDelegate to the EventTiming class. After this CL, the same types of
> > events are logged by both the UMA metric and the webexposed metric. In addition,
> > this CL removes the check that there are default actions or event handlers from
> > EventTiming, which means that now the webexposed API will expose events even if
> > they have no associated event handlers. In particular, this means that a click
> > will now trigger mousedown, click, and mouseup entries, in that order. This is
> > reflected in changes to the layout tests.
> >
> > Bug: 897656
> > Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc
> > Reviewed-on: https://chromium-review.googlesource.com/c/1334564
> > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
> > Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#610201}
> 
> TBR=dtapuska@chromium.org
> 
> Bug: 897656, 843184
> Change-Id: I4d97f2731fe957696c0e908d5ef3493235b52d49
> Reviewed-on: https://chromium-review.googlesource.com/c/1348254
> Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
> Reviewed-by: Timothy Dresser <tdresser@chromium.org>
> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610499}

TBR=tdresser@chromium.org,dtapuska@chromium.org,npm@chromium.org

Change-Id: Ib5a3717393c14d5455bb97e92187d887465bef88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 897656, 843184, 907981
Reviewed-on: https://chromium-review.googlesource.com/c/1349253Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610553}

We should release the Utility process when the last client is gone.

Bug: 837156
Change-Id: I66dc753d45a43455dc8cd4a8e759436ec330624a
Reviewed-on: https://chromium-review.googlesource.com/c/1349159Reviewed-by: Shu Chen <shuchen@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610552}

This is an experiment to see if the crashes in the referenced bug are
related to mmap changes on Windows. This CL will be reverted after it
goes live in 1-2 canaries.

TBR=cmumford

Bug: 897576
Change-Id: Ic44836c4ed848f8713d16b553f038c63119f0aaf
Reviewed-on: https://chromium-review.googlesource.com/c/1348736
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610551}

Before this CLs, all methods handling selectors took a
std::vector<std::string> as input.

This CL replaces all vectors of strings by a Selector struct, such that
it will be easier to add parameters (like pseudo type) to a selector.

Change-Id: Ic981282db840b02e996c21ceb1072607ff25606e
Reviewed-on: https://chromium-review.googlesource.com/c/1348049
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610550}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/b67f5e7a75c7..2135b68548af


git log b67f5e7a75c7..2135b68548af --date=short --no-merges --format='%ad %ae %s'
2018-11-23 chrome-bot@chromium.org Update config settings by config-updater.


Created with:
  gclient setdep -r src/third_party/chromite@2135b68548af

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I2da42b0193a0ad912be53115f5ee53dd4f372cb2
Reviewed-on: https://chromium-review.googlesource.com/c/1349039Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610549}

This CL makes the device info USS bridge more robust in handling
ApplySyncChanges(). Previously, in a shutdown race condition, the bridge
could receive such calls when the device info is not available any more.
This could lead to the bridge not acting on the ApplySyncChanges() call,
not deleting any metadata.

This CL caches the current guid (which is stable between OnSyncStarting
calls) in the bridge.

Bug: 871733
Change-Id: I18d0bdcbcd9677e21196ee986a6af40a5abb29d9
Reviewed-on: https://chromium-review.googlesource.com/c/1273042
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610548}

Bug: 846132
Change-Id: I69820a9934ad73810a8c67e20d53cddffb045ded
Reviewed-on: https://chromium-review.googlesource.com/c/1345684
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610547}