- 16 Dec, 2020 40 commits
-
-
Tina Wang authored
This cl adds strings to the material toast. Mock: https://screenshot.googleplex.com/Awx9JmcTid6QE3n A material toast will be shown when Chrome opens in a non-user-expected mode if incognito mode is disabled/forced by the policy. Follow up cls are: - Modify the actions of app long-press menu items when incognito mode is managed. - Modify the browser mode when open Chrome from other app when the incognito mode is managed. Bug: 1159323 Change-Id: Ic3f17fd9e042e955538d3bc6b4e7f4f6e8a8dd87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593939 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#837801}
-
Caroline Rising authored
Hide subheaders when there are no corresponding entries. Add helpful text when there are no unread or read entries. See screenshot of empty state in the bug. Bug: 1158847 Change-Id: I0c52e09e6277a785bed20b2994c6e6f8560518c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593476 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#837800}
-
rajendrant authored
This CL records the login type detected tied to a page load. UKM review doc: https://docs.google.com/document/d/1MfiiDSGvHHn0Is7_6DByOTK1qTPNtHXuEJq1xveNgQo/ Bug: 1149853 Change-Id: Idd26b3ea8a6260aa15ba578715f92158c385b41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587802 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#837799}
-
Roman Arora authored
Tags the web contents created in the WebUIBubbleManager so that the specified label shows up in the task manager. Screenshot: https://drive.google.com/file/d/1cql788sSWWh2aRYrB05-IayXZUVGAzWP/view See 'Tool: Search Tabs' Bug: 1151373 Change-Id: Ibbef901623a0bb31a6c2e36eca6dcd13c1327e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587624Reviewed-by:
Caroline Rising <corising@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#837798}
-
Xiaohan Wang authored
This was in the original design but missed in the implementation because ProtectedMediaIdentifierPermissionContext uses a custom permission prompt logic. This CL updates ProtectedMediaIdentifierPermissionContext to report the UKM. We are also able to remove our own ReportPermissionActionUMA() since that's covered automatically by the new approach. In the future, when we use standard permission bubbles for ProtectedMediaIdentifierPermissionContext we won't need this anymore. Manually tested: 0. Hacked media/blink/key_system_config_selector.cc to always request permission. 1. Build ChromeOS Chrome on Linux. 2. Start Chrome with the following flags: --force-enable-metrics-reporting --metrics-upload-interval=1 3. Play protected content on Shaka Player, and saw the prompt. 4. Go to chrome://ukm and chrome://histograms to check results. See below. Without this change: Histogram: Permissions.Action.ProtectedMedia recorded 1 samples, mean = 2.0 (flags = 0x41) 0 ... 2 ------------------------------------------------------------------------O (1 = 100.0%) {0.0%} 3 ... With this change: Permission Action 1 Gesture 2 PermissionType 21 PriorDismissals 0 PriorIgnores 0 PromptDisposition 0 Source 0 Histogram: Permissions.Action.ProtectedMedia recorded 2 samples, mean = 0.5 (flags = 0x41) 0 ------------------------------------------------------------------------O (1 = 50.0%) 1 ------------------------------------------------------------------------O (1 = 50.0%) {50.0%} 2 ... Bug: 1158868 Test: See above Change-Id: Ie852f26550e0f403806e70fb50f4c8897e7e5c11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594120 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#837797}
-
Nico Weber authored
TLS issues are fixed upstream, so let's undo the yucky workaround. Also add a few more now-known issues, and mention speed advantages. Bug: 1149587 Change-Id: I2eaa773cfec1e8004828cfd7cdf6b0660dbd4323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595607Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837796}
-
Eric Orth authored
Bug: 1081186 Change-Id: I86884342e628f95eb634c4d1a144f0dd7768a2bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595832Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#837795}
-
Anatoliy Potapchuk authored
This cl adds renderer-side implementation of the new managed configuration API. Explainer: https://github.com/Ananubis/WebApiDevice/blob/master/Explainer.md DD: http://go/pwa-api-config-dd Change-Id: I9f5649f43ef487326354b5af525d9272d8b536f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560629 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837794}
-
Yi Gu authored
Bug: 1152282 Change-Id: Ida2eab986d80bb02bf83c1bdad506fa5485495ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595596Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837793}
-
Piotr Bialecki authored
The older one is expiring on Dec 17th. Change-Id: I8acb05575fb46f80e708eb78bc5d74cc7fe0b80b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596107 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#837792}
-
Findit authored
This reverts commit 595ea7d1. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 837732 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU5NWVhN2QxNWMzM2Y2ZjQ1NjY4N2Y4YjY1ZDE4ODk3N2FlZmZhYWIM Sample Failed Build: https://ci.chromium.org/b/8860720074507463920 Sample Failed Step: compile Original change's description: > Re-land "Use new vulkan-deps repo for all Vulkan dependencies." > > Re-land includes missing headers directory. > > This replaces several grouped dependencies with one meta-repo. > The meta-repo will allow us to group multiple inter-dependent > deps rolls into one single roll. This solves the problem of > separate rollers breaking because of the inter-dependencies. > It also allows ANGLE and Chrome to share common bits like the > README and .gitignore files. > > Bug: angleproject:5390 > Bug: 1153258 > Change-Id: I22cefb1bfeeec656c2dbb173701a87a6db9cb8ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593888 > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Auto-Submit: Jamie Madill <jmadill@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837732} Change-Id: I8f225478f447b3be0bf0bc9eed4106516027e3d3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596423 Cr-Commit-Position: refs/heads/master@{#837791}
-
Phillis Tang authored
Add fieldtrial test configuration for Desktop PWA install icon In-Product Help finch experiment. Change-Id: Ida43f4ed7a173dcfc1794d8d945fad6842fd46ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594264Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#837790}
-
Ted Choc authored
(Excludes the render tests) Performance changes (from try-bot and previous try-bot run) RadioButtonWithEditTextTest: 10599 -> 1048 PromoCardCoordinatorTest: 8515 -> 60 MoreProgressButtonTest: 43132 -> 166 RadioButtonWithDescriptionLayoutTest: 13768 -> 8566 DualControlLayoutTest: 3934 -> 68 PromoCardImpressionTest: 6691 -> 148 WrappingLayoutTest: 38598 -> 422 ViewHighlighterTest: 2778 -> 11 PromoDialogTest: 11988 -> 234 RoundedIconGeneratorTest: 2806 -> 1792 RadioButtonLayoutTest: 4347 -> 61 RadioButtonWithDescriptionAndAuxButtonTest: 5689 -> 280 ScrimTest: 25664 -> 778 BUG=989569 Change-Id: Ib1bea431ce31ddfa4b2be86bbb1baff1cafb90e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595915Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#837789}
-
Min Qin authored
BUG=1159109 Change-Id: Iba334d54feb3574a5c81d18c3f1d042d2c7803de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593742 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
-
Mason Freed authored
These were left over from the big form controls refresh rebaseline project. Fixed: 1053725 Change-Id: I2011da373234290c9f245676ba9e2858a371967b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594316 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#837787}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e110c89ed50..632a23afa487 2020-12-16 michaelludwig@google.com Rename getTopDevice/getDevice to topDevice/baseDevice 2020-12-16 johnstiles@google.com Revert "Declare all inlined variables at the topmost scope possible." 2020-12-16 johnstiles@google.com Revert "Eliminate inliner temporary variables for functions with a single exit." 2020-12-16 brianosman@google.com Revert "Fix incorrect 'unreachable code' error in SkSL" 2020-12-16 egdaniel@google.com Update etc1.cpp. 2020-12-16 rmistry@google.com Add presubmit check for git conflict markers 2020-12-16 kjlubick@google.com [canvaskit] Update to 0.21.0 2020-12-16 rharrison@chromium.org Fix build issues preventing Dawn DEPS from rolling 2020-12-16 johnstiles@google.com Eliminate inliner temporary variables for functions with a single exit. 2020-12-16 johnstiles@google.com Declare all inlined variables at the topmost scope possible. 2020-12-16 herb@google.com cleanup SkArenaAlloc tests 2020-12-16 jvanverth@google.com Add support for directional lights. 2020-12-16 brianosman@google.com Fix incorrect 'unreachable code' error in SkSL 2020-12-16 egdaniel@google.com Fix Viewer crash when starting with vk msaa on windows. 2020-12-16 egdaniel@google.com Add checks in GrProgramInfo for resolve info. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1153993 Tbr: tdenniston@google.com Change-Id: I8e07332736a7e9acad4e339aa673a4baac120a32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595691Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837786}
-
David Grogan authored
This only tries to lay out images, no other replaced elements for now. It only works for the most basic cases and is behind the blink runtime flag LayoutNGReplaced. No virtual test suite is set up yet. Bug: 1114280 Change-Id: Ieb8b499fa7d69889531a98080ad6a7cfd6025b02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572750Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837785}
-
Yusuke Sato authored
This makes it clear that arc_vm_client_adapter.h should only have factory functions and testing functions. BUG=None TEST=try Change-Id: I47d70028d22a4c376eac3079a0523e8a4c38a59e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594791Reviewed-by:
Willie Koomson <wvk@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#837784}
-
Michael Bai authored
Notify the request failure of the current form to Java. Also add test for the failure case. Bug: 1151542 Change-Id: I3c6f9f5f4e2d118b887ce667c92ca7743ffdd826 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591911 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#837783}
-
Tom Anderson authored
Also change GFX_EXPORT to COMPONENT_EXPORT(x11). R=sky Bug: None Change-Id: Ie1c81bbef832dd747e7601f70d593b46fe47061e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595524 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#837782}
-
Garrett Beaty authored
"compile" appears as part of the name of some tests, so using it as a regex for tree closing is overly broad. This may still catch some unwanted failures but should narrow the false closures. Bug: 1159548 Change-Id: Ib19a6d5aad3818fe22430cb88007cb38f70c2615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595973Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#837781}
-
Fabrice de Gans-Riberi authored
media_control has been working reliably on Fuchsia for some time. The extra logging provides little benefits at this point. Change-Id: I50ac840fc96fa95237e970af87c5400bbff7d26d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595972 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837780}
-
Jonathan Ross authored
When we are not applying site-isolation a DelegatedFrameHost can be re-used when navigating between different pages. This can occur on Android as well as with the un-supported flag --disable-site-isolation-trials. When RenderWidgetHostImpl::ForceFirstFrameAfterNavigationTimeout is invoked, as either from tab-changing, or from thumbnailing, we set fallback surfaces. This is intended to be the first viz::SurfaceId that was generated by navigation. However if a navigation fails we don't actually embed a new surface. The DelegatedFrameHost then ends up utilizing outdated surfaces as the fallback. This change updates DelegatedFrameHost to be notified of when a navigation begins. If we fail to embed a new surface by the timeout, we evict the surface that predates the navigation. The ThumbnailTabHelper has been updated to also clear its currently cached thumbnail in the case that the page has transitioned back to the unready state. Thus clearing thumbnails that exist from before a navigation. TEST=NoCompositingRenderWidgetHostViewBrowserTest. NoFallbackAfterHiddenNavigationFails Bug: 1152894 Change-Id: Ia5734abb5201a56c271114a891bc81212a3aa975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585790Reviewed-by:Dana Fried <dfried@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#837779}
-
Tom Anderson authored
Some dependencies must also be moved to //ui/gfx/x * XWindowEventManager is used by PropertyCache * Parts of //ui/base/x/x11_util are used by PropertyCacheTest BUG=739898 R=sky Change-Id: I560be78262263b2c0fbe61d2f77a03305d44f454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596108Reviewed-by:
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/df75139becd7355e117c9860452265b898b49376..ca058c06474c4492f0fbd517679793234dde6165 Bug: none Change-Id: I798ae79013c403802127ca077ae091487387e5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595613 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#837777}
-
Yi Gu authored
Bug: 1152282 Change-Id: I9feb70e2ff921a1dc6d3c0a7b6ac41885ee9758d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595599Reviewed-by:
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/snappy.git/+log/f16eda346663..ea368c2f07de This CL also regenerates config.h. $ git log f16eda346..ea368c2f0 --date=short --no-merges --format='%ad %ae %s' 2020-12-16 costan Add AppVeyor status badge. 2020-12-16 costan Remove unused include in snappy_benchmark.cc. 2020-12-16 costan Split benchmarks and test tools into separate targets. 2020-12-16 costan Test stub improvements. 2020-12-15 cmumford Disable fuzzing on OSX. 2020-12-15 costan Fixup for adding the third_party/{benchmark, googletest} submodules. (#115) 2020-12-15 cmumford Fixed endif clause. 2020-12-15 cmumford Matching clang. 2020-12-15 cmumford Building with `-Werror` only with clang. 2020-12-15 cmumford Fix CHECK_EQ to call ok() instead of CheckSuccess(). 2020-12-15 costan Fixup for adding the third_party/{benchmark, googletest} submodules. (#111) 2020-12-15 costan Rework file:: stubs. 2020-12-15 costan Wrap snappy_unittest in an anonymous namespace and remove static from functions. 2020-12-14 costan Fixup for adding the third_party/{benchmark, googletest} submodules. (#110) 2020-12-15 costan Fix unused local variable warnings. 2020-12-14 costan Remove custom testing and benchmarking code. 2020-12-14 cmumford Add Travis-CI build status badge to README.md. 2020-12-14 costan Update Travis CI config. 2020-12-14 costan Replace #pragma nounroll with equivalent used elsewhere. 2020-12-14 costan Remove inline qualifier from static variables. 2020-12-10 no-reply 1) Improve the lookup table data to require less instructions to extract the necessary data. We now store len - offset in a signed int16, this happens to remove masking offset in the calculations and the calculations that need to be done precisely give the flags that we need for testing correctness. 2) Replace offset extraction with a lookup mask. This is less uops and is needed because we need to special case type 3 to always return 0 as to properly trigger the fallback. 3) Unroll the loop twice, this removes some loop-condition checks AND it improves the generated assembly. The loop variables tend to end up in a different register requiring mov's having two consecutive copies allows the elision of the mov's. 2020-12-09 nafi Optimize zippy decompression by making IncrementalCopy faster. 2020-12-03 no-reply Internal change 2020-12-03 nafi Optimize zippy decompression by making IncrementalCopy faster. 2020-11-19 no-reply Fix opensource version 2020-11-18 no-reply Add LZ4 as a benchmark option. Snappy is starting to look really good compared to LZ4. LZ4 is considered the fastest solution by many on internet. We now see that Snappy is actually becoming very competitive with compression a little faster and decompression slower but certainly not terribly slower. 2020-11-16 no-reply Extend validate benchmarks over all types and also add a medley for validation. 2020-11-14 no-reply Bug fix. Error on 0 offset copies. 2020-11-14 no-reply Make zippy decompression branchless 2020-11-13 no-reply Revert zippy optimization that causes heap buffer overflows. 2020-11-13 nafi Optimize zippy unzipping by upto >10% by making IncrementalCopy faster. 2020-11-13 no-reply Add a benchmark that decreased the branch prediction memorization by increasing the amount of independent branches executed per benchmark iteration. 2020-11-09 veluca Change hash function for Compress. 2020-11-02 no-reply Fix the use of op + len when op is nullptr and len is non-zero. See https://reviews.llvm.org/D67122 for some discussion of why this can matter. I don't think this should have any noticeable effect on performance. 2020-10-30 veluca Run clang-format 2020-10-29 jan fix compile warnings due to missing override specifiers 2020-07-15 ckennelly Replace ARCH_K8 with __x86_64__. 2020-07-10 no-reply Replace the division with a constant table in IncrementalCopy Created with: roll-dep src/third_party/snappy/src Change-Id: Ica5844c3799c3ccf6c814602ce03514b43f5cd16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596010 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#837775}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I557476c1e3a89e62b02af3a64efbd77e6dbdb35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595694Reviewed-by:
-
Fabio Rocha authored
This CL adds a couple of hooks for the OSIntegrationManager to call into the upcoming implementation of the ProtocolHandlerManager. There should be no observable difference in behavior with this CL. Bug: 1019239 Change-Id: I88455e0dd868d0b8944de231dd2cbf5f1a89516a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577769 Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#837773}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d976f379ec5..8a5112747ff0 2020-12-16 cpinnamaneni@microsoft.com adding image and icon support for markdownview.ts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1154783 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I167e0b02fb898b6750279d6d65093f6b3e0b150a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595495Reviewed-by:
-
John Abd-El-Malek authored
Update minimum version of NavigationCallback.LargestContentfulPaint now that it's been merged to M88. Bug: 1156663 Change-Id: I7ce80e2c5312c411bf362868083ea47cf69132bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595922 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/455dbfdd428f..307ece163070 2020-12-16 bclayton@google.com end2end: Enable textureLoad() tint tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC rharrison@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: rharrison@google.com Change-Id: I45c9ba9aeacfeb48054046b644e1912014350c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595703Reviewed-by:
-
Rakina Zata Amni authored
MetricsRenderFrameObserver currently only trigger sending of metrics: - When RenderFrame is destroyed, from its destructor. - When RenderFrame is detached, from WillDetach(). - When a navigation commits in a RenderFrame, from ReadyToCommitNavigation(). This doesn't work with cross-RenderFrame navigations as the third case doesn't happen, and the first two case will be too late as the current RFH in the browser would've changed to the new RFH already by the time the renderer's metrics update arrive in the browser, and we ignore metrics update from non-current RFHs. This CL adds two new triggers for sending metrics: - ReadyToStartNavigation, which will be fired for renderer-initiated navigations - DidSetPageLifecycleState, a new RenderFrameObserver method which will be fired on page lifecycle updates, including pagehide-in-commit that happens before the browser updates the current RFH to the new RFH on same-site cross-RenderFrame navigations that reuses the same process. See doc: https://docs.google.com/document/d/1RXGDkrSWTfaeio76joXKWBLGDHAbiB48sHUdcTX6rdc/edit#heading=h.476deggm397n See also linked bug for more details. Bug: 1150242 Change-Id: I22e5016f71a39d2420b38bfb1b406ba4845d54bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592288Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#837769}
-
Wenyu Fu authored
This reverts commit 8451c986. Reason for revert: Test is still flaky Original change's description: > Extend the time waiting for FirstRunIntegration completes > > DeferredStartupHandler.waitForDeferredStartupCompleteForTesting were > timing out with previous timeout. ChromeActivityTestRule was working > properly because this call was called when NTP is fully loaded, which > the flaky test case did not. Thus increase the time out to deflake. > > Bug: 1157611 > Change-Id: I4587c151659000c8962b40b74b4bc3575ec0e6cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590550 > Commit-Queue: Wenyu Fu <wenyufu@chromium.org> > Reviewed-by: Sky Malice <skym@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837207} TBR=skym@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenyufu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1157611 Change-Id: Ic6630f4476b1231573d56f7d8c8f1fe7f3eba21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596316Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#837768}
-
Fabio Rocha authored
This CL changes GetAppProtocolHandlerInfos to be virtual and adds web_app_protocol_handler_manager. This mimics the design of other components and avoids a layer of indirection between web_applications and web_applications/components. Bug: 1019239 Change-Id: Ibf9abbe66a4bf1addb13955040889b740cf578bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577888 Commit-Queue: Fabio Rocha <fabio.rocha@microsoft.com> Reviewed-by:
-
Michael Bai authored
Add the AutofillHintsService related aidls. Bug: 1151542 Change-Id: Ic1c2c21c78a6305706613a7eb8e0693c608a6054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592330 Commit-Queue: Michael Bai <michaelbai@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/958f1e8ca769..91beff4e632a 2020-12-16 vigeni@google.com Internal change If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I3369745a53dba5177cfb951514fe9f20bf4ced00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595702Reviewed-by:
-
Yu Su authored
1. Add a ShopWithGoogleLensChip metric to ukm.xml - go/ukm-collection-review-lens-chrome 2. Fix the merging logic for onClick callbacks. 3. Remove an unused field from LensQueryParams. 4. Fix direct intent enablement check in LensUtils. 5. Update the Classification UMA histogram to show EarlyTerminatedMs and SuccessOnQueryResultMs data. 6. Add a label to the ResultState UMA histogram to show a newly added enum value. 7. Update the ResultState UMA histogram labels for 'not shoppy image' cases. Change-Id: Id00133ceb9039fb479dfa646570fe38c1a0bece3 Bug: b/166648354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586221Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Ben Goldberger <benwgold@google.com> Commit-Queue: Yu Su <yusuyoutube@google.com> Cr-Commit-Position: refs/heads/master@{#837764}
-
Matt Menke authored
The feature it's meant to help evaluate hasn't been enabled on pre-release channels yet, let alone on stable, so we'll need it around a fair bit longer than its original expiration date. We're planning on enabling the feature on pre-release channels in January, after the field trial freeze ends. Bug: 969893 Change-Id: Iee2d0238978050cfb2f108693a6f571758052e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596127Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#837763}
-
Koji Ishii authored
This patch moves selection functions that are not related with |NGPaintFragment| to |NGInlineCursor|, in preparation of removing |ng_paint_fragment.cc|. Bug: 1154531 Change-Id: I6c1849ab443b04ac6c7c608c800b568a69d3b7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595748 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#837762}
-
