GitLab

This means the grey text under the title, which usually explains what
type the result is (e.g., "Google Search" or "Chrome Web Store").

BUG=450644

Review URL: https://codereview.chromium.org/935523002

Cr-Commit-Position: refs/heads/master@{#316953}

Clipboard is single-threaded, so Stop() is not useful there.

Review URL: https://codereview.chromium.org/930403002

Cr-Commit-Position: refs/heads/master@{#316952}

BUG=458379

Review URL: https://codereview.chromium.org/925733002

Cr-Commit-Position: refs/heads/master@{#316951}

Previous attempts:
https://codereview.chromium.org/880063002
https://codereview.chromium.org/895623003/
https://codereview.chromium.org/890013006/
https://codereview.chromium.org/907973004/

This latest attempt removes the logic that reloads ChromeVox at the beginning of a test.

Locally, under extremely heavy load, tests progressively ran slowe. The same copy of a test ran 1 second slower than a previous copy. Ultimately, this led to a timeout.

With the above change, this no longer occurs and hopefully fixes the flakeyness.

Change is located in chromevox_e2e_test_base.js.

TBR=dmazzoni@chromium.org

Review URL: https://codereview.chromium.org/940763002

Cr-Commit-Position: refs/heads/master@{#316950}

By defaulting Threaded GPU Rasterization to ON I inadvertently
disabled using more than 1 raster thread for Software rasterization
everywhere.

Fixing so IsThreadedGpuRasterizationEnabled() is only on if Gpu
rasterization is enabled or forced, so this will currently only be
on for Android.

We'll need a better way to support multiple raster worker threads
to turn on GPU rasterization on desktops, or to support multiple render
threads on Android.

BUG=454500
BUG=459760

Review URL: https://codereview.chromium.org/941443002

Cr-Commit-Position: refs/heads/master@{#316949}

Example: for "chrome-extension://extensionid/page.html",

Currently, the src would be set as: "chrome-extension://extensionid/page.html".

With the change, the src would be set as: "page.html".

BUG=459680

Review URL: https://codereview.chromium.org/936223002

Cr-Commit-Position: refs/heads/master@{#316948}

The new assets have correct colour contrast and more closely match the
Material Design spec. Affects both the classic and experimental
launcher.

The following assets were replaced:

- Microphone (hotword enabled and disabled states).
- Back button.
- Download progress bar.

BUG=457979,456953
TBR=oshima@chromium.org

Review URL: https://codereview.chromium.org/931483004

Cr-Commit-Position: refs/heads/master@{#316947}

New chrome os devices are going to make more frequent use of the dark
resume state - a hybrid power state where several hardware devices are
left off to save power.  One of these is the display.  Unfortunately
this creates issues with chrome, which believes that the display is on
and attempts to render things to the screen.  These calls fail in the
kernel and trigger a logical memory leak in the error handling code in
the GPU process.

In order to make this interaction more robust, have chrome stop sending
rendering requests at suspend time and restart them at resume time.
There are a few things to watch out for here.  If the user has requested
that the screen be locked at suspend time then rendering cannot be
stopped until the screen locker is visible.  Otherwise the contents of
the user's screen will be visible at resume time, which is a security
issue.  Additionally, the suspend must be delayed until any pending
requests have been handled by the GPU process to prevent a race where
the system suspends before all requests have been processed and they end
up being processed when the system later enters dark resume, triggering
the memory leak mentioned in the previous paragraph.

BUG=chrome-os-partner:35699

Review URL: https://codereview.chromium.org/910393002

Cr-Commit-Position: refs/heads/master@{#316946}

Address comments of RCH

BUG=none

Review URL: https://codereview.chromium.org/934383002

Cr-Commit-Position: refs/heads/master@{#316945}

This is temporary until we can determine a permanent solution.
This cannot be implemented at a lower level because the lower levels do not know
which version of EME is being used.

BUG=394926

Review URL: https://codereview.chromium.org/936653004

Cr-Commit-Position: refs/heads/master@{#316944}

This will be used to track session history items for subframes.
For now, each NavigationEntry owns a single one for its main frame.

BUG=236848
TEST=No behavior change.

Review URL: https://codereview.chromium.org/931333004

Cr-Commit-Position: refs/heads/master@{#316943}

The new accent color matches the rest of the app.

BUG=459699

Review URL: https://codereview.chromium.org/941513002

Cr-Commit-Position: refs/heads/master@{#316942}

BUG=439497

Review URL: https://codereview.chromium.org/938743002

Cr-Commit-Position: refs/heads/master@{#316941}

This eliminates one use of TextureUploader via
ResourceProvider::SetPixels.  The PICTURE_PILE_MODE is renamed to
OOM_MODE which more accurately describes what it is, and OOM tiles are
displayed in red again instead of gray (something that changed with
impl-side-painting).

R=enne
BUG=454575

Review URL: https://codereview.chromium.org/941433002

Cr-Commit-Position: refs/heads/master@{#316940}

Avoid possibly long blocking times in the Windows SetupDi function
calls made to enumerate devices by offloading to the FILE thread.
Now that we can be sure that a stray request to the device won't
block the UI additional calls to get the device's product and serial
number strings can be made.

BUG=457899

Review URL: https://codereview.chromium.org/936603003

Cr-Commit-Position: refs/heads/master@{#316939}

Also convert FormStructure::GetFieldTypePredictions() to return its data instead of using an out parameter.

Review URL: https://codereview.chromium.org/934863003

Cr-Commit-Position: refs/heads/master@{#316938}

The current mechanism is to clean all cache, which is very misleading.

Everytime we call LinkProgram, we simply delete the Program in the map,
getting rid of all cahces, and create a new Program.

BUG=429053
TEST=gpu_unittests
R=bajones@chromium.org

Review URL: https://codereview.chromium.org/933393003

Cr-Commit-Position: refs/heads/master@{#316937}

DEPENDENT on 914813002

* Combines app_banner_metrics_ids.*, app_banner_utilities.*, and
  app_banner_metrics_id_list.* into the app_banner_metrics.* files.

* Gets rid of the Java-side metrics because we can control and react
  to them entirely from native-side calls now.

* Updates the histograms accordingly.

BUG=457416
TBR=thakis

Review URL: https://codereview.chromium.org/929533002

Cr-Commit-Position: refs/heads/master@{#316936}

BUG=415689

Review URL: https://codereview.chromium.org/580233002

Cr-Commit-Position: refs/heads/master@{#316935}

This was reverted due to high crash rates on 10.10.2 (where we don't
full crash reports). This was tested on branch and didn't affect the
crash rate. The next step is to forward the event to the renderer.

BUG=452592

Review URL: https://codereview.chromium.org/940733002

Cr-Commit-Position: refs/heads/master@{#316934}

Many ClientSession unittests assume that the first video frame always
contains video dimensions. When running under valgrind the keep-alive timer
may fire before the first video frame is sent and this breaks the tests.

Fixed VideoFramePump to start sending keep-alive messages only after the
first real frame is sent. Also made the keep-alive timer non-repeating.
This ensures that the pump doesn't try sending a keep-alive message until
the previous one has been sent.

BUG=458691

Review URL: https://codereview.chromium.org/936553003

Cr-Commit-Position: refs/heads/master@{#316933}

Start running connect-to-localhost and connection-alive-after-focus-lost tests for v2 web-app on Linux.
Also, reactivating v2 web-app Auth test on Linux, now that http://crbug/447778 has been fixed.

BUG=

Review URL: https://codereview.chromium.org/941493002

Cr-Commit-Position: refs/heads/master@{#316932}

(Temporarily) copy app compat thumb drawables to chrome/android/java/res. These
were missed in the original CL to fix the app compat switch thumb not always being
drawn (crbug.com/455327).

BUG=459782

Review URL: https://codereview.chromium.org/937903002

Cr-Commit-Position: refs/heads/master@{#316931}

BUG=459400

Review URL: https://codereview.chromium.org/930413003

Cr-Commit-Position: refs/heads/master@{#316930}

BUG=417532

Review URL: https://codereview.chromium.org/927443004

Cr-Commit-Position: refs/heads/master@{#316929}

BUG=405305

Review URL: https://codereview.chromium.org/927483002

Cr-Commit-Position: refs/heads/master@{#316928}

BUG=459649
TBR=calamity@chromium.org

Review URL: https://codereview.chromium.org/939813002

Cr-Commit-Position: refs/heads/master@{#316927}

Adds an ellipsis to the 'Create shortcuts' and 'Remove' buttons, which
both require additional user input.

BUG=448359

Review URL: https://codereview.chromium.org/926993002

Cr-Commit-Position: refs/heads/master@{#316926}

This is a minimal fix to prevent silently doing the wrong thing.
A better fix would resolve names, and use the URL itself as a fallback.

BUG=none

Review URL: https://codereview.chromium.org/938853002

Cr-Commit-Position: refs/heads/master@{#316925}

The plugin is allowed to use Pepper without having bound a PPB_MessageLoop
to the calling thread, which means MessageLoop::current won't be valid.
Instead, we should just post to the Pepper main thread.

BUG=459671

Review URL: https://codereview.chromium.org/938843002

Cr-Commit-Position: refs/heads/master@{#316924}

Uses BrowserURLHandler since this depends on components and can't
live in content.

BUG=449829
TEST=See bug for repro steps.

Review URL: https://codereview.chromium.org/923183003

Cr-Commit-Position: refs/heads/master@{#316923}

r2031: Reland "msvs/ninja win: Fix support for ImageHasSafeExceptionHandlers"
r2032: msvs: Prefer x64 toolset if we are running on 64-bit
r2033: Make msvs-ninja work for target-arch=x64
r2034: ninja/posix: Introduce support for arflags variable.

BUG=453195
R=thakis@chromium.org

Review URL: https://codereview.chromium.org/937843002

Cr-Commit-Position: refs/heads/master@{#316922}

The existing code ends up moving values between threads, whether by
value or hidden in a callback, causing instability and races in edge-
cases, for example when abruptly cancelling the load.

This patch introduces a PendingNotificationTracker, which completely
lives on the same thread as NotificationManager and will store all
information associated with the notification, ensuring that it never
inadvertently leaves the thread.

The NotificationImageLoader lives on the main thread and is in charge
of doing the actual fetch. Rather than storing either a callback with
the Notification's data, it knows a pending notification id given to
it by the PendingNotificationTracker. This allows us to re-associate
the data when the fetched resource(s) are available.

I'm adding some layout tests in the following patch to exercise the
image loader in a number of additional cases. Unit tests will be added
in a follow-up patch.

https://codereview.chromium.org/933153003/

BUG=458640

Review URL: https://codereview.chromium.org/939513002

Cr-Commit-Position: refs/heads/master@{#316921}

Allows using crash key system for android cast shell similiar to how
it's used for chrome

BUG=internal b/18763538

Review URL: https://codereview.chromium.org/923263004

Cr-Commit-Position: refs/heads/master@{#316920}

skia and mojo dependencies were missing and were thus
added.

BUG=459399

Review URL: https://codereview.chromium.org/937863002

Cr-Commit-Position: refs/heads/master@{#316919}

Checking if the displays are suspended in
DisplayConfigurator::RunPendingConfiguration is exposing a race
condition in the interaction between chrome and powerd.  The original
reason for adding the check was to ensure that chrome did not attempt to
perform any modesets while the chrome os device was in a dark resume.
Since this really only happens when the display configuration changes,
we can move the check into OnConfigurationChanged.  Also, to deal with
the possbility that the configuration timer was started right before the
system suspended, stop the timer in SuspendDisplays.  The
DisplayConfigurator will force a probe and re-configuration on resume
anyway so stopping the timer at suspend time will not really make a
difference.

BUG=chrome-os-partner:36723,459783

Review URL: https://codereview.chromium.org/932203002

Cr-Commit-Position: refs/heads/master@{#316918}

Note that Chromium won't allow any non-zero value for |timeout| in WebGL 2.

If Nacl decides differently on this, we can revisit the code in the future.

This command has a GLuint64.  Instead of upgrading command buffer to be 64 bit,
we use a Union to decode the 64bit value to two 32bit values on the client side,
and encode them back into one 64bit value on the service side.

BUG=429053
TEST=gpu_unittests
R=piman@chromium.org

Review URL: https://codereview.chromium.org/932963003

Cr-Commit-Position: refs/heads/master@{#316917}

for tracking the frames received on the headers stream which arrived early.

Review URL: https://codereview.chromium.org/937803002

Cr-Commit-Position: refs/heads/master@{#316916}

As discussed in https://codereview.chromium.org/866163002/, this change will
allow consumer of the metrics component to configure the metrics uploader endpoint
without modifying the component.

BUG=453987

Review URL: https://codereview.chromium.org/886173002

Cr-Commit-Position: refs/heads/master@{#316915}

We're not moving the bitmap after injected cursor moves. This regressed
in r312018 ("ozone: dri: Synchronize the cursor state").

BUG=459447
TEST=Connect via remoting to freon chromebook & move cursor. Cursor
     displayed on remote system should track movement closely.

Review URL: https://codereview.chromium.org/933363003

Cr-Commit-Position: refs/heads/master@{#316914}