GitLab

The existing XR test workaround (crrev.com/c/1306173) checks for the
existence of isInitializationComplete by attempting to access it.
However, accessing an undeclared variable throws a ReferenceError -- the
correct way of checking for its existence is using typeof.

Bug: 894796
Change-Id: I86a5ac2ba45fea5e51c7e0f9fddc4167b8772443
Reviewed-on: https://chromium-review.googlesource.com/c/1319715Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605771}

Attempt to init the display device scale factor in WindowTreeHost's ctor.
WindowTreeHost subclasses/users may use the cached scale before InitHost.
See http://crbug.com/899084 and https://crrev.com/c/1311080 (PS7)

This may incorrectly use the primary display's scale for new windows on extended displays.
Still, a best effort attempt to initialize the cached value here may be worthwhile.
It's unclear if this solves any practical defects similar to crbug.com/899084.

Bug: None
Test: Automated
Change-Id: Ia776d870d8a51c5ac381b2a023c7a2a579dca97a
Reviewed-on: https://chromium-review.googlesource.com/c/1318693Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605770}

Bug: 901433
Test: manual. See bug for repro step
Change-Id: Idd25bc0b0b0519141660b11cb7db5e67bc04122c
Reviewed-on: https://chromium-review.googlesource.com/c/1319855Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605769}

Some services that run in a utility process such as the Data Decoder
Service will shut themselves down cleanly if they do not have requests
for a period of time. These were being treated as OOM kills previously.

This uses the approach Bo outlined in http://crbug.com/872343.

Bug: 872343
Change-Id: Iaf371520893076981d44429a7ec1c444b637c93d
Reviewed-on: https://chromium-review.googlesource.com/c/1298024Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605768}

I should've removed this line in crrev.com/c/1247184

R=dgrogan@chromium.org

Bug: 784059
Change-Id: Iad283f72794abce0dd46835afed1a90c77e0fc91
Reviewed-on: https://chromium-review.googlesource.com/c/1320213
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605767}

This adds the P2PQuicStream::WriteData function and adds tests. It also
adds the concept of a write buffered amount, enforcing this at the
P2PQuicStreamImpl.

Bug: 874296
Change-Id: Id02c8aa8d5368a87bb24a2e50dab5ef94bcae131
Reviewed-on: https://chromium-review.googlesource.com/c/1315534
Commit-Queue: Seth Hampson <shampson@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605766}

This CL changes the default behavior from always
placing the shelf on the top-left display in the
unified matrix, to placing it according to its
aligment:
- "left" alignment -> top-left display in the matrix.
- "right" alignment -> top-right display in the matrix.
- "bottom" alignment -> bottom-left display in the matrix.

This CL also fixes the shelf positioning when changing the
unified display zoom (the unified scale factor was not taken
into consideration).

BUG=897771
TEST=Modified tests.

Change-Id: Idf7a364ce40340e69a1dbb8785318725ea1aa890
Reviewed-on: https://chromium-review.googlesource.com/c/1315711Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605765}

Move the MediaSessionAction enum from blink to
//services.

BUG=875004

Change-Id: I29a13b696b0d27facbb1fbf98a162f827d9a476e
Reviewed-on: https://chromium-review.googlesource.com/c/1302694
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Sergey Volk <servolk@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605764}

Replaces individual Collection's ImageDataSource. Replaces the ImageDataSource for History and Recent Tabs.

Bug: 851665
Change-Id: I01329b6f0926361d85e48d310dd37c919de47d7f
Reviewed-on: https://chromium-review.googlesource.com/c/1318830
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605763}

Default code path is unchanged, this only changes behavior when the
network service is enabled.

This changes AwURLRequestContextGetter's HTTP cache to be in-memory when
the network service is enabled, to avoid creating a second HTTP cache
(in addition to the NetworkContext's cache).

R=jam@chromium.org

Bug: 887538
Test: N/A
Change-Id: I13073e68a46d6eedaca6d77cf2f96b3ea84fdecb
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1319334Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605762}

Story is flaky when running as smoke test.

NOTRY=true
TBR=nednguyen@google.com

Bug: 899887
Change-Id: I7e7a924329121c5fd5645dd8e0a92e61d7afe6a5
Reviewed-on: https://chromium-review.googlesource.com/c/1320173Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605761}

Ran into a bot failure where the tool didn't exist for vr tests:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8930637010680307008/+/steps/chrome_public_test_vr_apk_on_Android_device_Nexus_5X__retry_with_patch_/0/stdout

Change-Id: I815a5d591b7ef123449e545cd643948d5fa87fd0
Reviewed-on: https://chromium-review.googlesource.com/c/1319854
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605760}

Change-Id: Ib8e1aba6d56ee257664aef39aed635490f25f2e1
Reviewed-on: https://chromium-review.googlesource.com/c/1320019Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605759}

https://skia.googlesource.com/skia.git/+log/7a305a2ef715..5d3deb7301b1


git log 7a305a2ef715..5d3deb7301b1 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 fmalita@chromium.org [skottie] Preserve image aspect ratio
2018-11-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 3d86e89bce7a..77b2436e28f4 (1 commits)
2018-11-06 mtklein@google.com Revert "make enum santizer fatal"
2018-11-06 reed@google.com change MakeRecAndEffects to take SkFont


Created with:
  gclient setdep -r src/third_party/skia@5d3deb7301b1

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=allanmac@chromium.org

Change-Id: I7fbdbbd49fc71bc437e93c2339aa01386aae0c8b
Reviewed-on: https://chromium-review.googlesource.com/c/1320151Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605758}

Fixing logic bug in IPH triggering logic. Adding a variation for "force trigger on english" experiment as a flag to automatically trigger it.

Bug: 883456
Change-Id: Ice024580601fdfe5debb862bb7cfeff956b04dbc
Reviewed-on: https://chromium-review.googlesource.com/c/1318631Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605757}

Rely on the IdentityManager's API instead of SigninManager's one,
and implement identity::IdentityManager::Observer to monitor for
signed-in and signed-out events.

Bug: 890824, 887463
Change-Id: Ic8a7d46ba91c0824d8949475c04fa75131c5cf70
Reviewed-on: https://chromium-review.googlesource.com/c/1315213
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605756}

It's flaky everywhere, not just mash.

TBR=caseq@chromium.org

Bug: 889878
Change-Id: Iae5bdc6625102ad5dc59707a68f1f67db2a53dcd
Reviewed-on: https://chromium-review.googlesource.com/c/1318801Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605755}

https://swiftshader.googlesource.com/SwiftShader.git/+log/155f802a6be3..4169b31090db

$ git log 155f802a6..4169b3109 --date=short --no-merges --format='%ad %ae %s'
2018-11-05 tikuta Fix for unused-lambda-capture warning
2018-11-05 gordana.cmiljanovic [MIPS] Add support for 64b MIPS architecture
2018-11-03 tikuta Revert "Fix for unused-lambda-capture warning"
2018-10-23 tikuta Fix for unused-lambda-capture warning

Created with:
  roll-dep src/third_party/swiftshader

Bug: 681136
Change-Id: I74a53ae11edbd50fb69c95764a7c77dc54b473c1
Reviewed-on: https://chromium-review.googlesource.com/c/1318511Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605754}

As part of the effort to add read/write to the P2PQuicTransportStream,
some of the stream level tests need to be moved into their own more
isolated testing environment. This includes using a MockQuicSession.
This change moves the stream unit tests to this new environment, and
also updates the p2p_quic_transport_test.cc to use Mock objects instead
of the fake objects for the delegates.

Bug: 874296
Change-Id: Ifdfd30f753a2b6090c8f73330978c5feed2b9cf6
Reviewed-on: https://chromium-review.googlesource.com/c/1312971Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Seth Hampson <shampson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605753}

Experiments have been uneventful for many weeks. Enable by default for M72.

TimeToFirstFrame is negatively impacted by this change, as the startup IPC now
hops throught the browser where before it went directly over the GPU channel.
The cost is typically less than 30ms. Reconfigurations are faster because
PictureBuffer allocation no longer requires any IPC.

Bug: 522298
Change-Id: I40ea00150f7dadfe2319e2cdb27e3be5f29a702c
Reviewed-on: https://chromium-review.googlesource.com/c/1315940
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605752}

Change-Id: I5059c4f7e1351ea62749fd381fd6fea3a812f749
Reviewed-on: https://chromium-review.googlesource.com/c/1319345Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605751}

The fact that the LIVE_STATE_USING_WEB_SOCKETS reason exists might
confuse some devs who could assume that using a WebSocket will protect
their page, this add a comment to specify that this heuristic isn't
currently used.

Change-Id: Ibc6034a53c87291993dfa66094b69a2fa55aa0cf
Reviewed-on: https://chromium-review.googlesource.com/c/1319771Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605750}

WebGL may use GL_RGB texture, and choose viz::RGBA_8888 as resource
format. So to make WebGL work, we should not consider it an invalid
combination.

Bug: 901822
Change-Id: I4b6678492b2fb847d66de3fe8ec7b0049ca8eaff
Reviewed-on: https://chromium-review.googlesource.com/c/1318076Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605749}

On some scale factors the bottom most pixel is outside of
the display bounds. Snapping shelf region to display edge fixes
the problem.

Bug: 899007
Test: manual
Change-Id: I1eeb342756b46e683d0f30f96f1c428fbb74d7ca
Reviewed-on: https://chromium-review.googlesource.com/c/1320013Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605748}

R=hansberry@chromium.org

Bug: 899324
Test: none
Change-Id: I300f9e21a19abdfff93b8a70a21cec6dac00db31
Reviewed-on: https://chromium-review.googlesource.com/c/1319338Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605747}

The application default credential belongs to the default Swarming bot
account, not the dedicated service account for wpt-importer. As
suggested by LUCI task force, we need to use `luci-auth token` instead.

Bug: 790503
Change-Id: I3257db9a49196fd427c6f2371d00dcabab7ee3a6
Reviewed-on: https://chromium-review.googlesource.com/c/1315931
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605746}

Previously the body of structs was traversed in-order, but out-of-line
items were deferred to a queue, making traversal mostly breadth-first.
Instead, fix encoding by emitting any out-of-line items by allocating
(and filling) directly following the current item.

Bug: 883496
Change-Id: If157930521e4cf5f89f702207defe91beb862def
Reviewed-on: https://chromium-review.googlesource.com/c/1316429
Commit-Queue: Scott Graham <scottmg@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605745}

be translated or not.

Bug: 872096
Change-Id: I9cd2df787c46f6b95f3918adaf8023a030c0b480
Reviewed-on: https://chromium-review.googlesource.com/c/1313416
Commit-Queue: Alexandre Frechette <frechette@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605744}

https://webrtc.googlesource.com/src.git/+log/a8f54617c08d..277b6ea8508e


git log a8f54617c08d..277b6ea8508e --date=short --no-merges --format='%ad %ae %s'
2018-11-06 alessiob@webrtc.org Isolating APM API build target: adding dummy :api target.
2018-11-06 phoglund@webrtc.org Revert "Add support for screen sharing with PipeWire on Wayland"
2018-11-06 ilnik@webrtc.org Tune huge video frames detection threshold for GetStats googHugeFramesSent stat
2018-11-06 sprang@webrtc.org Make VideoSendStreamTest.NoPaddingWhenVideoIsMuted less flaky


Created with:
  gclient setdep -r src/third_party/webrtc@277b6ea8508e

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:682122,chromium:901319,chromium:none
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6dadb5c6014d55b6065ea8c415045b3854688c65
Reviewed-on: https://chromium-review.googlesource.com/c/1319810Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605743}

Expand an existing function in network quality
estimator (NQE) to more accurately determine the cause
of crash. This CL does not make any functionality change.

Bug: 899808
Change-Id: I77c8aa07ca23ea92f99775a36393431f4ebf8cb4
Reviewed-on: https://chromium-review.googlesource.com/c/1319339Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605742}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/04f1c7dac0fd..d85a5094684e


Created with:
  gclient setdep -r src-internal@d85a5094684e

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Icca8193d5c78d30a72193cbce0912c2e67e96d88
Reviewed-on: https://chromium-review.googlesource.com/c/1319812Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605741}

moved current test expects to platform/linux
added new test expects to platform/win

Bug: 889185
Change-Id: Ifdd0e9c4f0389967756e5dcc2fe3512da40e8e41
Reviewed-on: https://chromium-review.googlesource.com/c/1318375
Commit-Queue: Luna Lu <loonybear@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605740}

We currently keep a counter on the raster buffer provider for sampling
this metric, which can result in bias in some cases.

R=vmiura@chromium.org

Bug: 894200
Change-Id: I943afeaf5653ca30baee611f7d1f8ebb50a3030c
Reviewed-on: https://chromium-review.googlesource.com/c/1319029Reviewed-by: Victor Miura <vmiura@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605739}

Design doc and sequence diagrams are linked in the bug id.

Add Mojo API:

  - OnAccountUpdated

Add functionality to listen for account modifications in Chrome OS and
pass these notifications to ARC, only if ARC provisioning has been
reported to be successful.

Add functionality to push accounts from Chrome OS to ARC when the first
successful provisioning is reported, and at startup, if ARC has already
been successfully provisioned.

Bug: 871690
Test: browser_tests --gtest_filter="*Arc*AuthService*Test*"
Change-Id: I9e5610c8a00cdd4179328156d2a11540878986b2
Reviewed-on: https://chromium-review.googlesource.com/c/1238913
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605738}

In openInChrome, we had a past fix to check if Chrome can handle a VIEW
intent and pass back to the system if not. But this seems to have come
back with a smaller crash segment that fails because there are no
handlers. This CL handles that one last exception and lets Chrome do
nothing as a graceful failure.

BUG=891640

Change-Id: I9ad7146c5cf8a77e59527b909521460668717818
Reviewed-on: https://chromium-review.googlesource.com/c/1300104Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605737}

https://chromium.googlesource.com/angle/angle.git/+log/3d86e89bce7a..77b2436e28f4


git log 3d86e89bce7a..77b2436e28f4 --date=short --no-merges --format='%ad %ae %s'
2018-11-06 jmadill@chromium.org Vulkan: Reduce PipelineDesc size.


Created with:
  gclient setdep -r src/third_party/angle@77b2436e28f4

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=syoussefi@chromium.org

Change-Id: I8de0956ebe8b1b133ae308c17a0d2470033f50ee
Reviewed-on: https://chromium-review.googlesource.com/c/1319949Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#605736}

Use identity::IdentityManager::HasPrimaryAccount() instead of
SigninManagerBase::IsAuthenticated, and remove unneeded includes.

Bug: 890826
Change-Id: Iabe09231fa684e8249475ba9dcd8782d7ecd90d5
Reviewed-on: https://chromium-review.googlesource.com/c/1315969Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Cr-Commit-Position: refs/heads/master@{#605735}

This CL fixes DragBrowserWindowWhenMajorityOfBoundsInSecondDisplay
of tab-dragging for Mash;
- SetBounds are not great for testing with Mash since it may not
  reflect the correct location in Ash, or it may cause moving the
  browser window to the secondary display. Instead, dragging events
  to move the browser window which still resides in the primary
  display but covers on the secondary display.
- Creates a mouse move event on the warped pointer; as far as
  I debugged, this is not happening in the classic environment
  too, but the test was passing somehow (the newly added expectation
  of browser bounds at the end fails even without Mash).

BUG=901543
TEST=trybot

Change-Id: Id4826673975535e0dc12460cda4a62b060a328db
Reviewed-on: https://chromium-review.googlesource.com/c/1318794Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605734}

Currently, ImmersiveGestureHandlerClassic installs itself as a pretarget
handler on Shell. This is necessary to get events from bezel sensors,
which have bounds outside the immersive fs window. It also forwards
gesture events to ImmersiveFullscreenController.

Keep the part of ImmersiveGestureHandlerClassic that handles drag-
triggering gesture events in tablet mode (i.e. most of the class) and
run that within Ash in both Classic and Mash configurations.

Make ImmersiveFullscreenController a pretarget handler for the toplevel
window when it's in immersive mode. This works in either Ash or client
as ImmersiveFullscreenController doesn't need to get events outside of
the window's bounds. ImmersiveFullscreenController is now both an
EventHandler (for gesture events) and an EventObserver (for mouse and
touch events).

Bug: 624157,640374
Change-Id: I83536cb407b4ac890db63d4c6a0fe98b7912a3f4
Reviewed-on: https://chromium-review.googlesource.com/c/1300678
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605733}

BUG=889873

Change-Id: I3abc3bffc987333d9e0919a722c2d6a9f18815be
Reviewed-on: https://chromium-review.googlesource.com/c/1316929Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#605732}