GitLab

BUG=575210

Review-Url: https://codereview.chromium.org/2251733002
Cr-Commit-Position: refs/heads/master@{#412787}

This patch converts "editing/delete-by-word-00[12].html" to use w3c test harness
and integrates into "delete_by_word.html", since both test cases are
very similar, to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2252153004
Cr-Commit-Position: refs/heads/master@{#412786}

Revert of Roll clang 277962:278861 (patchset #5 id:80001 of https://codereview.chromium.org/2241413003/ )

Reason for revert:
This is suspect of breaking Mac 10.9 builder.

See
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/28850

Sample logs:
Retrying 1 test (retry #1)
[0817/224954:ERROR:kill_posix.cc(84)] Unable to terminate process group 8687: No such process
[ RUN      ] ThreadTest.StartWithOptions_StackSize
[2060/2060] ThreadTest.StartWithOptions_StackSize (CRASHED)
Retrying 1 test (retry #2)
[0817/224955:ERROR:kill_posix.cc(84)] Unable to terminate process group 8688: No such process
[ RUN      ] ThreadTest.StartWithOptions_StackSize
[2061/2061] ThreadTest.StartWithOptions_StackSize (CRASHED)
Retrying 1 test (retry #3)
[0817/224955:ERROR:kill_posix.cc(84)] Unable to terminate process group 8689: No such process
[ RUN      ] ThreadTest.StartWithOptions_StackSize
[2062/2062] ThreadTest.StartWithOptions_StackSize (CRASHED)
1 test crashed:
    ThreadTest.StartWithOptions_StackSize (../../base/threading/thread_unittest.cc:135)
Tests took 21 seconds.
Additional test environment:
    CHROME_DEVEL_SANDBOX=/opt/chromium/chrome_sandbox
    LANG=en_US.UTF-8
Command: ./base_unittests --brave-new-test-launcher --test-launcher-bot-mode --test-launcher-summary-output=/b/swarm_slave/w/ionk6XHB/output.json

Original issue's description:
> Roll clang 277962:278861
>
> BUG=636558,637866
>
> Committed: https://crrev.com/29ecb32ba7b5ca183782c5f5d2b7a1ae23309edb
> Cr-Commit-Position: refs/heads/master@{#412745}

TBR=rnk@chromium.org,dcheng@chromium.org,dpranke@chromium.org,inferno@chromium.org,hans@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=636558,637866

Review-Url: https://codereview.chromium.org/2249163007
Cr-Commit-Position: refs/heads/master@{#412785}

BUG=612908

Review-Url: https://codereview.chromium.org/2253043002
Cr-Commit-Position: refs/heads/master@{#412784}

BUG=580068
R=tyoshino

Review-Url: https://codereview.chromium.org/2257053002
Cr-Commit-Position: refs/heads/master@{#412783}

This fallback is active when we have less bookmarks with last visit info than specified by Finch (defaults to 3). This is relevant for existing users after they update to m54.

In this fallback mode, we
 - use creation date instead of (missing) last visit date and
 - do not impose age limit on bookmarks to show

BUG=638538

Review-Url: https://codereview.chromium.org/2256643002
Cr-Commit-Position: refs/heads/master@{#412782}

This patch converts "editing/deleting/delete-at-paragraph-boundaries-00[1-5].html" to
use w3c test harness to simplify test script for improving readability, and
consolidates into "delete_at_paragraph_boundaries.html" since samples of them
are similar.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2255063002
Cr-Commit-Position: refs/heads/master@{#412781}

There are situations where getSelectedList_ returns nothing and unselectAllItems
triggered by polymer fails if nothing is selected.Page shifted downwards since
polymer can't generate custom style for history-sidebar after the failure.

BUG=637196
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2248223003
Cr-Commit-Position: refs/heads/master@{#412780}

As detailed in the bug, Signed Certificate Timestamps (SCTs) can be marked as invalid for two reasons. This change splits the invalid SCT status into two:
* Invalid timestamp.
* Invalid signature.

Since right now we'd only like to collect data on whether invalidity is due to an ecosystem problem (invalid signatures) or misconfigured clients (invalid timestamp), the change only affects the metrics we collect.
All other consumers of the SCT verification status have been adjusted to treat both statuses the same.

Per rsleevi's recommendation, the SCTVerifyStatus enum has been expanded and the value for the old invalid status is no longer used.

BUG=634006

Review-Url: https://codereview.chromium.org/2241213002
Cr-Commit-Position: refs/heads/master@{#412779}

Add missing support to GN files.
Properly set nonsfi and glibc dependencies.

BUG=GN gen failure
TEST=Run GN gen with: target_cpu="mipsel" mips_arch_variant="r2" enable_nacl=true

Review-Url: https://codereview.chromium.org/2242893002
Cr-Commit-Position: refs/heads/master@{#412778}

BUG=638189

Review-Url: https://codereview.chromium.org/2244123004
Cr-Commit-Position: refs/heads/master@{#412777}

The failure seems to occurs on Win10 only, but these tests already had entries and it was not possible to add a new Win10-specific entry.

TBR=ericrk@chromium.org
BUG=638843

Review-Url: https://codereview.chromium.org/2242173007
Cr-Commit-Position: refs/heads/master@{#412776}

Revert of Fix ineffective --disable-gpu-driver-bug-workarounds (patchset #11 id:200001 of https://codereview.chromium.org/2195743005/ )

Reason for revert:
Cause failures on Nexus 9 GPU bot https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%209%29/builds/1385

Original issue's description:
> Fix ineffective --disable-gpu-driver-bug-workarounds
>
> It was hidden to the user since chrome://gpu was not showing
> any workarounds, but they were still applied in the gpu process.
>
> Also add a gpu test that sets
> --disable-gpu-driver-bug-workarounds --use_gpu_driver_workaround_for_testing
> and verifies that the only active workaround is USE_TESTING_GPU_DRIVER_WORKAROUND
> in both browser and gpu processes.
>
> BUG=359367
>
> R=kbr@chromium.org, zmo@chromium.org
>
> TEST=./content/test/gpu/run_gpu_test.py gpu_process --show-stdout --browser=exact --extra-browser-args="--no-sandbox" --browser-executable=./out/build/chrome
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
>
> Committed: https://crrev.com/d18006d595e7b6bf070f9ab9777d353ac8457755
> Committed: https://crrev.com/7eee382917c50ad10a487ef1c1402adc8c84e9fd
> Cr-Original-Commit-Position: refs/heads/master@{#409197}
> Cr-Commit-Position: refs/heads/master@{#412685}

TBR=kbr@chromium.org,zmo@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=359367

Review-Url: https://codereview.chromium.org/2253413002
Cr-Commit-Position: refs/heads/master@{#412775}

BUG=633185,633229

Review-Url: https://codereview.chromium.org/2253073002
Cr-Commit-Position: refs/heads/master@{#412774}

Every time PasswordFormManager is constructed in production code,
FetchDataFromPasswordStore is called on it immediately after construction.
It makes sense to automate calling FetchDataFromPasswordStore.

Doing so will also help keep the change of fetching credentials in
FormFetcher instead of in PasswordStore smaller. (See the overall plan
in https://docs.google.com/document/d/12CH_SV1gIJKaEIGTs7gWBiXrCMlBa3o32OyC2LRtPAo/edit#bookmark=id.cbgso0v3oogv

This CL:
  * Adds a call to FetchDataFromPasswordStore at the end of PasswordFormManager
    constructor.
  * Removes the after-construction calls to FetchDataFromPasswordStore.
  * Adjusts tests.

BUG=621355
R=vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2256703002
Cr-Commit-Position: refs/heads/master@{#412773}

Cr-Commit-Position: refs/heads/master@{#412772}

This patch converts "editing/deleting/delete-block-merge-contents-01[2-7].html" to
use w3c test harness to simplify test script for improving readability, and
consolidates into "delete_block_merge_whitespace.html" since samples of them
are similar.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2255073002
Cr-Commit-Position: refs/heads/master@{#412771}

Cr-Commit-Position: refs/heads/master@{#412770}

Only Node and Frame used it, and it didn't make sense because they are not
ref-counted.
This CL has no behavior changes.

Review-Url: https://codereview.chromium.org/2259763002
Cr-Commit-Position: refs/heads/master@{#412769}

ShutdownOnIOThread may be called more than once. If this happens,
the MessageLoop observer will be null during the second call.
This ensures that we don't dereference it in that case.

BUG=None
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2259753002
Cr-Commit-Position: refs/heads/master@{#412768}

This is a followup after r412613 to support legacy format loading.

Review-Url: https://codereview.chromium.org/2248963005
Cr-Commit-Position: refs/heads/master@{#412767}

Revert of arc: avoid checkbox AutomationNode issue (patchset #1 id:1 of https://codereview.chromium.org/2254673003/ )

Reason for revert:
https://crbug.com/638840

Original issue's description:
> arc: avoid checkbox AutomationNode issue
>
> Avoid checkbox AutomationNode issue https://crbug.com/638498
>
> BUG=638501
> BUG=b/30906810
> TEST=tested as described in the issue
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/359b23f1b3264cea0eac17380c45c200c5e5dd1f
> Cr-Commit-Position: refs/heads/master@{#412740}

TBR=xiyuan@chromium.org,khmel@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=638501

Review-Url: https://codereview.chromium.org/2257073002
Cr-Commit-Position: refs/heads/master@{#412766}

BUG=591606

Review-Url: https://codereview.chromium.org/2050463003
Cr-Commit-Position: refs/heads/master@{#412765}

BUG=636289

Review-Url: https://codereview.chromium.org/2229333002
Cr-Commit-Position: refs/heads/master@{#412764}

1. Distinguish PaintInvalidationNone and PaintInvalidationProbablyNone,
   so that callers of ObjectPaintInvalidator::computePaintInvalidationReasion()
   can treat them differently to avoid unnecessary overriding
   cases that definitely no paint invalidation is needed.

2. Check emptiness of newBounds and oldBounds earlier. This avoids
   unnecessary object and layer paint invalidations when both oldBounds
   and newBounds are empty but we computed a non-none paint invalidation
   reason.

3. Renamed LayoutObject::paintedOutputOfObjectHasNoEffect to
   paintedOutputOfObjectHasNoEffectRegardlessOfSize because it doesn't check
   for empty size. The behavior is required to do correct paint invalidation
   when the size changes to empty. Now the name is better suited to the
   actual behavior.

These changes will help spv1 paint invalidation and GeometryMapper-based
spv2 paint invalidation to produce the same result.

BUG=510908
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2247543003
Cr-Commit-Position: refs/heads/master@{#412763}

Manually revert all of https://codereview.chromium.org/2251583002/. NeedsRebaseline tags were removed by
rebaseline-o-matic - adding them back to reset test expectations to former state.
Replaces
https://codereview.chromium.org/2251393002/ which could not
auto-merge
BUG=638822
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=ericrk@chromium.org,vmpstr@chromium.org

Review-Url: https://codereview.chromium.org/2251863005
Cr-Commit-Position: refs/heads/master@{#412762}

BUG=627697
TEST=opened a file and moved to the next with <Right> and checked chrome://histograms. Confirmed 1 FileBrowser.QuickView.FileTypeOnLaunch is exported and 2 FileBrowser.QuickView.FileType are exported.

Review-Url: https://codereview.chromium.org/2252723005
Cr-Commit-Position: refs/heads/master@{#412761}

Otherwise Chromium claims supporting video/mp4 and fails to play some
YouTube video without falling back to video/webm even if supported by
the server.

BUG=571417

R=jrummell@chromium.org

Review-Url: https://codereview.chromium.org/1569053002
Cr-Commit-Position: refs/heads/master@{#412760}

Mark inspector/editor/text-editor-search-switch-editor.html as skip on Win7, Mac10.11, and Linux debug.
Example failures:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6954
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/8908
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/3999

BUG=638618
TBR=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2251373002
Cr-Commit-Position: refs/heads/master@{#412759}

This CL fixes a violation for a DCHECK that states |m_workerLoader| should be
cleared before the MainThreadLoaderHolder's destruction.

BUG=635436

Review-Url: https://codereview.chromium.org/2256103002
Cr-Commit-Position: refs/heads/master@{#412758}

Removed Wrap-Flow and Wrap-Through from ComputedStyle's
StyleRareInheritedData, since they are no longer used. Also removed some
additional unused ComputedStyle initial value methods.

BUG=628043

Review-Url: https://codereview.chromium.org/2223133004
Cr-Commit-Position: refs/heads/master@{#412757}

Before this CL, file names to include were decided with
the path of original IDL files.
This behavior could mislead us as if we included generated
files for partial interface and non-partial interface
in one aggregation file, although we aggregate files for
all partial interfaces into one file.

This change make it obvious in .gn/.gyp files to aggregate
files for (non-)partial interfaces.

BUG=634231

Review-Url: https://codereview.chromium.org/2259463002
Cr-Commit-Position: refs/heads/master@{#412756}

The --csv argument makes find_unmapped_histograms.py report unmapped
histograms in CSV format instead of logging them.

This makes it easier to digest the output in other software.

R=isherman@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2245263004
Cr-Commit-Position: refs/heads/master@{#412755}

This CL:

 - Renames PermissionInfobarDelegate to PermissionInfoBarDelegate
   (this is the only delegate class which doesn't follow the InfoBar
   naming convention).
 - Removes redundant requesting_frame_/requesting_origin_ members
   in PermissionInfoBarDelegate subclasses
 - Moves ShouldShowPersistenceToggle's feature query into
   PermissionUtil in preparation for the desktop and grouped infobar
   implementation
 - Moves ignore count incrementing after ignore action UMA, to be
   consistent with dismiss count UMA in PermissionContextBase.

BUG=638076

Review-Url: https://codereview.chromium.org/2250053002
Cr-Commit-Position: refs/heads/master@{#412754}

Review-Url: https://codereview.chromium.org/2250953004
Cr-Commit-Position: refs/heads/master@{#412753}

Review-Url: https://codereview.chromium.org/2255013002
Cr-Commit-Position: refs/heads/master@{#412752}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/8be763db2940..1383b507de4f

$ git log 8be763db2..1383b507d --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2257443003
Cr-Commit-Position: refs/heads/master@{#412751}

When a download is cancelled/failed/removed, it should be removed from
auto resume list.
Otherwise, resumption will be retried over and over as it is never
removed from auto resumption.

BUG=636724

Review-Url: https://codereview.chromium.org/2248963002
Cr-Commit-Position: refs/heads/master@{#412750}

This patch converts "editing/undo/4063751.html" to use w3c test harness
to simplify test script for improving readability.

This patch also renames it to "redo_rebalance_whitespace.html" to provide a
hint what this test script verifies.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2249833003
Cr-Commit-Position: refs/heads/master@{#412749}

This adds a check to make sure that the origin of the service worker is allowed
to run in the context of the "first party for cookies" (i.e. top-level document)
before starting it to handle a foreign fetch event. This makes sure service
workers with foreign fetch can't be used to bypass third-party cookie blocking.

BUG=540509

Review-Url: https://codereview.chromium.org/2255713003
Cr-Commit-Position: refs/heads/master@{#412748}