- 12 Jan, 2021 40 commits
-
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.148. R=rmhasan@google.com Bug: 1041619 Change-Id: I750fcfece9de37d5c56cc1a1a2c88bd8aa08047b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622996 Commit-Queue: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#842325}
-
Alison Maher authored
Loop through the inner multicols collected in CL:2612392 once we've hit the outermost fragmentation context, and lay out the pending OOF positioned nodes associated with those multicols. Currently, we are laying out the OOFs inside the outermost fragmentation context rather than the inner mutlicols. This results in incorrect offsets. However, this CL allows us to test that everything is bubbling up correctly and layout is happening at the correct time. In follow-up changes, the layout of these OOF nodes will move from the outer context to the inner. Note: I also updated how we were converting to logical offsets in the normal case of fragmented OOF nodes since I realized those didn't look quite right (although it doesn't change the result of any of the existing tests). Bug: 1079031 Change-Id: I8f43e9d8f2c8e5f7e4617dbe4b1b80579060f4c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616943 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#842324}
-
Trent Begin authored
This change exposes the video conferencing routine by adding it to the network-diagnostics component. This routine is added under a new routine group, 'Google Services'. Bug: chromium:1142857 Change-Id: Iff9b4eb1c2c8c42c6b06d03dc3ddacb53bba3867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613017 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kartik Hegde <khegde@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#842323}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fff8e7632e28..026943fd29be If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I391ddb8d51e46e6b4a5286e78a0dbae28ccd8365 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842322}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/49d291065fee..de32c3d2de00 2021-01-11 vantablack@google.com Reland "Created test and fixed texture storage bug in d3d11" 2021-01-11 lfy@google.com Vulkan: Prefer host cached memory for Buffers 2021-01-11 ynovikov@chromium.org Fix iOS build 2021-01-11 ynovikov@chromium.org Enable building angle_white_box_tests on Fuchsia 2021-01-11 ianelliott@google.com dEQP: Avoid undefined right-shift behavior for GLhalf 2021-01-11 jmadill@chromium.org Remove obsolete build flag. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1164276 Tbr: timvp@google.com Test: Test: Change-Id: I81cc1095de7a22f291900d9f1b31d4b308b64331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623244Reviewed-by:
-
Daniel Hosseinian authored
The version number is localized. Bug: 93619 Change-Id: Ide20d30ff2d43d609c5313fe36d4ac367bca90f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619000 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842320}
-
Cammie Smith Barnes authored
This CL is part of the Code Health Rotation (https://sites.google.com/corp/google.com/chrome-code-health/) and changes the few remaining occurrences in chrome/test/chromedriver of base::Bind, base::Callback, and base::Closure, to base::BindRepeating, base::RepeatingCallback, and base::RepeatingClosure, respectively, to match the surrounding code. Bug: 1007643 Change-Id: I3070f02201bdc338b6b70ab8f3b8b40f5111a6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622991 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#842319}
-
Ben Pastene authored
This bumps it from 2 to 4 across every bot. This helps builders like the amd64-generic CQ bot which runs shards with 15-17min runtimes (https://ci.chromium.org/p/chromium/builders/try/chromeos-amd64-generic-rel/737112) and the eve CI bot which runs shards with ~30min runtimes (https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12083). Bug: None Change-Id: I3ef9d7eaabf3d1d8085d55b4f25adc70a6fc3f03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622897Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#842318}
-
Frank Liberato authored
Allow duplicate pictures by returning the same ref-counted picture buffer to the VP9Decoder, with an updated timestamp. This also replaces the boolean "in client use" with a counter, since the same PictureBuffer can be out at the client as more than one VideoFrame now. We can only re-use it for decoding once all of the client uses are returned to the decoder. Bug: 1164463 Change-Id: I93fa076ae4fdd955687122df6c4cb12485cd6a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623030 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842317}
-
Cammie Smith Barnes authored
This change renews the CreativeOriginStatus* histograms, which are currently set to expire at the end of December. Bug: 1149522 Change-Id: Ic3d761871bb81e19d2aabec9e2b101d37b452459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597574Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Cr-Commit-Position: refs/heads/master@{#842316}
-
Dan Harrington authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2590649 First patchset has no changes. Fixes in the following patch. There were two fixes: * a test @Rule was private, should be public. * The java class FeedProcessScopeDependencyProviderTest was defined twice, so I renamed the new one to FeedProcessScopeDependencyProviderNativeTest Tbr: dewittj@chromium.org,ssid@chromium.org,isherman@chromium.org Bug: 1158468,1164102 Change-Id: I2be4e481dd34c8b07e0ce4e08baf75cb2c575d30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618497Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#842315}
-
Esmael El-Moslimany authored
The promo no longer takes on module styling. Instead the promo retains a pill style even when modules are enabled. The other change is the promo will be rendered below the most-visited element which eliminates the need for overlap detection. Bug: 1157037, 1163219 Change-Id: I6be99293b7c8e99ec43e88a7bf9eef715f4e84f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2594509 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#842314}
-
Nikolai Artemiev authored
BUG=b:169636434 Change-Id: I7e23564219f5292273140c0abb4882876c7b7093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619441 Commit-Queue: Nikolai Artemiev <nartemiev@google.com> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Philip Rogers authored
In https://crrev.com/624999, fixed and sticky positioned elements were promoted if they stick to a scroller. This patch takes that further and promotes fixed and sticky elements if they stick to a scroller, even if the scroller is overflow: hidden. This will let us remove the kHasNonLayerViewportConstrainedObjects main thread scrolling reason in a followup, which is difficult to support with CompositeAfterPaint. It is possible to have scroll animations with overflow hidden, scroll-behavior: smooth, and the root scroller. This is expected to regress the ie_chalkboard benchmark which now gets layerized which requires a raster larger than the visible rect. Before this patch, only the visible rect would be re-rasterized because there were no layers. This situation should be rare and this patch should be a small progression overall because it reduces main thread scrolling reasons. Bug: 649096 Change-Id: I6b1b15584166ace3dcd9b40d8271b13fb12b6366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2100113 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842312}
-
Tomasz Wiszkowski authored
The secondary thick text color for dark theme points to the wrong color definition. Change-Id: I6256b1e9a965656a26f415abfa197f4e654d86db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622755Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#842311}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4451f85e..43ed322b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1b13080a437dc485959d8067e05b7738be2b4ef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622753Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842310}
-
Becca Hughes authored
At the moment support for images that do not have a defined size or use "any" does not work. This fixes that. BUG=1085814 Change-Id: I28e6d52dfe4f0bf53edf0395af3d675a289340ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621955 Auto-Submit: Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#842309}
-
Sergei Glazunov authored
We're seeing a lot of Canary crashes that occur when BRP treats a freelist pointer as a reference count and corrupts it. Until we find the root cause, modify the layout of PartitionRefCount so that the count no longer overlaps with the pointer. Bug: 1164636 Change-Id: I39934867e042a1e54caa933e8ab82496c15f37fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622097Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Sergei Glazunov <glazunov@google.com> Cr-Commit-Position: refs/heads/master@{#842308}
-
Kuo-Hsin Yang authored
ScopedAllowIO in the main thread violates the thread restriction rule. Remove the unnecessary ScopedAllowIO. Bug: 1160988 Change-Id: I2fb606604473f10c845a77325a47fd9fad07c7ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620822Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#842307}
-
Lukasz Anforowicz authored
Before this CL, there would be an inconsistency between origins calculated by Blink vs //url for standard, no-access scheme URLs which meant that (browser-side, //url-based) NavigationRequest:: GetOriginForURLLoaderFactory would return a non-opaque origin, while (renderer-side, SecurityOrigin-based) Blink would commit an opaque origin. The CL ensures that IsValidInput in //url's scheme_host_port.cc considers no-access first, before any consideration of whether the scheme is standard - this makes it more consistent with how ShouldTreatAsOpaqueOrigin in Blink's security_origin.cc works. After this CL (i.e. after returning an opaque origin for no-access schemes), we still want to treat no-access-scheme URLs as potentially trustworthy - this requires small additional tweaks in IsUrlPotentiallyTrustworthy. Bug: 888079, 1021779, 1020201 Change-Id: I5e957700011186c312366c818bf143a027f025ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602402Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#842306}
-
Matt Falkenhagen authored
Bug: 1138155 Change-Id: Iafb12ae9de19e68e637e7fb990bb8439ec4df848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602307Reviewed-by:
Asami Doi <asamidoi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842305}
-
Austin Tankiang authored
Bug: 1160998 Change-Id: Ib08b57c71eb7e36517cd4e8e8c22877256ddd3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620924Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#842304}
-
Jarryd authored
* Implement new testing actions: - |add_policy_app_internal_tabbed| - |remove_policy_app| - |list_apps_internal| - |assert_app_not_in_list| * Reorder testing action implementations lexicographically * Rename ExecutePwaInstallIcon() to InstallOmniboxOrMenu() Change-Id: I167b4b00b4028f31702813a611d5616f7bc6c040 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2598638 Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#842303}
-
Meilin Wang authored
Introduces |ConversationController| (and its proxy) as a sub controller responsible for handling conversations between our Assistant service and Libassistant. Adds its first mojom API |SendTextQuery()| which sends a text query to Libassistant upon called. Bug: b/171748795 Change-Id: I9b86f9323c4e34ebce6fe78bfda487ad81d1f87a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545648 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#842302}
-
Michael Crouse authored
BUG: 1165517 Change-Id: I878bad081f44e7c258e009357aabe0d09df046fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623528 Commit-Queue: Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Auto-Submit: Michael Crouse <mcrouse@chromium.org> Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842301}
-
Yoichi Osato authored
This reverts commit 9a33bf90. Reason for revert: IOS build failure https://ci.chromium.org/ui/p/chromium/builders/ci/ios-simulator/61201/overview Original change's description: > Componentize OptimizationHintsComponentInstaller for reuse on iOS > > This also makes the component available on incognito (which was an > oversight in previous support to have optimization hints be in incognito) > > Bug: 1154790 > Change-Id: I97a427d5af0f94fa0b5282032b8cef6ce754c81d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617866 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Michael Crouse <mcrouse@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Commit-Queue: Sophie Chang <sophiechang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842267} TBR=sky@chromium.org,waffles@chromium.org,sophiechang@chromium.org,robertogden@chromium.org,mcrouse@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Iedea25977fe6265e6141dbdd198efa39f7943694 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1154790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623349Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#842300}
-
James Cook authored
This reverts commit 93b71b38. Reason for revert: Broke linux-lacros-tester-rel https://bugs.chromium.org/p/chromium/issues/detail?id=1165468 [destroyed object]: error 1: popup parent not constructed [18388:18388:0111/155132.274317:FATAL:chrome_browser_main_extra_parts_ozone.cc(38)] Wayland protocol error. Original change's description: > lacros: Re-enable most ContextMenuBrowserTest tests > > Only two fail. The failures are related to multiple profiles, not > context menus in general. > > Bug: 1150200 > Change-Id: I40c9fa722d3e888d77a31e0155afdaf6c4154369 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622574 > Auto-Submit: James Cook <jamescook@chromium.org> > Commit-Queue: Erik Chen <erikchen@chromium.org> > Reviewed-by: Erik Chen <erikchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842179} TBR=jamescook@chromium.org,erikchen@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0923409686a5595c0bfe7125f7dab82e24a5f632 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623425Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#842299}
-
Alex Newcomer authored
PM wants these to measure usefulness of clipboard history. More consecutive copies or pastes should mean users are using multipaste more. Bug: 1145445 Change-Id: I4d6cecb618e8e95f9438a44e8824aa23fbc5e89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613350 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842298}
-
Tarun Bansal authored
This experiment is no longer being worked on. See http://shortn/_YTSn6Rpl6W for more details. Change-Id: I0fd921cc62b518f6a142402389a6b8b9748b2fb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611836Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842297}
-
Nancy Wang authored
in CL:2556904, OnWindowDestroying is used by the WM to save the window info. So FullRestoreSaveHandler should not use OnWindowDestroying to delete the window from the restore data. So modify the interface to use OnWindowDestroyed to delete the window from the restore data. BUG=1146900 Change-Id: I824e216a898c6c28bf6cdae044e0a8fba7079a64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622354Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842296}
-
Rahul Arakeri authored
This CL fixes a CHECK failure with a base::Optional type. After the CL crrev.com/c/2553869 was landed, it exposed a pre-existing product bug (crbug.com/1164008) and that led to an increase in crashes in cc::ScrollOffsetAnimationCurve::UpdateTarget. Problem: In ScrollOffsetAnimationCurve::EaseInOutBoundedSegmentDuration the variable duration_behavior_ gets referenced. This variable did not have any value assigned to it and hence causes the crash. Why it did not fail before: Before the CL 2553869 landed, the logical flow was different. As in, if the animation_type_ (in UpdateTarget) was kEaseInOut, the new_duration would've been calculated by calling EaseInOutBoundedSegmentDuration. This is the only function that references the base::Optional value (duration_behavior_). All other animation types (kImpulse and kLinear) would've led to the function ImpulseSegmentDuration being called where duration_behavior_ was not referenced. In the crash dump, I observed that the animation_type_ was kLinear. This type does *not* have duration_behavior_ defined and UpdateTarget does *not* support kLinear animation_type_ and hence the crash. So in fact, UpdateTarget being called for a linear animation is the real issue here (and this issue is a pre-existing bug in the product). The CL 2553869 merely exposed it. Fix: I've added a bandaid solution where UpdateTarget simply returns if the animation_type_ is kLinear. Even after multiple tries, I was never able to repro the original bug (where UpdateTarget is called on linear animations). The original bug is tracked via crbug.com/1164008. Bug: 1158655 Change-Id: I0aca4870e8578de7690a6c4f8ee91f6786da1f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613934Reviewed-by:
-
Robert Ogden authored
This is important for the text capture effort. Change-Id: I8eb15afe1bd18690dc61ed340e14ade0e42c26c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622810 Auto-Submit: Robert Ogden <robertogden@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#842294}
-
Sophie Chang authored
I'm also not entirely sure if DownloadService is available on iOS but a lot of the code is still reusable for iOS (CRX verification and what not) for it to move into components. Not moving PredictionModelDownloadClient for now since that is more Chrome-specific since it references the OptimizationGuideKeyedService directly and is registered with the Chrome- side DownloadServiceFactory Bug: 1154790 Change-Id: Ide3e38c63e92eec8a87ce92899d3e8c3d7f94161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617124Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#842293}
-
minch authored
Bug: 1164980 Change-Id: Iadde28d35b316f811b2d60637dd27addc4525132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621747Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#842292}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/722b81ef1350..82b992a1656d 2021-01-11 ehmaldonado@google.com owners: Initialize db lazily. 2021-01-11 yuanjunh@google.com [cipd] Roll Led to a newer version 2021-01-11 chanli@chromium.org [dirmd] Roll dirmd to e338559 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103287,chromium:1145959 Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com Change-Id: I262891861ebefff2c13033d61573ef89dc77625c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623246Reviewed-by:
-
Sergey Ulanov authored
Direct image compositing causes excessive memory usage. This change disabled the feature on low-end devices to save memory. Currently it's limited to OS_FUCHSIA to disable potential performance impact on other platforms. Bug: 1161327 Change-Id: I709895c6564aba79cfeb762e8fd6d698bde7795c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601638Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#842290}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4367.0-1609764762-benchmark-89.0.4384.0-r1 to 89-4374.0-1610361443-benchmark-89.0.4385.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ic007ce3725e52a65dcd442379db8ef699ef0fcba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623249Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4367.0-1609757097-benchmark-89.0.4384.0-r1 to 89-4380.0-1610362181-benchmark-89.0.4385.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I02d1e0f12ef2e7a035030eadfbc0e5807b65c8bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623472Reviewed-by:
-
Hiroshige Hayashizaki authored
- wpt/html/semantics/forms/the-input-element/selection-pointer test no longer exists. - virtual/web-components-v0-disabled/* was removed by https://chromium-review.googlesource.com/c/chromium/src/+/2454693. Bug: 1164553, 937746 Change-Id: I29bed2f3e8eb4da05e7d94e5059036a712ac4e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621957Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#842287}
-
rbpotter authored
This allows bundling of extension URL hosts by passing: chrome-extension://extensionid/ as the host to fully work (e.g., excluding local files from the bundle). Bug: 1163956 Change-Id: Ib467c61c1bb507872292376b3508a10f72d8f076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618561Reviewed-by:
-
