GitLab

This change implements StartBulkLeakCheck() and StopBulkLeakCheck() in
the BulkLeakCheckServiceAdapter and makes it listen to the OnEdited()
event issued by the SavedPasswordsPresenter.

Bug: 1047726
Change-Id: I043edbdcaf901eff784ffe1d7740fedfee462d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070198
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744048}

https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/c22aa6b47ff6..a0ee3aa5b911

$ git log c22aa6b47..a0ee3aa5b --date=short --no-merges --format='%ad %ae %s'
2020-02-23 michaelfsun system_api: Add CRAS media player D-Bus constants
2020-02-11 zuan cryptohome: Port allow user to selectively remove keysets to UserDataAuth.
2020-02-10 zuan cryptohome: Port allow users to create data restore key to UserDataAuth.
2019-12-24 cylai system_api: protobuf message for new dbus service |pca_agent|.
2020-02-18 pmoy power: add three more fields to proto

Created with:
  roll-dep src/third_party/cros_system_api

Change-Id: I6f9ef976ce4c697182bc350cdd36738c7fd69948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067192
Auto-Submit: Michael Sun <michaelfsun@google.com>
Commit-Queue: Michael Sun <michaelfsun@google.com>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744047}

TestContentSettingImagePressed() wasn't actually verifying that the
image in question was visible before "pressing" it.  Fixing this
caused several different tests to start failing because they weren't
actually triggering the permission requests they thought they were
(but didn't previously detect it).  Fix these tests and improve the
InvokeUi cases to all show a requesting URL (of "example.com").

Bug: none
Change-Id: Ic64e233163d82d71e88cbb09e3da9a26ed2aede5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067745Reviewed-by: Orin Jaworski <orinj@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744046}

Refactors three Switch Access classes for clarity, consistency, and
readability.

Bug: None
Change-Id: Ib81a279cef24348f997f870f208413245a8c2357
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064790Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#744045}

This change makes DialogDelegate::Close non-virtual. It also splits
DialogTest.AcceptAndCancel into several smaller tests, to avoid it
needing to return false from Accept/Cancel/Close; this also makes the
tests easier to follow.

A followup CL will delete DialogDelegate::Close completely, replacing
it with a new method DialogDelegate::CloseDialog(), for unit tests that
want to simulate closing a dialog but have not created a Widget for it.

Bug: 1011446
Change-Id: I2cb64c3c757e7685d32c1d3b99406999a2cf626d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068299
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744044}

The desktop needs to be fundamentally different from other root nodes
in Switch Access because it is the only root that does not have a back
button.

Bug: 1054482
Change-Id: I47d1f8f5383d271debf1ef5749c106015102679a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065732
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744043}

https://android.googlesource.com/platform/external/perfetto.git/+log/3bde4517dec7..1cb4a3a99d23

git log 3bde4517dec7..1cb4a3a99d23 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 rsavitski@google.com Merge "traced_perf: enable SMB scraping + cts improvements"
2020-02-24 rsavitski@google.com Merge "traced_perf: record "expired" (skipped) samples in the trace"
2020-02-24 hjd@google.com Merge "ui: Fix formatting of dev_server errors"

Created with:
  gclient setdep -r src/third_party/perfetto@1cb4a3a99d23

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: I1d81a67265b9b4cb5e399d84ecf4f8216b19bf5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070437Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744042}

In previous CL, a bug on type name where 'bool' should have be 'Bool'
causes bool value calling PolicyValue constructor for double, with
extra param.

This CL fixes the bug and add tests on parse_default_value function.

Change-Id: Ica555f337336fe83ad061f3455769b5a0b3ffe67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069856
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744041}

chrome://downloads was previously displaying the in progress UX for
downloads that were in the middle of scanning. This could be confusing
given that we may remain in this state for several minutes. Instead, we
should indicate to the user that the file is being scanned.

This CL also removes the ".dangerous #description" selectors that could
cause warning text to change color. These currently aren't doing
anything (the text is black).

Screenshot: https://screenshot.googleplex.com/sTApKg55f4n.png
Bug: 1048891
Change-Id: I3fb736818814dd0343871c08ca230435899bf5aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063043Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744040}

Previously, Switch Access would get stuck in the virtual keyboard when
it was hidden, and would not jump to it when it was activated by any
method other than the Switch Access menu.

This change listens to events corresponding to the keyboard being shown
and hidden, and reacts appropriately.

Bug: 996899
Change-Id: Ic6c58c8f66afdbf7422b74a8dc86b0d64c700607
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062584
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744039}

Bug: 1054636
Change-Id: I46529471783a15c504b7b12c2f5998f84b8d3e92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067799
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744038}

https://chromium-review.googlesource.com/c/chromium/src/+/1945923
change erroneously initializes hold_time_ to null when scroll
timeline is inactive. This makes assert to fail in
Animation::CommitPendingPlay at:
DCHECK(start_time_ || hold_time_);

Bug: 1042924
Change-Id: I98060d065da93bb633d6cbc1506c591194a11692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037348
Commit-Queue: Olga Gerchikov <gerchiko@microsoft.com>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744037}

https://chromium.googlesource.com/angle/angle.git/+log/959d077f605e..c7f63a01d344

git log 959d077f605e..c7f63a01d344 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 jmadill@chromium.org Fix debug callback in perf tests.

Created with:
  gclient setdep -r src/third_party/angle@c7f63a01d344

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC geofflang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: geofflang@google.com
Change-Id: Ib4766d1bd355d1ad722635b87bbe1753838aedef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070435Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744036}

This Cl removes the softwareUsage fallback for CanvasResourceProvider,
it adds a new set of constructors for the different type of Resource,
and replaces the calls for all instances of SoftwareUsage.

This is the first part of a big refactor removing all of the fallback
use cases and that will enable an overall simplification of the codebase
and it will make more explicit this part of the code base.


Bug: 1035589, 1021287
Change-Id: Iaeec2ee05d2a95f35eec753acc39e948260b3142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013483
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744035}

This CL enables the focused annotation to scroll into view in a PDF.
The method Form_OnFocusChange() is added which gets called when PDFium
calls FFI_OnFocusChange(). Here we check if the focused annotation is
out of the viewport and scroll to bring the top left corner of the
annotation into the center of the viewport.

This CL also adds FormFillerTest.Form_OnFocusChange which expects
appropriate function calls to scroll when needed.

Bug: 989027
Change-Id: Ice8da8d7080404b4e34b830fd29bccb1a0b11546
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032483
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#744034}

Skia is planning to change how the CTFont is created for glyph metrics
and drawing. As a result there will be some changes to layout tests.
Hold out the Skia side changes until the tests can be updated.

Change-Id: I807591eba700c7af3e20c5e234af06d16155a742
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068829Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744033}

Add users actions to various points in the sharing hub.

Bug: 1009124
Change-Id: I92379ef1153d54d64257d4b32f369ec402119534
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055689Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744032}

When dragged app item view is dropped into a folder at the end of the
drag, hide its title, and keep it hidden. Generally, the title will be
hidden at the end of the drag while the item is animating to the new
target bounds, but the item view is removed from the views model before
the bounds animations run, so AnimateToIdealBounds() will not update
the dragged view title.

BUG=1053935

Change-Id: Ief279b9f11f7c6bf7d562e4e4d9a690e89acf229
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068279
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744031}

BUG=878133

Change-Id: I3b65e4013536aa7a7e28b1425d6ffa6852f26c42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066390
Auto-Submit: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744030}

https://quiche.googlesource.com/quiche.git/+log/7c89615d6dd7..5f23a2d78434

$ git log 7c89615d6..5f23a2d78 --date=short --no-merges --format='%ad %ae %s'
2020-02-20 nharper Move QuicCryptoServerStream::Helper to QuicCryptoServerStreamBase
2020-02-20 bnc Dump header name and value length (not value itself) if value too long.
2020-02-20 danzh gfe-relnote: n/a(test only) fix a GCC complier error in QUIC test utils. Not protected.
2020-02-19 dschinazi Introduce QUIC_VERSION_IETF_DRAFT_25
2020-02-19 fayang gfe-relnote: In QUIC, when arming PTO timer, ignore application data until handshake completes rather than handshake confirmed. Not affecting prod, not protected.
2020-02-19 fayang gfe-relnote: Add an IsAckFrameEmpty const method to received_packet_manager and make sure GetUpdatedAckFrame is only called to retrieve nonempty ACK frame. Refactoring only, not protected.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

Change-Id: I08858b30e044a162bdcb167b8819bc973151cd8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068649Reviewed-by: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Auto-Submit: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744029}

https://pdfium.googlesource.com/pdfium.git/+log/d41bcabd124f..c93fa1ff0194

git log d41bcabd124f..c93fa1ff0194 --date=short --first-parent --format='%ad %ae %s'
2020-02-24 thakis@chromium.org Fix a Wrange-loop-analysis warnings in pdfium.
2020-02-22 thestig@chromium.org Disable RenderManyRectanglesWithExternalMemory test for Skia.
2020-02-21 thestig@chromium.org Roll third_party/freetype/src/ 8930cc961..49f3394d7 (3 commits)
2020-02-21 thestig@chromium.org Add placeholder comments to DEPS to mitigate CQ interference.

Created with:
  gclient setdep -r src/third_party/pdfium@c93fa1ff0194

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1039697
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I3723464918b59eec3463ae50f8ff71cc972c9756
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070436Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744028}

AppCache's net::DiskCache wrapper header currently declares a static
const kUnknownResponseDataSize in the content namespace, resulting in a
copy in each translation unit that includes the header. While the copies
are most likely eliminated by the linker due to lack of use, this
declaration still pollutes the namespace.

This CL moves the constant into the HttpResponseInfoIOBuffer class, so
it is only emitted once.

This CL doesn't introduce any functional change.

Bug: 1055133
Change-Id: Ib9c8a339e6a543a908ee4c952bb0bc1174fa7dab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069842
Commit-Queue: Victor Costan <pwnall@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744027}

Bug: 1052228
Change-Id: I2c14024f760148cc8ddaec96cbeea3cdee7edf96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065319Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744026}

Kim is no longer active in this area but has done a review recently and
we want to make it easy for her to return :)

Other emeriti are not, in practice, reviewing in this area. Remove them
so that tools don't auto-suggest them for CLs that they'll only have to
bounce to someone else.

Change-Id: I5d46659e1621e526912b3b48323b2027c8878593
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070563Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744025}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/cb8594a9..f6d87d0f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Ica9cd42176f680ef802c5421446e482d9a6b7045
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070536Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744024}

This reverts commit 27ed0337.

Reason for revert: Top crasher on Windows.

Original change's description:
> Report crash-dump for GetFontFallbacks that succeed on Windows
> 
> On Windows, ShapeRuns(...) is shaping the text by trying:
>   PrimaryFont
>   GetFontFallback(...) : using DWrite
>   GetFontFallbacks(...) : using registry keys (Font Linking)
> 
> The GetFontFallbacks function is deprecated and should be
> remove. There is still a long tail of cases that succeed
> only with the use of that mechanism. This CL is making
> these cases to be reported as a crash to be analyzed
> before removing the code. The goal is to avoid breaking
> the text rendering even for a small population.
> 
> R=​robliao@chromium.org
> 
> Bug: 995789
> Change-Id: I381753ed3985779cd34dae58a34f523c2f215c9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049126
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741606}

TBR=robliao@chromium.org,etienneb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 995789
Change-Id: Ibd4e3a1dd4fadb9178511a0cab38200c8fd4ade4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068830Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744023}

Bug: 1025603
Change-Id: I061f50b6666376a9f829dd833c507ce200e31765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069853
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Auto-Submit: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744022}

Add a new method so observers of the DedicatedWorkerService and
SharedWorkerService can be notified when the final response URL is
determined when fetching the worker's script.

Bug: 1048332
Change-Id: I1d6593e876e88d4c067d49e56d2cb635a2973ff8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063448
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744021}

Lots of tests were listening for "permission request shown" using the
same class, and I want to add another.  First refactor to a common
location to avoid yet-more-copy-and-paste.

Bug: none
Change-Id: Iabf5ff8ad250e8b50a7f97ac3e2b15e75ef6c76f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068093Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Kamila Hasanbega <hkamila@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744020}

TBR=jlebel@chromium.org

Bug: 1055457
Change-Id: I651b22a882ea847f5930e02e8a9a3362bf0beb4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070110
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744019}

https://crrev.com/c/2011130 changed Display::DisableSwapUntilResize() to
also block draw instead of just swap. This had the side of effect of
blocking draw when the browser window is minimized, which means we stop
casting tab/window contents. Switch DisableSwapUntilResize() back to
just block swap instead of draw+swap.

Bug: 1054239, b/149923568
Change-Id: I66a10dc1e801c56783107ce4412ab557f70da9f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068642
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744018}

We were subtracting border_padding when it wasn't present if the item
had min-size:auto but didn't qualify for the special flex min-size:auto
behavior because, for instance, it has overflow: hidden.

This fixes the telemetry_perf_unittests failure FlexNG was hitting on
the bots, which was caused by a recorded google docs page.

Change-Id: Ia6bde490651daf63e4ca77f9525870987bb9fe5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065626
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744017}

Remove SetNeedsResizeObserverUpdate, and associated flags and functions
in order to make the notification delivery process stateless. With this
change, ResizeObservation::ObservationSizeOutOfSync will determine
whether notifications should be delivered rather than
element_size_changed_ and observer_changed flags being set by
SetNeedsResizeObserverUpdate, which is called at various points in the
layout process.

Cases involving many ResizeObservers were considered, and it is decided
that it would be more desirable to have slower pages which contain
many (>10^4) observers rather than slowing down
LayoutBox::StyleDidChange with extra operations (which would have been
required for scenarios involving content box changes).

With this change, content box changes can be observed, fixing all WPT
observe.html tests.



Bug: 1034329
Change-Id: Ie2225ad2865ee15d82be548c1455949946734074
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033849Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Daniel Libby <dlibby@microsoft.com>
Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#744016}

This patch removes the --enable-web-authentication-testing-api flag. The
flag disconnected the real webauthn API and replaced it with a
simple mock.

This flag had two goals:
  * To allow developers to write tests against webauthn.
    This use has has been superseded by the WebDriver WebAuthn Testing
    API.
  * To allow WPTs to have some sort of mock that avoided timeouts.
    This is now achieved by using the testdriver WebAuthn API.

The patch also removes an inspector-protocol test that relied on a mock
authenticator being set up automatically when the flag was set.

Fixed: 1054422
Change-Id: Iddde2b7e84bd6c37eaf5365f52fb0ddd401617e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067088Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744015}

All the WebAuthn directories have OWNERS that point to a master OWNERS
in //device/fido. The Java directory was different because other team
members were less familiar with it but we expect to be doing a lot more
Android work soon.

Change-Id: Ia64abcc78aacd9bc2b99c71e8217ee48b61f6127
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070562
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744014}

This CL adds splash icon fetching to InstallableManager and removes
badge icon part.

A bool valid_splash_icon is added to InstallableParams but
valid_badge_icon is not removed yet since the usages of
"params.valid_badge_icon" are not removed yet. (going to be remove in
the following CLs).
Now InstallableParams class has 9 booleans, so chromium style check
require it to have a explicit constructor. The constructor (and
associate .cc file) will be removed once valid_badge_icon is removed.

With this CL, badge icon will not be fetched even if valid_badge_icon is
set. It's ok to do so since it's not used.

Bug: 1043271
Change-Id: Ife4e99afe4fa9d94580adfff3b9ba6a6f312254c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037813
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744013}

Currently, two calls to observe with the same 'type' will result in a
console error, whereas the spec implies that this is valid, with the
later call overriding the initial one. This CL fixes that. It also fixes
a problem where disconnect would not clear the filter_options_, as shown
in https://github.com/w3c/performance-timeline/pull/161. This would not
be a problem with 'entryTypes' because this variable would be replaced
on every call to observe(). Tests are added for these two cases.

Bug: 1052509
Change-Id: I75865b2925e2fb1a7e7fd64d7e979907c3b7650c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067250Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744012}

If a download doesn't create more than 1 slices during the first attempt,
we should assume that parallel download is not supported.

BUG=1054875

Change-Id: I046ca7b32300e124527a16ec9fbc544d376d6ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068747
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744011}

https://skia.googlesource.com/skia.git/+log/108a494984da..02497d40161f

git log 108a494984da..02497d40161f --date=short --first-parent --format='%ad %ae %s'
2020-02-24 egdaniel@google.com Update nanobench and skpbench to use flush API for gpu syncing.
2020-02-24 kjlubick@google.com [canvaskit] Expose releaseResourcesAndAbandonContext on GrContext
2020-02-24 westont@google.com Update tasks.json based on Go Deps Cl.
2020-02-24 bsalomon@google.com Prevent unbounded invalidator growth on SkPathRef from GrSWPathRenderer
2020-02-24 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 605b00d7728f..cbf3b9df1ae1 (1 commits)
2020-02-24 csmartdalton@google.com Lift calls for setting dynamic state to Ganesh level
2020-02-24 csmartdalton@google.com Remove "setData" operations from GrMtlPipelineState::setTextures

Created with:
  gclient setdep -r src/third_party/skia@02497d40161f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jlavrova@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jlavrova@google.com
Change-Id: I164f72adcbd657fb903e0c726db4fe6b1ef0065b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070432Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#744010}

This cl adds the new fields display_globally and display_countries.

Bug: 1040145
Change-Id: Ice70d5c44537950420c9aeca822c652919d6298d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067561Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Katharine Daly <dalyk@google.com>
Cr-Commit-Position: refs/heads/master@{#744009}