- 26 Mar, 2018 40 commits
-
-
Michael Spang authored
These are no longer necessary since PlatformEvent is now a typedef to ui::Event*. BUG=none TEST=compile Change-Id: I49749511c7db8d0f2f96add58201ad6d288445f3 Reviewed-on: https://chromium-review.googlesource.com/978468 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#545807}
-
Devlin Cronin authored
A few APIs validate arguments against a signature specified in an event call, rather than as an API method. Allow this validation to happen natively when native bindings are enabled by adding a JS utility to add a custom signature and validate against it. Use this for certificateProvider, printerProvider, and webRequest custom bindings instead of the JS validation. Add unittests for the new JS utility method. Bug: 810487 Change-Id: Ifbc8480ae15acbdaa9ecdffcfb7bfe159e201510 Reviewed-on: https://chromium-review.googlesource.com/914808Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#545806}
-
Mugdha Lakhani authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/956183 caused a few tests to be flaky, which was due to the garbage collector getting rid of BackgroundFetchOptions from under us. This change creates a copy of background fetch options early on, converting them from blink::BackgroundFetchOptions to mojom::blink::BackgroundFetchRegistrationPtr. This copy is not going to be deleted by the GC, hence ensuring accurate data later on in the processing of the fetch. Bug: 822276 Change-Id: Iaab780b18182372cf607b57eb15815c852d4595a Reviewed-on: https://chromium-review.googlesource.com/977909 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#545805}
-
Becca Hughes authored
Harden feature policy layout tests and switch them back on. These tests are still disabled with site isolation until HasBeenActivated is replicated. BUG=794631,790549 Change-Id: I8fd2be1f9222c71288d5e39e1639c4d990df995b Reviewed-on: https://chromium-review.googlesource.com/966069Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#545804}
-
Fergal Daly authored
Bug: 805271 Change-Id: I839abbb345aecaf675b762780700f882b3635c2e Reviewed-on: https://chromium-review.googlesource.com/972772 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#545803}
-
Hwanseung Lee authored
block-size[1], inline-size[2], max-block-size[3], max-inline-size[4], min-block-size[5], min-inline-size[6] are added to support in whitelist. and test file are also added. [1]https://drafts.csswg.org/css-logical-1/#propdef-block-size [2]https://drafts.csswg.org/css-logical-1/#propdef-inline-size [3]https://drafts.csswg.org/css-logical-1/#propdef-max-block-size [4]https://drafts.csswg.org/css-logical-1/#propdef-max-inline-size [5]https://drafts.csswg.org/css-logical-1/#propdef-min-block-size [6]https://drafts.csswg.org/css-logical-1/#propdef-min-inline-size Bug: 820299 Change-Id: I97c589deea28bfedc82ec1b1686ceaf9979cb95e Reviewed-on: https://chromium-review.googlesource.com/973561 Commit-Queue: Hwanseung Lee <hwanseung@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#545802}
-
Luke Zielinski authored
This fixes a regression where the SBER checkbox sometimes had to be clicked twice to be toggled. Bug: 819203 Change-Id: Iad26a6eaa33e4798a086c297fd11540c7c2674e8 Reviewed-on: https://chromium-review.googlesource.com/978629Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#545801}
-
Sahel Sharify authored
This is a reland of b23ffdff Original change's description: > Moved feature_list initialization to test SetUp. > > Since I didn't want to disable wheel scroll latching in > InputEventRouterWheelTargetTest I moved MainframeWheelEventsOnMainThread > and SubframeWheelEventsOnMainThread tests to a new subclass that > disables WheelScrollLatching in the SetUp function. > The change is for avoiding data race due to initialization of the > feature_list in the tests. > > Bug: 822764 > Change-Id: I76d9fee1474e8e7a50eca8d311941bcd969dafe3 > Reviewed-on: https://chromium-review.googlesource.com/974366 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545216} Bug: 822764 Change-Id: I385b522c2c56bede81f432060519b4055407e859 TBR: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/978421Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#545800}
-
John Budorick authored
Bug: 799759 Change-Id: I57d860f897db5fbc477e1b67e8979a651768d052 Reviewed-on: https://chromium-review.googlesource.com/979610 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#545799}
-
Eric Stevenson authored
This CL adds two fields to Android crash reports. Specifically: 1. custom_themes: Whether or not the user has apps installed for using custom themes. This should help debug obscure resources related crashes. 2. resources_version: The product version as stored in resources.arsc. This should help us detect if we tried to load resources from the old apk during an update. Bug: 820591 Change-Id: I1e2b36ec5640bb1376f83452851eaa5319d0f32f Reviewed-on: https://chromium-review.googlesource.com/969597 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#545798}
-
Rob Wu authored
browserAction and pageAction methods take a tabId as parameter. An extension cannot ensure that the tabId is valid, since the tab might be removed between the invocation and the handling of the API method. To suppress the error, extensions need to be able to access the `chrome.runtime.lastError` object in the callback, which means that all extension action API methods need to accept an optional callback. BUG=451320 Change-Id: I4bd1fe8b17bdb98da7b33a03ec814294d5860da1 Reviewed-on: https://chromium-review.googlesource.com/979451Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Rob Wu <rob@robwu.nl> Cr-Commit-Position: refs/heads/master@{#545797}
-
Manuel Rego Casasnovas authored
Update the baseline for Windows platform. BUG=554893,825209 Change-Id: Iea34acced865105aabb11b1bce804c454bbd01f7 Reviewed-on: https://chromium-review.googlesource.com/979793Reviewed-by:
Ryan Landay <rlanday@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#545796}
-
Emily Hanley authored
This reverts commit 301c89e2. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove "Skipped" file and Port.skips_perf_test > > I believe this might be dead code; I'm not sure if > the layout test runner is used to run any Blink > performance tests. > > The last related change was last year: > https://codereview.chromium.org/2734823006 > > Before that, all changes seem to be from about 5 years ago. > > Change-Id: Ib1a23055391112c83b97e000707f0b2f333040e5 > Reviewed-on: https://chromium-review.googlesource.com/966484 > Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#545710} TBR=qyearsley@chromium.org,tkent@chromium.org,yoichio@chromium.org Change-Id: I3b905a29342fa0a65b8c2dbb7e643d62cf39679f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/980792Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#545795}
-
Andrew Grieve authored
This way the diff output is the same whether or not the diff was cached. Change-Id: I14428725408d6cf49ae570d269849d6b0b7e1a35 Reviewed-on: https://chromium-review.googlesource.com/979232Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#545794}
-
tzik authored
This applies base_bind_rewriters at //tools/clang/base_bind_rewriters to replace base::Bind() with base::BindOnce() on mechanical cases, and to remove unneeded base::Passed() on base::BindOnce() arguments. Bug: 714018 Change-Id: Ibcdab031e117eb0ecffc2dd75295966cb032ea02 Reviewed-on: https://chromium-review.googlesource.com/979880Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#545793}
-
Ryan Daum authored
Touch events and gesture events which occurred after a ET_SCROLL_FLING_START were still being propagated to the underlying application rather than processed as part of the system gesture event. Fixes detection of gesture begin to include FLING_START. Avoids propagating all touch events while gesture is in progress. Bug: internal b/76161997 Test: CQ, manual test Change-Id: Ie764339d586c16051420720276e7f7202e920acf Reviewed-on: https://chromium-review.googlesource.com/978653Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#545792}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0351f2cb..7ab45c02 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia048a579f79f9fa80ace9897e25a13b17a88e76e Reviewed-on: https://chromium-review.googlesource.com/979974Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#545791}
-
Avi Drissman authored
BUG=268984, 170921, 411569 TBR=sky@chromium.org Change-Id: I667c03c27e632336fb5a1c22f198e617ee7451c4 Reviewed-on: https://chromium-review.googlesource.com/979616 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545790}
-
Mihai Sardarescu authored
This CL avoids saving passwords when the user is signing in to Chrome via the Desktop Identity Consistency flow. It basically avoids saving password for URLs with origin "accounts.google.com" and that have the URL parameter "ssp=1". This CL also reverts https://chromium-review.googlesource.com/888623 which was a poor attempt to fix the same bug. To review the code: * Patch 1 is the revert of https://chromium-review.googlesource.com/888623 * Following patches contain the real fix. Bug: 805826 Change-Id: I947b63cea5e2a875260fc9d6066eed696198e35f Reviewed-on: https://chromium-review.googlesource.com/979932Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#545789}
-
Lizhi Fan authored
media::Audio[In|Out]putBufferParameters member name changed to: AudioInputBufferParameters::capture_time_us; AudioOutputBufferParameters::delay_us; AudioOutputBufferParameters::delay_timestamp_us; R=raymes@chromium.org, tommi@chromium.org Bug: 802212 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I95b3205087e04b9508760d6bc4cc9fb88456c5b0 Reviewed-on: https://chromium-review.googlesource.com/977249Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#545788}
-
Robert Phillips authored
This reverts commit f17c70fe. Reason for revert: It looks like this change: slowed down the file___static_top_25_weather.html rasterize_and_record time on the AndroidOne (crbug.com/825594) slowed down getImageData and putImageData for the HTML5 Canvas across the board (crbug.com/825585) Bug: 825594 Bug: 825585 Original change's description: > Use new Skia GPU read/write pixel code paths > > Change-Id: I8ea66d1b3bb8db174deab690a0cdacc39cf81992 > Reviewed-on: https://chromium-review.googlesource.com/973267 > Reviewed-by: Robert Phillips <robertphillips@google.com> > Commit-Queue: Brian Salomon <bsalomon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544777} TBR=bsalomon@chromium.org,robertphillips@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Icaee5a1afa55bc8aec4567687661dacef0ccf565 Reviewed-on: https://chromium-review.googlesource.com/980292Reviewed-by:
Robert Phillips <robertphillips@google.com> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#545787}
-
Fredrik Söderquist authored
Rather than doing an attribute lookup in GetRestart() and Fill(), just map the attributes in ParseAttribute. Pack with active_state_. Also get rid of the static AtomicStrings. Noticed while looking at the referenced bug. Use new accessor GetActiveState() for active_state_ accesses to avoid stumbling over signedness mismatches. Bug: 823473 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9adf72cdfcc794885b79be1bfc374554f9382d11 Reviewed-on: https://chromium-review.googlesource.com/979807Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#545786}
-
Jun Choi authored
For "FIDO-U2F" attestation statement format, attestation credential data within authenticator data is always present. However, for attestation data received from CTAP authenticators, this may not be the case as the WebAuthN spec defines attested credential data as optional. Change the DCHECK conditions for none attestation statement format to execute only when attested credential data is present. Bug: 825455 Change-Id: Ie63f051846b67c9deaa1b6bb64de76efa49a7aa1 Reviewed-on: https://chromium-review.googlesource.com/979217Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#545785}
-
tzik authored
On cross build of Windows Chrome on Linux, path detections in setup_toolchain.py fail due to path separator mismatch. https://chromium-review.googlesource.com/c/chromium/src/+/923161 broke the win/cross build, this fixes it. Bug: 495204 Change-Id: I1fe5405ce956b8e7522958704c012000df42966e Reviewed-on: https://chromium-review.googlesource.com/980392 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#545784}
-
Andreas Haas authored
Apparently some memory leak was introduced by https://crrev.com/c/958865. Reverting this CL would be quite painful already. Therefore I surpress the check for now to make the bots green again. NOTRY=true R=machenbach@chromium.org Bug: chromium:825741 Change-Id: I7cb6ee3db03c234bcca6bade73aa0208c71e7b52 Reviewed-on: https://chromium-review.googlesource.com/980532 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#545783}
-
Koji Ishii authored
From manual review of: https://ci.chromium.org/buildbot/tryserver.chromium.linux/linux_layout_tests_layout_ng/4385 Following failiures are space-only failures with matched images: images/55.html images/png-suite/test.html virtual/gpu-rasterization/images/55.html virtual/gpu-rasterization/images/png-suite/test.html Following failures are 1px glyph positioning differences: fast/forms/text/input-text-scroll-left-on-blur.html fast/text/justify-ideograph-complex.html fast/text/justify-ideograph-simple.html fast/text/justify-ideograph-vertical.html fast/text/orientation-sideways.html fast/text/international/plane2.html svg/text/text-repaint-rects.xhtml svg/text/tspan-multiple-outline.svg TBR=xiaochengh@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I23ec527ea0198f64e6c7871bb76f3672bd58ddcf Reviewed-on: https://chromium-review.googlesource.com/980512 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#545782}
-
Sahel Sharify authored
https://chromium-review.googlesource.com/931998 has accidentally added testing/buildbot/filters/mojo.fyi.viz.content_browsertests.filter back which was deleted in https://chromium-review.googlesource.com/968703. This cl deletes the file again to undo the unwanted change. Bug: 760181 Change-Id: I67bb96e33b4f4e905c137f73400f44b52173fc41 Reviewed-on: https://chromium-review.googlesource.com/978851Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#545781}
-
Finnur Thorarinsson authored
Bug: 734095 Change-Id: Ic65f138b41d76ffddec97eb6ec229e64f612a880 Reviewed-on: https://chromium-review.googlesource.com/970474Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#545780}
-
Geoff Lang authored
BUG=815092 Change-Id: I1da2cbdabe5a3352d3653f8eed78ff9739db63b6 Reviewed-on: https://chromium-review.googlesource.com/971468Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#545779}
-
Dominic Battre authored
See crbug.com/825540 for details. TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org notry=true Bug: 825540,796395 Change-Id: I70e628fd0b5f7fc98358be225ef0fd856a155359 Reviewed-on: https://chromium-review.googlesource.com/980256Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#545778}
-
Morten Stenshorne authored
Edge and Firefox seem to let table flex items use the sizing algorithm of the table extensively, and are therefore generally broken when it comes to flexing tables. We, on the other hand, let the flex sizing algorithm be in charge of sizing tables, so that flexing actually works. However, this causes tables with a specified main size of less than the minimum intrinsic logical width of the table to shrink below their minimum intrinsic logical width, a situation that's generally unwanted for tables. Amend by ignoring the specified main size when resolving min-width:auto on table items. Also ignore max-width/max-height. Just use the preferred minimum logical width. Bug: 821832 Change-Id: I78ca0c8e0041ea69bb606ff72d340bb3f5f9bb96 Reviewed-on: https://chromium-review.googlesource.com/964203Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#545777}
-
Illia Martyniuk authored
Avoiding unnecessary complexity in FrameSinkObserver. We are interested in events like creating and destroying FrameSinks which are handled in "OnCreated...FrameSink" and "OnDestroyed...FrameSink", so we don't need to use events "OnRegistered...Support" and "OnUnregistered...Support". These two just give us the unnecessary overhead of handling more events. Sorry for missing this in previous CL. Bug: 816802 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I53eba6a103834cc9d48ced14e013825c3b49027a Reviewed-on: https://chromium-review.googlesource.com/978374 Commit-Queue: Illia Martyniuk <illiam@google.com> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#545776}
-
Matt Falkenhagen authored
* |browser_provider_id| was misnamed and should always be valid. * Also rearrange some code around CreateForNavigation. Change-Id: I9842292ca73e1b6c2ca3e4d64b7ca086a611b9d8 Reviewed-on: https://chromium-review.googlesource.com/979882Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#545775}
-
Dominic Battre authored
TBR=yhirano@chromium.org,ricea@chromium.org notry=true Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I783bbf75592236dd33b168ccf7b3cb958ec4cbc2 Reviewed-on: https://chromium-review.googlesource.com/980315 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#545774}
-
tzik authored
This CL changes the ownership of base::Clock and base::TickClock from injectee-owned to injecter-owned. Before this CL, these instances are owned by the owner of the injectee or one of the injectees themselves. That makes the ownership handling complex. After this CL, the injectee of clocks never own the clock. Instead, injecters owns a clock for testing, and a shared clock is used on the production code. Bug: 789079 Change-Id: I9505403cc81e67d02286a3bfb107cb8efb19ba52 Reviewed-on: https://chromium-review.googlesource.com/975502 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#545773}
-
https://skia.googlesource.com/skia.git/+log/9b67c565cc7b..103e7243718a $ git log 9b67c565c..103e72437 --date=short --no-merges --format='%ad %ae %s' 2018-03-26 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 26ed93d7d..822a84b19 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=mtklein@chromium.org Change-Id: Ib39288d433cee302f82a569df63647947d4b1827 Reviewed-on: https://chromium-review.googlesource.com/979778Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545772}
-
Daniel Bratell authored
In some extreme jumbo configurations the newly added TestPrerendererClient class in Source/core/html/parser/HTMLDocumentParserTest.cpp compiled in the same translation unit as TestPrerendererClient in Source/core/exported/PrerenderingTest.cpp and then it didn't compile. This patch renames TestPre* to MockPre*/MockWebPre* which also matches a common pattern when creating mock classes. Change-Id: Ib800e5e65756bf3c3709d8f570982aaa46dc7cd4 Reviewed-on: https://chromium-review.googlesource.com/980332Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#545771}
-
Raphael Kubo da Costa authored
Stop referencing http://crbug.com/497616; the bug was fixed years ago and since e56d75ce ("bindings: Supports inheritance of [Unforgeable] attributes as accessor-type properties") it does not look like unforgeable attributes are turned into data properties. Bug: 497616 Change-Id: I79835434ad1a7955f3a0a76ae0a0e07e3d102555 Reviewed-on: https://chromium-review.googlesource.com/980333Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#545770}
-
Yutaka Hirano authored
They were needed but are no longer needed because we moved the class. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia461eede4c2549651e5e2b8a2da897c06afca592 Reviewed-on: https://chromium-review.googlesource.com/979879 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#545769}
-
https://webrtc.googlesource.com/src.git/+log/b0ba558c966c..dc4737bbdacc $ git log b0ba558c9..dc4737bbd --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I944a3841230d077463b38ecc6300ce26da8404ee Reviewed-on: https://chromium-review.googlesource.com/980132 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#545768}
-