- 25 May, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ca8a7e8ce304..215663a2c334 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com,mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: bcwhite@google.com,mpearson@google.com Change-Id: I7e0c139437d43ed868ade1bf942a25c36403b382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215362Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771632}
-
Minoru Chikamune authored
The original mojo::ReceiverSet can be specified ContextType. This CL add the same functionarity to HeapMojoReceiverSet. This CL also adds ContextType related functionarity. Bug: 1049056 Change-Id: I8639e34760fd16c6e70302c03ddadfa853ae2ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214854Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#771631}
-
Michael Thiessen authored
Introduces the @Batch annotation, which causes the test runner to run tests without a separate instrumentation run for each test (in other words, no Activity/process restart). Lowers the per-test overhead from around 10 seconds on my device to <5ms for all tests with this new annotation. (Bots from ~2s to <5ms) The BATCH.UNIT_TESTS batch is for unit tests that don't require any globally shared setup/teardown and don't change global state. The Batch.PER_CLASS batch is for integration tests that don't require a restart between each test, but do require a restart before/after the suite runs. It is equivalent to @Batch('unique_name'). In the future, batches may be added at other layers for suites that agree on known starting conditions, and reset to those starting conditions. This change also removes some dead handling of junit3 tests so that we can re-interpret an array of tests as a collection of tests to run in a single instrumentation call. Some followup work will be required to fix reported duration, as each test individually is reported as taking the duration the batch of tests took. Bug: 989569 Change-Id: I2fee81c33363789ca63174432a3b90b4fb472097 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2199706 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#771630}
-
Peter Kasting authored
* Use const and constexpr more. * Use constexpr TimeDelta instead of constexpr int + runtime TimeDelta. * New-style numeric casts, per styleguide recommendation. * Use TimeDelta::InMicrosecondsF() more to avoid manual casting. Bug: none Change-Id: I79710a10ec7ef0825c3fa3f2ca9a1a268f2d8406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214463 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#771629}
-
Yi Xu authored
In PutByteArray, the available byte array to allocated is calculated by: src_bytes_per_row = bytes_per_pixel *source_size.Width where source_size.Width is int_32 and src_bytes_per_row is uint_32. It's possible that src_bytes_per_row is valid and bytes_per_pixel*source_size.Width return integer overflow. In this cl, I added CheckMath for the assignment to src_bytes_per_row. Bug: 1084404 Change-Id: Ib52006b03eb37d8ca969e5835538edde4bc7257b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204831 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#771628}
-
James Cook authored
This was added to support the mash/mustash project, which was shut down over a year ago. This CL is a partial revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1292400 Bug: none Change-Id: I0306b48d8b8d0c0229238481fb9e8b20f5eb60d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210733 Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771627}
-
ckitagawa authored
This CL removes failed captures from disk as they happen. This only applies at a per-SkPicture level. It also cleans up some recorder behavior to avoid writing an invalid SkPicture to disk. Bug: 1084657 Change-Id: Idf479f2be824cddd8e47f9ba2bc32f086a5ff4dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211907 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#771626}
-
Etienne Bergeron authored
This CL is adding unittests from a recent commit: https://chromium-review.googlesource.com/c/chromium/src/+/2169069 The new tests ensure Time::ActivateHighResolutionTimer(...) is not called when power is suspended. Bug: 1074332, 1074028 Change-Id: I07de5932a0007163bedbd623ae276df0f2ea1af4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200042 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#771625}
-
ckitagawa authored
Minor change. Allows partial success status to count as a success. This means one or more subframes were unable to be captured. Usually this is due to a subframe not being loaded (e.g. lazily loaded iframe). This loss in fidelity is usually minor and acceptable. Change-Id: I65a4ca2d0e366e4b93bfede7212b45ff2f6d7fd8 Bug: 1084657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211914Reviewed-by:
-
ckitagawa authored
During capture TabObserver#onLoadStarted() may be triggered if the page is still loading (e.g lazily loaded content). We should avoid exiting in such a scenario. Bug: 1084657 Change-Id: I680c85d6b918bf054e285f37445a7c3674158959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212402Reviewed-by:
-
ckitagawa authored
A largely mechanical refactoring of the compositor. This has one minor change where if a file deserializes to an invalid SkPicture it is expunged from the tree. Bug: 1084657 Change-Id: I2226b713ffd9f97e6db2a2fb5ecd1e0ad5622342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211906Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ebf28a80ca38..e01c229a07aa 2020-05-25 fmalita@chromium.org SkMatrix::Rotate() 2020-05-25 fmalita@chromium.org [skottie] Layer auto-orient support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Id2ee94023a746812fdb6101e4a0eac229486e32f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215278Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771621}
-
Charlie Hu authored
All flaky instances are timeouts because the test procedure is too long. Fix the test by granting more time. Bug: 1082081 Change-Id: I785c368dd552c8fbbdd9df742879aa3b2b3675bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208011Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#771620}
-
Etienne Bergeron authored
This CL is introducing a helper class ThreadControllerPowerMonitor that assist ThreadController for tasks scheduling. The use of ThreadControllerPowerMonitor is optional and the power state is assume to not be suspended when unused. The end goal is to activate it by default after testing on stable channel. TBR=nasko@chromium.org Bug: 1074332 Change-Id: I40c3580ccba0b4755efed19f264e4634e3f13770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2200421Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#771619}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/414d114a..5db4a28e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie1b9628617f02327a7bea4efd2ff7024ef5d8b94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213066Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771618}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ef877fb5c549..cbbfde6c068f 2020-05-25 m.maiya@samsung.com Excplicitly include <string> header in tga_utils.h If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: I8d16238dd73bf4c5f9b1b9009109b17ff811317d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215264Reviewed-by:
-
Saurabh Nijhara authored
This CL introduces a new browser test for kiosk auto launch on views login when device is not enrolled and the user had requested to auto launch a kiosk app in the previous session. Bug: 989001 Change-Id: I25633ffda6d6b16c7e99051168a042c4dc8a4d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209219 Commit-Queue: Saurabh Nijhara <snijhara@google.com> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#771616}
-
Ted Meyer authored
Wez pointed out a good issue in crrev.com/c/1153144 Bug: 867872 Change-Id: I40e6f100c1f2fdee77ff536923e202f18d4eb7a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212932Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#771615}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/728938372b26..ca8a7e8ce304 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com,mpearson@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: bcwhite@google.com,mpearson@google.com Change-Id: I3280cc00e52d3ce2e99335b549c2357bffa93679 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215267Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1ea5180e. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools rego@igalia.com: external/wpt/css/selectors NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I062cba27ee277059fe983c58b2e44d584ea52d78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215118Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771613}
-
Vi Nguyen authored
Courtesy of jrummell's TODO: Now that there are 2 types of persistent sessions, the session type should be passed from blink. Type should also be passed in the constructor (and removed from initializeNewSession()). Bug: 1085463 Change-Id: Ic6f5f496d7f696d1563c0af0c80e42c8d54ec060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212685Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Vi Nguyen <ving@microsoft.com> Cr-Commit-Position: refs/heads/master@{#771612}
-
Dominic Farolino authored
This CL adds UKM to count the number of async scripts associated with a given mainframe document. Google-internal UKM privacy review: https://docs.google.com/document/d/1bKyDRF5BAQpPJ-bRyKs2dgqBTJI43b63kOULO-HIuXM/edit Bug: 1086227 Change-Id: Iaaee8c756952613c2ea58416b453a98a0843773f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209118 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#771611}
-
Jeremy Roman authored
Dead since 2013: https://codereview.chromium.org/64843004 Change-Id: I2e26bb531fca1e8e590b2f45b829fa485c145bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215303 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#771610}
-
Christopher Cameron authored
There exist standard colorSpaceConversion options of none (ignore color space) and default (use color space). Specifying srgb, p3, or rec2020 here is not appropriate. A more appropriate place would be in ImageData (where there do exist canvas color space parameters). Bug: 1083693 Change-Id: I3741454c36a59b3c8d679ec843aa05cebcc9d9c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213777Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#771609}
-
Scott Little authored
The result of the call is unused, and it's called again for the switch statement directly below it, so this CL removes the unused call. Change-Id: If5d86d4c30286057442dd8f9d06ef0a0b314487b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210926 Auto-Submit: Scott Little <sclittle@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#771608}
-
Antonio Gomes authored
... to replace |opener_routing_id|. This CL switches content.mojom.CreateFrameParams::opener_routing_id to use mojo_base.mojom.UnguessableToken. Note that it is a step forward toward stopping representing |opener frames| through its routing ID when doing mojo communications between browser -> renderer. The next CL will move callers of CreateViewParams::opener_frame_route_id to also use mojo_base.mojom.UnguessableToken (ie base::UnguessableToken). That will allow the removal of RenderFrameHostManager::GetOpenerRoutingID() altogether. BUG=1051144 R=avi@chromium.org, dominickn@chromium.org, dtapuska@chromium.org, haraken@chromium.org Change-Id: Ib0789617cb35234c28cd59584064b4ac84c76bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210635 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#771607}
-
Robert Kroeger authored
Suppress intermittently failing conformance/textures/canvas_sub_rectangle/tex-2d-rgb-rgb-unsigned_byte.html on Nvidia Mac Retina. TBR=kbr@chromium.org Bug: 1086194 Change-Id: I13cf0f95f980f2236d4ceb6a7dec53faf654762f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214906Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#771606}
-
Alex Ilin authored
Currently, there are 5 different URL switches in google_apis/gaia/gaia_switches.cc that need to be manually set to set non-prod Gaia environment. This CL introduces a new command line switch to rule them all: --gaia-config=gaia_test.json A JSON config file allows to override all URLs available in google_apis/gaia/gaia_urls.h. For a format example take a look at google_apis/test/data/gaia/all_urls.json. The proposed design was chosen because of the following: - It allows to override each individual URL separately without bloating the command line. This can be useful for developers who run their own test instances. - It makes easy to hide test URLs used at Google in the internal repo. Bug: 1072731 Change-Id: I3c32c53f9dc27b01ceab8ef57eb71c00d5df0977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166197 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#771605}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590407971-070878b52cdd641358380b2e2b381cb8c8d5514d.profdata to chrome-win32-master-1590422180-44e949163b7e7ddb0abdc3ec30e05825d5bf8262.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie9a82042330dbe101aac78457cf42b23cba90e83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215274Reviewed-by:
-
Andrew Grieve authored
Disabling is no longer necessary after latest R8 roll. It now optimises away extra bridge methods. Bug: 1056299 Change-Id: I85be3b0571500e47fd6f7c2c290c7e4d814086c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169754 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#771603}
-
Koji Ishii authored
The Canvas [text-preparation-algorithm] requires to run bidi algorithm using |TextDirection|, without |ComputedStyle|. In LayoutNG, |NGBidiParagraph| splits the text into bidi runs and compute bidi levels. This patch changes |NGBidiParagraph| so that Canvas code can use it without |ComputedStyle|. This patch changes |TextMetrics| to use |NGBidiParagraph| to resolve bidi levels, and measur each run. [text-preparation-algorithm]: https://html.spec.whatwg.org/multipage/canvas.html#text-preparation-algorithm Bug: 1010893 Change-Id: I46d8e5e3fd9e76910e86a5be71f9d7247911fbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196086Reviewed-by:
-
Koji Ishii authored
Making |NGFragmentItem| not a |DisplayItemClient| has two benefits: 1. Give a persistent |DisplayItemClientId| across multiple layout cycles. 2. Allow making |Vector<NGFragmentItem>| instead of |Vector<scoped_refptr<NGFragmentItem>>|, because a |Vector| of |DisplayItemClient| is not allowed. This change is expected to reduce the memory allocation cost, which is high for text-heavy pages. This patch is only for 1. The work for 2 will be in following patches. Still, this patch improves `blink_perf.paint/ paint-offset-changes` microbenchmark by ~10%: https://pinpoint-dot-chromeperf.appspot.com/job/15b8f60a120000 https://pinpoint-dot-chromeperf.appspot.com/job/14e61bb6120000 and slight positive changes to blink_perf.layout, probably due to simpler paint invalidations: https://pinpoint-dot-chromeperf.appspot.com/job/17d3126c120000 This patch is on top of following foudnation patches: * r770260 <crrev.com/c/2207948> supported |wtf_size_t| for fragment id. * r770637 <crrev.com/c/2209774> added |NGFragment:: FragmentId()|. Bug: 982194 Change-Id: I1cb5e2633bd591723632f1acb0cbb09ab4d77f83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208586Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771601}
-
Xianzhu Wang authored
These tests are still flaky on Win7. Added into NeverFixTests for Win7 because we'll never fix them and we have test coverage on Win10. Bug: 657646 Change-Id: I3f81979ca080807b645a2428f5000d22fc835db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209649Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771600}
-
David Bokan authored
Small style cleanup - there should be no behavior difference from this CL. Bug: NONE Change-Id: I532d13df78f7e02e52ae30a0fd05f46528f8ce91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213111 Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771599}
-
W. James MacLean authored
Removing a redundant/repeated boolean expression. TBR=alexmos@chromium.org Bug: n/a Change-Id: I1b64c620412279ca6871710ef0a7a67807cbbb8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214902Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#771598}
-
Antonio Gomes authored
Today, to pass the opener frame when creating a content remote (aka proxy) frame, its routing ID is used. This CL changes it to use the unique base::UnguessableToken instead. Note that it is a step forward toward stopping representing |opener frame| through its routing ID when doing mojo communications between browser <-> renderer. The next CL will move callers of content.mojom.CreateFrameParams.opener_routing_id to also use mojo_base.mojom.UnguessableToken (ie base::UnguessableToken). End goal is the removal of RenderFrameHostManager::GetOpenerRoutingID() altogether. R=avi@chromium.org, dominickn@chromium.org, dtapuska@chromium.org, haraken@chromium.org Bug: 1051144 Change-Id: I1add33224ce7909bac400da13bb3f361335b9dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209399 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590407971-3e57b161debb1f13fcdd2d2d0d37a285d980c990.profdata to chrome-mac-master-1590422180-66411a4557786c8add52c855489371af12277b8b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I723879d099895d254149466e2a235837472c79ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215269Reviewed-by:
-
Marc Treib authored
All Sync data types have been migrated to USS, so the migrator isn't needed anymore. Bug: 1084499 Change-Id: I62c13ae30f686c6670bec826bbf6ecf0bd1978bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207384Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#771595}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ec8892b5506b..ba95542b7b83 2020-05-25 patrick.brosset@microsoft.com New simple E2E tests for the styles and computed panes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1079076 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I690d459b35539efeb57e48a68e68e7ffed86e0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214474Reviewed-by:
-
Robert Kroeger authored
media/controls-layout-direction.html pixel tests are failing on Linux/SkiaRenderer with and w/o Vulkan. Suppress. TBR=jonross@chromium.org Bug: 1086181 Change-Id: If289b9ee276fb75691565cfc499c11b5073e2a6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214904Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Auto-Submit: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#771593}
-
