GitLab

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a062e707..0fe515a8

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I8d455d2da7ea252114a3ea2d2f77b5aab8945c66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744049Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685223}

This change adds a menu for the Native File System write permission in
chrome://settings/content. This permission controls whether sites are
allowed to ask the user for permission to save to the original file that
the user previously selected using the Native File System API.

Bug: 982904
Change-Id: I97bdedaed31cfff6c54b6c2a89efdb374f0b2951
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696390
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685222}

This CL turns on by default support for sites to lazily load <img> and
<iframe> elements by specifying "loading=lazy".

This CL also changes automatic lazy loading to by default get restricted
to lite mode users only, to more closely match what will be launched,
and updates the default distance-from-viewport loading threshold for
"Unknown" effective connection types to match the "4G" values, since
"4G" is the most common effective connection type.

Bug: 990967
Change-Id: I5ea3a5f03acc38b8d3475a847c14075e78cc1d2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740307Reviewed-by: Yoav Weiss <yoavweiss@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685221}

Bug: None
Change-Id: Iad4bf594dbc90c9e246d43fe9729e4b56fed9679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740128Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Chris Mumford <cmumford@google.com>
Cr-Commit-Position: refs/heads/master@{#685220}

https://android.googlesource.com/platform/external/perfetto.git/+log/07dff948a085..b307d657e8b7

git log 07dff948a085..b307d657e8b7 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 treehugger-gerrit@google.com Merge "Use noice-json-rpc for the extension to communicate with devtools"

Created with:
  gclient setdep -r src/third_party/perfetto@b307d657e8b7

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I3172b428cecdb8b3029bfe59045dafa792bf12a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744276Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685219}

The CSS Inline Layout spec has been updated to
show the initial value of dominant-baseline as
'auto', matching SVG 1.1 and browsers.

https://drafts.csswg.org/css-inline/#dominant-baseline-property
https://github.com/w3c/csswg-drafts/issues/4115

Change-Id: Ib2dbdf91a9535c4d149aa773b61302c36c360305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741445
Auto-Submit: Eric Willigers <ericwilligers@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685218}

This CL sends scrollend event if GSE is being
handled on the main thread after the snap (if
the snap has started after GSE). It also takes
care of sending scrollend event for snap after
fling.

Bug: 907601
Change-Id: I21aba5d098b25ddc765d78a7792ec8a2fb7987cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743253Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685217}

The WebUIListener type is referenced in WebUIListenerBehavior, so export
it and import it in the behavior.

This is to prevent a closure error when compiling modules that use the
behavior, specifically:
gen/ui/webui/resources/js/web_ui_listener_behavior.m.js:19:
ERROR - [JSC_UNRECOGNIZED_TYPE_ERROR] Bad type annotation.
Unknown type WebUIListener
     * @private {!Array<!WebUIListener>}


Bug: 965770
Change-Id: I442a476b178fbbcab75de551b2501f9481b61125
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743249Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685216}

These are now equivalent to if this is the default (Google) NTP.

Bug: 869931
Change-Id: Iac37cb3584da352215128b4077ae75999e98d937
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730588Reviewed-by: Nik Bhagat <nikunjb@chromium.org>
Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685215}

Some crashes happen in WebFramesManagerImpl::OnFrameBecameAvailable,
probably due to a lifecycle issue of WebStateImpl/CRWWebController.
When these classes are destroyed, WebFramesManagerImpl::OnWebViewUpdate
should be called and callbacks for JS messages should be unregistered.
However this might not be true according to crash reports.

Use WeakPtr in WebFramesManagerImpl for callbacks should help suppress
crashes, and we need further investigation to fix the lifecycle issue
and revert this patch.

Bug: 990842,991616,991950
Change-Id: I746c53eaa920bd96d6820edd563d2b7f94f7eb50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742135Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685214}

This adds the inteended launching arm of LightweightNoStatePrefetch to
the field trial testing config file based on experimental results so
far.

Bug: 934466
Change-Id: I86fac0798ae0cf8cfc539c65386761f41c4d6c94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742516Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685213}

Show debug borders for DC layers (red for overlay, blue for underlay)
with --show-dc-layer-debug-borders flag.  The debug borders are drawn
at an offset for visibility.  This will be useful for debugging webgl
overlays.

Also includes minor cleanup in the non-root render pass path.

Bug: 939658
Change-Id: I88ae03444b92e4fcfbd3d332ce68a862431c4c3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730296
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685212}

Moved unit test delegate to general test launcher tests
to share results file parsing.

Added test for unit test delegate and test launcher to
launch 3 tests, and validate their results.

Windows versions prior to Windows 8 required a new flag
'dont-use-job-objects' to avoid unsupported nested job objects.

This test is more comprehensive, and also tests
the gtest xml results parsing of the delegate.

Bug: 936244
Change-Id: I28afe983f8960c366f9b61a22c05103b32fafaa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732885
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685211}

Properly set the GLSurface size.

Bug: 990535
Change-Id: If5d5cc513693463d994d07f5361996db795f4a8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742208Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685210}

TBR=blundell@chromium.org

Bug: 942244
Change-Id: I720e5b692a8c6e785811e8547a889c916973e16d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739977
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685209}

Bug: 951969
Change-Id: Ia7c033604400393c55dea4d2895f5a2d320264d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710886
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685208}

Both this and PreviousOnLineInlineNG had the same typo, but
PreviousOnLineInlineNG was fixed in r659579
(http://crrev.com/c/1608867).

Unlike http://crrev.com/c/1608867, unfortunately this does
not seem to have a test coverage.

Change-Id: I707884c83e9c5bf711def37ceee888a294409e41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739235
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685207}

A few methods in Map and Vector classes (and private classes)
miss the override keyword. This can break compilation.

This CL adds override keyword to those methods.

BUG=728870

Change-Id: If518719dd7a06a9474a8f4691302a7af5fdd4a02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742131
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685206}

Bug: 983940
Change-Id: I6e590a6464a880eb5cac2f1b587cb43b0f2a860f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735465Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685205}

As part of preparation for adding secure remote powerwash command, change the
remote command infrastructure so it supports receiving secure remote commands.

Design doc go/cros-secure-commands

TBR=pbond@chromium.org

Bug: 967383
Change-Id: I8da7b6d7195331fb071418ba91bb1ffe499a6b6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731894
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685204}

This installer and app_shell itself are unused.

Bug: 987150
Change-Id: I299a53b2d4090e35c81ff32aeffe717303921c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716604
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685203}

This avoids an unnecessary strlen (the length is already known) and would also fix
the result for any hypothetical resource that had a null character inside it, which
is legal (though it's somewhat doubtful that we have any such resource).

Change-Id: I2a75d1a058d6980076bdc33467fd1c50c7b19591
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741290
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Auto-Submit: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#685202}

Bug: 937369
Change-Id: I711bafa333c5bdf20413826f73218d59826da091
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741630
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685201}

But coverage builder is not running now (crbug.com/991450).

Bug: 954450
Change-Id: Ie72178253fd64fb6c11893f71d9b13e859cfdb72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743243
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685200}

the extension to be loaded, so remove RunLoop::RunUntilIdle
which causes the flaky tests.

ChromeTestExtensionLoader: :LoadExtension is already waiting for
Change-Id: I7c7727617e93b2152e84ec32532ab084b889c745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743242Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685199}

Move the enums out from the SecurityTokenPinDialogHost interface (that
is defined at //chrome/browser/chromeos) into a separate header under
//chromeos.

This allows to reuse these enums in //ash.

Bug: 983103
Change-Id: Ide120d445ad235e93888886d4ae5d7707304ad7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744147Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685198}

Bug: 991593
Change-Id: Ia5e5f8885e5f94ace4afcdb32393636f91b3a973
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743728
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685197}

Bug: 991520
Change-Id: Ib44d086aecfa6739ec961de1f5479f95a1fbe259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741923
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685196}

Touchless tests are hitting network errors inexplicably on bots, and I'm
unable to repro locally, so I'm adding logging to hopefully get more
insight.

Bug: 983769
Change-Id: If9ed3b7569c1d26a7923bac5f458a44fb4edb331
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1741291Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685195}

This is a clean up task similar to what we did for WrappedSkImage
(https://chromium-review.googlesource.com/c/chromium/src/+/1651916):
rather than keep an SkSurface around indefinitely to keep a ref on a
GrBackendTexture, we explicitly allocate and destroy a GrBackendTexture
and create an SkSurface on demand to mutate the GrBackendTexture.

Bug: 974870
Change-Id: I0a8be55500e51d1c84312580e8b9410933dea6ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742286Reviewed-by: Sean Gilhuly <sgilhuly@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685194}

Bug: 955171, 984550
Change-Id: I5d8429c414e5cc4593cd7f3823da180a0cd47510
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742777Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Lucas Gadani <lfg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685193}

The IncognitoView was being created with an initial frame based off of
keyWindow.bounds, which returns a different value under iOS iPad
multitasking and was causing the incognito view to be smaller than its
superview.  Setting the view's initial frame to superview.bounds fixes
this bug.

BUG=991560

Change-Id: I522967b9238f31b1f9b2ce2bf2f1f12f6e063490
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744328Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685192}

https://chromium.googlesource.com/catapult.git/+log/bca4ad25f4fd..8e2aad881bcc

git log bca4ad25f4fd..8e2aad881bcc --date=short --no-merges --format='%ad %ae %s'
2019-08-08 simonhatch@chromium.org Pinpoint - Add queue length stats to scheduler

Created with:
  gclient setdep -r src/third_party/catapult@8e2aad881bcc

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=oysteine@google.com

Bug: chromium:991306
Change-Id: I44fbe023b919aa546284340b61aa503dab9185d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743457Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685191}

The associated TODO says to replace the use of std::list in this file
by a WTF::HashSet. However, after looking at how the container is
actually used in the .cc file, WTF::Deque seems like a perfect match.

BUG=704136
R=guidou@chromium.org

Change-Id: I731a3770c7039fcfd1520caf1277c52ffefc94d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744048Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#685190}

https://android.googlesource.com/platform/external/perfetto.git/+log/6e0df67d958d..07dff948a085

git log 6e0df67d958d..07dff948a085 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 hjd@google.com Merge "Add uuid in perfetto_cmd"

Created with:
  gclient setdep -r src/third_party/perfetto@07dff948a085

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Bug: None
Change-Id: I830675b7388d06dac84874a0496b562f3a8921a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743460Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685189}

Marked node 17 as ignored in the comments. Should have go with change
https://chromium-review.googlesource.com/c/chromium/src/+/1737870

Bug: 988153
Change-Id: I6dc3da7765c54f0909e29e1134b28b36574a9c08
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739629
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#685188}

This implements an (ideally temporary) intervention which allows cookies
that don't specify SameSite and get defaulted into SameSite=Lax mode
(under SameSiteByDefaultCookies) to be sent on requests with "unsafe"
http methods (e.g. POST) in addition to the usual Lax-mode restrictions,
if they are recently-created (within some threshold time delta).

This adds a CookieSameSite enum value LAX_MODE_ALLOW_UNSAFE which is
applied to default-Lax cookies that are recently-creatd. If a cookie has
effective SameSite of LAX_MODE_ALLOW_UNSAFE, it is sent with a request
if it meets all the Lax-mode requirements except for "safe" http method.

Bug: 990439
Change-Id: I5a650383699562a71ddf01447d3e23c6836c6362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734031Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685187}

This way all static initializers that happen before
main() can be estimated.

Bug: 988395
Change-Id: I95bc3edf2052d18b73f6bcf2d76c34815f282839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730899
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685186}

https://chromium.googlesource.com/angle/angle.git/+log/7270a6d578f5..e86a8560f202

git log 7270a6d578f5..e86a8560f202 --date=short --no-merges --format='%ad %ae %s'
2019-08-08 syoussefi@chromium.org Vulkan: Fewer subgroup ops in seamful cubemap emulation

Created with:
  gclient setdep -r src/third_party/angle@e86a8560f202

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Bug: None
Change-Id: I18912bb38bf94b07468d2773a0ecc529636bd3e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743458Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#685185}

Currently the dialog always prompts for both passwords
(the old one once, and the new one twice).

This change modifies it to only ask for passwords that
were not scraped.

Details:
If no passwords are scraped, both prompts are show immediately.
If the wrong old password is then entered, the same prompts are
shown again with "Incorrect password" next to the old password prompt.

If both passwords are scraped, a spinner is shown immediately.
If the old password scraped then fails to unlock cryptohome, then
the old-password prompt is shown as below.

If only the new password is scraped, then only the old password
prompt is shown. If the wrong old password is then entered, the
same prompt is shown again with "Incorrect password" next to it.

If only the old password is scraped, then only the new password
prompt is shown. Once the new password has been entered consistently,
if the old password scraped then fails to unlock cryptohome, then
the dialog is reshown but now with an old password prompt added.
If the old password is then entered incorrectly, then as usual,
the "Incorrect password" text will be shown next to that prompt.

The dialog is sized appropriately when first shown to make room for
the prompts that it contains. In the case that a new prompt is
added, it resizes itself.

Bug: 930109
Change-Id: I89f326ce50f4b0543c5053af25cae618b0c8ee92
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724080
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685184}