GitLab

Rebaseline to fix a few web test failures on MacOS 10.14, due to added
padding to input text related types introduced by r736729, which was
submitted before MacOS 10.14 became a default trybot.

TBR=wangxianzhu@chromium.org

Bug: 1028242
Change-Id: I707514ef4cfd3e24cf6bbccf4d44b66c41a29772
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031708Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737026}

SplitSettingsSync will allow the user to opt-out of browser sync.
However, IdentityAccessor::GetPrimaryAccountInfo() assumes the user has
consented to browser sync. Assistant has its own consent. Drive
doesn't have (or need) consent separate from Google account creation
and sign-in. Switch to using the "unconsented" primary account,
which exists whether or not the user has consented to browser sync.

See go/cros-sync-mock and go/cros-primary-account for details.

Bug: 1042400
Test: updated existing unit tests
Change-Id: Ib368939c3a25ebd21db62955c1394197bf4f8d03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023304Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737025}

1. Use const and pass by reference when appropriate.
2. Convert NULL to nullptr in the modified files.
3. Fix some file formatting to match clang.
4. Use default and explicit constructors where they should be
5. Remove unused SetCrtc overload.

BUG=987274
TEST=HardwareDisplayControllerTest, HardwareDisplayPlaneManager*Test

Change-Id: Ic0f019bfa862a5160805ecbfd22dc391e6f9f418
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031864
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Auto-Submit: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737024}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b2f79dd4c2c7..7ea79fbc6f6f


Created with:
  gclient setdep -r src-internal@7ea79fbc6f6f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1046904
Tbr: jbudorick@google.com
Change-Id: Idd406a06ebca19bfc23792133c4664a237ac3d0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031636Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737023}

https://webrtc.googlesource.com/src.git/+log/670af2692e5d..8e998f17e0ce

git log 670af2692e5d..8e998f17e0ce --date=short --first-parent --format='%ad %ae %s'
2020-01-30 srte@webrtc.org Fixes stall in SimulatedProcessThread
2020-01-30 ilnik@webrtc.org [VP9] Shift spatial layers on RTP level to always start from 0.

Created with:
  gclient setdep -r src/third_party/webrtc@8e998f17e0ce

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I4308d855a0fcc1f34504cdad5d4768e01d7aaa22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031635Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737022}

This change is a follow up to this CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2018094

1. We remove the tree_id() method from the TreeWrapper and use
GetTreeID() instead.

2. We use wrapper->GetNodeFromTree() instead of
wrapper->tree()->GetFromId().

3. We overload GetNodeFromTree to take fewer parameters.

Change-Id: Icb2dd678ca10f1faf67ddc536351f1b51728f02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028734
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737021}

PaymentRequest.TransactionAmount.[Completed|Triggered] UMA metric records
transaction amounts after converting them to USD and mapping them to one
of the following three categories: 0$, <= 1$, or > 1$
This cl adds UKM for the same metric to enable analyzing transaction
categories per origin.

Bug: 970597
Change-Id: I6de11b41e4af4cf59a8c1422a39a17fb391ea4e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025872Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737020}

Miscellaneous spellfixes. No functional changes.

Mostly instances of "clipboard" and "synchronous", and one of "currently".

Change-Id: Ic313394247301698afee43e6c96bdb5de3f38bac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029458
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Auto-Submit: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737019}

This change adds the
http/tests/devtools/persistence/persistence-move-breakpoints-on-reload.js
web test to TestExpectations in order to allow the Mac10.13 Tests (dbg)
Builder to be green.

Bug: 1047420

TBR=ioanap@chromium.org,szuend@chromium.org,sigurds@chromium.org

Change-Id: I86ccdb09994d7894176caf0968bc7fb8c63afca9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031928Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737018}

In addition to .pak files, //tools/grit/pak_util.py outputs .info files.
This however is not reflected in the gn template list of outputs. This
can cause errors with running ninja with '-d explain' after a successful
build which the trybots do.

Bug: 1045024
Change-Id: Id4e8915cff182f5d7c55cb947f4f2aa513ccc2b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031530
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737017}

The following tests need to be rebaselined after https://crrev.com/736729:
fast/forms/form-element-geometry.html
fast/forms/select/menulist-appearance-basic.html
paint/invalidation/caret-subpixel.html
paint/invalidation/details-open-repaint.html
paint/invalidation/float-offscreen.html
paint/invalidation/multi-layout-one-frame.html
paint/invalidation/search-field-cancel.html
paint/invalidation/subtree-root-skipped.html
paint/invalidation/clip/caret-ancestor-clip-change.html
paint/invalidation/scroll/caret-invalidation-in-overflow-scroll.html
paint/invalidation/scroll/invalidate-caret-in-composited-scrolling-container.html
paint/invalidation/scroll/invalidate-caret-in-non-composited-scrolling-container.html
paint/invalidation/selection/selection-in-composited-scrolling-container.html
paint/invalidation/selection/selection-in-non-composited-scrolling-container.html

The following tests are newly failing and now have bugs filed:
http/tests/subresource_filter/ad-highlight-frame-resized.html
paint/pagination/composited-paginated-outlined-box.html

Change-Id: Iee55b2d42925b77ac750e44c876b058c7c3e16bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031561
Auto-Submit: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737016}

When there are composited animations in the process of being started,
we defer the start of main thread animations in order to synchronize
the start times. This process can lead to main thread animations getting
stranded in the pending state if composited animations are being
continuously generated. With this patch, main thread animations queued
up in a previous frame will no longer get blocked waiting to synchronize
with a fresh batch of composited animations.

Bug: 666710
Change-Id: I21eb1184bbf636230991e09691498a190ccf8f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024476
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737015}

The reason is CL:2006847 adds the checking whether the app exists in
AppService. However, unrecognised Crostini apps should still load icons
using AppServiceProxy, though they doesn't exist in AppService. So
update the checking condition, and special handle the unrecognised Crostini
apps, similar with the icon loading function.

BUG=1047036

Change-Id: I80a3ae3704a9cc6e2e57df1fef53867aa731552a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029470
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737014}

https://pdfium.googlesource.com/pdfium.git/+log/65137d177ac2..60ca7defc0eb

git log 65137d177ac2..60ca7defc0eb --date=short --first-parent --format='%ad %ae %s'
2020-01-30 thestig@chromium.org Change JpegModule::LoadInfo() to return an optional struct.
2020-01-30 thestig@chromium.org Merge ICC components validation code into CPDF_ColorSpace.

Created with:
  gclient setdep -r src/third_party/pdfium@60ca7defc0eb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I891cd02e891e2d0a2bb60db83be422e6272da698
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031632Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737013}

This CL implements async desalinization of PaintPreviewProto in
PaintPreviewBaseService. This can be used by implementers of
PaintPreviewBaseService, if they store the proto on disk.

Bug: 1043267
Change-Id: I6739b3122ef23a9b6a47c1358013f55dca7301fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006256
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737012}

This change enables the mode switch between signed-in and signed-out
for Liassbistant when user enters/exits the ambient mode, so that we
can further explore the behavior of signed-out mode.

Bug: none.
Test: run unittest added in this change
Change-Id: Idcb4903401173b8f86a3428a0f452b5ce9b7a5ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995804
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737011}

The type was refcounted, but only ever had a single owner
(StoragePartitionImpl). Change the ownership to unique_ptr and
slightly simplify the class.

Change-Id: Idaed9b5b0443982731b6a78c0027a959014d354c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028731
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Auto-Submit: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737010}

Bug: 1046930
Change-Id: I32201efb8617bafb2a904b4f6f8d8f6c007fc657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028216Reviewed-by: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737009}

This allows devices to send Sharing messages via WebRTC if they are both
in the experiment. This allows us to control the rollout more controlled
and prevents devices not in the experiment to receive WebRTC messages.

Bug: 1021131
Change-Id: I25f137ed06075c8de7b1e9a5fbc48eb3b89219a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027794
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Himanshu Jaju <himanshujaju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737008}

https://dawn.googlesource.com/dawn.git/+log/48e7da791f14..1edaa1d1e18f

git log 48e7da791f14..1edaa1d1e18f --date=short --first-parent --format='%ad %ae %s'
2020-01-30 rharrison@chromium.org Use the spvc translated version of the Vulkan shader

Created with:
  gclient setdep -r src/third_party/dawn@1edaa1d1e18f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: cwallez@google.com
Change-Id: I3f3fcabb5944860b408c0ca5c262e32d9735468e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031631Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737007}

Update the proposal process to use the new template. In particular:
- Update links to use the new template
- Remove sign-off labels from the bug, as they are in the template
  instead
- Slight rewordings and updates

Bug: None
Change-Id: Ifd9c59408396c8346e6d778839f9da7893a6bac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028967Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737006}

For Google navigations, the hrefTranslate hint may trigger a translation
automatically. Add a histogram to track if the hint is present on a
Google navigation, record whether or not automatic translation happened.
If automatic translation was already going to happen, then we use the
auto translate target language. Also record if this caused the target
language to be different than the hrefTranslate target language.

Bug: 900586
Change-Id: Idaf09ba10ad980a0cfdeca23e21a247548dcbeb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029290
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737005}

TBR=odejesush@chromium.org
NOTRY=true

Bug: 1047427
Change-Id: I374536199803ca6b73948ad4b1053aa5f22a53ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031539Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737004}

Change-Id: I9507db19bca8d87abc062bc59df13a944878676e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029268
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737003}

Updates the Reader Mode active icon, and adds a new icon for
inactive state. See go/reader-mode-ux.

Bug: 1040706
Change-Id: I42658b42b19ade8d723d08c5e74f306d9c89c46a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028257Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737002}

TBR=bling-p10-rolls@google.com

Change-Id: I0da4df8e9c2b504114e509d05b3b3f5674ef8e68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031669Reviewed-by: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#737001}

No change to logic, only docs.

This updates the build instructions for Android Q:

 * List which package names work for Q
 * Mark which package names are preinstalled, and make the "remove
   preinstalled WebView" section more general
 * Document that trichrome_library_apk is automatically handled by ninja
   and generated wrapper scripts
 * Clarify 'enable-redundant-packages' is removed in Q

Bug: 956316, 1044821
Test: tools/md_browser/md_browser.py
Test: Upload to gerrit > open file > click "gitiles"
Change-Id: I1d4543ddbb1844564b5c6ff2fa37ed573d2012c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018337
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#737000}

When user and device policies provide the same certificate, keep the
certificate as device-wide certificate when combining them.

Bug: chromium:1045902
Test: chromeos_unittests --gtest_filter=NetworkCertLoaderTest*
Change-Id: I8685ba03e5a333814583d158a216f8ff0a98865c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025108Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Omar Morsi <omorsi@google.com>
Cr-Commit-Position: refs/heads/master@{#736999}

R=kylechar

Fixes: 1044437
Change-Id: I469d7589eb1a70034a3324782a20784d646eb769
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011685
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736998}

These events indicate that network activity indicator has started or
stopped spinning. These logs are not very useful, but take space.

Bug: 1046231
Change-Id: Ifef0cc43fc0ce8cf84299265482e5ab2004b38ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029328
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736997}

This will encrypt / decrypt messages sent via WebRTC with Web Push
encryption. SenderID is preferred with a fallback to vapid. We only
support sending via FCMChannelConfiguration (remote device will receive
the message via FCM) and not ServerChannelConfiguration (remote is a
server endpoint). This means Sharing messages via WebRTC need to be
initiated via Chrome and not server side.

Bug: 1045406
Change-Id: Ida249ca1cdd44a4552d85700c857c8288d598ec4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011925
Commit-Queue: Richard Knoll <knollr@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736996}

The DevTools Performance Timeline tool with 'Advanced paint instrumentation' enabled captures layer trace events, which includes compositing reasons. This change adds compositing_reason_ids to the trace information, so that we can localize the compositing reasons in the client (i.e. DevTools frontend).

Bug: 946860
Change-Id: Ibb9b655c739947898b857489d5f8d727a40ef19b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031528Reviewed-by: Mandy Chen <mandy.chen@microsoft.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Lorne Mitchell <lomitch@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#736995}

The new MIME types are
* application/pdf
* The types listed in firefox.desktop

R=thestig

Fixes: 1046912
Change-Id: I23e314694a08677f13cee8c1399ae68b58f1aab7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031865
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736994}

Change-Id: Id268acba620b57196e06cc1160d95a7d2b036a17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028861Reviewed-by: Darwin Huang <huangdarwin@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736993}

Bug: 1011441
Change-Id: I990c53761f39003a9dfea21274c61e881dcb00ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031304Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736992}

These are the shell-specific changes from
019a8580 with some
adjustments to make sure the viewpoint doesn't change size
(as changing the viewport size affected perf test outcomes).

Bug: 1038415, 1045609
Change-Id: I1c74c1326a5541de23eb1d1c1a2f383b26466ae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025875Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736991}

This is a precursor CL for https://crrev.com/c/1992341 which creates
the TabContentManager pre-native, and splits its creation into
creation + post-native initialization.

In this CL, we refactor TabContentManager::getTabThumbnailWithCallback
to use a tab ID instead of Tab which can't be created in pre-native.

Bug: 1041865
Change-Id: I8a0c82e40b5e0f05974a66bceb7cc96d2e4bcf5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003433Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736990}

This CL disables
PictureInPictureWindowControllerBrowserTest.SurfaceIdChangeDoesNotMoveWindow
due to flakiness.

TBR=odejesush@chromium.org
NOTRY=true

Bug: 1002489
Change-Id: Ia0da98a68c4d9e669cff36ab7a55bee220da66ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031598Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736989}

jacoco (Java code coverage tool) requires turning off strict mode
since it writes the coverage data to files.

AwStrictModeTest enables strict mode and therefore it currently
causes strict mode violation (in a flaky way).

Unfortunately, we are disabling this in one of the main tryservers
(android-marshmallow-arm64-rel) which enables jacoco, but
android-pie-arm64-rel in CQ and 5 other bots run this
continuously, and such violations will be locally reproducible.

        test can be run, check tryserver result

Bug: 1021403, 1045270
Tested: change use_jacoco_coverage value in build gn and see if
Change-Id: I95b41f82906f6d7f0ec32a353203928f831079a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029327Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736988}

Bug: 1045114
Change-Id: Ifd1a1cac094daab05e2d2330d393c3bdfc0d75b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020425Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736987}