- 10 Apr, 2018 40 commits
-
-
stkhapugin@chromium.org authored
Rolls MDC and updates the BUILD.gn following the changes in MDC. Bug: 831114 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ida3e76d77c68be7830575a2c261d214c51fd81dd Reviewed-on: https://chromium-review.googlesource.com/1005156Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549529}
-
https://chromium.googlesource.com/angle/angle.git/+log/fe4bbe6cbec6..26084d0aae38 $ git log fe4bbe6cb..26084d0aa --date=short --no-merges --format='%ad %ae %s' 2018-04-09 jmadill Vulkan: Create TextureVk's Image lazily. 2018-04-09 jmadill Optimize Subject's binding method. 2018-03-30 jiawei.shao Use ShaderBitSet for active use bits on uniforms Created with: roll-dep src/third_party/angle BUG=chromium:829906 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I56fc6e687699170e99bd4d210db0b1ac88aedf48 Reviewed-on: https://chromium-review.googlesource.com/1005023 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549528}
-
Devlin Cronin authored
Signature parsing failed in cases where an optional parameter of a certain type was followed by a required parameter of the same type. The parsing was greedy, and would always use a parameter if it matched. This meant that passing a value like `1` to a signature that matched (optional int, int) would fail, because the `1` would be applied to the first optional int, and the second int would be missing. Tweak signature parsing to find the signature that matches the supplied arguments (if any possible signature matches) and resolve the arguments before performing parsing. Update unittests for the same. Bug: 818555 Change-Id: I57c9909ff73505467fb9d333690113bea8eea433 Reviewed-on: https://chromium-review.googlesource.com/993532Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549527}
-
David Bokan authored
This patch fixes the Android find-in-page feature when used by dragging down the tickmarks. The issue was that prior to RLS, absolute coordinates were equivalent to "document" coordinates. That meant that after scrolling, they don't change. When RLS is turned on, absolute coordinates are frame-relative so scrolling will change the location of an absolute rect. This find in page feature would scroll the text match into view and then attempt to zoom in on it. However, because of the above change, the coordinates used for the zoom have now changed. The solution here is to simply query the bounding rect after the scroll into view again. Bug: 828758 Change-Id: I807a05b89707080b1eed1bb3682147411776aa44 Reviewed-on: https://chromium-review.googlesource.com/1004010Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549526}
-
Mikel Astiz authored
We adopt them already in some existing tests and plan to use them in future patches as part of the migration of session sync to USS. Bug: 681921 Change-Id: I91bcb5b2d0383be89bef1b905e1d3b16259f94bb Reviewed-on: https://chromium-review.googlesource.com/983918Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549525}
-
Matthew Wang authored
This is a reland of 34f59cac Turns out it was enough to clobber the WebRTC mac builder. Original change's description: > ONC: Add FTEnabled property to WiFi > > Support FTEnabled property in ONC. > > BUG=791202 > TEST=chromeos_unittests > TEST=chrome.networkingPrivate.createNetwork with "FTEnabled":true > enables the device to connect to an FT network. Setting > "FTEnabled":false disables the device from connecting to an FT > network. > > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I2470753fd139505704987e301b18983dc51c5c47 > Reviewed-on: https://chromium-review.googlesource.com/982275 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Matthew Wang <matthewmwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549366} TBR=matthewmwang@chromium.org Bug: 791202 Change-Id: Ia7c49d75e3c7b769e5853e377ef860fef6663abc Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/1005114 Commit-Queue: Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#549524}
-
kylechar authored
Make OzoneGpuTestHelper::Initialize() run UI thread tasks after OnGpuProcessLaunched(). In https://crrev.com/c/980574 Ozone DRM was changed so the DRM display controller handle was only accessed on the UI thread to prevent races. This means that when GpuPlatformSupportHost OnGpuProcessLaunched() is called from the IO thread there is a UI thread task that needs to run to finish initialization. This CL adds a RunLoop that runs on the UI thread and immediately posts a task to quit that run loop. That will run any tasks on the UI thread that are pending and then continue, ensuring the Ozone DRM initialization is finished. This should be safe for other Ozone platforms as well. Bug: 830233 Change-Id: I5b2e45c36f7042d59800c0822ca97b13a60a7aab Reviewed-on: https://chromium-review.googlesource.com/1003076Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#549523}
-
Francois Doray authored
Previously, the test ran all pending tasks, waited for all stores to be equal, and then verified that the printer description was equal in all stores. It is better practice not to wait for all pending tasks to run, and instead wait for the specific condition that we want to verify. Bug: 810408 Change-Id: Ifa5fe80368285786664498991c82c1ccdecb5072 Reviewed-on: https://chromium-review.googlesource.com/1003224 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Nicolas Zea (slow) <zea@chromium.org> Cr-Commit-Position: refs/heads/master@{#549522}
-
Sebastien Marchand authored
Initial piece of the Site Characteristics Local Database[1], this is the internal class that will be used by the LocalSiteCharacteristicsDataStore. Bug: 773382 Change-Id: Ic125fb1200b0b22bf4c985eff4f140d7db2357c3 [1] @google: https://docs.google.com/document/d/1OODhTnNu4v9dUv6tl6i2vofh0K2DS1OM6EfKs5ewbPA/edit?usp=sharing Change-Id: Ic125fb1200b0b22bf4c985eff4f140d7db2357c3 Bug: 773382 Reviewed-on: https://chromium-review.googlesource.com/976603 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#549521}
-
Mikel Astiz authored
The last known device name is already loaded in current_session_name_ by the time InitFromSyncModel() is called, so there's no point in overriding the field with another string that we restore from the persisted state. Bug: 314681 Change-Id: I91abebec85204a8d86a44f35e65bf3803ae1c44e Reviewed-on: https://chromium-review.googlesource.com/1004994Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#549520}
-
Peter Beverloo authored
TBR=jianli, finnur and jamescook for include path changes Bug: 829604 Change-Id: Icb53714ede7a4ce40ca38ee4c79740b64c70997a Reviewed-on: https://chromium-review.googlesource.com/1001894Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Gabriel Charette authored
As promised @ https://chromium-review.googlesource.com/c/chromium/src/+/999795 Scripted via https://crbug.com/825327#c18 Also cleaning up MessageLoop/MessagePump APIs from now unused types. TBR=fdoray@chromium.org Bug: 825327 Change-Id: I9b458bc24223e57afb3e8a08678f97b2cd8330da Reviewed-on: https://chromium-review.googlesource.com/1003080 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#549518}
-
Gabriel Charette authored
(MessagePumpIOSForIO|MessagePumpLibevent)::FileDescriptorWatcher => (MessagePumpIOSForIO|MessagePumpLibevent)::FdWatchController (MessagePumpIOSForIO|MessagePumpLibevent)::Watcher => (MessagePumpIOSForIO|MessagePumpLibevent)::FdWatcher TBR=fdoray@chromium.org Bug: 825327 Change-Id: Id7268678ace3e713173483abc077c8a27e680554 Reviewed-on: https://chromium-review.googlesource.com/1003058 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by: -
Henrik Grunell authored
Bug: 826664, 830624 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I61b09bfbc5c71d0f8573da8d315475b32727f289 Reviewed-on: https://chromium-review.googlesource.com/1002851 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549516}
-
Adithya Srinivasan authored
- TraverseChildNodes.html has been disabled since it's creation in 2013 - event-target-wrapper.html has been disabled for almost 4 years (https://crrev.com/11fa29bfc9db3ab9befd51719fdd086394570449) and is a "manual" test, it's unclear whether we actually use it - click_webkit_user_select_none.html was disabled (https://crrev.com/8c2c59c239e9d02eb14d88fa7596d0e15caba70d) 2 weeks after it was created, and never fixed after Bug: 825837 Change-Id: Ied18ae861d704f99e215360aecc1caf1a127d97c Reviewed-on: https://chromium-review.googlesource.com/1003081Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#549515}
-
Troy Hildebrandt authored
When cutting/copying text in the URL bar, there's currently an assumption that we're copying a URL and it sends some formatted version of the URL to the clipboard instead of copying what's in the URL bar verbatim. This change allows us to copy the text as-is if we're displaying search terms. Bug: 830050 Change-Id: If45ecdb68a08f2333274a785c29b2c15ce78d9bb Reviewed-on: https://chromium-review.googlesource.com/1003314Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549514}
-
Aleksei Loshkarev authored
We discover heap use after free in ASAN builds for our signin unit tests. It happens because the asynchronous processing in IdentityManager does not check own lifetime. This cl adds WeakPtr usage for PostTask in IdentityManager. R=blundell@chromium.org Change-Id: I85cbdd4d5da97c0c3d3ab92a01642523c6d0a8f0 Reviewed-on: https://chromium-review.googlesource.com/999607 Commit-Queue: Alexander Yashkin <a-v-y@yandex-team.ru> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#549513}
-
Luciano Pacheco authored
This change helps when debugging failing tests by displaying the caller's file name and line number/column when a test fails. I have tested it on |waitForFiles| function and it showed the exact test and file failing when waiting for files that haven't appeared. [31960:31960:0329/003500.134613:INFO:CONSOLE(112)] "Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbpejbbpdbkdjmoco/test_util.js (112) With this patch: [260320:260320:0405/133233.683120:INFO:CONSOLE(136)] "at /file_manager/directory_tree_context_menu.js:125:23: Element #directory-tree-context-menu > [command="#copy"]:not([disabled]) (maybe in iframe undefined) is not found.", source: chrome-extension://oobinhbdbiehknkpbp ejbbpdbkdjmoco/test_util.js (136) Bug: 829203 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I97e07683b52f107b36ff8af2335e98193ff275b2 Reviewed-on: https://chromium-review.googlesource.com/995242Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#549512}
-
Adithya Srinivasan authored
This CL adds a way to check if an element is focusable without requiring layout to be up to date. This allows us to skip doing a full layout for elements that aren't focusable. Bug: 808503 Change-Id: I9cbcde28262039e908aac6cbc9ce00a057320c30 Reviewed-on: https://chromium-review.googlesource.com/955544Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#549511}
-
Mihai Sardarescu authored
This CL passes the information that the default promo account was selected from the settings WebUI when the user attempts to enable sync. This leads to the right histograms Signin.SigninStartedAccessPoint.{NewAccount|NotDefault|WithDefault} when sync is enabled from settings. This CL is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/986141 Bug: 819431 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I55c7390819ace71ae6cb937248d2d425a5a0396f Reviewed-on: https://chromium-review.googlesource.com/999420 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#549510}
-
Josh Karlin authored
Includes the script of the top stack frame in ads detection processing. Bug: 807640 Change-Id: I8f4d0364ea088bf00abcc7310e4dccce7fec78f3 Reviewed-on: https://chromium-review.googlesource.com/986337 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#549509}
-
Chih-Yu Huang authored
We added Flush() function in VEA interface, but not all devices and drivers support this. This CL adds a new argument "--disable_flush" into VEA unittest to skip checking the flush function. Bug: chromium:829276 Test: Pass video_encode_accelerator_unittest --disable_flush at peach-pit device Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I82477a75178ec6aeb3ebf382b601005455c957a4 Reviewed-on: https://chromium-review.googlesource.com/999233Reviewed-by:Ricky Liang <jcliang@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549508}
-
Gabriel Charette authored
TBR=fdoray@chromium.org Bug: 825327 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I935efa140d0e97cc91a9d76ae8acbf821eb24312 Reviewed-on: https://chromium-review.googlesource.com/1003221 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL is a few cleanups to ease review of crrev.com/c/986353: - PictureById() is moved to the end of the cc file, following the order of its declaration. Code untouched (except s/NULL/nullptr/). A call to PictureById is substituted with base::ContainsKey() to better reflect intent. - OutputPicture() loses its last parameter, that is then calculated on the spot (it's |available_picture_buffers_.front()|). This makes OutputCB unnecessary, so it's made a Closure, and a OnceClosure at that. Test: eve crosvideo vp9 cycling resolutions. Bug: 822346 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie17f23f2fb20752463e9ebeacd1bf7a9b6150437 Reviewed-on: https://chromium-review.googlesource.com/1000297Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#549506}
-
Balazs Engedy authored
Interface requests to RenderFrame::GetRemoteInterfaces are dropped when they arrive to the RenderFrameHostImpl after the RenderFrameHostImpl had already committed the next cross-document navigation. In follow-up to crrev.com/c/974263, this CL adds a histogram to record, for each load, and for each dropped Mojo interface request in a frame, a sample with a value corresponding to the hash of the dropped interface's name, calculated as the lower 31 bits of the base::HashMetricName(name). Bug: 795258 Change-Id: I0a4a3aa552c4bc2eb543b4aad3a3a35ecae9f831 Reviewed-on: https://chromium-review.googlesource.com/993059Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549505}
-
Max Morin authored
This is a reland of 21f2ef4c Per offline discussion, this code is fine. Original change's description: > Bind StreamFactory in audio service. > > Bug: 803102 > Change-Id: I4d8cb112445095045c492488f7c3b8d9853b6c23 > Reviewed-on: https://chromium-review.googlesource.com/1004634 > Commit-Queue: Max Morin <maxmorin@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549481} Tbr: Bug: 803102 Change-Id: I3b14b633dd1419eae570d2b9ab411fc8732fad4c Reviewed-on: https://chromium-review.googlesource.com/1005080Reviewed-by:
-
Sriram authored
This reverts commit e6b16d30. Reason for revert: https://crbug.com/824746 Original change's description: > Remove old position adjustment for non-snap-to-lines WebVTT cues > > This is a remnant of what the spec originally said. Just like the bug > report says, this turned out to be pretty confusing: > https://www.w3.org/Bugs/Public/show_bug.cgi?id=19178 > > Bug: 551245 > Change-Id: I1063b940db81555a65211fa93e84441b53e2b091 > Reviewed-on: https://chromium-review.googlesource.com/753102 > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> > Cr-Commit-Position: refs/heads/master@{#513819} TBR=fs@opera.com,srirama.m@samsung.com # Not skipping CQ checks because the original CL landed 4 months ago. Bug: 551245 Change-Id: Ic0fa56ae68b11332f6e0336c290290f434c7df3c Reviewed-on: https://chromium-review.googlesource.com/1004974 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#549503}
-
Jan Krcal authored
This CL is part of the process of switching from protobuf nano to protobuf lite. Bug: 782237 Change-Id: Iffbdafb225d2ba2dadee14a5b17e7be88a452341 Reviewed-on: https://chromium-review.googlesource.com/1000698Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#549502}
-
Christian Biesinger authored
Addresses kojii@'s comment on https://crrev.com/c/1001721 R=kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I3632cc61d4eb957d1cff67bbdd41cd9cbe0d0f75 Reviewed-on: https://chromium-review.googlesource.com/1005095Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#549501}
-
Kent Tamura authored
- InternalRuntimeFlags.h.tmpl -> internal_runtime_flags.h.tmpl - InternalRuntimeFlags.idl.tmpl -> internal_runtime_flags.idl.tmpl - InternalSettingsGenerated.cpp.tmpl -> internal_settings_generated.cc.tmpl - InternalSettingsGenerated.h.tmpl -> internal_settings_generated.h.tmpl - InternalSettingsGenerated.idl.tmpl -> internal_settings_generated.idl.tmpl This CL has no behavior changes. Bug: 768828 Change-Id: I1538695125ff78b701a71e4cb50024cb4e5e6eab Reviewed-on: https://chromium-review.googlesource.com/1004395Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#549500}
-
Darren Shen authored
Some failures: - fill & stroke shorthands do not seem to follow spec (it should be list valued) - fill-opacity & stroke-opacity do not clamp their values (ComputedStyle should clamp values, like opacity). - fill-color is not implemented. Bug: 820299 Change-Id: I0879e353cd22291aa8a34f2a10895809b43d8aa5 Reviewed-on: https://chromium-review.googlesource.com/998454Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#549499}
-
Vasilii Sukhanov authored
TBR=georgesak@chromium.org Bug: 663847 Change-Id: Iefaed745947d459821b29b0726bcac79e89d23a6 Reviewed-on: https://chromium-review.googlesource.com/1005214Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#549498}
-
Adam Rice authored
The browser test ProxyBrowserTest.BasicAuthWSConnect was flaky because the testserver.py proxy it configured could only handle one request at a time, and other parts of the browser randomly launched unrelated requests while the test was running, occasionally taking the proxy's one request until the test timed out. testserver.py's basic auth proxy mode has been modified to support multiple simultaneous requests, so the ProxyBrowserTest.BasicAuthWSConnect test should no longer be flaky. Re-enable it. BUG=822614 Change-Id: Id390f01807b532316e3aa2d4de199e8082ae0bf0 Reviewed-on: https://chromium-review.googlesource.com/999374Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#549497}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/86b145e5..4acb5079 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iae9b04497f44470ddb6d874589597bee1c6b3016 Reviewed-on: https://chromium-review.googlesource.com/1004596Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549496}
-
Daniel Vogelheim authored
Allow control of the deprecation via runtime enabled features, with a first step for logging a warning to the console, and the second step to block it outright. Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/35t5cJQ3J_Q/FH45dl0vAwAJ Change-Id: I1be1001cbbef152458119b1516750bb4f1d1e4de Reviewed-on: https://chromium-review.googlesource.com/975611 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#549495}
-
Mark Cogan authored
As a follow-up to crrev/999712, this CL updates the GridCommands protocol to, where possible, express actions on tabs in the tab grid in terms of item IDs instead of indexes. Bug: 986379 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib92ba83fe37ac789b693d006e0ca60cb665b22b5 Reviewed-on: https://chromium-review.googlesource.com/1000860 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549494}
-
David Roger authored
This CL adds an API to OAuth2TokenServiceDelegate::Observer to listen to changes in auth errors. AccountReconcilor uses this API to trigger a ListAccount call when a token becomes invalid. This is necessary because in that case, the account can be invalid in the cookie without the cookie changing. Chrome needs to make a call to ListAccount to have an accurate view of the Gaia accounts in the cookie. Bug: 823714 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie22226adfe6c425acaffe875a314c4a6b8de5e88 Reviewed-on: https://chromium-review.googlesource.com/986268 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#549493}
-
Henrik Grunell authored
Bug: 826664, 830624 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I08e1ee4237f4e221baca4a0adec7a8bff19c1fa6 Reviewed-on: https://chromium-review.googlesource.com/997740 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Elad Alon authored
As a feature, the value could only be off/on. As a switch, the value can be force-off, force-on, or default. Default is at the moment OFF, but will later be made ON for non-mobile builds where the user has given appropriate consent. Bug: 775415 Change-Id: I75b46074434505d65a3a60f2858068d1ad6513c2 Reviewed-on: https://chromium-review.googlesource.com/1002849Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#549491}
-
Vasilii Sukhanov authored
TBR=huangml@chromium.org Bug: 814990 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6db1b62ec0b0d007fdcde56b866ce6500ec71234 Reviewed-on: https://chromium-review.googlesource.com/1005078 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
