- 16 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/d7cd1203a42b..28d8d7bc673a git log d7cd1203a42b..28d8d7bc673a --date=short --no-merges --format='%ad %ae %s' 2018-11-16 33432579+alan-baker@users.noreply.github.com Fix min base alignment (#2075) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@28d8d7bc673a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1edd77b44e26cb3624ede1bb0f42ecea2c74c249 Reviewed-on: https://chromium-review.googlesource.com/c/1340573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608955}
-
Aiden Benner authored
See bugs for rationale Bug: 904912,906160 Change-Id: Ib3e45f2eee2189e90179a6857e5878342c9393ce Reviewed-on: https://chromium-review.googlesource.com/c/1340900Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com> Cr-Commit-Position: refs/heads/master@{#608954}
-
Ella Ge authored
This reverts commit 4c95576e. Reason for revert: live-edit-no-reveal.js failed on mac bots crbug/906189 Original change's description: > [LayoutTest] Rebaseline live-edit-no-reveal.js after V8 roll > > Bug: V8:8405 > Change-Id: I150f74bf5de8c0a2cd784e6d1399c1c702c2936e > Reviewed-on: https://chromium-review.googlesource.com/c/1339961 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608839} TBR=rmcilroy@chromium.org,delphick@chromium.org Change-Id: I8d115789c789b22379fc95e418af388edeaea41b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: V8:8405, 906189 Reviewed-on: https://chromium-review.googlesource.com/c/1340943Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608953}
-
Robert Kroeger authored
WebglConformance_conformance_textures_video_tex_2d_rgba_rgba_unsigned_short_5_5_5_1 is failing intermittently on Nexus9. Suppress. BUG=906158 TBR=kbr@chromium.org Change-Id: I1311556d5d2fc040c2b9e7c256a25b1bf0a7c18d Reviewed-on: https://chromium-review.googlesource.com/c/1340866Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#608952}
-
Bruce Dawson authored
ARM64 on Win32 adds a third Win32 target platform which requires updates to the script which configures the toolchain. This includes handling build\win_toolchain.json listing either two or three toolchains, and not copying UCRT DLLs in the ARM64 case, except for ucrtbased.dll. This also fixes some erroneous double quotes, probably left over from previous changes I made to this file. This is in preparation for landing and then using crrev.com/c/1330185 Bug: 893460 Change-Id: I1fa775b662e3c0483174c32ad3c73f30f2802ea9 Reviewed-on: https://chromium-review.googlesource.com/c/1339101Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#608951}
-
Lily Chen authored
This reverts commit dc8c60c3. Reason for revert: Bug causing crashes was fixed in https://crrev.com/c/1333135 Original change's description: > Revert "Add reprioritization to SSLConnectJobs" > > This reverts commit 8a9302e2. > > Reason for revert: Causing flaky crashes in external/wpt/webusb/idlharness.https.any.worker.html > > Original change's description: > > Add reprioritization to SSLConnectJobs > > > > This change allows the priority of an SSLConnectJob to be changed. If > > the reprioritization occurs while the job is establishing its underlying > > connection, the priority change is also passed down to the lower-level > > socket pool. > > > > Bug: 166689 > > Change-Id: I87d1e536846443901cc628423f4615c3ffa7542a > > Reviewed-on: https://chromium-review.googlesource.com/c/1327423 > > Commit-Queue: Lily Chen <chlily@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#606876} > > TBR=mmenke@chromium.org,chlily@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 166689, 904345 > Change-Id: I6458798e11d210258f2a26330548f1ca33eb6c90 > Reviewed-on: https://chromium-review.googlesource.com/c/1331139 > Reviewed-by: Matt Menke <mmenke@chromium.org> > Commit-Queue: Lily Chen <chlily@chromium.org> > Cr-Commit-Position: refs/heads/master@{#607301} TBR=mmenke@chromium.org,chlily@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 166689, 904345 Change-Id: I54fe803331be6fe3df534c0f6042bf0fb0057cbb Reviewed-on: https://chromium-review.googlesource.com/c/1340824Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#608950}
-
Min Qin authored
Currently DownloadDB records some of the persistent for DownloadItem. And DownloadItem will constantly requesting these data from the DownloadDBCache during its life cycle. Which is unnecessary as these data are already passed to DownloadItem during the creation time. This CL allows DownloadItem to cache those persistent data after creation. So there is no longer any need to request them again, and we can remove them from the DownloadDBCache in future CLs to save memory. BUG=893651 Change-Id: Ic360bd81e283272105ef9d43d91e2b8dd00d9145 Reviewed-on: https://chromium-review.googlesource.com/c/1338328Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608949}
-
Evan Stade authored
It was added in 2012 for PrintPreviewTest but is no longer needed and is causing issues with single process mash tests, where OzonePlatform only expects to get initialized once. If this happens in a test's SetUp(), and parts of it get destroyed by the AtExitManager, they won't be re- initialized for later tests. Tests will still pass in isolation but not when run as a suite. This CL also simplifies PrintPreviewTest a bit, which is the test fixture for which the AtExitManager was originally added. Bug: 905430 Change-Id: I4617aed098962f4eea6a9d1bfe052e3902278557 Reviewed-on: https://chromium-review.googlesource.com/c/1340798Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#608948}
-
Justin Cohen authored
This happens when clearing browser data, and forces the NTP to be recreated (and not show previous NTP tiles). Bug: 905735 Change-Id: If818e02703c7324f0a660bf6b115603db3682b74 Reviewed-on: https://chromium-review.googlesource.com/c/1339340Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608947}
-
Ella Ge authored
TBR=kbr@chromium.org BUG=906092 Change-Id: I11105b926d35b5bcb16c2930c04f98db20e5f4b4 Reviewed-on: https://chromium-review.googlesource.com/c/1340788Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#608946}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/09299cdfd973..4d0fac4a2c9e git log 09299cdfd973..4d0fac4a2c9e --date=short --no-merges --format='%ad %ae %s' 2018-11-16 tsepez@chromium.org Remove some unused strings from CFX_CSSData tables. Created with: gclient setdep -r src/third_party/pdfium@4d0fac4a2c9e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7108ae0af76028e59a5cc51eeedcf69a9094f9fc Reviewed-on: https://chromium-review.googlesource.com/c/1340572Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608945}
-
Toni Barzic authored
The larger goal is to stop using sign-in profile after a user session starts (with hopes that it will eventually be possible to shut the profile down after sign-in completes). BUG=901768 Change-Id: Ic019113cad1284cffb50581d3e52b891cd509ff5 Reviewed-on: https://chromium-review.googlesource.com/c/1338866Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#608944}
-
Nico Weber authored
Bug: none Change-Id: I4cd719751f4962bd80c7f9b6531535e15a1d3d99 Reviewed-on: https://chromium-review.googlesource.com/c/1340520 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#608943}
-
Jesse McKenna authored
TaskScheduler: Make method ordering consistent between SchedulerWorkerPoolImpl:: and SchedulerSingleThreadTaskRunnerManager::JoinForTesting This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1338140 Bug: 889029 Change-Id: I1c179f6617bac417fb54c55e9328e2391d2d7b5b Reviewed-on: https://chromium-review.googlesource.com/c/1340360 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#608942}
-
Joe Downing authored
This change adds a DataChannelHandler for Action messages and ties it into ClientSession. When a new handler is created, it will receive an ActionExecutor (added in a previous CL) which is used to invoke the requested action. BUG: 892434 Change-Id: I56b60fdc56b89900297943eafe78f50982b7681f Reviewed-on: https://chromium-review.googlesource.com/c/1294715Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#608941}
-
Johannes Henkel authored
This directory is rolled manually and thus far does not contain anything that's synced in by gclient or similar. So it's confusing to have it in .gitignore because it makes it easy to forget updating things in it this way. an automatic deps mechanism, but for now this should be it. PS: We may later add this back, if we end up going with Change-Id: I74441dd50055efa860dd793789786b42c6c0fa2b Reviewed-on: https://chromium-review.googlesource.com/c/1338720 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608940}
-
Tarun Bansal authored
Enable DataReductionProxyMainMenu by default. This has been enabled for 99% of population for over a year. Also, remove the variation param "persistent_menu_item_enabled" since we decided not to launch with that setting. See the bug for more details. Change-Id: I551f90132e3a5daaedd544cd7847c0949400f09f Bug: 905911 Reviewed-on: https://chromium-review.googlesource.com/c/1338883Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#608939}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/417ac91cdb06..e4634a13a74d git log 417ac91cdb06..e4634a13a74d --date=short --no-merges --format='%ad %ae %s' 2018-11-16 jmadill@chromium.org Apply code formatting. 2018-11-16 ynovikov@chromium.org Vulkan: Handle VK_ERROR_DEVICE_LOST 2018-11-16 jmadill@chromium.org Use angle::Result in front-end (Part 9) Created with: gclient setdep -r src/third_party/angle@e4634a13a74d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I54172fc246c9772b6b184cdd9e131f366c31e228 Reviewed-on: https://chromium-review.googlesource.com/c/1340390Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608938}
-
Bettina authored
We created another uninstall reason when uninstall functionality was made available in Chrome Web Store but didn't update the condition for showing the uninstall URL. I've re-enabled the browser test for EnsureExtensionUninstallURLIsActiveTabAfterUninstall since I've run the test 100 times in one run and 600 times in another run and it did not fail. Bug: 900554 Change-Id: I805840717709606a8e98d1c82cbea2b611efdfd6 Reviewed-on: https://chromium-review.googlesource.com/c/1336522 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#608937}
-
Vlad Tsyrklevich authored
This change is preparing for an upcoming refactor. kFreePagesNumBits and kGpaMaxPages are equivalent. Get rid of the latter with a static_assert() that kGpaMaxPages is always equal to the size of the BitMap. Bug: 896019 Change-Id: I7e99766d2e6fffa0e3d3eb3a47a2e76038b522ab Reviewed-on: https://chromium-review.googlesource.com/c/1340526Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#608936}
-
Vlad Tsyrklevich authored
Get rid of the SlotMetadata constructor/destructor and replace the destructor with a Destroy() method. Also change alloc_ptr to be a uintptr_t. This refactor makes SlotMetadata safer to initialize with out-of-process memory in an upcoming crash handler change, because the SlotMetadata we read should not be automatically destructed (the members will be from another memory space). Since alloc_ptr is only used in the crash handler there's no reason to not make it a uintptr_t to make it appear less like a pointer in crash handler's memory space. Bug: 896019 Change-Id: I3f1f22eac6277722de9594a3331b8daef618d29d Reviewed-on: https://chromium-review.googlesource.com/c/1340868 Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> Reviewed-by:
Vitaly Buka <vitalybuka@chromium.org> Cr-Commit-Position: refs/heads/master@{#608935}
-
Aaron Krajeski authored
Provide a pointer to SecurityOrigin within SVGFEImageElement so that it can test if its content actually taints the origin. Previously all filters with feImages tainted the canvas. When the filter is set (during CanvasRenderingContext2DState::SetFilter) the SecurityOrigin is stored. During CanvasRenderingContext2DState::GetFilter is it determined whether the compiled filter should taint the canvas. Next step is to make this work for other svg_fe elements. Change the test expectations for SVGFEDisplacment tests as FEImages no longer necessarily taint the origin. Reverting changes here: https://chromium-review.googlesource.com/c/chromium/src/+/782649/ Bug: 618871 Change-Id: I506c443f842068f08eab0e3d6b214f2b10878a86 Reviewed-on: https://chromium-review.googlesource.com/c/1258968 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#608934}
-
Shawn Gallea authored
Move wl_seat interface out of server.cc, removed usage of keyboard and pointer for cast shell. Bug: 896710 Test: Built on ChromeOS Change-Id: I3e91381883ff028e684b5c4bfbb1dd744cf31ed8 Reviewed-on: https://chromium-review.googlesource.com/c/1324099 Commit-Queue: Shawn Gallea <sagallea@google.com> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#608933}
-
Robert Flack authored
In BGPT, each KeyframeModel on a given Animation may need to animate a different ElementId, as the various effects of an element are split into multiple different nodes in some of the same node trees. This change sets the ElementId on the keyframe model and uses that when applying mutations. Since animations currently expect to look for the existence of a single element, this patch also modifies PaintPropertyBuilder to construct each node type that may be needed for an animation when any property is being animated on an element and then uses the kPrimaryEffect id to check whether this has happened. This also makes several changes to plumb the proper list of element ids: - Register all ancestor ElementIds in PaintArtifactCompositor::Update. - Synchronize registered ids during commit. - Synchronize registered ids during activation. Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Bug: 896549 Change-Id: I717822a1ca174658ef792005e76613a5033f4f6a Reviewed-on: https://chromium-review.googlesource.com/c/1297305Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#608932}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a3d34a0f7ad..c1d08bca895a Created with: gclient setdep -r src-internal@c1d08bca895a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I38e460f59dfdedb9f0f088a77c85e8f60468ee76 Reviewed-on: https://chromium-review.googlesource.com/c/1340391Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#608931}
-
Mitsuru Oshima authored
* WindowSelectorObserver listens the activation change first so that it can cancel the overview before resuming minimized window. * This also fixes a crash that happens if you click the overview button while activating a window in overview. * This also fixes the bug in WindowSelectorController was calling wrong "Starting/EndingAnimation". This happens to work fine because the end results are the same. Bug: 905813 Test: covered by unit test. WindowSelectorControllerTest::AnimationCallbacks Change-Id: I2b3d3fdc2e68bb41c0d037d46552cf6cfda98746 Reviewed-on: https://chromium-review.googlesource.com/c/1338175 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#608930}
-
kylechar authored
Bug: 874797 Change-Id: Iced662e0de18687740b1ad374f5743ae01916ef6 Reviewed-on: https://chromium-review.googlesource.com/c/1340361Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#608929}
-
Jun Cai authored
Network Service: Update comments about the callback parameter for NetworkConnectionTracker::GetConnectionType() This CL updates the comments about the callback parameter for NetworkConnectionTracker::GetConnectionType() to make it clear that the |callback| will not be called when connection type can be retrieved synchronously. Bug: None Change-Id: I39eefe13311d9e594dc3f2518fb543014ccf5487 Reviewed-on: https://chromium-review.googlesource.com/c/1336078Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#608928}
-
about://newtabJustin Cohen authored
Bug: 905721 Change-Id: I6218a61cdd74b93257cb44580351c9c666092c0c Reviewed-on: https://chromium-review.googlesource.com/c/1338964 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#608927}
-
Shawn Gallea authored
Fix bounds unittest to make sure an offset from fullscreen_surface will be detected. Bug: 896710 Test: FullscreenShellSurfaceTest.Bounds Change-Id: Ia8e3213b5c854f423537a9d0e58455f3d497bea7 Reviewed-on: https://chromium-review.googlesource.com/c/1340863Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#608926}
-
Mohamed Amir Yosef authored
When a message arrives for a lazy GCM subscription and Chrome isn't in the foreground, it is persisted on disk until next time Chrome is in the foreground. This CL adds two histograms 1- Record the time spent to check if a subscription lazy upon receiving a GCM message while Chrome is in the background. 2- Record the time spent in reading and replaying persisted messages when Chrome goes to the foreground. Bug: 882887 Change-Id: I2ea8e5a5c5242b573e842b56f08d7f1070d48856 Reviewed-on: https://chromium-review.googlesource.com/c/1333656Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#608925}
-
Lindsay Pasricha authored
Migrate from using our custom utility and helpers to a similar util developed and maintained by the EG team. Doc at go/bling-axe Bug: 856622 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib86b171447eac2961ec2591c8a08764d06b7a953 Reviewed-on: https://chromium-review.googlesource.com/c/1291570 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#608924}
-
Sunny Sachanandani authored
This is a reland of 56f3274d Fix uninitialized |rotation_| in VideoFrameSubmitter. Original change's description: > Reland "Fix video quad rect and surface output rect" > > This is a reland of 1dfd4418 > > Original change's description: > > Fix video quad rect and surface output rect > > > > Video surface output rect didn't take rotation into account so when > > SurfaceAggregator would stretch content to fill bounds, it would end up > > with the wrong scaling factors (squash in one dimension and expand in > > another) since the surface quad's bounds (in the embedder) were rotated. > > > > To work around this (or by accident), VideoFrameResourceProvider was > > passing the rotated size as the quad's rect which doesn't make sense > > intuitively. This also worked by accident with DirectComposition > > overlays because of applying another scaling which would fix the aspect > > ratio again. > > > > This change makes it possible to use the |quad_to_target_transform| as > > is, without having to apply an aspect ratio correcting scaling, and to > > assume that the quad's rect is in the pre-transform space. > > > > Bug: 904035 > > Change-Id: Ia55e44f1f2b49b8d368a97af54f3ce9d90a81234 > > Reviewed-on: https://chromium-review.googlesource.com/c/1334971 > > Reviewed-by: enne <enne@chromium.org> > > Reviewed-by: Kenneth Russell <kbr@chromium.org> > > Reviewed-by: Frank Liberato <liberato@chromium.org> > > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608495} > > TBR=enne@chromium.org,kbr@chromium.org,liberato@chromium.org > > Bug: 904035 > Change-Id: I278a0ea2c5507f01ea13b31d2090b5f99537c7c3 > Reviewed-on: https://chromium-review.googlesource.com/c/1338418 > Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608596} TBR=enne@chromium.org Bug: 904035 Change-Id: I0f94cd8d71c7c9af60d3d57ac593d2f509e566b0 Reviewed-on: https://chromium-review.googlesource.com/c/1339200Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#608923}
-
Katie D authored
This logs image minimum dimension and dimension ratio for all images loaded when a screen reader is enabled. For more info see go/gchro. Bug: 905419 Change-Id: I75402356c4cf5e64211e37d928634b7b4754fc2b Reviewed-on: https://chromium-review.googlesource.com/c/1336001 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#608922}
-
Steve Anton authored
Bug: 874296 Tbr: hbos@chromium.org Change-Id: I1d76f979d9ff4cfcec0b5d5a34663dc48bb94056 Reviewed-on: https://chromium-review.googlesource.com/c/1289698 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#608921}
-
Jeremy Roman authored
This is required for correct heap tracing, since RTCQuicStream derives ContextClient, which is a GC mixin. Bug: 869498 Change-Id: I124c3a23e4a6e670fc3af195fa43498c3f9a857e Reviewed-on: https://chromium-review.googlesource.com/c/1340790Reviewed-by:
Steve Anton <steveanton@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#608920}
-
John Budorick authored
Tbr: justincohen@chromium.org No-Try: true Change-Id: Ie1eaf6202192b20bbbc42ca272f44e2c36921d06 Reviewed-on: https://chromium-review.googlesource.com/c/1340909Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608919}
-
Brad Hall authored
https://chromium.googlesource.com/infra/luci/client-py.git/+log/f78187ab7712..7f463e66e1c4 $ git log f78187ab7..7f463e66e --date=short --no-merges --format='%ad %ae %s' 2018-11-16 bradhall Only allow repeated dimensions for 'caches' 2018-11-06 tikuta [client] Add --filepath-filter option to choose download files from isolate 2018-11-02 tikuta Revert "[client] Increase worker to download isolate files faster" 2018-11-01 tikuta [client] Increase worker to download isolate files faster 2018-11-01 vadimsh [isolate] Don't unexpectedly raise KeyError if the cache state file was lost. Created with: roll-dep src/tools/swarming_client Bug: 871453 Change-Id: If2148a3a89af930dcf8ec0a6a5f71684cf974c9b Reviewed-on: https://chromium-review.googlesource.com/c/1340332 Commit-Queue: Brad Hall <bradhall@google.com> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#608918}
-
Casey Piper authored
When a request is originated from cryptotoken, bypass the checks of the origin as cryptotoken already validates the origin. Change-Id: I9105a8e5881c901322a417845d2976636205a05c Bug: 902567 Reviewed-on: https://chromium-review.googlesource.com/c/1318064 Commit-Queue: Casey Piper <piperc@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#608917}
-
Xiaocheng Hu authored
This patch parameterizes CharacterIteratorTest for LayoutNG to prevent regressions when LayoutNG is enabled. Bug: 810579 Change-Id: I160081c9389aed9ee8cb326be6e022d7b6fd375f Reviewed-on: https://chromium-review.googlesource.com/c/1340271Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#608916}
-