- 07 Aug, 2018 40 commits
-
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/f3a3393a2f96..e1c2f6d7fe7a git log f3a3393a2f96..e1c2f6d7fe7a --date=short --no-merges --format='%ad %ae %s' 2018-08-07 tsepez@chromium.org Remove WideString::Format() from ThrowException() methods. 2018-08-07 tsepez@chromium.org Use wide string addition in place of some Format() calls. 2018-08-07 tsepez@chromium.org Add test for {Byte,Wide}String Operator+(). 2018-08-07 tsepez@chromium.org Combine redundant CJBig2_Image code. 2018-08-07 tsepez@chromium.org Speculative fix for null deref above ThrowNoDefaultPropertyException Created with: gclient setdep -r src/third_party/pdfium@e1c2f6d7fe7a The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:870952 TBR=dsinclair@chromium.org Change-Id: I10fe6cd6f0dd97baf6b7e2f3b774bab1558c9875 Reviewed-on: https://chromium-review.googlesource.com/1166042Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581395}
-
Reilly Grant authored
This reverts commit b624551f. Reason for revert: Reverting this change broke the tree because of a patch that depends on it. Since the test is only flaky fixing the tree is better than causing more disturbance by reverting more changes. Original change's description: > Revert "Port policy::UploadJobImpl to network::SimpleURLLoader" > > This reverts commit 581330a9. > > Reason for revert: SimpleURLLoaderTest.OnUploadProgressCallback/3 is flaky > > Original change's description: > > Port policy::UploadJobImpl to network::SimpleURLLoader > > > > This change ports UploadJobImpl from net::URLFetcher to SimpleURLLoader. > > > > Since this request does not make use of the response a new method has > > been added to SimpleURLLoader, DownloadToNull. This download mode still > > reads the response body from the network but does not save it anywhere. > > This is useful for requests which upload data and would otherwise have > > to specify an arbitrary |max_body_size|. A maximum may still be set if > > the caller wants to limit the amount of data transferred over the > > network. > > > > Bug: 773295 > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > > Change-Id: Iee1fdc6f7406066ced8c91122e22cd51ddcb1c5f > > Reviewed-on: https://chromium-review.googlesource.com/1161551 > > Commit-Queue: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Matt Menke <mmenke@chromium.org> > > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#581060} > > TBR=pastarmovj@chromium.org,reillyg@chromium.org,mmenke@chromium.org > > Change-Id: Ica09c85a12861d35efbdfd9a882d137bac6b9e56 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 773295, 872023 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1166288 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581389} TBR=pastarmovj@chromium.org,reillyg@chromium.org,mmenke@chromium.org Change-Id: I793ab6c8c22c5bec97ef853f520dc506809970cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295, 872023 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1166301Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581394}
-
Patrick Monette authored
Also render them valid to trigger an incompatible applications warning. Bug: 846953 Change-Id: I6fa9951043d19a44a820aeaf44cab1c0e9b981e2 Reviewed-on: https://chromium-review.googlesource.com/1158986Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#581393}
-
Quan Nguyen authored
This stops the shelf from updating its button visibility only to be deleted anyway due to a successful sign-in. Bug: 836172 Change-Id: I2a7f31610cd3317c87f06bce064cd0331a583d3c Reviewed-on: https://chromium-review.googlesource.com/1166156Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581392}
-
Xiaoqian Dai authored
already has a snapped window in place. Bug: None Change-Id: Ia8b43095e851b30f52814f65cb52d2349be25dbf Reviewed-on: https://chromium-review.googlesource.com/1162939 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#581391}
-
Eric Willigers authored
overscroll-behavior shipped in M63 https://chromium-review.googlesource.com/797351 https://www.chromestatus.com/features/5734614437986304 BUG=789590 Change-Id: Ib5237ff2ccc2d2549aed6292520db0878658db45 Reviewed-on: https://chromium-review.googlesource.com/1165047Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581390}
-
Reilly Grant authored
This reverts commit 581330a9. Reason for revert: SimpleURLLoaderTest.OnUploadProgressCallback/3 is flaky Original change's description: > Port policy::UploadJobImpl to network::SimpleURLLoader > > This change ports UploadJobImpl from net::URLFetcher to SimpleURLLoader. > > Since this request does not make use of the response a new method has > been added to SimpleURLLoader, DownloadToNull. This download mode still > reads the response body from the network but does not save it anywhere. > This is useful for requests which upload data and would otherwise have > to specify an arbitrary |max_body_size|. A maximum may still be set if > the caller wants to limit the amount of data transferred over the > network. > > Bug: 773295 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Iee1fdc6f7406066ced8c91122e22cd51ddcb1c5f > Reviewed-on: https://chromium-review.googlesource.com/1161551 > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581060} TBR=pastarmovj@chromium.org,reillyg@chromium.org,mmenke@chromium.org Change-Id: Ica09c85a12861d35efbdfd9a882d137bac6b9e56 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295, 872023 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1166288Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581389}
-
Joe Mason authored
Also add crash and logging deps to test_main.cc R=proberge Bug: 830892 Change-Id: I1fae62bfcff0beded07a1827cab1d58dab79f3ac Reviewed-on: https://chromium-review.googlesource.com/1163635 Commit-Queue: Joe Mason <joenotcharles@chromium.org> Reviewed-by:
proberge <proberge@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581388}
-
Matt Falkenhagen authored
Replace vague RunUntilIdle() calls with FlushForTesting() and explicit events. Bug: 862294 Change-Id: I76e6cf9501b5d480960f431316e385bd7bf9941d Reviewed-on: https://chromium-review.googlesource.com/1164737 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#581387}
-
wutao authored
Trilinear filtering uses many memories which can cause tile missing in WindowCycleList view and Overview mode. Turn it off by default. Bug: 871984 Test: manual. Change-Id: Icbe758c2a2c707ca58aa0816a76436fb487144df Reviewed-on: https://chromium-review.googlesource.com/1166199Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#581386}
-
Daniel Murphy authored
This is the first component of LevelDB Scopes. The lock manager is a basic leveled lock system with shared and exclusive locks. This change contains an implementation which requires disjoint lock ranges, which is what the IndexedDB system will be using. This also includes a README with the implementation plan. This will be updated as more code is submitted. Bug: 862456 Change-Id: Ib4300ae8c59035c06772625323b3de0cc9ef3f6a Reviewed-on: https://chromium-review.googlesource.com/1134407 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581385}
-
Wan-Teh Chang authored
Add a space between the bullet point '-' and the package name. R=johannkoenig@google.com Change-Id: Iec44d755cc2540375dadfd6324dbe0c633c0db28 Reviewed-on: https://chromium-review.googlesource.com/1166160 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#581384}
-
Philip Rogers authored
On platforms that need preferred content size updates (MacOS and Android), an additional blink lifecycle update is issued if layout changes because ContentsPreferredMinimumSize is called after layout. In most cases this is unnecessary because layout is already up-to-date. On platforms that use PreferredSizeChangedMode (e.g, MacOS), the preferred size is updated after layout (RVI::DidUpdateMainFrameLayout) and when the PreferredSizeChangedMode setting is enabled. When called from DidUpdateMainFrameLayout, no lifecycle update is needed. When the setting is first enabled, this patch now explicitly updates the lifecycle before updating the preferred size. On Android (AwRenderViewExt), the preferred size update does not appear to need to force a lifecycle update because the common path in AwRenderViewExt::UpdateContentsSize uses DocumentSize which does not force a layout update. This patch removes the forced lifecycle update from ContentsPreferredMinimumSize and adds a DCHECK that is is only called with up-to-date layout. An integration test has been added that ensures no extra lifecycle updates occur. This would have caught https://crbug.com/866981. This patch changes the expectations for media/video-zoom-controls.html which was different on MacOS compared to Windows and Linux. The media controls code is racy with layout and will put up a bad frame (see: MediaControlsImpl::NotifyElementSizeChanged). Before this patch, the preferred content size layout timer would occur before the media controls layout timer and cause different controls to show up on MacOS. With this patch, the expectation on MacOS now matches other platforms. Bug: 868983 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I80098edd844bb88e3c64a54cc42b54063ec1c583 Reviewed-on: https://chromium-review.googlesource.com/1153972Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581383}
-
Becca Hughes authored
The autoplay policy should follow the kBlockAutoplayEnabled pref if the kAutoplaySoundSettings feature is enabled. If the pref is true we will use document-user-activation otherwise we will use no-user-gesture-required. The only exception is if the user has overridden the autoplay policy in which case we will use the autoplay policy command line switch. BUG=865548 Change-Id: I79ba3bbf5542ba17af9ab96baef80cd89d5b5326 Reviewed-on: https://chromium-review.googlesource.com/1157199 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#581382}
-
Jacob Dufault authored
Bug: 839604 Change-Id: I7a9048afb50151a6c3eab2a0a2ca09cd5f5ec2ae Reviewed-on: https://chromium-review.googlesource.com/1166185Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#581381}
-
Eric Willigers authored
Web payments modifiers shipped in M62 https://chromium-review.googlesource.com/632597 https://www.chromestatus.com/feature/6636936064139264 BUG=660926 Change-Id: Id0ab64582180f3cba875618efe3b31177d9ce9b8 Reviewed-on: https://chromium-review.googlesource.com/1164973Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581380}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3cb00fbd5681..ada05b3a7a57 git log 3cb00fbd5681..ada05b3a7a57 --date=short --no-merges --format='%ad %ae %s' 2018-08-07 deanliao@chromium.org Update FindBrowser() doc-string and its browser chosen code. 2018-08-07 perezju@chromium.org [Telemetry] Allow to run if either root or su is available 2018-08-07 perezju@chromium.org [telemetry] Explicitly KillAll as_root in android platform 2018-08-07 digit@google.com Remove pyling warnings. 2018-08-07 nednguyen@google.com Add Win_7 and Win_10 expectation Created with: gclient setdep -r src/third_party/catapult@ada05b3a7a57 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867328,chromium:871748,chromium:871748,chromium:868306 TBR=sullivan@chromium.org Change-Id: Ic75ef799a28f1a3577c79cd83218a7d7ddc77a9e Reviewed-on: https://chromium-review.googlesource.com/1165423Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581379}
-
Weilun Shi authored
[NTP] Update NTP to respect the HideWebStoreIcon policy and enable NTP MD feature for HiddenWebStoreIcon test Now, Changing the HideWebStoreIcon policy will affect the prepopulated_list when a new profile opens or reopen the browser. The policy doesn't affect current profile on the NTP. This is because the browser will cache the prepopulated list so that it can fetch the tiles quickly. Also, force to enable New Tab Page Material Design flag for the HiddenWebStoreIcon test so that the PolicyTest can now get the new md-tile element instead of the old mv-tile. Bug: 871166, 855603 Change-Id: I77a632daa73d655d9d1df053186782917405a15b Reviewed-on: https://chromium-review.googlesource.com/1164077Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#581378}
-
Eric Willigers authored
The img.decoding attribute shipped in M64 https://chromium-review.googlesource.com/828273 BUG=772470 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia75ff9b42b0e6bd245bc789278627fb49e5e3cf7 Reviewed-on: https://chromium-review.googlesource.com/1165044Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#581377}
-
Alexei Filippov authored
Module names and address offsets within the module can be used by symbolizers to determine symbol names. BUG=803276 Change-Id: Id3cca2b5f39a3e4f6bb5eb9ddd4c2bb8ec80ed68 Reviewed-on: https://chromium-review.googlesource.com/1159363 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#581376}
-
Aldo Culquicondor authored
Also performing the UI update after obtaining a frame. Bonus: replace __FUNCTION__ by __func__ to comply to styleguide. Bug: 767282 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I88f59a2991f8fed1ce7d9842781d2d63d8b351fa Reviewed-on: https://chromium-review.googlesource.com/1162702 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#581375}
-
kristipark authored
Fixed tile deletion functionality. The id of the tile was not being obtained correctly. Also fixed various accessibility issues: - Keyboard focus will start on the first input field of the edit dialog. - The iframes now have titles instead of "frame 0". - The "x" button on a tile will no longer remain visible after clicking and releasing with a mouse. - The button labels for screen readers are now applied correctly. - "Restore all" is now "Restore default shortcuts" in the shortcut removed notification. - If custom links is enabled, pressing "backspace" or "delete" while the shortcut is focused will now delete the shortcut. Also adjusted variable names to match their CSS name. Bug: 871663, 864357 Change-Id: I10135be42d9525931077daf0b7c859c60dd59e89 Reviewed-on: https://chromium-review.googlesource.com/1166028Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581374}
-
Xiangjun Zhang authored
Add pthcatcher@ and aburago@ to the WATCHLIST. Change-Id: Iea60d0fcb3ae16663023bfad7b27efe922dc06fe Reviewed-on: https://chromium-review.googlesource.com/1165851 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581373}
-
Donn Denman authored
Rolls back a recent auto-roll of AFDO because we suspect that it could be causing problems with the recent Android Official build. TBR=gbiv BUG=871173 Change-Id: Icec331079f2b1be1d0b6a5e61d3ca096b46c3f91 Reviewed-on: https://chromium-review.googlesource.com/1166157Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
George Burgess <gbiv@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#581372}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/181422428b90..b19466d75e3f git log 181422428b90..b19466d75e3f --date=short --no-merges --format='%ad %ae %s' 2018-08-07 primiano@google.com Merge "Fix brush interaction" 2018-08-07 fmayer@google.com Merge "Expose peer_pid on Linux and Android via UnixSocket." Created with: gclient setdep -r src/third_party/perfetto@b19466d75e3f The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I787a554f6221129b2a03fea00f7c01627c5c0c23 Reviewed-on: https://chromium-review.googlesource.com/1166043Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581371}
-
Wenzhao Zang authored
The "installed" event is fired when ArcAppListPrefs::Observer::OnAppRegistered is called, which is the time that |launchApp| can be used to actually launch the app. Bug: 819404 Change-Id: If874607a351fb2e0e24637c7b6b4c1013b6812ae Reviewed-on: https://chromium-review.googlesource.com/1152703 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#581370}
-
Matt Wolenetz authored
If using video/webm for an audio codec/stream, some user agents will say the type is unsupported where otherwise it would be if it were audio/<bytestream-format> for the same codec/stream. This change makes the types in audio test metadata match the stream types more closely (audio/webm;... and audio/mp4;...). This change also includes a drive-by comment addition to help ensure the audioOnlyTypes in mediasource-util.js remain correct relative to the changeType tests' assumptions that none of the audioOnlyTypes generate timestamps automatically. BUG=871929 WPT issue https://github.com/web-platform-tests/wpt/issues/12336 Change-Id: I768035b817ad46f9f17f7dc681c3f9f5c1dad8e4 Reviewed-on: https://chromium-review.googlesource.com/1166030Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581369}
-
Eric Willigers authored
Device-Memory Client Hints Header shipped in M61. This client header exposes the device Memory to web applications. https://chromium-review.googlesource.com/579795 https://www.chromestatus.com/feature/5741299856572416 BUG=710702 Change-Id: I33213321cb42ce72e6b5dc9594605d63d12f1a01 Reviewed-on: https://chromium-review.googlesource.com/1165046Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581368}
-
Dominik Laskowski authored
The purpose of the origin offset was to adjust window geometry in screen coordinates during display reconfiguration, but this is no longer needed in the upcoming protocol with explicit target display. Bug: b:77972398 Test: None Change-Id: Id346b8c6c1a743975e5f9b075931635ac7697d53 Reviewed-on: https://chromium-review.googlesource.com/1164547Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Cr-Commit-Position: refs/heads/master@{#581367}
-
Ned Nguyen authored
along with the "rebaseline-expectations" subcommand in blink_tool.py. Also clean up the remaining references to NEEDS_MANUAL_REBASELINE left from https://crrev.com/c/1140927. Bug: 621126, 738152 Change-Id: I33c109e4343e7bf41aac6e7527237702e4cce94a Reviewed-on: https://chromium-review.googlesource.com/1164405 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#581366}
-
Lei Zhang authored
The checkout that was in third_party/deqp/src has moved to third_party/angle/third_party/deqp/src. Change-Id: Ia1b99361cc93c8e8323bc4ea82fc1316e2e59ed3 Reviewed-on: https://chromium-review.googlesource.com/1166144Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#581365}
-
James Cook authored
The tap visualizer mojo app creates a fullscreen widget in the overlay container. It draws "tap point" circles in that widget. When the display work area changes (for example, after display rotation) the widget needs to be resized. Add a layout manager that handles the resize. In theory we should do this for maximized and pinned windows as well. However, I'm limiting it to fullscreen windows because I intend to backport the fix to M69. (The bug is a user-visible regression that affects recording demo videos on detachable and tablet devices.) Bug: 869130 Test: ash_unittests, enable "Show taps" in about:flags, rotate display, tap near the bottom of the display Change-Id: If54c65e2964f2a709c707e255c1b80d8e16666d9 Reviewed-on: https://chromium-review.googlesource.com/1165956Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#581364}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I948b0310563d88cd52bc5a96b0fd67469d8edffd Reviewed-on: https://chromium-review.googlesource.com/1166200Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#581363}
-
Alex Newcomer authored
There is a bug where users can keep their clamshell mode context menu open by detaching the keyboard. This allows users to have a side shelf in tablet mode, and they may get stuck in this state. This CL fixes the bug by explicitly closing menus when tablet mode state changes. Bug: 870469 Change-Id: I72bb42733000077947219f5868d32615738ab80d Reviewed-on: https://chromium-review.googlesource.com/1165699 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#581362}
-
Elly Fong-Jones authored
The inverted background tab design doesn't work at all with pre-Refresh tabs. Bug: 870844 Change-Id: I598b92ed8d6e8fa8b586166fb7352df1d13c8360 Reviewed-on: https://chromium-review.googlesource.com/1163316Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#581361}
-
Weilun Shi authored
Enable the .png image upload by default. Change the options drop down menu to only have one option with hardcoded string "*.jpeg, *.jpg, *png". Screenshot: https://screenshot.googleplex.com/1sd8JoBoM14.png https://screenshot.googleplex.com/5mnsxOtRxJD.png Bug: 864303 Change-Id: I3b041d0f4e08898fa0c6998742a8ce04065ab5ac Reviewed-on: https://chromium-review.googlesource.com/1166027 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#581360}
-
Fredrik Hubinette authored
This reverts commit 5e61a5b7. Reason for revert: Seems to be calling LSAN problems on linux: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29 BUG: 871986 Original change's description: > Handle legacy camera app in consolidated icon > > This CL does 2 things: > 1. Hide legacy camera app icon > 2. Launch legacy camera app (com.android.camera2) when > com.google.android.GoogleCameraArc is not available. > > Sometimes when devices are upgraded from version with Camera2 installed, > GCA still has com.android.camera2 as the package name. That's why this > CL is needed. > > Bug: b:112121210 > Test: Tested on nautilus that after this CL, the legacy camera app icon > > Change-Id: I16e4d29d4cb538bd2ad6607456bcf4667be1f188 > Reviewed-on: https://chromium-review.googlesource.com/1127899 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Sheng-hao Tsao <shenghao@google.com> > Cr-Commit-Position: refs/heads/master@{#581047} TBR=stevenjb@chromium.org,shenghao@google.com Change-Id: Ibd24eb5f9821e23a3986fbabc45db3d3ed14c81b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:112121210 Reviewed-on: https://chromium-review.googlesource.com/1166004Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#581359}
-
Min Qin authored
When browser is not fully running, Profile cannot be accessed. This CL also disables the use of toast as it is very expensive when full browser is not running. BUG=695115 Change-Id: I7560e3684307741e0a1ba01ec8efec0ff97fdbc4 Reviewed-on: https://chromium-review.googlesource.com/1165849Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581358}
-
Mike Klein authored
There ought to be one small layout test diff, https://test-results.appspot.com/data/layout_results/linux_trusty_blink_rel/34136/layout-test-results/results.html Change-Id: I3468dff4ae22a7ea9b9d38b7e3896b33f65b7666 Reviewed-on: https://chromium-review.googlesource.com/1165831Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#581357}
-
Xing Liu authored
This class adds the required infrastructure to generalize sharing across content types. This comes down to adding an async API to OfflineContentProvider to request the URI (if available) to use in generating a share intent. This also adds the utility class to build the intent from that set of OfflineItems and share info (URI)s. TBR=petewil@chromium.org BUG=850780 Change-Id: If9d5d4f01a8559bec90b7de1adb70c8aaafa9302 Reviewed-on: https://chromium-review.googlesource.com/1105125Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581356}
-