- 22 Aug, 2019 40 commits
-
-
Raymond Toy authored
WebAudio legacy code often does something like: DCHECK(foo); if (!foo) return; The style guide says the if/return should be removed; DCHECK failures should not be handled. Part 3 of N: Update a few more files and for the most obvious cases where we can remove the if/return. Bug: 957654 Change-Id: Ib9f66273db36dc4b6b2333e15ebb965251927c80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763259 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689618}
-
Xing Liu authored
This CL applies the custom time window in schedule parameters to select the notification to show. Also add unit test cases in DisplayDeciderTest. Bug: 991010 Change-Id: I843eff284176635bfaf8ec7ed258b1b9793e299b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755043 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#689617}
-
Sadrul Habib Chowdhury authored
Do not allow running chrome with swiftshader for the rendering benchmark, since the produced metrics wouldn't be generally useful. BUG=988045 Change-Id: I58d765ff056ad220912fc6a1a258c706c09a50c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734190 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#689616}
-
Eric Roman authored
Use 0.0.0.1:1 in place of 0.0.0.0:8000 as the address of the proxy server. The test expects connections to the proxy server to fail - however connecting to the ANY address (0.0.0.0) can succeed. The new literal should fail consistently since: (1) 0.0.0.1 is a reserved IP address. (2) We disallow connections on TCP port 1. Bug: 996367 Change-Id: I54ce278e75983110961da0cc49dd923decdd5ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765662Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689615}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4c55b355580f..7f90416c08be git log 4c55b355580f..7f90416c08be --date=short --no-merges --format='%ad %ae %s' 2019-08-22 ehmaldonado@chromium.org depot_tools: Use git-checkout instead of git-rebase. Created with: gclient setdep -r src/third_party/depot_tools@7f90416c08be The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:996359 Change-Id: I31f04d609746e82cdc60e6ecedaba6f87a2bdeed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765989Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689614}
-
Erik Chen authored
Previously, WebView was created by RenderView, but destroyed by RenderWidget. The call to destory the WebView in RenderWidget was shared with a call to destroy other WebWidget subclasses, even though that semantically represents a very different operation. This CL is a refactor with minimal intended behavior change [slight destruction timing change]. It makes the RenderView both create and destroy the WebView. Change-Id: I1d84f2c5cc1eff9558ffcbf4b5384f2f10a8d71b Bug: 995981, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764757 Auto-Submit: Erik Chen <erikchen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#689613}
-
Justin Donnelly authored
Both are committers, have been on the omnibox team for over a year, and have demonstrated good knowledge and judgement in code reviews. Change-Id: I88c1aa50cff969a4afb6a958e5ac2c01b69a385f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765658Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#689612}
-
W. James MacLean authored
This CL removes existing code that was intended to prevent OOPIF over-rendering by limiting LayerVisibleRect() for the OOPIF's content layer to the viewport intersection sent from the browser. This is being removed in advance of new work to fix the problem by making |device_viewport_size_| on LayerTreeHost a gfx::Rect instead, and having it define the required intersection. Bug: 852348 Change-Id: I15426c08cfc7eb09a99b30811421b0ab613ab8f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764238Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#689611}
-
Bettina authored
There was a check for tests where primary account is not syncing and we should not show a modal warning on password reuse. However, this should not be the case since when not syncing, there is no primary account. Bug: 914410 Change-Id: Ia2ece03990aba58501d207f96c6fd1c5ed5b0abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762829 Commit-Queue: Bettina Dea <bdea@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#689610}
-
Patrick To authored
Bug: 989254 Change-Id: I8f2ad0214cc17c324774e08ee34baba87dae7f42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745502 Commit-Queue: Patrick To <patrto@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#689609}
-
Synthia Islam authored
Add comment like "// this file is autogenerated, do not edit" at the top of the files generated from .mojom files Bug: 609794 Change-Id: I1b39afc0d7c054510f7446af8795e606f07fdfdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757406Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#689608}
-
Jun Cai authored
This CL updates the title icon of the sms infobar based on the mock. I uploaded a screenshot on the issue page Bug: 995434 Change-Id: I428682330936fffc13df19871fc3bf22bfa7e838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761256Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ayu Ishii <ayui@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#689607}
-
Olivier Yiptong authored
After an atomic write finalizes, this applies Mark-Of-The-Web on the resulting file. This is done via the Quarantine component, which on Mac OS X, simply applies some file metadata. On Windows, the Quarantine component may call the AttachmentServices which could start an Anti-Virus check and that may cause the file to be deleted if malware is found. Bug: 986588 Change-Id: Iebefe25abbc32501b55e29bc8196f8a049dee2c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737163 Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#689606}
-
Alex Cooper authored
This adds support to resolve required/optional features against device capabilities as well as sets up the plumbing for appropriately tailored consent. A WPT test for lack of device support was also added, which required updating the tests. Bug: 991605 Change-Id: Ibce6924492311544fd75ca36ed79aa855c943aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757183 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#689605}
-
Shimi Zhang authored
Per AndroidX API design guide, put single abstract method (SAM) to be the last parameter so kotlin could interop with them. Rename removeWebMessageListener() to unsetWebMessageListener(). Bug: 918065 Change-Id: Ief2d7fa80a4cd48185487a39b0463511cc9c6311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764260Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#689604}
-
Jun Cai authored
Per discussion at: https://chromium-review.googlesource.com/c/chromium/src/+/1751966/18/content/browser/sms/sms_service_unittest.cc#458 The SmsServiceTest.SecondRequestTimesOutEarlierThanFirstRequest can be deleted. The test that makes sure there is at most one pending request already exists: SmsServiceTest.AtMostOnePendingSmsRequest https://cs.chromium.org/chromium/src/content/browser/sms/sms_service_unittest.cc?rcl=371f17218c2bd68a8e4ec467f78efb96df8ffa71&l=273 Bug: 996831 Change-Id: I0bf54e959dfb13f81f9ea4ee9f01fde6f5ea52cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764561Reviewed-by:
-
chrome://omniboxMoe Ahmadi authored
Bug: 996516 Change-Id: I741bdc946d07619afa55c45e1cf2969bbd492fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764106Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689602}
-
Bailey Berro authored
- Removes bold weight on network name - Removes unneccessary styling for NetworkTitleText font-color - Removes unneccessary styling for NetworkState font-weight Spec: https://screenshot.googleplex.com/zX25XV2M5pE.png Bug: 996496 Change-Id: I720932a1fc86d44fe9f62431827d428671eccdc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765660 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#689601}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/068af9e416cb..2b39cbe8619a git log 068af9e416cb..2b39cbe8619a --date=short --no-merges --format='%ad %ae %s' 2019-08-22 scroggo@google.com Remove SK_LEGACY_HEIF_API 2019-08-22 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@2b39cbe8619a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: chromium:b/78868457,chromium:b/120414514 Change-Id: I175b234afb8df2e0fd7b3d1fcb73dfbd7f890729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765002Reviewed-by:
-
Eric Seckler authored
Enables startup tracing for child processes spawned by the browser while a tracing session is active. This allows us to collect early trace events in the period of time before the child connects to the tracing service. Bug: 968424 Change-Id: I1708cabae77cdd2ab3a33929c28cfab04eb723e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755746 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#689599}
-
Aaron Leventhal authored
Bug: 990455 Change-Id: If3a06c76d08cc6106c91fc22e542464fefdb8b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763231 Commit-Queue: Jesse Doherty <jwd@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#689598}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/cab59a32b90b..b179babe2c3e git log cab59a32b90b..b179babe2c3e --date=short --no-merges --format='%ad %ae %s' 2019-08-22 saklein@chromium.org uprev_lib: Fix chrome ref/version parsing. Created with: gclient setdep -r src/third_party/chromite@b179babe2c3e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I8e0a93b874f90c5628f441beba81492cef837cca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765001Reviewed-by:
-
Daniel Rubery authored
This CL adds the code to manage BinaryUploadService instances per-profile, and upload files to them. This is currently behind an off-by-default Feature, since the enterprise policy isn't landed yet. Bug: 980784 Change-Id: Ie3454cd653311bbdc2d009aa5237c32046d38f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742776 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Brett Kilty authored
PushBuffer had a DCHECK that could be hit in some startup scenarios where there is no data to push (Hit in Bluetooth connect cases here). Zero is the error return from the OnMoreData call, so we should propagate the error and return in the production codepath as well. Bug: internal Test: local build and test against case that was hitting this. Change-Id: Ia9e55bfc9b426399e70753604d0b0118a2070990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729055 Commit-Queue: Brett Kilty <brettk@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Brett Kilty <brettk@google.com> Cr-Commit-Position: refs/heads/master@{#689595}
-
Ali Juma authored
When a load fails while offline, and an offline version of the page is available, two loads are currently performed: a blank error page is loaded (driven by ErrorRetryStateMachine) and an offline readling list page is loaded (driven by OfflinePageTabHelper::PresentOfflinePageForOnlineUrl). These two loads race with each other. When the second load happens to while the first load is in between didStartProvisionalNavigation and didCommitNavigation, then a didFailProvisionalNavigation is triggered for the first load, and WKWebView's URL is reset to the value it had before that load (which happens to be a placeholder URL). This URL change is incorrectly interpreted as a location.replace call in webViewURLDidChange, which ultimately leads to a placeholder URL being displayed in the omnibox instead of the URL of the offlne page. This CL prevents this race by eliminating the load of the blank error page in this situation. Change-Id: I3e951ed4356b7b1e1efa2b96077f22ad74af60ce Bug: 980912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754511 Commit-Queue: Ali Juma <ajuma@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#689594}
-
Christopher Cameron authored
This most notably includes tearing out AppsPageShimHandler, which then allows us to remove much of the complexity from AppShimHostManager. This will allow cleaning up much of the complexity of the AppShimHost and ExtensionAppShimHostHandler classes (which will then allow sharing a single shim process between multiple profiles). Bug: 982024 Change-Id: If8be5323a29502cc447cd3cf4134fac6b53ec834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757370Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Bettina authored
For non-syncing users, we use the SecurityEventRecorder to record an event when users use to Protect Account on receiving a Password Protection warning. https://screenshot.googleplex.com/Jc9TGRxqCkf Doesn't have any events in the screenshot because the Recorder is WIP still. Bug: 914410 Change-Id: I5a451ca9f2518362a72a858ab78d561c0c0b82df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764790Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#689592}
-
Justin Cohen authored
Bots rolled with the following script: git grep -l '11m382q' | xargs sed -i '' -e 's/11m382q/11m392q/g' This CIPD package only includes iOS 12.2 and iOS 13 to conserve disk space, so cronet (which still tests on iOS 9, 10 and 11) was not rolled to beta 6. CIPD packages: infra_internal/ios/xcode/mac 11m392q infra_internal/ios/xcode/ios 11m392q Bug: 995797 Change-Id: Ie375b0bb61989d87c3ba6cf883bf7bf32f5b6b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760286 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#689591}
-
Jun Mukai authored
Currently the wayland code sends the new bounds immediately when the bounds changes, but this might happen during the display change and the display change can be delayed since multiple method calls happen in a single change. This CL also delays sending the bounds change if it happens during the display change -- the remote shell now stores the pending requests and flushes all pending ones right after the display changes are sent. Bug: b/130897153, b/134776218 Test: todo Change-Id: Id7eb2b7c1a3c16d2f105bfe6adc37fc7bb2e3ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760281 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#689590}
-
Xiaocheng Hu authored
Bug: 978682 Change-Id: I428f84d516cf5ab4df8aa754f406008c034b6e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764793Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#689589}
-
Hans Wennborg authored
Extra changes in this update: - Update the released clang version to 10.0.0. - Move -momit-leaf-frame-pointer next to -fno-omit-frame-pointer since that's where it logically belongs. clang started warning on momit without fno-omit after r365860, but it stopped doing this again in r368728 so this change is no longer needed for the roll. But it's still a nice cleanup. - A file in the profile runtime with static init was renamed, do that in the check - Disable new -Wno-implicit-float-conversion warning - Remove ifdefs for plugins using new ErrorOr API in clang - Remove -Wno-error=return-stack-address flag for ToT builds. - Replace llvm::make_unique with std::make_unique in clang plugins for LLVM r369130, remove LLVM_FORCE_HEAD_REVISION ifdefs TBR=dprake Binary-Size: crbug.com/992372, compiler update adds 32KB, seems reasonabe Bug: 983371 Change-Id: Icdcbd70adec2548a2bf8222df15560e70ce32d1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763261 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Malay Keshav authored
This patch adds method to WebUIDataSource class to allow overriding of worker-src. This is needed by webui that implement lottie on a web worker and initialize them using a blob url. Bug: 976057 Test: Manually tests this and dependent changes by navigating to OOBE Change-Id: I504cf603baeb4f804a60dd5916a552d63f44602e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764629Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#689587}
-
Pavel Yatsuk authored
The feature was approved for stable rollout in crbug.com/955951 R=jwd@chromium.org Change-Id: I78bb35573a5078c8126af8a37e52314d27520df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765988Reviewed-by:
-
Peter Kasting authored
This removes four entries from the tab context menu; changes the text on several others to stop saying "tab(s)" explicitly; adds one entry to the frame context menu; and changes the bookmark-related menu entry strings from "page" to "tab" for consistency. Most of the file changes here are due to renaming enums/APIs to match the string changes. Bug: 515930 Change-Id: I22415f21936c6162494cfbe84fea24cf29282d90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761666Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#689585}
-
Nico Weber authored
Bug: 961769 Change-Id: I866e83728d107203edfeea0ce6bdebebaa128eef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1765869Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#689584}
-
Regan Hsu authored
Modifies update_engine_client to process an additional optional integer parameter representing the number (if it exists) of milestones until end of life. (See https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/1759285) Bug: 994999 Change-Id: I0ae17d9f8022a9897b16b8529da89eb6f3938924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758979 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#689583}
-
David Black authored
The ProactiveSuggestionsLoader is tasked with downloading proactive suggestions on behalf of Assistant's ProactiveSuggestionsClient in the browser. Note that this CL removes ProactiveSuggestionsClientObserver in favor of ProactiveSuggestionsClient::Delegate, as there is only a single entity in ash (AssistantSuggestionsController) that will need to bind to the ProactiveSuggestionsClient to respond to its events. This makes it easier to pass ownership of objects through the delegate pipeline. Bug: b:139199715 Change-Id: Ic67fda79ea15c9e822244be8aa43ccd7ada83904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758738Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#689582}
-
Tetsui Ohkubo authored
Based on the discussion in https://crrev.com/c/1743869, we decided to add autotestPrivate.swapWindowsInSplitView() instead of using automation API in Tast. Tast side CL: https://crrev.com/c/1716679 TEST=arc.SplitView BUG=135150701 Change-Id: I9e96b01daf0c8c84dc77363727dd4e38244562c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758037Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#689581}
-
Andy Paicu authored
Many users find the fact that the warning message is displayed on every startup annoying (https://support.google.com/chrome/thread/11549634?hl=en) This CL adds a 14 day cooldown period for the warning after it is dismissed. Bug: 918428 Change-Id: I358b1646c797d48e12c1b2718d3f8631483736d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761592Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Anthony LaForge <laforge@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689580}
-
Mohamed Amir Yosef authored
With the recent introduction of FakeServerInvalidationSender which excerises FCM-based invalidation production code, the FakeServerInvalidationService isn't needed anymore. Change-Id: I18b8eba337c27d9d3f7a5d12dd101ed5aea0c38f Bug: 985287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758242 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#689579}
-
