- 02 Oct, 2019 40 commits
-
-
Geoff Lang authored
When running on top of ANGLE, ES2 contexts are often used because the exact context version requested is returned. BUG=989194 Change-Id: Iedd673a7c5bee7a291991145f3f7d30552b34d54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727169Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702006}
-
Annie Sullivan authored
This had been missed when updating FirstInputDelay over the summer. Change-Id: I9f635708265c009b4e89d1152c3388a499a78858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834116Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Annie Sullivan <sullivan@chromium.org> Cr-Commit-Position: refs/heads/master@{#702005}
-
Justin Cohen authored
This reverts commit ceff1a21. Reason for revert: Fixed. Original change's description: > Revert "[ios] Enable preload with slim-navigation-manager." > > This reverts commit 101b5ae0. > > Reason for revert: Needs some more work, some last minute > refactoring introduced some crashes. > > Original change's description: > > [ios] Enable preload with slim-navigation-manager. > > > > Previously, preload required CopyStateFromAndPrune and > > CanPruneAllButLastCommittedItem within NavigationManager, but those > > are not supported with SlimNav. Here, preload is implemented by > > creating a preload WebState with navigation history by restoring the > > current WebState. > > > > The performance of this implementation depends on Slim > > Navigation Manager's session restoration performance which can be > > measured with existing kRestoreNavigationTime metric. > > > > Original implementation of this CL was written by eugenebut@, > > simply updated in this resurrected CL. > > > > Bug: 834116 > > Change-Id: I86c9ecf7e3ed213ebaeddce6264dff3bbb8a8c94 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815702 > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#701228} > > TBR=rohitrao@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,gambard@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 834116 > Change-Id: I16beb96bc2d1eab9a9c36a8e03728fd3cc23f035 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833743 > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701746} Change-Id: I52889208ed3a84c08c66742e72b524adce0560af Bug: 834116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833706Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#702004}
-
Tim van der Lippe authored
This issue went unnoticed because of two different CLs touching the same kind of code in unrelated parts of DevTools. It is likely that no tests covered this codepath, blocking one of the CLs from being submitted. Bug: chromium:1006759 Tbr: yangguo@chromium.org Change-Id: If3ef1d86e3ab1d887ece3372649705c96e0b0ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834144Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org> Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#702003}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8d2930613094..cf0a9a628490 git log 8d2930613094..cf0a9a628490 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@cf0a9a628490 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: Ic359821741312538e99e24d499d38f02f2556da0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834670Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702002}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17fcc592..3dc289df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I990fa92ded61f5977b00d18392ca308dfe34acf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835293Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#702001}
-
Geoff Lang authored
This reverts commit c8b3d68a. Reason for revert: <INSERT REASONING HERE> Original change's description: > When binding an image to a texture, make sure the texture is bound. > > The the passthrough command decoder did deferred image bindings, it didn't > ensure that the correct GL texture was bound first. This caused canvas -> > WebGL copies to fail when they are using IOSurface backed canvases. > > BUG=990368 > TBR=true > > Change-Id: I5d555c7a715d0f47382053840c3db78576dc4e82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819520 > Commit-Queue: Geoff Lang <geofflang@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: Geoff Lang <geofflang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#701645} TBR=zmo@chromium.org,geofflang@chromium.org,khushalsagar@chromium.org Change-Id: I0b62b0c97243c76eec8364f2e5a2220466e999e3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 990368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835193Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#702000}
-
Fredrik Söderquist authored
This test doesn't appear to be flaky any longer. Tbr: schenney@chromium.org Bug: 981522 Change-Id: I5d39dd67cec50c6e467417dca38d112660f1012d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834350Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#701999}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 1010472 Change-Id: Idd6a3e1a0c13241801d93cb8956aa406b4713fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835698Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701998}
-
Arthur Hemery authored
Excluding a few extra tests that are currently failing on the android_bfcache_debug fyi bot. Bug: 1007276 Change-Id: I8f80af27b6f0deee4dff340d1e1befbdab68a315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835613 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#701997}
-
Benedikt Meurer authored
The eager evaluation when hovering expressions only works sort of reliably inside the innermost scope anyways (even there we have cases where we get it wrong), so in order to avoid confusing the developer, limit it to the innermost scope for now. Bug: chromium:995036 Change-Id: I6c44326ee5794df1ea6574cd6cf510419b6f4cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835357Reviewed-by:
-
Arthur Hemery authored
Excluding a few extra tests that are currently failing on the android_bfcache_debug/linux_bfcache_debug fyi bots. Bug: 1007276 Change-Id: Idc7a94f2fb67446537ea1d32f9fbe027519d903e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835364 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b4eef2d93601..9bdb26527d65 Created with: gclient setdep -r src-internal@9bdb26527d65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I46456857e4ef2cdebf1e898fa878cf5865b86883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835468Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701994}
-
Henrik Boström authored
See bug. TBR=dmurph@chromium.org, mpearson@chromium.org, rockot@chromium.org, mek@chromium.org, jam@chromium.org Bug: 1010414 Change-Id: I4a87b8873a878cedeaf5d87bc62474a2adaa1444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834088Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701993}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9682cc2dc22..2458b31208f8 git log d9682cc2dc22..2458b31208f8 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@2458b31208f8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I7047f009b2e11ba115589d9095fd481495109026 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835465Reviewed-by:
-
Henrik Boström authored
See bug. TBR=huangdarwin@chromium.org, sky@chromium.org, dcheng@chromium.org, staphany@chromium.org Bug: 1010415 Change-Id: I0d0ec9fbeac9af7e2f3cc60e723fffcd9ca83d73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835501Reviewed-by:
-
Maksim Ivanov authored
Allow this API to be called by extensions/apps more frequently than it used to be, in order to not confuse the user with the sudden breakage of PIN requests in the legitimate scenarios (see the bug for the examples). The quota is still preserved in order to protect the user from being spammed by a misbehaving app/extension, but it's changed to the combination of these two restrictions: * no more than 10 calls per minute; * no more than 30 calls per 10 minutes. (Note that this does NOT count the cases when the extension makes a repeated call to re-request a PIN in the same dialog.) Bug: 1010459 Test: (1) repeat 10 times an attempt to log into Chrome OS via a smart card, check that the PIN request is shown each time, and abort it; (2) go into user session, repeat >10 times opening a website that uses client authentication via a smart card, abort each PIN request and check that eventually the PIN requests aren't shown anymore. Change-Id: I1c322e98c2c2578307f3372b07663a495f3e2a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835614Reviewed-by:
Igor <igorcov@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#701990}
-
Javier Ernesto Flores Robles authored
Adds a simple view controller and coordinator for the password breach screen. To be tweaked once UX is done with the details. Bug: 1008862 Change-Id: I3cc49d5de7f33e453a4a9504b7d976672427a71c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832817 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#701989}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/dc9f1e680699..867f72058a4f git log dc9f1e680699..867f72058a4f --date=short --no-merges --format='%ad %ae %s' 2019-10-02 enga@chromium.org Add missing "strlen" parameter for Device InjectError command. 2019-10-02 enga@chromium.org dawn_wire: Only generate has_member for optional members Created with: gclient setdep -r src/third_party/dawn@867f72058a4f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: chromium:1004368,chromium:1009166 Change-Id: Idf72b8fa81d01508217bd08fa25cbcd625f34dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835277Reviewed-by:
-
Philip Jägenstedt authored
Based on https://chromium-review.googlesource.com/c/chromium/src/+/1833804/: > Using wpt-import in Chromium 8c798c26. > With Chromium commits locally applied on WPT: > 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" > ab4b7009 "[Native File System] Aborting a directory iteration succeeds" > 8d24de75 "Port rotate-interpolation.html to wpt" > c19433ef "Reland "[ChromeDriver] Stop using --ignore-certificate-errors"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Bug: 1010422 Change-Id: If498cede6b6873bb5069d49c34610fedcbd6e1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835611Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#701987}
-
Oleg Davydov authored
ContentHash::Status enum has three values assuming that having valid verified_contents.json is mandatory intermediate step on a way to get full ContentHash. We can simplify code a bit by removing this intermediate stage from enum (and replacing remaining two-values enum with just a bool). Also this will simply things a little for self-hosted extensions (which don't have verified_contents.json, but still have to be checked for corruptions). Bug: 796395 Bug: 958794 Change-Id: Iacbd7a90853b0e30d611c7f0e90eb2d53aea989d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810899Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Oleg Davydov <burunduk@chromium.org> Cr-Commit-Position: refs/heads/master@{#701986}
-
Gyuyoung Kim authored
To reduce pre-processed size of header files have been including find_in_page.mojom-blink.h, this CL replaces .mojom-blink.h with .mojom-blink-forward.h in find_task_controller.h, text_finder.h, and web_local_frame_impl.h. This CL has no behavior changes. Bug: 1001360 Change-Id: I276e5e9c286525a72f3a1998a181a4bcf45f96dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833373Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#701985}
-
Nico Weber authored
Bug: 1010458 Change-Id: Ie36ee1a87e7801fafdbfc2f38c0762ebbf7cace7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835155 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#701984}
-
BUG=762641 TBR=achuith@chromium.org Change-Id: I7eda207ef9e2e0145df4261ed7c87ec2f8934c40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834832Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701983}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dec74f3ff6ec..8d2930613094 git log dec74f3ff6ec..8d2930613094 --date=short --no-merges --format='%ad %ae %s' 2019-10-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8d2930613094 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC rmistry@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmistry@google.com Bug: None Change-Id: I13447be729f7c592d076c831f115faf8b1fb5d00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835252Reviewed-by:
-
Mikel Astiz authored
This patch changes the implementation within NigoriSyncBridgeImpl to avoid reusing the codepath for user-entered passphrases, since there are subtle differences, including: 1. Different observer notifications should be triggered. 2. The selection of the default encryption key is determined via Nigori specifics (sync protocol). Bug: 1834222 Change-Id: Ief85905bb576a82faba515a71c7a6afd9e1612d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834227 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#701981}
-
Javier Ernesto Flores Robles authored
Merge c/b/ui/passwords/credential_leak_dialog_utils.* with components/password_manager/core/browser/leak_detection_dialog_utils.h. Move the strings it uses to components/password_manager_strings.grdp. Move the constants it uses to components/password_manager/core/browser/leak_detection/leak_detection_dialog_constants.* Bug: 1008862 Change-Id: I5766efef92cc343b861baaf4cf66ca8aeb1315f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833473 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#701980}
-
Michael Ershov authored
Extract main part of challenge key flow from extension API to allow calling it without an extension. Bug: 1000589 Change-Id: I4f32eeedc87f3b76511bf471fd3ea7641102bf5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782810Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#701979}
-
David Van Cleve authored
This commit extends metrics coverage to provide more descriptive logging of TLS 1.3 handshakes' 0-RTT state, by logging the ssl_early_data_reason computed in BoringSSL. This records whether TLS 1.3 early data handshake attempts succeed and, if they fail, why. R=csharrison@chromium.org,davidben@chromium.org Bug: 1000659 Test: expanded prior metrics unittests to cover new cases Change-Id: Iaeba249c2be3ddb23900a51f9d223580481421f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1784159 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#701978}
-
Henrik Boström authored
See bug. TBR=michaelbai@chromium.org, changwan@chromium.org NOTRY=True Bug: 1010416 Change-Id: I03df0ab4ea40aecd09511a0129861b439326f577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834085Reviewed-by:
-
Mikel Astiz authored
This separates the codepath for trusted vault keys from the regular user-entered passphrases. This patch covers the plumbing from SyncEngine to SyncEncryptionHandler, which excludes the very upper layers. TODOs have been added to address SyncUserSettings in follow-up patches. Bug: 1010189 Change-Id: I6a01a444018698cd0d75e68bfb83edf3ab72085b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834222 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Henrik Boström authored
See bug for details. TBR=michaelbai@chromium.org, changwan@chromium.org, tobiasjs@chromium.org, jochen@chromium.org NOTRY=True Bug: 1010417 Change-Id: I9a68b4f29a76a1941fe42b9d741e653d9541b00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835499Reviewed-by:
-
Juan Antonio Navarro Perez authored
These will still be reported as regular measurements. Bug: 1003530 Change-Id: I207540eeaa4447b01536ab4205712d0822c1c91a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828904Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#701974}
-
Paul Lewis authored
This adds tests for common/SegmentedRange that broadly match those of the original layout tests. Bug: 1009443 Change-Id: I60a986c2568bd46bb0f9ba64a85b42d24b54b40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831910Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Henrik Boström authored
See https://crbug.com/1010418. TBR=livvielin@chromium.org, jdonnelly@chromium.org, pkasting@chromium.org NOTRY=True Bug: 1010418 Change-Id: Ide19821fa54dc1033c216799352cd37445f5d143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835497Reviewed-by:
-
Adam Rice authored
The WebSocketStream explainer describes being able to pass an AbortSignal object to the WebSocketStream constructor to abort the handshake. This wasn't implemented yet in Blink. Implement it. Bug: 983030 Change-Id: I9d96bf145a4978867dd8ae98a13af9ad9cff752c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827116Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#701971}
-
Yi Su authored
Since we are using Xcode11 beta6 for compiling right now, FontSizeJsTest can be re-enabled. Bug: 983776 Change-Id: Id3a36a9fb5666ff5eca1f20f3c7fad4b194a070b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816497Reviewed-by:
-
Keishi Hattori authored
BodyJsonConsumer::DidFetchDataLoadedString() was binding ScriptValue which is a traceable disallow new type. This shouldn't be allowed as GC fails to trace them. This CL - adds a check disallowing binding traceable disallow new types. - adds WrapDisallowNew() to wrap a disallow new type in a GarbageCollected class, making it possible to be referenced off heap from a Persistent. - fixes BodyJsonConsumer::DidFetchDataLoadedString() Bug: 1009740,1009944 Change-Id: I7b15b46550b9994f0b7982c3508de9c3e7ff66be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833039 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#701969}
-
Michael Lippautz authored
Blink stand-alone GCs are used in testing and on thread termination. Such GCs iterate Blink->V8 references (global handles) to find the corresponding V8->Blink references that should be treated as roots. On WorkerOrWorkletGlobalScope dispose we also clear the DOMWrapperWorld that holds the Blink->V8 references (global handles). In the case a stand-alone GC happens at this point, WorklerOrWorkletGlobalScope is reclaimed. Access through the JS wrapper back references results in UAF. Bug: chromium:1003729 Change-Id: Iba0cb340a2037445947920888596ea7ecf7c32da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833825Reviewed-by:
-
Oleg Davydov authored
Whether we have loaded or not valid verified_contents.json is an internal detail of ContentHash class, which doesn't need to be exposed to clients. The only external usage of this is passing it to ContentVerifier::TestObserver. But TestObserver and its implementations never used this flag since TestObserver introducing in https://codereview.chromium.org/1250473002. Therefore it is possible and makes sense to change it to overall success flag. Bug: 796395 Change-Id: Ibd48b998a4c42d68e30549a4078184179f5593e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810358Reviewed-by:
-
