- 01 Oct, 2019 40 commits
-
-
Michael Liao authored
Changes: - Adding label to search input, number of matches and line number - Added SR functionality for when the search finishes and # of matches Keyboard Nav CL: https://chromium-review.googlesource.com/c/chromium/src/+/1819493 Different ways to read search result status: https://imgur.com/koruZRk Bug: 963183 Change-Id: Ia5dc1608d3cffe3c6164f15da895896b4191b008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613675 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#701635}
-
Sylvain Defresne authored
base::Bind/base::Callback are deprecated in favor of either base::BindOnce/base::OnceCallback or base::BindRepeating/ base::RepeatingCallback (depending on whether the callback is invoked once or multiple time). Convert all uses of base::Bind/base::Callback in ui/gfx to the recommended methods/types. Bug: 1007851 Change-Id: Iac0a7b8e9bb05a9f9c3f498bc43c078e0d7ee64e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831862 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#701634}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/7c079f650def..65235d3ae771 git log 7c079f650def..65235d3ae771 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 nisse@webrtc.org Add GetStats at end of PeerConnection quality tests 2019-10-01 nisse@webrtc.org Avoid memcpy in JavaToNativeEncodedImage 2019-10-01 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision aa4c7d6a..443491f4 (701411:701518) 2019-10-01 nisse@webrtc.org Delete old placeholders for moved api/ header files Created with: gclient setdep -r src/third_party/webrtc@65235d3ae771 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: Ida0c6a0e838a58148f9f4428d08f6ff134f58b69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833288Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701633}
-
Trevor Perrier authored
This CL changes the Lite mode FRE to include a "Learn more" link that points to the Chrome Lite mode help documents. This uses p-link "lite_mode" The wording on the FRE page has also been changed to make indicate that Lite mode sends web traffic to Google. Bug: 997248 Change-Id: Idb2f69ecfefe68f1a5f6d8052d393d213283e64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830106Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#701632}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: I06b679d48413f0b30bc72fe88b199205c6b37429 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834061Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701631}
-
arthursonzogni authored
Add regression tests for https://crbug.com/1003167. This checks what happens with cookies in iframes when using special URLs like about:srcdoc, about:blank, and data-URLs. This checks normal navigations and history navigations. This is able to trigger the DumpWithoutCrashing() in: network::RestrictedCookieManager::ValidateAccessToCookiesAt Tests= - NavigationBaseBrowserTest.CookiesInheritedSrcDoc - NavigationBaseBrowserTest.CookiesInheritedAboutBlank - NavigationBaseBrowserTest.CookiesInheritedAboutBlank2 - NavigationBaseBrowserTest.CookiesInheritedDataUrl Bug: 1003167 Change-Id: I73b9e62021490cfb74caf49c32009171dd9bea00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831762Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#701630}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: I184d6bdef8cc39577faab29f9b7b87314cf5776f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833900Reviewed-by:
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: Ie2519fec6a3faaf65437dcc218699b5b8a666fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833294Reviewed-by:
-
Xiaocheng Hu authored
NoTry: True Tbr: eae@chromium.org, futhark@chromium.org Bug: 825895 Change-Id: I4b483d2960c216f4dd99a38d3004b9ac9a1df3d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833907Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#701627}
-
Ryan Hansberry authored
Owners of a BluetoothDiscoverySession may delete the object upon receiving confirmation via callback of stopping it. Move all necessary calls to clean up internal state to before these callbacks are invoked. Bug: 1007594, 490401 Change-Id: I113820c818b07eb9695842f8ee2a93ccc03945b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833045Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#701626}
-
Etienne Bergeron authored
This CL is extending the duration of the histogram until the FontLink code for removed. "FontFallback.GetLinkedFonts.CacheMissTiming" "FontFallback.GetLinkedFonts.FontCount "FontFallback.GetLinkedFonts.Timing" Adding drott@ as metrics owner since it's better to have two owners for histograms. R=asvtine@chromium.org Bug: 1006980 Change-Id: If78758fc68a3e9ebfda3b4e0d5cd96d558ccd3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829789 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
-
Theresa Wellington authored
BUG=1009781 Change-Id: I44d3f515e32eba65a558cd970825f387c51ede5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833894 Auto-Submit: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#701624}
-
Alex Keng authored
This change fixes a bug for <color> where the color-viewer (The big circle to the left of the 'hue slider', color-selection-rings (the small circles on 'color well' and the hue slider), and the colored rectangle of the in-page color control are black due to the auto adjustment from the forced color mode. The fix is to turn off the auto adjustment for these particular UI elements when high contrast mode is enabled. The test controls-new-ui-high-contrast/color-picker.html is also updated (based on controls-new-ui/color/color-picker-appearance-color-well-click.html) to verify that selected colors are correctly shown in the high contrast mode. Bug: 994219 Change-Id: I51c73b3ba2b30010bf1388fc67a07d0033090e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832608 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#701623}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cf9b9029..5a8a51c2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic9b033fca913dc08d8e42875bfd72781cdf96762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833801Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701622}
-
Kyle Horimoto authored
Prior to this CL, the dialog title was missing when configuring a network. This was caused by [1], which renamed the |type| property to |type_| instead, but did not also update the HTML to reflect this name change. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1803724 Bug: 1009409 Change-Id: I4bbb10d1fad65cd6b94da8e8248852205565cf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832628 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#701621}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010061 Change-Id: I741e49ba958631aa46dd9a77995a5060ce12b200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832913Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 99c3aa1b. With Chromium commits locally applied on WPT: 03ccd4e9 "html: Move autofocus tests to html/interaction/focus/the-autofocus-attribute/" ab4b7009 "[Native File System] Aborting a directory iteration succeeds" 8d24de75 "Port rotate-interpolation.html to wpt" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/i18n external/wpt/css/css-text/line-break external/wpt/css/css-text/overflow-wrap rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If0484606f7cfda539717e167c269c1e7f405600d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833761Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701619}
-
Sorin Jianu authored
This change has no effect on the component updater since the component updater uses CRX ids derived from their public key hashes. chrome/updater is using Omaha-style app_ids that don't look like extension CRX ids. Therefore, chrome/updater needs the app_id value from CrxComponent. TBR=waffles@chromium.org Bug: 1001126 Change-Id: Ibb32637a03d4b4167f603873822f492295a55835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832325 Commit-Queue: Sorin Jianu <sorin@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#701618}
-
Xida Chen authored
TBR=jyasskin@chromium.org NOTRY=true Bug: 1010119 Change-Id: Id12b237e6659a80b27a510358ba661dcee6440cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833892Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b689fa536c9b..9203f768126d git log b689fa536c9b..9203f768126d --date=short --no-merges --format='%ad %ae %s' 2019-10-01 fmayer@google.com Merge "remove duplicate assignment" 2019-10-01 lalitm@google.com Merge "ui: migrate all slice queries to use track_id instead of ref/ref_type" 2019-10-01 fmayer@google.com Merge "Print problems with profiles in new pprof converter." Created with: gclient setdep -r src/third_party/perfetto@9203f768126d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0ff972542a87f609198c3060046da77aa54ecafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833516Reviewed-by:
-
Francois Doray authored
This change converts IDBFactory mojom interface client in blink to use BrowserInterfaceBroker. This is a prerequisite to keep track of the execution context associated with each transaction in the browser, which is required to opt-out of page freezing frames that hold IDB transactions. Bug: 936482, 980533 Change-Id: I9f5ad10532da91a772078e253dd0cb92a8c34e77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815852 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#701615}
-
John Chen authored
This is a reland of 8f486945 Original change's description: > [ChromeDriver] Stop using --ignore-certificate-errors > > ChromeDriver was passing --ignore-certificate-errors switch to Chrome, > regardless of whether user wants to ignore certificate errors or not. > Fixing by stop passing this flag to Chrome, and relying on using > Security.setIgnoreCertificateErrors command when user wants to ignore > certificate errors. > > Bug: chromedriver:3148 > Change-Id: I5e8493f4cca48ebaeb211c95cd7fd645891c8659 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824005 > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: John Chen <johnchen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#699890} Bug: chromedriver:3148 Change-Id: I96ce5e6746af65e01407e7c6c92fed7428d686ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829802Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#701614}
-
Askar Aitzhan authored
Chrome Reporting API requires those fields to be set, otherwise the request get rejected. Bug: 1006757 Change-Id: If39bd56287719579ba1067488a38c2216eed5ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814830 Commit-Queue: Askar Aitzhan <askaraitzhan@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#701613}
-
Andrey Shponko authored
If the order of notifications is inverted we should use the bounds of the latest notification popup to determine if the next popup will fit. Change-Id: I90fd83278175c068e6bf65121f8b2f834e044ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827005Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#701612}
-
Tommy Steimel authored
This CL adds a circular colored background to dismiss buttons in the GMC dialog. This fixes a contrast issue where the X was not always visible against the media artwork. Bug: 1006049 Change-Id: Ib56353437fce6e4ec1ad8e15268e5bbbb284607c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829537Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#701611}
-
Stefan Zager authored
BUG=1009201 R=dcheng@chromium.org Change-Id: I85655f4de68dea44f213fe819742fdcaf44d2775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831260Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#701610}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3044c24181e9..2a412ea20590 git log 3044c24181e9..2a412ea20590 --date=short --no-merges --format='%ad %ae %s' 2019-10-01 chrisforbes@google.com Remove array restriction from EOpEqual, EOpNotEqual Created with: gclient setdep -r src/third_party/swiftshader@2a412ea20590 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/141916742 Change-Id: Ib430f9a3b610676469195e4caf33cc01c2df76c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833762Reviewed-by:
-
Lily Chen authored
This change makes the named test work under SameSiteByDefaultCookies and CookiesWithoutSameSiteMustBeSecure. Namely, any cookies accessed in a third party context must be marked with the attributes "SameSite=None" and "Secure". Bug: 1006816 Change-Id: I9eb7e46df890a7ac520768a4b2ba3b15f654462c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833742Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#701608}
-
Lukasz Anforowicz authored
Bug: 980641 Change-Id: I6dced7cfeb0532afdf9440989bce3afacc426a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833633Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#701607}
-
kdillon authored
The console message should point developers towards the status entry for more context as well as some alternative solutions. Bug: 827324 Change-Id: I5043eea620903089000b4dace14fb62403dda342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832660Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#701606}
-
Anastasiia Nikolaienko authored
Account Manager is enabled by default now. Merge ArcAuthServiceAccountManagerTest to ArcAuthService tests. Bug: 912537 Change-Id: Icfe560f097a449ed2e6b62c16b13c3c39ca6a8cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824101Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#701605}
-
Nico Weber authored
TBR=hans Bug: 1010111 Change-Id: Ic6fb5a4a1ff065ff1f6fff3c8c0bdf7d8fbdd50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832498Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#701604}
-
Xida Chen authored
TBR=hbos@chromium.org NOTRY=true Bug: 849670 Change-Id: Ib3d14f2ea1b6e812e5f57bd30d26953a6dba700c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833901Reviewed-by:
-
arthursonzogni authored
This is intented to be merged into M78. Bug 1003167 is intented to be fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/1829350/ but we are not confident enough for merging it into M78 beta. A lot of users are triggering this DumpWithoutCrashing(). To save their resources, this patch remove it temporarily. It will be added back with in M79 after a fix is landed. Bug: 1003167 Change-Id: I17abcaebc3a6177c45a193ad47c4c731b340d12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832816Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#701602}
-
Koji Ishii authored
This patch changes |NGLineBreaker| to include empty or space- only trailing spans into the line. Such spans were thought not observable, but it turned out that they are in a few cases; e.g.,: a. The space is wrapped in an inline box with borders; e.g., text<span style="border: 1px solid"> </span>text b. When it is not collapsed (e.g., `pre-wrap`) and is in an inline box with background. Open tags are in most cases not-trailable but sometimes they are. Before this change, |NGLineBreaker| assumed open tags are not-trailable, and handles exceptional cases separately. This patch changes open tags to be trailable. Then non- trailable open tags were removed after the line breaking was determined. With this chagne, the rare logic runs only once for each wrapped line. This patch: 1. Split over-loaded `kTrailing` state to `kOverflow` and `kTrailing`. This simplifies the conditions when each state can transit to other states. 2. Re-implemented negative margins[r674177]. The logic became simpler because open tags are now trailable by default. 3. Re-implemented hanging trailing space fix[r674430]. In addition to the fix, this patch handles trailing spaces in a span. We do not handle multiple space nodes yet as in TODO(crbug.com/1009936) comment, but this change moves one step closer to support it. [r674177]: https://crrev.com/c/1684243 [r674430]: https://crrev.com/c/1662451 Bug: 1001241, 1003184 Change-Id: Ife2f8470a510f6e006da9d2397df5c5153e3abd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1826063 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#701601}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/563255c6577d..2a383228fbdd Created with: gclient setdep -r src-internal@2a383228fbdd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Id320ae13e6aedfa00c98a705126f13c90fdf8bb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833119Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#701600}
-
Matthew Mourgos authored
This change unifies the shelf colors by moving shelf color calculation into ShelfConfig, to be accessed with ShelfConfig::Get()->GetDefaultShelfColor(). The base color for the shelf is calculated using colors from AshColorProvider and wallpaper_controller. Bug: 1008700 Change-Id: If25805e613d4f47ecb834ac5a2912b22688fe5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1823603Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#701599}
-
Pavel Shmakov authored
This is a quick fix. Generally this class can be made less error-prone e.g. by collecting the code that should run only when mView != null into an inner class, where mView would be non-null and final. Change-Id: I69d5beb01baec7f7e8cbec1b3013d461d45d03f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832216Reviewed-by:
-
Xiaocheng Hu authored
https://github.com/w3c/csswg-drafts/issues/94 made a resolution that "Any math expression of a complex type is treated as auto. Simple typed things continue to work as today." This patch adds new tests and revises existing tests to reflect the resolution. Bug: 382725 Change-Id: I522799b51fdd4a7cfa66e137ae31c68aaf2dea73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832619 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#701597}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ic45946b3d2af90edfb65ab60cb68de39f985900f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1833781Reviewed-by:
-
