- 18 May, 2019 14 commits
-
-
Collin Baker authored
This reverts commit 63ac6323. Reason for revert: base_unittests failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/43060 Original change's description: > Promises: Implement Promise<> handle with Then and Catch > > Implements Then and Catch on top of AbstractPromise as well as > ManualPromiseResolver<> which is needed for testing at this > stage (PostTask doesn't yet return a promise). It's also > necessary for promises to interface with old style callback > based libraries which are extremly common in Chromium. > > Design: https://docs.google.com/document/d/1l12PAJgEtlrqTXKiw6mk2cR2jP7FAfCCDr-DGIdiC9w/edit > > Bug: 906125 > Change-Id: Id7206698f37c59cfc201f3970cbf66a2ef89ee4e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599620 > Commit-Queue: Alex Clarke <alexclarke@chromium.org> > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#661045} TBR=fdoray@chromium.org,alexclarke@chromium.org,etiennep@chromium.org Change-Id: I52dc57a8ba9515ea68101f5e16b1f92a926e594d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618077Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#661122}
-
David Grogan authored
RecalcVisualOverflow might be trying to read a cell that's been removed from the tree. I've not been able to get this to repro on android or linux. Bug: 956625 Change-Id: I1353bd537245fc458e9eeec48bd8861b70364cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617559Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661121}
-
chrome://omniboxOrin Jaworski authored
This CL makes it possible to use chrome://omnibox as a batch query processing tool, transforming an input set of queries to an output set of exports. This is currently done by detecting the type of import data, but the functionality can easily be wired into dedicated UI elements if we want it to be more discoverable. This CL also fixes a bug in generated export filenames: it was including extra spaces due to code formatting, but now the spaces are removed and the date/time text is shortened to the essentials. Bug: 964528 Change-Id: I09036af82aaf9c4ade9f7dc929c338c85159e77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614711 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#661120}
-
Darwin Huang authored
Bug: 962055, 962083 Change-Id: I374f86ba980484aa7471bdded7dad2b36e0d78fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618155 Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#661119}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a777e434. With Chromium commits locally applied on WPT: c4dc3441 "[WPT] Reland Upload a test for sending mouse events with key pressed" fec827fb "Added wpt tests for overscroll customization." c9077e39 "Restore original tail-processing for ScriptProcessor and AudioWorklet" d814fafc "Check for detached ArrayBuffers in Web Bluetooth writeValue functions" 64cbdf7a "Replace originOffset public member with getOffsetReferenceSpace method" e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iaf0a8b32cfae9968bebe23e2d6a084527dcdc71e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618153Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661118}
-
Kyle Milka authored
Bug: None Change-Id: I7e3aff5d30853dd8c38ab1c7f74c554b76faeef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618144Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#661117}
-
Ravi Chandra Sadineni authored
Notification reporter intends to treat notification as user activity for screen dim and idle timeouts. Thus it notifies powerd whenever a new notification (priority > DEFAULT) is drawn or the one that is already shown is updated. When a notification of system priority is drawn, chrome keeps updating the notification until is cleared by user which results in regular HandleWakeNotification calls to powerd. Thus this can result in screen staying on forever. Let us not do this. In the follow up CL, I intend to notify powerd directly where the notification is created. This way we do not use notification priority that is already overloaded to determine if the screen should stay on. BUG=chromium:964470 TEST=Connect external monitor and make sure screen turns off. Change-Id: I616926994f66982ecb5886f17af85813ee34efe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618047 Commit-Queue: Ravi Chandra Sadineni <ravisadineni@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Auto-Submit: Ravi Chandra Sadineni <ravisadineni@chromium.org> Cr-Commit-Position: refs/heads/master@{#661116}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79b19c11139f..1584db48bcf3 Created with: gclient setdep -r src-internal@1584db48bcf3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:891734 TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Iae23373dd45e7c8f333a6652bb76768e177f7924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618072Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661115}
-
Antonio Gomes authored
This is a reland of 81046e57 This is exactly the same as the original CL (crrev.com/c/1594114) that was reverted in [1] but turned out not to be the culprit of the flakiness on the Mac ASan bot. [1] crrev.com/c/1616857 TBR=haraken@chromium.org,guidou@chromium.org,hiroshige@chromium.org Original change's description: > Migrate blink::MediaStreamVideoSource to WTF::Bind > > This CL is the 3rd out of n CLs to convert modules/mediastream/ > away from base::Bind{Once,Repeating} to their respective Blink/WTF > counterparts. > > In this particular CL, a weak reference of MediaStreamVideoSource is > passed to VideoTrackAdapter ctor to avoid double-bind methods with > CrossThreadBind -> ConvertToBaseCallback -> CrossThreadBind. > > R=dgozman@chromium.org, guidou@chromium.org > CC=blink-reviews-vendor@chromium.org > > BUG=923394 > > Change-Id: Ibd75c5fef80bef1a4328c4abb007fb07efbcc095 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594114 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660725} Bug: 923394 Change-Id: I8368328d8a57da0145b96e4c24d8469061952ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618381Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#661114}
-
Sunny Sachanandani authored
WaitForVBlank can fail if D3D11 device is lost. Also use InMillisecondsRoundedUp in fallback Sleep() call to match PostDelayedTask() behavior. Bug: 953970 Change-Id: I129a93b41be553f184682e09b21f83ca8d3aedb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618264Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#661113}
-
Zhenyao Mo authored
1) Only check NV12/YUY2 overlay support. 2) Get rid of g_supports_scaled_overlays and g_overlay_format_used. 3) Get rid of OverlayFormat enum class and use DXGI_FORMAT instead. BUG=909827 TEST=gl_tests, bots R=sunnyps@chromium.org Change-Id: I01d0c60b7131b56fbbea599da733b9f68a6233b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616386Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661112}
-
Tony de Luna authored
This CL: - Refactors HelpAppTestHelper::Waiter to a general dialog window waiter. - Renames HelpAppTestHelper to ScopedHelpAppForTest. - Adds a test fixture that sets up a kiosk session for error screen tests. - Adds a test that verifies that clicking on the "Manage certificates" button in the error screen opens a certificate manager window. Bug: 959340 Change-Id: I92a9121872ff28d9c1752c222343cfc643f18501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612599 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#661111}
-
Avery Musbach authored
In tablet mode, if you start to drag a window from the top of a nonprimary display, before the present CL, the functionality is completely broken. You do not even see the window. If you try to drag a window from overview on a nonprimary display, before the present CL, the drop target is created on the primary display. After the present CL, dragging a window (either from the top or from overview) on a nonprimary display shall be similar to dragging a window on the primary display. Future work will address functionality where a window is dragged from one display to another. Test: ash_unittests OverviewSessionTest.* Bug: 916856, 964063 Change-Id: Iddbafc7b289ab2f711db47ebaf18bfcfcda2539c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617906 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#661110}
-
Rakib M. Hasan authored
Bug: chromium:948891 Change-Id: If35daa4956139bc61c3cc4829dbbf35f3061bee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618020 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#661109}
-
- 17 May, 2019 26 commits
-
-
Lucas Tenório authored
Bug: 958995 Change-Id: I115ba68ed9b58a6c0d50d1d94d52b1070f3837db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600133 Commit-Queue: Lucas Tenório <ltenorio@chromium.org> Reviewed-by:
-
Nikita Podguzov authored
Bug: 960274 Change-Id: I01aa63287ecd9b492a112eafe7f2d5b8186418dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609907Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#661107}
-
Esmael El-Moslimany authored
Bug: 960564 Change-Id: Ied93550b6f591e64404ebed7324d2ac6ed3c08d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618056Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#661106}
-
Wei-Yin Chen (陳威尹) authored
This depends on https://crrev.com/c/1595292 to actually release the memory of the Bitmap. On Pixel 2 XL, before this CL, there can be up to 8 (visible or to-be-visible cards) + 5 (recycled in the view pool) thumbnail Bitmaps in the memory after GC when GTS is visible. After hiding GTS, there are still 5 Bitmaps in the recycled views after GC. This CL addresses the recycled views in the pool. Bug: 959054 Change-Id: I601417e5d2e67eafd69aee36fe00614beb046aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595128 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#661105}
-
Esmael El-Moslimany authored
Bug: 960564 Change-Id: I5a5e083a9fa3ff43dcf252ea7faaa508dfd8bd36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618053Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c9cf972dcae3..7dae5d770f4c git log c9cf972dcae3..7dae5d770f4c --date=short --no-merges --format='%ad %ae %s' 2019-05-17 benjhayden@chromium.org Simplify some action creators in spa. Created with: gclient setdep -r src/third_party/catapult@7dae5d770f4c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011 TBR=simonhatch@google.com Change-Id: Id6efcf4389a8d168ba4a8e5ab565627689f0686f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618069Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#661103}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/238d886eb99c..f2674464ef86 git log 238d886eb99c..f2674464ef86 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 saklein@chromium.org BuildTargetUnitTest: Add package blacklist support. 2019-05-17 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@f2674464ef86 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Idf057285a75b3e141c8c65cb23e8a90677eedf59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618067Reviewed-by:
-
Eric Roman authored
Bug: 962523 Change-Id: I7f1d20a2864470b0addb8064f6e553ea3d95435c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614697 Commit-Queue: Eric Roman <eroman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#661101}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/036cc9ae1244..35993b267671 git log 036cc9ae1244..35993b267671 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 fdegans@chromium.org [fuchsia] Disable build warning. Created with: gclient setdep -r src/third_party/swiftshader@35993b267671 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:921807 TBR=swiftshader-team+autoroll@google.com Change-Id: Iba107f6e2f15b0f664564b4c520748ea1f1d6adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618066Reviewed-by:
-
Xianzhu Wang authored
The client calls (static) GraphicsLayer::UnregisterContentsLayer() when it changes cc contents layer (sometimes deletes it), so we should never return contents_layer_ when it's unregistered. This further hardens https://chromium-review.googlesource.com/c/chromium/src/+/1617639. Bug: 962879 Change-Id: I6fade10d360ec3e8120db9cdbfa308c3d6099d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618054Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#661099}
-
Max Moroz authored
- Rename the roles into Sheriff and Marshal; - Clarify the responsibilities a little bit; - Remove the "check in on the weekend" part; - Format the markdown source. Change-Id: Ief674326ae87c835313579290255ce94e8591805 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602442 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#661098}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/25331bfed596..a86225ee247d git log 25331bfed596..a86225ee247d --date=short --no-merges --format='%ad %ae %s' 2019-05-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@a86225ee247d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If1c46cc5fe0045271bca867ee7549949fb768655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618068Reviewed-by:
-
Eric Aleshire authored
goBack requires waitForPageToFinishLoading, so that is converted also. The wait is moved from app-side to test-side using a GREYCondition. Uses http://crrev.com/c/1578949 as a guideline. Bug: 922813 Change-Id: I4e4616f5f9bc7857e89e28df01171d3167e396c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610548 Commit-Queue: ericale <ericale@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#661096}
-
Wei-Yin Chen (陳威尹) authored
This mostly reverts commit 57639246. The "Create group" functionality has been moved to Grid Tab Switcher (GTS), so this is not used anymore. Having it left behind leads to visible artifacts in the compositor layer animations we plan to add to GTS transitions. Bug: 936038, 964406 Change-Id: I0ffa76fd90e57e2f3a9b30ca91601271f93e99ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617554Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
-
Jordy Greenblatt authored
The goal of this CL is to protect passwords saved to the Chrome browser running on CrOS by requiring a GAIA password entry within the last minute to show a saved password in settings and a fresh auth token [1] to export passwords to a .csv. The key steps for changing the password flow for CrOS were -Provide passwords-section with a authToken and bound to a password-prompt-dialog -On "show password" clicks, check if there is a valid there is a valid and <1 minute old auth token [2] -If not, prompt the user for their password and check again -If so, go back to the old flow. The new steps in the export passwords flow are almost the same except that the password prompt comes up on every request [3]. The less intuitive parts of the code come from trying to tinker as little as possible with security an UX for non CrOS users. In particular, I added and infrastructure for pausing the password flows to allow the user to enter their password and then resume the flow when the auth token is received [4] and incorporated an auth token check in a way that fits the general OS specific password safety flow [5]. I also added CrOS specific browser tests in a new file and refactored the existing password-section browser tests to share utilities with the new file. Beyond that there were some minor changes to the existing file that the change required due to the more involved Polymer event dependencies for CrOS. --- Testing: Beyond the browser tests, I manually tested on CrOS by -going through a flow of entering an incorrect password, cancelling, and then entering the correct password for all the affected elements -checking that I could freely show passwords for a minute after a successful password entry/auth token request -checking that I could not export passwords or get plaintext passwords after the respective deadlines of 5 seconds and 1 second through the standard user flow or by manually entering the requests directly into the JS console. I also tested on Linux (i.e. my workstation) and Mac (a corp loaner) to ensure that the functionality was not changed. --- [1] In practice we require it be within the last 5 seconds because it saved some work and provided comparable security. [2] The auth token does not need to be passed through the passwordsPrivate API because there is a single auth token for the machine so just checking its age ensures that the user entered their password in the last minute and provided it to the quickUnlockPrivate API. [3] Since the 5 second expiration is a proxy for immediate expiration and in practice will rarely allow for reusing a token, we can prompt the password on each attempt for a more consistent UX. [4] See AuthTokenRequestorBehavior and the 'request-auth-token-refresh' event. [5] See PasswordsPrivateDelegateImpl::OsReauthCall(). Bug: 917178 Change-Id: I8d8e988270ff627668f2022c093e558fa0409a63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1574684 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#661094}
-
Dana Fried authored
Bug: 961764 Change-Id: I33b888e06cd02155407f18f2a64840da911d60e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612176 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#661093}
-
Suman Kancherla authored
The metrics added are - 'XR.WebXR.ConsentFlowDuration' measures how long the consent dialog was open 'XR.WebXR.ConsentFlow.Presented' counts the number of times the consent dialog was displayed 'XR.WebXR.ConsentFlow.ConsentGranted' counts the number of times the user clicked the 'allow' button on the dialog 'XR.WebXR.ConsentFlow.ConsentNotGranted' counts the number of times the user either clicked the 'cancel' button on the dialog, or closed the dialog Bug: 962755 Change-Id: I16f9e7fc00abb7188e4ebe7a1685c15b2e94a232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614458Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Cr-Commit-Position: refs/heads/master@{#661092}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1b5fb81a01df..3a8aa31d88b1 git log 1b5fb81a01df..3a8aa31d88b1 --date=short --no-merges --format='%ad %ae %s' 2019-05-17 enga@chromium.org Rename .inl to .inc Created with: gclient setdep -r src/third_party/dawn@3a8aa31d88b1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel BUG=chromium:964411 TBR=cwallez@google.com Change-Id: I80c842e683c118adb960f798fd1ee1c84ae7ba0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617885Reviewed-by:
-
Doug Turner authored
For an yet unexplained reason, we must allow kern.tcsm_available AFTER kern.tcsm_enable or we are unable to set kern.tcsm_enable. Bug: 964353 Change-Id: I732b93cca4d1a6fad07ddba6d5e64c63bcda9c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617634Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#661090}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f17fbca40861..79b19c11139f Created with: gclient setdep -r src-internal@79b19c11139f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:764900,chromium:764882,chromium:790415,chromium:790399,chromium:764883,chromium:764882,chromium:764880 TBR=beverloo@google.com,collinbaker@google.com,bcwhite@google.com,tasak@google.com Change-Id: Ia9dd144b93a55e1b45a0dc4e4906b12b53226f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618307Reviewed-by:
-
yilkal authored
Updated KioskNextBackButtonTest so that TestApi is recreated using the new ShelfView when a KioskNextUser logs in. Updated ApplistButtonTest to not keep a local pointer to app_list_button_. Bug: 951212 Change-Id: I72d3c3a3470ff776f63d841b39d9218b2bc00c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618060 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#661088}
-
Xianzhu Wang authored
The type-safe version FlipForWritingMode() flips LayoutRect/LayoutPoint to PhysicalRect/PhysicalOffset or vice versa. The original FlipForWritingMode() from LayoutRect/LayoutPoint to LayoutRect/LayoutPoint is renamed to DeprecatedFlipForWritingMode(). They are still used in legacy inline layout, hit testing (will change to type-safe soon), multicol, etc. Change-Id: I8a348f2930b9a6d19b9ae57d2aac75d9c6fa995f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614253 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#661087}
-
Kyle Milka authored
This was broken for the current version of the picker in https://crrev.com/c/1603206. Bug: None Change-Id: I90474ff2fa6c0a64a1f886d53cdb92d6522fbc16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618266 Commit-Queue: Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Kyle Milka <kmilka@chromium.org> Reviewed-by:
-
John Budorick authored
Bug: 816629 Change-Id: Icbe9e55a4560d51ad9c384a66d0c7e2c7c730549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606599 Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#661085}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: I71906e6b47518046e9e7c1b812ff0faaa016cfdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1618023 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#661084}
-
Lucas Tenório authored
To power the tests we need to setup an HTTP server to handle access token requests and supervision pages. It's expected that the Supervision server will return a custom HTTP header with an specific value when the user is eligible to see the flow. We test cases where the server doesn't send the header as well as when the header doesn't contain the values that we want. Bug: 958995 Change-Id: Ib8017678951ba9da1ae9b7b5b801c755ee2f7533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611038Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
