- 16 Dec, 2020 21 commits
-
-
Sonny Sasaka authored
Battery reporting via HFP is now consolidated into BlueZ, so there is no need to listen to CRAS directly. BUG=b:172361090,b:166543531 Change-Id: Id0f54323790a5788e09441a32a9a4be77a3d8bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593821Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#837358}
-
Findit authored
This reverts commit 4a67dcea. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 837301 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRhNjdkY2VhZDFkOTRmMDU1ODMxMzU5YjgxZjZiZjZlZTVmY2RlYjIM Sample Failed Build: https://ci.chromium.org/b/8860806375392401232 Sample Failed Step: compile Original change's description: > Use new vulkan-deps repo for all Vulkan dependencies. > > This replaces several grouped dependencies with one meta-repo. > > Bug: angleproject:5390 > Bug: 1153258 > Change-Id: Ifd7a8d5b2903d141d9029fe803c981bdffdedda3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590264 > Reviewed-by: dsinclair <dsinclair@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#837301} Change-Id: Ifafd9ffe155db577b0afed54721fcc38b3c43fae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1153258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593594 Cr-Commit-Position: refs/heads/master@{#837357}
-
Patrick To authored
When an offscreen canvas doesn't have a placeholder canvas (such as when new OffscreenCanvas(width, height) is called to create an offscreen canvas in javascript), the corresponding C++ object is OffscreenCanvas, not HTMLCanvasElement. This change obtains the XRSystem object from the OffscreenCanvas so that MakeXrCompatible can be called on it. Bug: 1154424 Change-Id: I4fb1c7005a8c3a41cc4ddcd457c81c4bec4464ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578710Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Patrick To <patrto@microsoft.com> Cr-Commit-Position: refs/heads/master@{#837356}
-
Gavin Williams authored
Record Scan app entry point for launching from Setting and the Launcher. Remove the |kBrowser| enum as we aren't able to track when the app is opened from the Omnibox. |kBrowser| is safe to remove because the ScanAppEntryPoint histogram has not recorded any entries yet. Bug: 1059779 Change-Id: I2be9cc0e519a40f11e3838efaf5b30309267de7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577607 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#837355}
-
Nick Burris authored
* Make ExternalAuthUtils provide its own instance instead of callers having to use AppHooks. A follow up patch will remove the ExternalAuthUtils instance from AppHooks. * This is patch 3/5 for providing ExternalAuthUtils as a singleton instead of from AppHooks. Change-Id: I6527d93dbce453626aa0c02f7093d7686f67266a Bug: 1154371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587430 Commit-Queue: Nick Burris <nburris@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#837354}
-
Dominik Röttsches authored
Bug: 1153329, 1158774 Change-Id: I6acd298f841f92a751f606d710415fe32343825f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593261 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#837353}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I256109baf116d8f66037b3bd27bb7ed4e609907d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593995Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837352}
-
Ikjoon Jang authored
Set valid sched_flag and uclamp range to sched_setattr(), Without this, desired uclamp values are not applied to the task: - sched_setattr() should have appropriated flags to apply uclamp min/max values to kernel. - sched_setattr() is not using percentage format, fix it to use real capacity scale (~1024) BUG=1041117 TEST=check /proc/*/sched for all urgent threads Change-Id: I0dcdbf843591e2916fd10c6fe524f4dd71dcd20f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518536 Commit-Queue: Ikjoon Jang <ikjn@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Cr-Commit-Position: refs/heads/master@{#837351}
-
Zhiyuan Cai authored
This change contains the following: * Remove/restore the message when the binding tab closes/closure undone. * Disable the message after showing 10 times and no actions taken. * Reset tabs when users turn on/off "track prices on tabs" from the menu. Bug: 1148020 Change-Id: If54e9352aa5f3ce724f1141a90f40d8cc0e0a230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575579Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#837350}
-
David Maunder authored
Currently GetInstance() does not scale to multiple protos. This is because the function is generated for each template. For example if there were instantiations ProfileProtoDB<Foo> and ProfileProtoDB<Bar> each would generate a GetInstance(). It is not possible to create one templated function which will be expanded out to two different return types. We must use template specialization instead. Bug: 1159157 Change-Id: I5879b768ed55179b17a7c58a3d12bde87fb20f81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593219Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#837349}
-
Min Qin authored
BUG=1136562 Change-Id: I474995a05ce42974e2a38cbb34e93a366cd8fc34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2588302 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#837348}
-
Yu Han authored
The launch crbug.com/1086530 has been approved for M88. This is to enabled the feature for desktop. Launch is done through finch. Bug: 929098 Change-Id: I65c7ba06533d7d9e437821e28d9648b836d10205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2585645Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yu Han <yuzhehan@chromium.org> Cr-Commit-Position: refs/heads/master@{#837347}
-
Cheick Cisse authored
This CL adds a feature flag for shared highlighting color change. Bug: 1156124 Change-Id: I4288cf260a536c13e30dbffba1c1956c9431ea70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590326 Commit-Queue: Cheick Cisse <cheickcisse@google.com> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#837346}
-
Nate Fischer authored
No change to logic. This extends Android.WebView.DevUi.* histograms since the team is still looking at these as we think about stable launch. Fixed: 1156192 Test: N/A Change-Id: Ib3dc8fb07f77b90bcc878caf7c53451f71587483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2590689 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#837345}
-
Lukasz Anforowicz authored
Bug: 1157988 Change-Id: I655e6b332382b6863c5a7484557f976cae4604f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593736 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#837344}
-
behdad authored
Pending frames are stored in a circular_deque instead of a vector, which improves time complexity of erase. Also limits the size of pending_frames_ to 300 frames in order to prevent 'out of memory' in case of many frames being started but not flushed. Bug: none Change-Id: Ia9d49d8d2cf0f767e02aff568ee0fec128036cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593768 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#837343}
-
Dominic Mazzoni authored
Bug: b/174321021 Change-Id: Ia16533af50f24f3062ee3169b95b2ec3bb225514 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591897 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#837342}
-
Victor Vasiliev authored
Change-Id: Ia73a201aef15fbe2ee027999cb258d50aa6dd3d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587358Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#837341}
-
Yuke Liao authored
This CL adds a lacros fyi builder to run on-device tests, and once it turns out to run reliably, will switch to use the existing CI builder. Bug: 1158590 Change-Id: I469e0168c32534b6fe8983195ed341d7a064408a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593813Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#837340}
-
Mike Dougherty authored
CRWJSInjectionManager is deprecated and translate is one of the few remaining features using it. Migrating it off of this dependency will help to cleanup existing JavaScript feature code in preparation for new JavaScript features. Bug: 949178 Change-Id: I4931c97db89859703ff021a17049de5593be1d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587393 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#837339}
-
Jinsuk Kim authored
The theme color for location bar background should come from a specified tab, not the current theme color from TopUiThemeColorProvider. This addresses the wrong color when multiple tabs are being presented such as in tab switcher. This CL makes TUTCP#calculateColor public to get the right theme color for a given tab object. Bug: 1157417, 1157433 Change-Id: I10c30a7fc93bf9a21b0d113847651c4138a3c02e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589135Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#837338}
-
- 15 Dec, 2020 19 commits
-
-
Ken Buchanan authored
When IdentityDialogController::CloseIdProviderWindow() calls CloseWebIDSigninWindow(), it runs the callback that proceeds to the next step of the identity flow. Currently there is no next step and the identity request completes, destroying the controller. Therefore touching any state in IdentityDialogController after that point is a use-after-free. I am adding a TODO to revisit the lifetimes of these objects, but in the meantime for the prototype to work properly this fixes the immediate problem. Bug: 1141125 Change-Id: Ib1f5c8363f17b428e72449577c9e614c18187c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593831 Auto-Submit: Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837337}
-
Cattalyya Nuengsigkapian authored
Bug: 1156248 Test: Manual testing (see pics in crbug). Change-Id: If80bb03bf237acc995169423d6dbda57c2e3bd81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592139 Commit-Queue: Cattalyya Nuengsigkapian <cattalyya@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#837336}
-
Eugene Zemtsov authored
https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/6d9096c9e3f7..841aa72c9e15 $ git log 6d9096c9e..841aa72c9 --date=short --no-merges --format='%ad %ae %s' 2020-12-11 eugene Roll FFmpeg for M89 2020-12-11 eugene robosushi: Prep work for the next roll 2020-12-11 onemda avfilter/vf_fade: add timeline support 2020-12-11 onemda avfilter/af_afade: add support for commands to afade filter 2020-12-11 onemda avfilter/vf_convolution: add support for commands (...) 2020-10-01 jamrial avcodec/options: add missing FF_API_COPY_CONTEXT checks 2020-10-01 jamrial avcodec/libvpxenc: add missing FF_API_ERROR_FRAME check 2020-10-01 timo avcodec/cuviddec: avoid copy of uninitialized extradata pointer 2020-10-01 timo avcodec/cuviddec: use correct type for extradata_size 2020-10-01 timo avcodec/cuviddec: fix copy&paste error Created with: roll-dep src/third_party/ffmpeg This CL also adjusts tests to match new ffmpeg metadata ffmpeg always emites vendor_id tag. This behavior was introduced by commit 4d97acfe3349995689f995d14b321a3354aa90ed libavformat/mov.c: export vendor id as metadata author Thierry Foucu <tfoucu@gmail.com> Wed, 18 Nov 2020 12:09:37 -0800 (12:09 -0800) committer Gyan Doshi <ffmpeg@gyani.pro> Fri, 4 Dec 2020 20:46:51 -0800 (10:16 +0530) Bug: 1157765 Change-Id: Iad210aa503721a7e6d90022fa8ee2468027b14ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591971Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Will Cassella <cassew@google.com> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#837335}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/4ae71a4c7aea7287b7090dfa664bf9a1f30ea787..df75139becd7355e117c9860452265b898b49376 The following commits have update notes: a929e3274 Finish switching to NASM. Bug: none Change-Id: Ib5b202fcd3d705b714d495ce89a01700079270f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593931 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#837334}
-
Andre Le authored
When an user has already gone through the onboarding process, we should not make them do it again even when the feature is turned off. In that case, when user enable the feature through the tray icon, we will silently enable the feature in settings. Test: manually, unit_tests Fixed: 1157145 Change-Id: I8941c629bec260adc4e851ef17bd8870f2dd2214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592132 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#837333}
-
Mason Freed authored
This function is now unused. Fixed: 1158418 Change-Id: Ib714755f0a3f820b2340fb15383ed6162f822ce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593283 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#837332}
-
David Munro authored
Bug: None Test: None Change-Id: I20a4bf51333de786a2c6bf802bd37511e38fbfc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593788 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Munro <davidmunro@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#837331}
-
Lukasz Anforowicz authored
Bug: 1154799 Change-Id: I0bc5e8886bdbe67bdb6eecdb372ba54c510a10c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587397Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#837330}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f1c7d0dd2ddc..d8fe52139faf 2020-12-15 sokcevic@google.com Check PACKFILE_OFFLOADING env variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1136986 Tbr: apolito@google.com,ehmaldonado@google.com,sokcevic@google.com,ajp@google.com Change-Id: I1a505b5b332dddd9e7d3b14b63b76327275ee95a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593184Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#837329}
-
Mason Freed authored
This CL contains two automated (via find/replace) changes: 1. in web_tests/fast/forms/{anydir}/*, replace: "../../../fast/forms/" with "../" 1. in web_tests/fast/forms/{anydir}/{anydir}/*, replace: "../../../../fast/forms/" with "../../" This should cause no behavior changes. As such I'm going to TBR it, but feel free to comment or ping me to fix anything you see wrong here! TBR=schenney@chromium.org Fixed: 1102647 Change-Id: I5eb293b918905aed13067adce82e48dffffbccfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593245Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#837328}
-
Liviu Tinta authored
Bug: 1156243,1086625 Change-Id: I098ee3dab3aa31f84398bc92b7e2d185a8558521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593557 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#837327}
-
Callistus authored
suggestion chip for Help app. Bug: b/169897551, b/175501984 Change-Id: I841c438a40c5399df062ce95dfcf375ee1fd587f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592227Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Callistus Tan <callistus@google.com> Cr-Commit-Position: refs/heads/master@{#837326}
-
Tanya Gupta authored
Initial end-to-end plumbing to capture a screenshot when triggered from Sharing Hub. Takes 1000px length of screenshot for now. Bug: 1153969 Change-Id: I8b266548c9221a896770f077b9271ac26ed4a82f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589359Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#837325}
-
Weiliang Chen authored
On top of the average smoohtness calculation, also display the max dropped frame and 95th percentile dropped frame on the HUD as well. R=sadrul Change-Id: Icdcc456e13c6a84ca8617592684412945a7955e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593553Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#837324}
-
Matt Menke authored
This reverts commit 33bc167c. Reason for revert: This was issue https://crbug.com/1157926, which has since been fixed. Original change's description: > Sheriff: Disable flaky PasswordManagerBackForwardCacheBrowserTest tests > > Tbr: jdoerrie > Bug: 1157926, 1158588, 1157517, 1158333 > Change-Id: Id10db4c2218625c7331ec64706705218fa5bbdb0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2591028 > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org> > Cr-Commit-Position: refs/heads/master@{#836902} TBR=lucmult@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I709bdfdccb6d1bf8b49921a1a50c3a108865f7a7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1157926 Bug: 1158588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593938Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#837323}
-
David Bertoni authored
This CL changes how unpacked extensions get file and incognito access during testing. Previously, file access would always be granted, which required a reload to remove that access. Conversely, incognito access would not be granted, requiring a reload to add it. With this CL, file and incognito access are granted before the extension is installed, so no reload is required. This only affects testing code paths. Bug: 1146173 Change-Id: I4faf809738d7f402dc56bc42a868e799443b50ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572688 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#837322}
-
David Bokan authored
The same EventDisptachCallback in this class is invoked each time a message or error occurs. The CastMessageHandler that owns the callback is only removed when a listener is so the callback may be executed several times.. CastMessageHandler copies the callback and binds it using BindOnce (since the posted task will be invoked only once). Due to the copy, this is semantically a RepeatingCallback. Since Callback is a typedef of RepeatingCallback this is purely a rename and no-op. Bug: 1152268 Change-Id: Ie88c7c1d9b01356ded2469f41caa40865bf41895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593559 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#837321}
-
Tao Wu authored
This reverts commit 5e5acdd4. Reason for revert: Some corner cases need to be handled. Bug: b/175398984 Original change's description: > ambient: Handle key press exit path > > Currently ambient mode container does not have focus. A key press will > enter into the login pod. > To be consistent with other platforms, the key press is consumed in > ambient mode by making the ambient mode container activatable. > > Bug: b/173642446 > Test: new unittest > Change-Id: I2331079635834972e292076e55bec54dffe6f507 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577923 > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#835380} TBR=xiyuan@chromium.org,xiaohuic@chromium.org,wutao@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/173642446 Change-Id: I1789704605085aece066ad65d87241594d222619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593746 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#837320}
-
Kenneth Russell authored
Flaking substantially while collecting GPU info. A workaround may be possible, but need to suppress the flakiness first. Bug: 1158857 Change-Id: I80b021024dc83a63e5a48516e020819186d25bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593759 Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#837319}
-