- 05 Nov, 2019 40 commits
-
-
Lan Wei authored
For the multiple touch points case, if we have one point move and the other point stay still, such as point 1: pointerdown, pointermove, pointerup point 2: pointerdown, pause, pointerup We should send five touch point events of "pointerdown", "pointerdown", "pointermove", "pointerup", "pointerup" with pointer id 1, 2, 1, 1, 2. Bug: 1020674 Change-Id: I2a738154fee5a4356b64467fd9483c69429217d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895861Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#712684}
-
Maksim Moskvitin authored
This is a reland of b9c8d354 CL was reverted because of test failures on many builders. The reason for this failures is ModifyEntitySpecifics() being wrapped in DCHECK(), which makes new test extremely flaky. Solution: unwrap it. Original change's description: > Add test for keystore key rotation > > New test mimics server-side behavior for triggering keystore key > rotation: generation of new keystore key with touching the Nigori > node. After that client should receive updated keystore keys and the > same Nigori node as it already has (modulo metadata update). The client > should commit the new Nigori node with rotated keystore key and this > verified by checking |encryption_keybag| encryption key name. > > Bug: 922900 > Change-Id: I91b86bbb0f68a55fdcc10049fa90afa70dc32155 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887611 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> > Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com> > Cr-Commit-Position: refs/heads/master@{#712502} Bug: 922900 Change-Id: I994af8befefb8207cedd37e53022329258455221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899497 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#712683}
-
Tim Sergeant authored
These disk reads on the main thread are working as intended and safe enough to ignore. Change-Id: I67a9a2b94e26c97c7427d283a239acefc7a400a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899615 Commit-Queue: Tim Sergeant <tsergeant@chromium.org> Auto-Submit: Tim Sergeant <tsergeant@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#712682}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/51a6086ce618..287edca9b437 git log 51a6086ce618..287edca9b437 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 taylori@google.com Merge "perfetto-ui: Only do logs queries when there are logs" Created with: gclient setdep -r src/third_party/perfetto@287edca9b437 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ica863f91fb995f837782726899fa719ec21ede6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900088Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712681}
-
Daniel Murphy authored
content/browser/indexed_db/leveldb/leveldb_env.h is the leveldb_env::ChromiumEnv implemenation that is exlusively for IndexedDB. Because tests and other systems can create their own leveldb_env::ChromiumEnv, this can just be in the indexed_db/ directory, as there is no reason to share it. Bug: 1015212 Change-Id: I6f8ae76329d30bb25e6d4877fcaef80b3356f8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898327Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#712680}
-
Mounir Lamouri authored
Bug: 1016906 Change-Id: I9baa32384e0b82490efc605583878681a85c7245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898621 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#712679}
-
gogerald authored
Bug: 1021399 Change-Id: I7b9aa63e6613b495614b38acbf850786c159054b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899408 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712678}
-
Nazerke authored
This CL - adds the source file to sources list, - adds required gn dependencies, - links to both eg1 and eg2 frameworks, - adds helper to +(void)setUp to support eg2. Bug: 866147 Change-Id: I7b3b794b6ef11ac2eae114904764a00151f901e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893066 Auto-Submit: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#712677}
-
khmel@chromium.org authored
This adds serialization/deserialization of information about tracing session in graphics model instead of attaching it per each session done. This includes app title, icon, timestamp and platform. This allows it to reuse when loaded offline. TEST=Locally, unit test extended. BUG=b/143532713 Change-Id: If8888e46c3327c725f15ea7dec28310f92e66920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898617Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712676}
-
Elly Fong-Jones authored
After r712264 much of the controller for this class is const, so it is now clear that it's safe to create the signin promo view once in the constructor. Woo! Bug: 1011446 Change-Id: I9ac5b0c9e557915594e6da17a9e58c726296bf57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899417Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#712675}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/63c55152..4abff70f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I54ad7494662d8ebc38189db15c832e101b207369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899788Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712674}
-
Andrew Xu authored
Move the logic of adding the extra four-pixel padding for tablet mode from ScrollableShelfView::Layout to ScrollableShelfContainerView's layout. It helps to update the shelf view's layout after switching to the tablet mode. Bug: 1012354 Change-Id: I975954faf687c144166e8a86ae9fa89959e931f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850796Reviewed-by:
-
Andrew Luo authored
Bug: 1016864 Change-Id: If0df06cd26bec317e5838d0dea82e4e51cfdd43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885156Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Andrew Luo <aluo@chromium.org> Cr-Commit-Position: refs/heads/master@{#712672}
-
Joshua Pawlicki authored
TBR=rsorokin@chromium.org Bug: 1021594 Change-Id: If3684e34bfcf3c36350175fa0154c7b43e933ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899889Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#712671}
-
Vladislav Kaznacheev authored
Currently --enable-dim-shelf flag has the opposite effect (dimming is disabled when the flag is present, and vice versa). This is due to a spurious negation in the IsUsingShelfAutoDim implementation. Bug: 996006 Test: manual Change-Id: I44340bbacb2a998f57176bb7405c39cf4309380d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899088Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Auto-Submit: Vladislav Kaznacheev <kaznacheev@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#712670}
-
Michael Ludwig authored
Just a minor clean up to some of the internal drawing/prep functions that don't actually modify SkiaRenderer itself. CalculateRPDQParams cannot be const because it needs to create ScopedSkImageBuilders, which don't work with const SkiaRenderer*'s. Bug: 1013735 Change-Id: Ic3bddd6cea28dfaf4b977ebef77e1ced4eea6089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863629 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#712669}
-
Christopher Cameron authored
If an app shim doesn't specify a profile (as multi-profile shims will), or if the profile is no longer valid (as is the case for zombie shims), do something reasonable. Add tests for the new behavior - one where an invalid profile is specified, and we fall back to a profile for which the app is installed. - one where no profile is specified, and we use one for which the app is installed. Bug: 1001213 Change-Id: I96de89cf96697612f3ba56e680ef86411ded3212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894067 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#712668}
-
Andrew Grieve authored
Bug: 916880 Change-Id: I623ce658212173c116780d5816d0de8733acac65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878612 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#712667}
-
Raymond Toy authored
Continue to add to the rendering orphan handlers list if the destination is still rendering. If the destination is requested to stop, set a flag so that the rendering won't pull on the audio graph anymore, even if the audio device is still running and requesting data. In the test case from the bug, we were not adding the handlers to the list because the context was closed. However, the destination was still running because the audio device wasn't stopped yet. In the test, the handlers were being destroyed at the same time as the audio thread was accessing the handlers to render audio. Bug: 1003807, 1017961 Change-Id: I87052c8504c5698d71f041e6d4305cf42851f067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879784Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#712666}
-
Sinan Sahin authored
Bug: 971514 Change-Id: I925edaf78eb090d9c77fdcf3e36bde07b3ad4c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894435Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#712665}
-
Clark DuVall authored
Actually granting and revoking permissions caused a lot of problems, instead this modifies the WebLayer implementation context to return the permission we want. Bug: 1021050 Change-Id: Ibd8dc3d42fc420b86060d8d8647df528aa0cef0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898626Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#712664}
-
Tommy Steimel authored
This CL adds horizontal alignment to the title and artist labels to ensure that they stay properly aligned to the left. This fixes a bug where overflowing text would shift slightly to the right. Bug: 1021589 Change-Id: I7c007f4d7af4abe1556941b901a57569dcc41f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899089 Auto-Submit: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Jazz Xu <jazzhsu@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#712663}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aaa64b76c0b4..b0a1f0a96806 git log aaa64b76c0b4..b0a1f0a96806 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 capn@google.com Update Vulkan CTS testlist Created with: gclient setdep -r src/third_party/swiftshader@b0a1f0a96806 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140172528 Change-Id: I2c83a7bcefd1083393d30dab942b6c35c88282d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899588Reviewed-by:
-
Sergey Ulanov authored
FuchsiaVideoDecoder was crashing with a DCHECK in SendInputPacket() while being destroyed because in_flight_input_packets_ were cleared while there is pending data in the queue, which was causing new input packets to be produced. Added ReleaseInputBuffers() call in ~FuchsiaVideoDecoder() to avoid this issue. Bug: 1013919 Change-Id: Id455e97ad8dad70d6aaa7dfc1bbee0426df7ae48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898777 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712661}
-
Jazz Xu authored
ScrollNodeIntoView is causing the clickNode failure. Set it to false to fix the issue. Bug: 1000183 Change-Id: Ic80afd852e57a9a54e55cb1d7406bf3f0f701b0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896344Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#712660}
-
Mikhail Khokhlov authored
As discussed on the doc [1], adding a test_path_format option for correct parsing of test paths. The testPath attribute is now mandatory, so adding it to the test. [1] https://docs.google.com/document/d/18PstJFR6kmEeDiQZjVzJaqXWm4SocuZXrFVu57xDm-4 Change-Id: Id988cd620da0927fab9fb42b81fd52855198f75c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899625 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#712659}
-
Collin Baker authored
Fixes: 1015132 Change-Id: I8b99f9fdd044b249f44c681bafe10bb2037046a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898305Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#712658}
-
Ken Rockot authored
The service (in //services/image_annotation) has been hanging off of ProfileImpl since it was moved off of Service Manager APIs. That breaks image annotation for OTR profiles. This CL migrates the client code to the AccessibilityLabelsService that hangs off of all Profiles. This also opportunistically moves Data Decoder consumption off of Service Manager APIs in favor of the new DataDecoder client API. Fixed: 1020657 Change-Id: I62f77f2f1bcfc84225efb8b62a75d74f2d0c655c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895963Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#712657}
-
Yuki Shiino authored
Implements two type conversion functions in blink_v8_bridge.py. Bug: 839389 Change-Id: I31dfbf882e8abd3a71719b54d8226313dd4bba92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899632Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#712656}
-
Jay Civelli authored
Removing myself as an OWNER as I am not actively contributing to the project. Change-Id: I29ed3d24114bfd36c6c618de62de169ed2bc3a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897951Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#712655}
-
Mirko Bonadei authored
In order to avoid regressions on the WebRTC component build in Chromium, WebRTC will add 2 trybots to build Chromium in WebRTC's CQ with is_debug=true and is_component_build=true. Bug: webrtc:9419 Change-Id: Ib68d5c1a170069bd032b4e8141b24765afb7c2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862680Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#712654}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cfa4f60270cf..e9b546970ec2 git log cfa4f60270cf..e9b546970ec2 --date=short --no-merges --format='%ad %ae %s' 2019-11-05 bsalomon@google.com Add valgrind suppressions for GrClearImage 2019-11-05 robertphillips@google.com Revert "Fully embrace skcms types in SkColorSpace API" Created with: gclient setdep -r src/third_party/skia@e9b546970ec2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: I3353721916bffe80cf52c308d99d27f8faf8ece9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899967Reviewed-by:
-
Alex Chau authored
Bug: 1021141, 1021143 Change-Id: I4c38246c2dd80b4090e084261b0853f37d0650d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897930Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#712652}
-
liberato@chromium.org authored
Previously, we would use one weak pointer for the media WebContentsObserver for all power experiment callbacks. However, since the experiment manager posts callbacks, it's possible that a callback will run after its RenderFrameHost is deleted. Since we use the RenderFrameHost to notify the renderer, this would be a problem in that case. This CL adds per-frame weak pointers that are invalidated after the frame is destroyed, so that any pending callbacks don't run. Change-Id: I02835ebfd620816e385fd215472dd78ecbeae4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897701Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#712651}
-
Toni Barzic authored
Adds logic to notify the home screen delegate of transition to home screen from app (when home button is tapped) for homerview transition. This reflects what's done by HomeLauncherGestureHandler when kHomerviewGesture feature is not enabled. Some perf tests rely on this notification being sent (for example LauncherDragTest.Close/1). BUG=1005366 Change-Id: I0a12ddb1289c8e5d1d093f438bdaa9a354deba29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897011Reviewed-by:
-
Pavel Shmakov authored
BrowserControllerImpl::DidFinishNavigation can be called while destroying WebContents: https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.cc?rcl=81163fe37074bf1ea2bb5a76fe88b2f49e86f23a&l=694 https://cs.chromium.org/chromium/src/content/browser/frame_host/navigation_request.cc?rcl=81163fe37074bf1ea2bb5a76fe88b2f49e86f23a&l=1062 This led to a nullptr dereference. Bug: 1021041 Change-Id: I1894912ed77e377dd0e1ffa2b746921f13f392b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897833 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#712649}
-
Pavel Shmakov authored
Both WebView's and Chrome's cache clearing APIs do the following: 1) Clear the GL shader cache, which corresponds to DATA_TYPE_CACHE in the language of browser_data_remover.h. 2) Clear the Blink cache of the renderers. This CL implements the second part. Change-Id: I2c85de5ca6d286c22954c56a838e4b02cd57b5ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893251Reviewed-by:
-
Owen Min authored
Extension requests are cached in the profile pref. Append the pending list into the report. Bug: 1006899 Change-Id: I62bee93204bb68a790f6ac6176046f17e1860172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894034Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#712647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b48a39e6e2c8..e600381cfd17 Created with: gclient setdep -r src-internal@e600381cfd17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ib5faec20da1a7279bda6421d7e490839596ee63f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899966Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#712646}
-
zhaoyangli authored
The constants.h import was introduced in crrev/c/1888601 to ensure the egtest in internal code base can continue accessing the constants. Now tha egtest in internal code base has been changed to directly import the constants header in crrev/i/2066050. So the header can be removed as it's not used in the file. Bug: 1015907 Change-Id: I6f4be06fd6327ea704012d2bac1e80a59a49bf68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893546Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#712645}
-
