- 17 Jul, 2019 40 commits
-
-
Mitsuru Oshima authored
Looks like I forgot to remove it in crrev.com/c/1328709 Bug: None Test: None Change-Id: Ib2c2482861c4f5e260e447e87c1bbfbff2da189f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706390Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#678425}
-
Takuto Ikuta authored
He is suggested by Nico in https://chromium-review.googlesource.com/c/chromium/src/+/1701624/2#message-a7daaee06d9a39661d505583614efd17929dbce6 Change-Id: Ib4920a0be79cfa19707e74a79fd2ee9fe63034f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705889Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Evgenii Stepanov <eugenis@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#678424}
-
Julian Pastarmov authored
As aggreed we are going to reduce the translation set for policy documentation to the 12 primary marketing languages and the five next top ones. BUG=984053 TEST=The policy_templates target builds. Change-Id: I72acf55803ae6a7f192d63d8a8291c32f46a8a4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705920 Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#678423}
-
Mia Bergeron authored
MediaPosition has been added to the media session API. This CL also makes MediaPosition available over Mojo through StructTraits. MediaPosition will later be used with MediaSessionObserver to notify when the position has changed and provide the updated position through the algorithm defined in |MediaPosition::GetPosition()|. The observer will be implemented in an upcoming CL. Bug: 985019 Change-Id: I208c4c713741550812f0263838279ba4f94eedbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705111Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Mia Bergeron <miaber@google.com> Cr-Commit-Position: refs/heads/master@{#678422}
-
Daniel Cheng authored
Bug: 975688 Change-Id: Ic0514e5f8e4c6d182cbc868502dbd0565554c4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703131Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#678421}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3ec321d4..483d4365 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5ed4c63c5344ee3acca4a5292a46ac4af7691689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707110Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678420}
-
Harry Cutts authored
To test this, we need a small modification to `ServiceProviderTestHelper` to accommodate services which register multiple methods. See go/cros-gesture-properties-dbus-design (Google internal only, sorry) for more details about the full design. Bug: 952054 Test: call the `ListProperties` method with this command (substituting a valid device ID): dbus-send --print-reply --system \ --dest=org.chromium.GesturePropertiesService \ /org/chromium/GesturePropertiesService \ org.chromium.GesturePropertiesServiceInterface.ListProperties \ int32:"$DEVICE_ID" Change-Id: I063389d24d10f27df4edcc0e0b13577acef37acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589448Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Harry Cutts <hcutts@chromium.org> Cr-Commit-Position: refs/heads/master@{#678419}
-
Yi Gu authored
Given that HitTestRegionObserver is now able to wait for all kinds of changes in hit test data after crrev.com/c/1689285, the observer that can only wait for transform change can be replaced / removed. Bug: None Change-Id: Ie0131be0bd98129dadc4244d25d35f1d3bff4537 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703592Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678418}
-
Roberto Carrillo authored
This fixes a bug caused by running the extraction tool outside of the checkout causing an infinite loop. TBR=chanli,dpranke Change-Id: I0df6bfff84a77c43a5f5ddbcf5e879a233750d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707388Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#678417}
-
Xing Liu authored
This CL fixed a crash in DownloadDirectoryProvider.isDownloadOnSDCard. Bug: 984906 Change-Id: I07caa6a299f68a750d06f65156363bc75fb57a5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707169Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678416}
-
Dan Harrington authored
Zine will eventually start sending some suggestions without image URLs. This change allows those articles to be retained and shown correctly on the NTP. Bug: 984787 Change-Id: I96babe4488ac75def4067d88c2023e4ec121ca65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705021 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#678415}
-
Wenjie Shi authored
As the second step for implementing usage of the Windows.Devices.Sensors WinRT API in Chromium, this CL: - Finishes the implementation of PlatformSensorProviderWinrt. - Adds more unit tests to PlatformSensorProviderWinrt. - Abstracts out the PlatformSensorReaderWin interface so it can be generically reused by both the ISensor and Windows.Devices.Sensors implementation. Verified by running unit tests. Bug: 958266 Change-Id: I71783954d4db37f6e921d9c4eaac150763382722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693732 Commit-Queue: Wenjie Shi <wensh@microsoft.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678414}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b94733f8. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" 1e9c7b68 "[Client hints] Enable ACHL persistence in content shell, refactor tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iff81396915a82cd2f71b3aa2450985968bda5dbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706612Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678413}
-
Yann Dago authored
Bug: 984219, 984251, 985012 Change-Id: Ied33dc059986e57e66dbb32614b4059faf9e5655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707111Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#678412}
-
Darwin Huang authored
clipboard_representation_index was off-by-one due to the peculiarity of the order in which functions were called in the Async Clipboard Write structure. Splitting WriteNextRepresentation() to also have a function invoked after write, allows this confusing inconsistency to be avoided. Bug: 981006 Change-Id: I8e84b66aa769c6597a55b77cf9ca43aebce92cdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700483 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#678411}
-
Xiang Ji authored
Change-Id: I054350b94190f600df7d3de200f89dfd5accddbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702863Reviewed-by:
-
Shakti Sahu authored
Bug: 984907 Change-Id: If53f96e81bf021e610c5e1141a5a4623495e5197 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706873Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8c31f2bf7f15..fad9fbc3c4da git log 8c31f2bf7f15..fad9fbc3c4da --date=short --no-merges --format='%ad %ae %s' 2019-07-17 egdaniel@google.com Revert "First draft of Dawn backend: clears are working." 2019-07-17 fmalita@chromium.org [skottie] De-dupe sequential cubic mappers 2019-07-17 egdaniel@google.com Remove RG32F color type and pixel config. 2019-07-17 reed@google.com change colorfilter signature back to just inout color 2019-07-17 senorblanco@chromium.org First draft of Dawn backend: clears are working. 2019-07-17 fmalita@chromium.org [skottie] Fix default cubic controls detection Created with: gclient setdep -r src/third_party/skia@fad9fbc3c4da The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=nifong@google.com Change-Id: I98f024d17c534aece409d6521b4ae0bd337c3a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706361Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678408}
-
Julian Pastarmov authored
The grd reader is invoked from _GetGrdMessages with defines which specify "chromium" build. Drive-by fix for the MockFile to support basename on Windows. BUG=984910 TEST=A modified grd fail doesn't trip the presubmit run. Change-Id: I1b30dcaf8b91d40292e631ba854b4f0dfa54de69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705799Reviewed-by:
-
Anton Bikineev authored
Bug: 967258 Change-Id: I322882558aed37154f2cb2ff655b11c8337b10a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702265Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#678406}
-
Miguel Casas authored
crrev.com/c/1600950 update the calls to |decoder_| but didn't update the corresponding unit tests expectations. Since |mock_decoder_| is a nice mock, nothing broke. This CL updatese |mock_decoder_|s expectations and makes MockAcceleratedVideoDecoder a StrictMock. Bug: 984836 Test: media_unitests on any cros target, including CQ bots. Change-Id: I339b657502ea27702ce8c90b94c0f9d847e97b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706553Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#678405}
-
John Lee authored
With crrev.com/650435, focus and other accessibility attributes were moved to the radio button itself instead of the host element. Change-Id: I42cf86b2ea4bb67cb55add00dc6602e692a8800c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706909Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#678404}
-
Sunny Sachanandani authored
HIGH_PRIORITY_CLASS uses priority level 10 for THREAD_PRIORITY_LOWEST, which is higher than THREAD_PRIORITY_NORMAL (8) used by most Chrome threads. ABOVE_NORMAL_PRIORITY_CLASS should give us the same benefit without the drawbacks. This only affects the GpuProcessHighPriorityWin experiment. Bug: 965778 Change-Id: I59fa93bd534bfe0e0c2014735bb7d13e82715f6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705575Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#678403}
-
Peter Beverloo authored
Change-Id: I2b193903f0c16d92b26a3d66df9f570819ebe235 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690962 Commit-Queue: Peter Beverloo <peter@chromium.org> Auto-Submit: Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#678402}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/64f2cec30c96..0662a4afb5d1 git log 64f2cec30c96..0662a4afb5d1 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 sugoi@google.com MacOS WSI Created with: gclient setdep -r src/third_party/swiftshader@0662a4afb5d1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: Id52348e60fbde859b574094f96d4e263a1664687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706360Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/66c4e85a160b..a552be46f95c git log 66c4e85a160b..a552be46f95c --date=short --no-merges --format='%ad %ae %s' 2019-07-17 vapier@chromium.org move from filter builtin to list comprehensions Created with: gclient setdep -r src/third_party/chromite@a552be46f95c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ie0af8229da1f2ad8beadcec093753c3fd83f2886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706358Reviewed-by:
-
Brian Sheedy authored
Halves the number of iterations in TestControllerInputRegistered. With the old value of 10, the test runtime was ~9 seconds, which was uncomfortably close to the default JS timeout of 10 seconds. It's suspected that if the test machine was a bit slow, the test would end up timing out. 5 iterations should still be plenty to verify that input works. TBR=alcooper@chromium.org Bug: 984989 Change-Id: Ie6c67725c692ea47aa83a4adc3c8fcf0aa9e9692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706774Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#678399}
-
Esmael El-Moslimany authored
Bug: 870742 Change-Id: Ie24c86d270212f2dd2d630ea91f751f0bcebf1cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698645Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#678398}
-
Nina Satragno authored
When DevTools reports an error with code InvalidParams, translate it into an InvalidArgument error instead of UnknownError. This lets us perform certain checks on the devtools side that are not possible on the chromedriver side and return InvalidArgument when they fail without comparing against the error description on chromedriver. Additionally, we can avoid duplicating certain parameter checking on the chromedriver side. This patch also adds tests for the ParseInspectorError function. Bug: chromedriver:3025 Change-Id: I4a01136c87a53a1c5b2baac20c1ea65a60699d4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706618 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678397}
-
Reilly Grant authored
In r626961 and r643767 we removed the CancelRead() and CancelWrite() calls from ~SerialConnection() with the assumption that since the SerialPortPtr was being closed it would cancel I/O in the process of closing the OS-level file handle. The problem is that SerialIoHandler explicitly retains a self-reference when submitting a read or write operation and until those are completed (or canceled) the object won't be destroyed and the OS-level file handle closed. SerialConnection solved this problem by explicitly canceling the I/O in its destructor and this patch moves that logic to ~SerialPortImpl(). A better long-term fix is to remove the self-references and make SerialIoHandler uniquely owned by SerialPortImpl but that requires other refactoring work. Bug: 964683 Change-Id: Ie5e59696df23c48dc9e9224772c621db5438c1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707028 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#678396}
-
Pavel Shmakov authored
Bug: 984205, 984300 Change-Id: I6d3c9344a51fa12fe61d000b7d78706b3635ba2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705897 Auto-Submit: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#678395}
-
Geoff Lang authored
These extensions were being exposed as requestable but failing to initialize because they weren't requested. Allow GL_OES_compressed_ETC1_RGB8_texture in all cases when the driver supports it. ANGLE has been updated to only expose this extension with native support. TBR=kbr@chromium.org BUG=angleproject:3675 BUG=983142 BUG=983750 Change-Id: Idb4b20638990432d3526d5559396a695fc814b31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702765 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#678394}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/0be40bf53fc4..3a51b0e9d143 git log 0be40bf53fc4..3a51b0e9d143 --date=short --no-merges --format='%ad %ae %s' 2019-07-17 oprypin@webrtc.org Reland "Reland "Add wrapper to normalize flags."" Created with: gclient setdep -r src/third_party/webrtc@3a51b0e9d143 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia084a5be237c3347f30511f5cf420c5474d3136a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706357Reviewed-by:
-
Ian Kilpatrick authored
This adds an optimization to speculatively place floats based on either: - The previous layout's "forced" BFC offset. - The previous layout's "optimistic" BFC offset. - The current layout's BFC block-offset. (in that order). This turns out to be an important optimization for sites which always trigger a 2-pass layout when we can't determine the "exact" position of them during the 1st pass (washingtonpost.com was one of these sites for example). If the "optimistic" BFC block-offset isn't set, this shouldn't change the control-flow of the current layout algorithm. This also saves some more stack space by removing a: Vector<NGUnpositionedFloat, 1> from the stack. Change-Id: Iae2ce8684e00ab166d810e875d7d0c420202a194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619047Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#678392}
-
Yao Xiao authored
Why: All call sites that create a non-empty network isolation key must provide a top-frame-origin. Bug: 984157 Change-Id: I26c15816073a6424fe8bad23c52494114ba08e31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704522 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#678391}
-
Yi Su authored
Bug: 983776 Change-Id: I96b5e093b2c33e94339051625b75fe9733e915ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706852 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#678390}
-
Dominik Röttsches authored
In preparation for moving Blink fallback to an API call on all Windows versions instead of using a hard-coded list, add a test to retrieve fallback fonts for a larger set of languages and establish a test baseline for those. It is important to note that the results are not only affected by fallback but also by what we configure as default preferences fonts for certain scripts, which needs updating too (issue 960450). Bug: 976737 Change-Id: Ibdf990e9ea8beb6c9742774d97fff4b4981a00b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705916 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Jeroen Dhollander authored
Previously we used a capture delay (i.e. the delta from 'now'), which 1) was rounded to milliseconds and 2) started losing accuracy if the message took a while to process. This has been replaced by a |TimeTicks| instance. BUG=335335,587291,978644,b/79769953 Change-Id: Ieb4434e8ba44348b251593425236a0481ee601d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1691787 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#678388}
-
Francois Doray authored
Changes in this CL: - Make FrameSchedulerImpl::main_thread_scheduler_ const. - Remove unnecessary MainThreadTaskQueue::DetachFromFrameScheduler(). Reason: - Make it easier to reason about association between MainThreadTaskQueue and (MainThread|Frame)Scheduler in upcoming frame interference CL https://chromium-review.googlesource.com/c/chromium/src/+/1689339. Bug: 984057 Change-Id: I0ba99a7ce6126ddf3ac5cf661c3bd3b32e8d82b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706714Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#678387}
-
Roberto Carrillo authored
This changes the component scraping to use the nearest ancestor's component/team/os tag if the current directory does not define one. Also, allow multiple teams mapping to the same component, and modify presumbit to use the same criteria, warning instead of failing when such situation arises. Note that the 1:1 component to team mapping will continue to be present in the mapping output, but it will show the team that is defined at the topmost OWNERS file in the tree that is tagged with such component. R=chanli,dpranke Bug: 981713 Change-Id: Ie6f51f0beeb4ce63cedf302f4f15b2e2af25b451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693362 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
Chan Li <chanli@chromium.org> Reviewed-by:
-
