- 02 May, 2018 40 commits
-
-
Kent Tamura authored
This CL has no behavior changes. Presubmit scripts have never applied to the script, and it has many style errors. This CL has NOPRESUBMIT=true to suppress presubmit errors, and we should fix them later. See crbug.com/838772. NOPRESUBMIT=true Change-Id: I724be7f9af79f9e82ff76bb04e713e0ada860a30 Reviewed-on: https://chromium-review.googlesource.com/1039107 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#555311}
-
Hiroshige Hayashizaki authored
This CL adds "enable-layered-api" flag to chrome://flags and a corresponding web runtime feature that will enable Layered API. Also, this CL enables Layered API when ExperimentalProductivityFeatures is enabled. Bug: 829084 Change-Id: I0ed0346aa9bc685b2ba79ce5ba353a6f7f614c40 Reviewed-on: https://chromium-review.googlesource.com/1013319Reviewed-by:
Ojan Vafai <ojan@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#555310}
-
Timothy Loh authored
Change-Id: I26bab2e43fa0599b052b0740e8b9949b12022860 Reviewed-on: https://chromium-review.googlesource.com/1036708Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#555309}
-
Nate Fischer authored
This marks the SupportLibWebViewContentsClientAdapter as final. This instance is 1:1 with WebViewContentsClientAdapter and is set during the constructor, so it can be final. Test: N/A Change-Id: I288ea6784e3a6c613825f8256dcecf78a1201f2c Reviewed-on: https://chromium-review.googlesource.com/1039156Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555308}
-
Han Leon authored
This CL switches those interfaces (ServiceWorkerHost, ServiceWorkerRegistrationObject[Host] etc.) associated with EmbeddedWorkerInstanceClient interface before to be associated with ServiceWorkerEventDispatcher interface living on its particular service worker thread in the renderer process. This will not only ensure them keeping the FIFO ordering with ServiceWorkerEventDispatcher, but also make all their Mojo message dispatches skip the main thread completely to avoid possible congestion. The idea is to let browser-side pass ServiceWorkerHost endpoint and ServiceWorkerRegistrationObjectInfo via a newly defined Mojo call ServiceWorkerEventDispatcher::InitializeGlobalScope() to the service worker thread, which holds on evaluating its service worker script until received that call. BUG=745327,834200,834183 TBR=lazyboy@chromium.org for enabling a test in chrome/browser/extensions/service_worker_apitest.cc Change-Id: Icc9d03d2cc0f099735cfcf34660b835ccf908402 Reviewed-on: https://chromium-review.googlesource.com/981898 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#555307}
-
Chris Blume authored
Previously, ParentLocalSurfaceIdAllocator would default to an invalid LocalSurfaceId. A new LSI had to be explicitly allocated before the normal behavior could use it. With ParentLocalSurfaceIdAllocator now default initializing a valid LSI, the various call sites no longer need to explicitly check for the uninitialized state. viz/service & viz/test contain some of those call sites. BUG=837030 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Iace37fb0be4c6389fdf2c89dbd4bb77c9696036f Reviewed-on: https://chromium-review.googlesource.com/1038124 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555306}
-
Ken Rockot authored
Adds a note about properly configuring .gclient Bug: None Change-Id: I8ef7f054b283cf4d2c22e89e1436503504701358 Reviewed-on: https://chromium-review.googlesource.com/1039152Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555305}
-
Kent Tamura authored
This CL fixes #includes and/or include guards of the following generated files: - html_element_factory.cc - html_element_factory.h - html_element_lookup_trie.cc - html_element_lookup_trie.h - html_element_type_helpers.cc - html_element_type_helpers.h - svg_element_factory.cc - svg_element_factory.h - svg_element_type_helpers.cc - svg_element_type_helpers.h Bug: 836071 Change-Id: Ie9cd4e4c937262f32e64c574903be4580281f3b1 Reviewed-on: https://chromium-review.googlesource.com/1038924 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#555304}
-
Sungguk Lim authored
Use std::unique_ptr instead of deprecated linked_ptr Bug: 556939 Change-Id: Iefb3dcb3ae891fe4b0fd0dd70be408517bcd9d85 Reviewed-on: https://chromium-review.googlesource.com/1034942Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Sungguk Lim <limasdf@gmail.com> Cr-Commit-Position: refs/heads/master@{#555303}
-
Chris Harrelson authored
Previously, we would update all of the composited layers plus reach into the LayerTreeHost (via some virtuals) to update even more things. All of these will be updated anyway if the composited layer configurations actually change, and it's pure overhead here. PaintLayerCompositor::FrameViewDidScroll does the same thing (and this is where I cribbed from in my original patch), but it's overkill. I didn't change that call site, however, since it is non-RLS specific. Bug:818709 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3643e42bc4b68bafcfd06dfe787a18b09ee2c7da Reviewed-on: https://chromium-review.googlesource.com/1038439 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#555302}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I4d9f55a3463f97aea1a44d4ca32b5531bd99a956 Reviewed-on: https://chromium-review.googlesource.com/1039148 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555301}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4736430a2b1c..dd3fcf9f3eb0 $ git log 4736430a2..dd3fcf9f3 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 rockot Set target_os=['chromeos'] in generated gclient specs Created with: roll-dep src/third_party/chromite BUG=chromium:838608 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I770cc7362ad14fc63e8173eeed6661d85b8f4bb1 Reviewed-on: https://chromium-review.googlesource.com/1038821Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555300}
-
Devlin Cronin authored
Add a test to invoke the refresh-required bubble for click-to-script. Bug: 834494 Change-Id: Ie58dc3f98699f3a2b54289a25078c5b414f18fb9 Reviewed-on: https://chromium-review.googlesource.com/1038661Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555299}
-
Xi Cheng authored
... in CreatePrimaryProfile(). This is consistent with the logic in GetStartupProfilePath() in startup_browser_creator.cc file. Bug: 734095, 833663 Change-Id: Ic74bf5af947d0ef75006169676ed3bfcad7cde91 Reviewed-on: https://chromium-review.googlesource.com/1037930Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#555298}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I3dae1a3c23f259efc05a68d0ff2b80d5ea6ab039 Reviewed-on: https://chromium-review.googlesource.com/1038906Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555297}
-
Joel Einbinder authored
When a RuntimeModel with multiple execution contexts was removed, some of the execution contexts could be unintentionally left in the ConsoleContextSelector. Change-Id: I8fea191af5a2f02c1de350866d29ddffe24338f6 Reviewed-on: https://chromium-review.googlesource.com/1038794Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#555296}
-
sangwoo.ko authored
In order to set proper bounds for active tab which is being dragged, TabStrin::StartedDraggingTabs() should be called after ResetSelection(). Bug: 836004 Change-Id: I7243bf75b1d3243e55892386f2a5debc092bf925 Reviewed-on: https://chromium-review.googlesource.com/1027590 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#555295}
-
Alexei Filippov authored
The agent is going to be removed soon. The ExecutionContextWorkerRegistry is made responsible for reporting workers. Each worker is reported as a trace event when a worker starts. Also all previously registred workers are reported on trace start. Change-Id: I3cde31ae74e991ad522c476b606bee3c0a5f8587 Reviewed-on: https://chromium-review.googlesource.com/1038684Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#555294}
-
Ken Rockot authored
Using a normal skia Bitmap mojom type means that large frames may be transmitted as shared memory regions, which in turn means that animations with more than 64 large frames can cause DecodeAnimation's reply to exceed Mojo's self-imposed per-message handle limitation. This is a temporary solution which restores DecodeAnimation to using inline bitmap data (which it did prior to CL:1004598). Bug: 838706 Change-Id: I53542a0070b6d554b52c6b0e3576b94af233a9f4 Reviewed-on: https://chromium-review.googlesource.com/1038760Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555293}
-
Kent Tamura authored
Bug: 836071 Change-Id: Icf7069a6c58d395edae8fddcdb84d07854e8d341 Reviewed-on: https://chromium-review.googlesource.com/1039103Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555292}
-
chrome://discardsMichael Giuffrida authored
Load the favicons shown in chrome://discards via cr.icon instead of doing a direct network request from WebUI. Remove LifecycleUnit::GetIconURL() which is now unused. Bug: 837420 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0ce123cdf944ace2e03b2b56feb18402848f875d Reviewed-on: https://chromium-review.googlesource.com/1031783 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555291}
-
Kent Tamura authored
generate_event_interfaces.py should produce paths relative to the repository root. Bug: 836071 Change-Id: Ibcb9fbe2cdb1e6e0e8f46ad1c0caec11c23123f3 Reviewed-on: https://chromium-review.googlesource.com/1038984Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555290}
-
https://pdfium.googlesource.com/pdfium.git/+log/9294ffdf371f..c9cd2874278e $ git log 9294ffdf3..c9cd28742 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 hnakashima Transform float out params from reference to pointer in CXFA_Node. 2018-05-01 tsepez Add CPDF_Document::Extension::DeletePage() 2018-05-01 tsepez Avoid perpetual spins for parserless CPDF_Pages 2018-05-01 hnakashima Transform size out param from reference to pointer in CXFA_Node. 2018-05-01 hnakashima Transform rect out param from reference to pointer in XFA code. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia3177603cfe492a853b4aa4903c52473995b84ef Reviewed-on: https://chromium-review.googlesource.com/1038686Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555289}
-
Kent Tamura authored
Also, fix include guards. This CL has no behavior changes. Bug: 836071 Change-Id: I21d78c16c302405e9fb375843388aaaaaf093500 Reviewed-on: https://chromium-review.googlesource.com/1037047Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#555288}
-
Michael Giuffrida authored
WindowActivityWatcher logs the WindowMetrics UKM event for a browser window, with features like window show state and tab count. Replace the WindowMetrics struct with a public WindowFeatures struct. The UKM logging function forwards info from the new struct to the UKM event. Later we will use the same CreateWindowFeatures function to calculate tab scores with an ML model. Encapsulating the logic for these features in a single function ensures that we use the same logic for logging as we will for inference, and makes the inferencing CL smaller. Bug: 791824 Change-Id: I940b7fc3d9b6d71d2c23f3a6b054b4f0eb74894a Reviewed-on: https://chromium-review.googlesource.com/1028563 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#555287}
-
Saman Sami authored
Currently we send the default CompositorFrameMetadata with the first VideoFrame. This makes inspecting a remote target in DevTools buggy when viz is enabled. Bug: 837362 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ie57e4bb290c1fa683839f7e5f09be1d5c2472b3a Reviewed-on: https://chromium-review.googlesource.com/1035365 Commit-Queue: Saman Sami <samans@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555286}
-
Hirokazu Honda authored
Introduce GLRenderingVDAClient::Config and pass arguments to GLRenderingVDAClient's constructor with it. BUG=chromium:834170 TEST=VDA unittest on eve and kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5db1cbd9140f9a347f45f89b3903b3f1334b36e1 Reviewed-on: https://chromium-review.googlesource.com/1027490 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#555285}
-
Noel Gordon authored
Many tear-down can occur if this is not the case: bug references can be for the curious. Tbr: slangley, yamaguchi No-Presubmit: true Bug: 833834 Change-Id: I5e795f7ef5b5e28af4050c9506640d8f6df8941a Reviewed-on: https://chromium-review.googlesource.com/1038983Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555284}
-
David Black authored
State is simplified to {kInactive, kActive} for now but will need more granularity later on. Bug: b:78913434 Change-Id: I558c4f2c9b2b266a621a36fc67ecd5af1d28eed6 Reviewed-on: https://chromium-review.googlesource.com/1036729Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#555283}
-
Kevin Marshall authored
Shared libraries are now spread over two directories in the SDK, causing some libraries to be omitted from packages, rendering the libraries non-executable. This CL registers $sysroot/dist as a library data dependency. Bug: 707030 Change-Id: Ie05e1b5dacf8924475576c3c53bf0d8d460db1f3 Reviewed-on: https://chromium-review.googlesource.com/1039026 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#555282}
-
Paul Miller authored
Chrome stores the seed in preferences, but WebView doesn't persist preferences. WebView must save save seeds separately. Serialize with protos, and add aw_variations_seed.proto to mirror the fields in VariationsSeedFetcher.SeedInfo. Since writing might not complete successfully, the file format must make truncation unambiguous. The proto wire format is such that truncation in the middle of a field will be detected, but truncation between fields is permitted. But by requiring in code that all SeedInfo fields are present, any truncated seed file will fail to load. BUG=733857 Change-Id: I7f8d787afed83019c2d891aef419cdf7d593b71c Reviewed-on: https://chromium-review.googlesource.com/1033823 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555281}
-
Steven Bennetts authored
Bug: 682402 Change-Id: I6502a46e7dfa5293e8e5b29fefd44b3c3034db2c Reviewed-on: https://chromium-review.googlesource.com/1011547 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#555280}
-
Ben Pastene authored
This will add a positional arg to run_vm_test.py that can take one of two values: - "host-cmd": Runs a command on the host. Just launches the vm then immediately calls the passed in cmd on the host. It's assumed the cmd will handle data deps, ssh commands, etc. - "vm-test": Runs a test in the vm. Takes care of spawning the vm, pushing the test and its deps to the vm, executing the test, and tears down the vm. (This is the current default behavior.) Bug: 832374 Change-Id: Ib8bd1b2e7dd393f8a4578979fa164381a8342ef2 Reviewed-on: https://chromium-review.googlesource.com/1038747 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#555279}
-
Xida Chen authored
We have completed the experiment of "turning off compositing for 2D transform & opacity animations". We have data to show that running opacity and 2d transform animations makes them multiple times slower without significant GPU memory savings. This CL remove related code for that experiment. Bug: 754471 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib933deeef82fb05632d09e530356769e2d23befb Reviewed-on: https://chromium-review.googlesource.com/1034283Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555278}
-
Albert J. Wong authored
Now that the module boundaries are clear, refactor some functions to make a clear layer separation for types and remove the -inl.h files. Yay! \o/ Bug: 766882 Change-Id: I17934666c640c8f5daed40c2c8435b2e220b7b79 Reviewed-on: https://chromium-review.googlesource.com/1008964 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#555277}
-
Kyle Horimoto authored
This CL creates a new directory in //chromeos/services for the upcoming SecureChannel service (see go/chrome-os-multi-device-apis). Additionally, this CL adds the secure_channel.mojom file which will be used to implement the service. Currently, that file only defines the ConnectionDelegate interface, which is intended to be implemented by clients of the service. This CL adds a test double for that class, to be used in a follow-up CL: https://chromium-review.googlesource.com/c/chromium/src/+/1038649 Bug: 824568, 752273 Change-Id: I9ce9d7d7bff02464e1eec71d3193c63602e27477 Reviewed-on: https://chromium-review.googlesource.com/1033509Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#555276}
-
Tien-Ren Chen authored
There was a mistake in PaintPropertyTreeBuilder::UpdateClipPathClip() to early exit when properties didn't change. However in that case we still have to update the context for descendants to inherit. This CL removed the early exit. BUG=836127 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I38b229b86bd9c2106ac32bf54d520d39cb892e0c Reviewed-on: https://chromium-review.googlesource.com/1038705Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555275}
-
Chris Lu authored
TableViewTextItem text used to be a single line that was cropped once it reached the end of the screen. Also sets the right color for the cells. Screenshots: https://drive.google.com/file/d/1ZS_bk01JU38rbC5nxMKK76yhj62VU_XU/view?usp=sharing https://drive.google.com/file/d/1p1Qv27DOP1ZP97F2ZR7X8yg2DpKDSOIC/view?usp=sharing https://drive.google.com/file/d/1f4gigdxaV58Scbfeuz-3GexEPxLNCCY4/view?usp=sharing https://drive.google.com/file/d/1eet07y_X2UXXk15x0Tcwm3xCw1SlH_bt/view?usp=sharing Bug: 822988 Change-Id: If5f7a25505e6014adbd3068f9c4f5b1868cd4f18 Reviewed-on: https://chromium-review.googlesource.com/1026807 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#555274}
-
https://chromium.googlesource.com/catapult.git/+log/faa15b5e1038..5b642efe8459 $ git log faa15b5e1..5b642efe8 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 dtu [pinpoint] Add isolatedserver field to Swarming tasks. Created with: roll-dep src/third_party/catapult BUG=chromium:822008 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: If2833a7f56032c662d39efa25791a9f2dd100c18 Reviewed-on: https://chromium-review.googlesource.com/1038843Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555273}
-
Tarun Bansal authored
Change-Id: Ia4ad8b4647432352928e23e5cbc6e4c29cfa0443 Bug: 826558 Reviewed-on: https://chromium-review.googlesource.com/1035444Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#555272}
-