- 18 Dec, 2017 40 commits
-
-
bsheedy authored
Moves the VR HTML/JS files used for end-to-end testing from chrome/test/data/android/webvr_instrumentation to chrome/test/data/vr/e2e_test_files. VR browser test support has been added, so these files are not Android-specific now. Also updates any files that use or reference the old path to use the new one. Bug: 795455 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3d5905fb00e3f05ca18b445bb1443846df5afdf4 Reviewed-on: https://chromium-review.googlesource.com/831253Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524747}
-
Daniel Bratell authored
Both the floating keyboard container and the full width keyboard container need kAnimationStartOrAfterHideOpacity so instead of having two of them, this patch moves it to container_behavior.h. Bug: 773275 Change-Id: I1196570016881bd58e9f3c73f33f3a674d8fc607 Reviewed-on: https://chromium-review.googlesource.com/824274Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#524746}
-
Kenneth Russell authored
They're in the Chrome-GPU pool, not the Chrome pool. BUG=754875 NOTRY=true TBR=jmadill@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I23a033fc1dd22abe59e851ba47dac7cce2e504d1 Reviewed-on: https://chromium-review.googlesource.com/833020Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524745}
-
Klaus Weidner authored
This reverts commit 9ebbc362. Reason for revert: Occasional doubled rAF on exiting presentation. Will re-land with additional fix included. Original change's description: > Fix rAF handoff on exiting WebVR presentation > > If there's an outstanding presenting VSync request when presentation exits, > it must be converted to a normal VSync request for magic window mode. > > This fixes a regression introduced by crrev.com/c/817545. > > BUG=794266 > > Change-Id: I93f0739facb702f68c29d8af7c77b669d6b54bda > Reviewed-on: https://chromium-review.googlesource.com/822985 > Reviewed-by: Bill Orr <billorr@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523612} TBR=mthiesse@chromium.org,klausw@chromium.org,billorr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 794266 Change-Id: If0990fa84e7dce6edcd628a92e03792202d94865 Reviewed-on: https://chromium-review.googlesource.com/832926Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#524744}
-
JunHo Seo authored
Problem: Imagine the focused element F "scrolled out" = hidden outside of its container C's viewable area. In this case spatnav would start its search for focus candidates up at the document root and therefor miss (possibly nearby) candidates in C. Solution: Let AdvanceFocusDirectionallyInContainer() use the currently focused element F's container C as its starting rectangle unless F is an HTMLAreaElement. For HTMLAreaElement the search starts in the HTMLAreaElement's image. Bug: 763206 Change-Id: I4b721e92bf47ff5361d6f0fa8b70805eb0b485c2 Reviewed-on: https://chromium-review.googlesource.com/826345Reviewed-by:
Hugo Holgersson <hugoh@vewd.com> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#524743}
-
Dominic Mazzoni authored
Bug: none Change-Id: I3533cb5c3ce7645dd08cf9190c194274309a8b0a TBR: dtseng@chromium.org Reviewed-on: https://chromium-review.googlesource.com/832910Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#524742}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/a2d981418d78..0e74e059621b $ git log a2d981418..0e74e0596 --date=short --no-merges --format='%ad %ae %s' 2017-12-17 fjhenigman Fix gcc builds. Created with: roll-dep src/third_party/angleBUG=none The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I8c3d4b70c914cfee723a5efbdac14f4037f91b47 Reviewed-on: https://chromium-review.googlesource.com/832370Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524741}
-
Fredrik Söderquist authored
With geometric presentation attributes it's quite common to need to resolve an <x, y> pair of Lengths to produce a point or a size. Add a helper ResolveLengthPair() that accepts a pair of Lengths and return a FloatPoint. Except for a reduction in LoC, it also amortizes the cost of determining a viewport when percentages are used. Use the new helper for 'cx' / 'cy' and 'rx' / 'ry' on <ellipse>, 'cx' / 'cy' on <circle>, 'x' / 'y', 'width' / 'height' and 'rx' / 'ry' on <rect>, 'x' / 'y' and 'width' / 'height' on <image> as well as 'x' / 'y' on <use>. Since this means using FloatPoint/FloatSize to a larger degree than before, use the abilities (operators et.c) of these a bit more where possible. Bug: 400725 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I15f5c17190b060a7e8312d5e3e124846301804b9 Reviewed-on: https://chromium-review.googlesource.com/832606Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#524740}
-
Sidney San Martín authored
The placeholder frame is based on `-[NSEvent mouseLocation]`, which isn't aligned to device pixels. Use `-centerScanRect:` to align it before storing it. Bug: 756262 Change-Id: I54dd54866a3fe0433c986b368d563d51d4f2256f Reviewed-on: https://chromium-review.googlesource.com/832826Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524739}
-
rhalavati@google.com authored
Network Traffic Annotation which is received in BufferedSocket::Write is passed to the actual socket. Bug: 656607 Change-Id: Ic5c7eb8faff9eb840d9965b0911c0032d6845994 Reviewed-on: https://chromium-review.googlesource.com/827063Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#524738}
-
Xiyuan Xia authored
Throttle redirected requests as well to avoid the racing between background MergeSession call and tab/xhr loading to google servers. Bug: 781451 Test: Start up tab of gmail.com loads fine. Change-Id: Ideb16c8ad8609e0585fe9840f6592fcc2a655360 Reviewed-on: https://chromium-review.googlesource.com/830833 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#524737}
-
Chris Hamilton authored
This creates a policy for explicitly enabling/disabling third party blocking. Further CLs will integrate this with the blocking and messaging logic. BUG=789174 Change-Id: I1cdb81cbce2af5ece4e972208f428baab7e53207 Reviewed-on: https://chromium-review.googlesource.com/801894 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#524736}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/1aa285974b6b..019008bd9306 $ git log 1aa285974..019008bd9 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtcBUG=None,None,None,None,NONE,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9e128a0b7296776772a9cf13bebc6123b497f782 Reviewed-on: https://chromium-review.googlesource.com/832846Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524735}
-
John Abd-El-Malek authored
Bug: 711579 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: If272f72850da85b7959df00de5c1b5f97600f520 Reviewed-on: https://chromium-review.googlesource.com/830653Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#524734}
-
Nicolas Dossou-gbete authored
Duplicate resource id lookups in PasswordEntryEditor were flagged by Android Linter and broke compilation. This CL fixes them as well as some other warnings around unnecessary casts and lambda conversions. Bug: 788943 Change-Id: I194b7c80e6ba5d0e37c4b5eba3c95488b4003a0b Reviewed-on: https://chromium-review.googlesource.com/832406Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#524733}
-
John Chen authored
Modify ChromeDriver log file to use absolute time (number of seconds from Unix Epoch) instead of relative time (number of seconds since ChromeDriver start). This makes it easier to correlate the timestamps against event recorded elsewhere. The resolution of the timestamps remain at milliseconds. Bug: chromedriver:2179 Change-Id: I7d52eeb2bb90204850d04e36a9ec74560fc56834 Reviewed-on: https://chromium-review.googlesource.com/830530Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#524732}
-
Jonathan authored
telemetry_perf_unittests needs --xvfb this change adds that. Also adds one more skip for telemetry_unittests. TBR=sky@chromium.org Bug: 795760 Change-Id: Ic5e1f09bdf94397c11d1b25fa71e783a4a9e7a4d Reviewed-on: https://chromium-review.googlesource.com/832766Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524731}
-
Anthony Berent authored
Bug: None Change-Id: Iac3de7f8dcad9692beb58ff991d1f70df8ca5eae Reviewed-on: https://chromium-review.googlesource.com/738231 Commit-Queue: Anthony Berent <aberent@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#524730}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/46845d1c3af5..7035a8e797eb $ git log 46845d1c3..7035a8e79 --date=short --no-merges --format='%ad %ae %s' 2017-12-15 brianosman Fix benches that aren't really timing what we want Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I05ee66a40123082be0e5fe0e73c671d4ea772067 Reviewed-on: https://chromium-review.googlesource.com/832368Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524729}
-
Jonathan Backer authored
If you patch in https://pastebin.com/k1MTXxYt, this is enough to get poster circle "running" with black tiles. The magic set of flags to run with this stub are: --enable-gpu-rasterization --enable-oop-rasterization --enable-gpu-async-worker-context --enable-raster-decoder Sample LOGs from stub: https://pastebin.com/48sGk6cM BUG=789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5ce826f68acdfb7ca23a2fb7698d156bf1a7505c Reviewed-on: https://chromium-review.googlesource.com/820150 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#524728}
-
Tommy C. Li authored
Small fix to adjust the Omnibox suggestions dropdown for the new Harmony (kSecondaryUiMd enabled) BubbleBorder. Bug: 783778 Change-Id: Id0b2a9e962aad098f46d53d1eedffad668639221 Reviewed-on: https://chromium-review.googlesource.com/831046Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#524727}
-
Fredrik Söderquist authored
When a layout is triggered when the parser is interrupted, an instance tree can be built for a <use> that references a subtree that contains the insertion point of the parser. This <use> instance (or instances) would then not be invalidated when the parsing resumed. Invalidate instances of an element when its children changes even when the mutation originates from the parser. (This condition was added in 3c2310f2 without further explanation "Only invalidate SVGElementInstances when !changedByParser is set.". Due to the lazyness of the shadow tree/instance rebuilding this will hopefully not regress performance.) Bug: 794594 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I58f3a74ef9812503c0111d3564dad8ee3527d27b Reviewed-on: https://chromium-review.googlesource.com/832386Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#524726}
-
Anita Woodruff authored
- Now all the integer ids are request ids to avoid confusion with the string notification ids. Bug: 595685 Change-Id: Idd8008f59bb4a3db8eadf1455c6185fc7a01b338 Reviewed-on: https://chromium-review.googlesource.com/829553 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#524725}
-
Jonathan authored
More tests are flaking in viz_browser_tests disabling until we triage. TBR=kylechar@chromium.org Bug: 794961 Change-Id: I9eba78c0017a492eaed54826e0aa75f2354ee600 Reviewed-on: https://chromium-review.googlesource.com/832667Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524724}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c85ab812..c4318728 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5becfb65da0c4de8d44627d0c0951e1d2d2224c8 Reviewed-on: https://chromium-review.googlesource.com/832346Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#524723}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-webvtt-tc026-voice.html 2. track-webvtt-tc027-empty-cue.html 3. track-webvtt-tc028-unsupported-markup.html 4. track-webvtt-tc029-timings-whitespace.html 5. track-webvtt-tc030-interspersed-non-cue.html 6. track-webvtt-tc031-cue-recovery.html 7. track-webvtt-tc032-degenerate-cues.html Bug: 782555 Change-Id: I21d68c80e7606eaf8125c1122107e4b1b79e4972 Reviewed-on: https://chromium-review.googlesource.com/832106Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#524722}
-
Olivier Robin authored
If a form contains multiple fields with the same name, autofill suggestions often fills only one. The current resolution process keeps the value of the last element with a given name (each value overrides the previous value). This CLs make the resolution process to favor the non-empty value. The filling will try to fill every fields with the same name with this value. Bug: 728374, 732360 Change-Id: I5c5c1635c59679a9823589e914c65bb734b3b505 Reviewed-on: https://chromium-review.googlesource.com/806162Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524721}
-
Matthew Cary authored
This is timing out for me when I use run_chrome_public_test_apk with a filter, on a nexus 5 device. There may be a better place to put the timeout, any suggestions welcome :) Change-Id: Iac12a7843bfa299471ba7b2522de367a82793b5d Reviewed-on: https://chromium-review.googlesource.com/805136Reviewed-by:
Yoland Yan <yolandyan@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#524720}
-
Guido Urdaneta authored
A crash has been reported where apparently it is possible for a state update to arrive for a stream after the stream has been removed. This CL makes AudioStreamMonitor handle this case instead of DCHECKing. Bug: 795501 Change-Id: Id43c3c4a846af5d8e7d1d387d36ed31e45724ad8 Reviewed-on: https://chromium-review.googlesource.com/832186Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#524719}
-
Alexandros Frantzis authored
This commit adds plane in-fence support for KMS atomic modesetting. The in-fence fds are supplied as part of the overlay plane information. If the used drm device supports atomic modesetting, then any supplied fence fds are used as plane properties when committing the planes. If atomic modesetting is not supported, the implementation asynchronously waits for the fence fds to become ready before executing the page flip. Bug: 653908 Test: ozone_demo, ozone_unittests Change-Id: I438b4c9eb97538cb36fdda2fb002f7359f194c0b Reviewed-on: https://chromium-review.googlesource.com/814294 Commit-Queue: David Reveman <reveman@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524718}
-
kylechar authored
The FrameEvictionManager expects a response from DelegatedFrameHost::EvictDelegatedFrame() otherwise it will DCHECK and crash. Implement the correct logic in DelegatedFrameHost. There is no CompositorFrameSinkSupport to clear, but we clear the SurfaceLayer which will drop the surface reference to the evicted frame. Bug: 777881 Change-Id: Id6725d6cdb141c668b8217419535863ecf586a17 Reviewed-on: https://chromium-review.googlesource.com/829618 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#524717}
-
Robert Ma authored
WPT Import Notification is finally around the corner! And we should of course fishfood it. R=foolip Change-Id: Id05734a4c348b4444c63c4d06aed062d8b60e076 Reviewed-on: https://chromium-review.googlesource.com/830788Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#524716}
-
Yuzu Saijo authored
This CL updates the pageset for leak detection benchmark and update the wpr as well. Bug: 763280 Change-Id: Ic8d873ecb94c060c10589aa5ce535808e90620ea Reviewed-on: https://chromium-review.googlesource.com/828422Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#524715}
-
Mathias Bynens authored
We’ve recently shipped some new regular expression features in V8. This patch extends the fuzzer dictionary with the new syntax for: - positive lookbehind assertions - negative lookbehind assertions - named capture groups - Unicode property escapes More information on these features can be found here: - https://mathiasbynens.be/notes/es-regexp-proposals - https://developers.google.com/web/updates/2017/07/upcoming-regexp-features BUG=v8:7225 Change-Id: Ia506ba2282932fce43b02f1eccf327c8cd869101 Reviewed-on: https://chromium-review.googlesource.com/832526 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#524714}
-
Dave Tapuska authored
To support synchronous compositor for Android webview over mojo add a struct trait for ScrollOffset BUG=722928 TBR=vollick@chromium.org Change-Id: I4138ac3ff93fc17e6a123335ac3a82975df48db4 Reviewed-on: https://chromium-review.googlesource.com/830115 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#524713}
-
Hui(Andy) Wu authored
Autofill calls libphonenumber.IsValidNumber for number validation. This method validates carrier code(among other things) and it's a bit too strict for autofill's usage. For example, it would reject 6501231234 as a valida US number because the first number after area code cannot be 1. This CL switches to use IsPossibleNumber instead, so autofill will take above number and parse it as if it is a valid number. Benefits: 1. metadata of libphonenumber might not be the latest due to chrome's release cycle, therefore IsValidaNumber might reject valid numbers, while IsPossibleNumber will not. 2. Might allow libphonenumber to use a lite metadata to save a little of binary size. Bug: 792471 Change-Id: I25d3b21b81010b92a69b16f91f7d072e86ac7839 Reviewed-on: https://chromium-review.googlesource.com/827163Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Hui Wu <wuandy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524712}
-
Daniel Bratell authored
There are two namespaces named testing, there is ::testing and there is ::blink::testing. Inside blink code you have to write ::testing to be sure to get the root ::testing namespace. Depending on how ignorant the compiler is, it might work anyway, but in jumbo builds the compiler often knows about the blink::testing namespace. TBR=leon.han@intel.com Change-Id: I7617e074dba5cabb813c3a823757e0ba0ce15008 Reviewed-on: https://chromium-review.googlesource.com/832607Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#524711}
-
Bernhard Bauer authored
This prevents an ErrorProne warning about parameter mismatch. Change-Id: Ia9b3eae945980b47d92cf6affe042de1875eae3a Reviewed-on: https://chromium-review.googlesource.com/832427Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#524710}
-
Jonathan authored
viz_content_browsertests has exceptions on 3 bots. This is just because we never manually added them to these bots in the old format of configuring bots. TEST=ran the associated trybots for viz_content_browsertests Bug: 760181 Change-Id: I9c197c4ab906aad35522c49a0f618925d7ca258d Reviewed-on: https://chromium-review.googlesource.com/829654Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524709}
-
Christian Dullweber authored
This reverts commit e9cc36e4. Reason for revert: https://crbug.com/795744 Original change's description: > [Ribbon] Remove CSSProperty groups > > Gist for gen diff here: > > https: //gist.github.com/rjwright/d32835d21f8b313c46ec7a1c6d4d0155/revisions > Bug: 788554 > Change-Id: Ia19d78686e9742a91455fa044c69c22c94c05552 > Reviewed-on: https://chromium-review.googlesource.com/804645 > Commit-Queue: Renée Wright <rjwright@chromium.org> > Reviewed-by: meade_UTC10 <meade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524692} TBR=rjwright@chromium.org,meade@chromium.org Change-Id: I0c1d41d5ef0f93b4563ad755b3b1743810b8a9b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 788554 Reviewed-on: https://chromium-review.googlesource.com/832469Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#524708}
-